Enable usb0 and usb1 on shikra QLI by akakum-qualcomm · Pull Request #1001 · qualcomm-linux/kernel

akakum-qualcomm · 2026-08-23T14:51:31Z

arm64: dts: qcom: shikra: Replace out-of-tree USB DT with upstream lore series (v7 USB nodes + CYPD6129 role-switch v2)

This branch reverts the 3 out-of-tree/FROMLIST/PENDING Shikra USB commits
carried in this tree and replaces them with the equivalent upstream
lore.kernel.org patch series, applied cleanly on top of qcom-6.18.y:

https://lore.kernel.org/all/20260811-usb-shikra-v7-v7-0-753e928f37ae@oss.qualcomm.com/
(arm64: dts: qcom: Add support for usb nodes on Shikra, v7)
https://lore.kernel.org/all/20260821-shikra-usb-dt-v7-apply-v2-0-628885fc1d0e@oss.qualcomm.com/
(arm64: dts: qcom: shikra: Wire up usb-role-switch for USB Type-C ports, v2)

Reverted:

Revert "FROMLIST: arm64: dts: qcom: Add changes for usb on IQS platform"
Revert "FROMLIST: arm64: dts: qcom: Add USB changes for Shikra"
Revert "PENDING: arm64: dts: qcom: Add typec role switching changes to shikra"

Applied on top (from lore, unmodified upstream patches):

arm64: dts: qcom: Add support for usb nodes on Shikra
arm64: dts: qcom: Enable USB controllers on Shikra platforms
dt-bindings: usb: Add Cypress cypd6129/cypd6229 Type-C controller
usb: typec: ucsi: ccg: Add support for cypd6129/cypd6229
arm64: dts: qcom: shikra: Wire up usb-role-switch for USB Type-C ports

Net effect: shikra-cqm-evk, shikra-cqs-evk, and shikra-iqs-evk now use the
upstream CYPD6129/CYPD6229 UCSI Type-C controller for USB role switching
(via &i2c3/typec@40) instead of the previous PM4125-native typec block,
while shikra.dtsi/shikra-evk.dtsi gain the base usb_1/usb_2 dwc3, USB
HS/QMP PHY, and QUSB2 efuse-trim nodes needed to support them.

All four affected board/SoC DT files were rebuilt with dtc
(qcom/shikra-cqm-evk.dtb, qcom/shikra-cqs-evk.dtb, qcom/shikra-iqs-evk.dtb)
with no warnings or errors.

Signed-off-by: Akash Kumar akash.kumar@oss.qualcomm.com

links: https://lore.kernel.org/all/20260811-usb-shikra-v7-v7-0-753e928f37ae@oss.qualcomm.com/
https://lore.kernel.org/all/20260820145036.2035641-4-akash.kumar@oss.qualcomm.com/

CRs-Fixed: 4652998
CRs-Fixed:: 4635219

This reverts commit 1c76289.

This reverts commit 90ffd3d.

…o shikra" This reverts the pm4125_hs_in/pm4125_ss_in typec role-switch wiring introduced by commit 102ec26: - Remove the &pm4125_typec connector node and &pm4125_vbus regulator node (with the pm4125_hs_in/pm4125_ss_in endpoint labels) from shikra-cqm-som.dtsi. - Remove the &pm4125_hs_in/&pm4125_ss_in remote-endpoint stanzas and the &usb_1_dwc3_hs/&usb_qmpphy_out remote-endpoint stanzas from shikra-cqm-evk.dts and shikra-cqs-evk.dts. - Restore usb_1's dr_mode to "peripheral" in both files. The &wifi node and all other content are left untouched. Signed-off-by: Akash Kumar <akash.kumar@oss.qualcomm.com>

qswat-orbit-external · 2026-08-23T14:51:41Z

Merge Check Failed: CR Not Eligible for Merge

CR 4652998 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity:kernel.qli.2.0
CR:4652998
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

Shiraz Hashim (shashim-quic)

arm64: dts: qcom: Add support for usb nodes on Shikra

You missed to add FROMLIST prefix and add Link: tag in the commits.

qswat-orbit-external · 2026-08-24T08:23:22Z

Merge Check Failed: CR Not Eligible for Merge

CR 4652998 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity:kernel.qli.2.0
CR:4652998
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

Add support for both USB controllers and their respective phys on Shikra. Link: https://lore.kernel.org/all/20260811-usb-shikra-v7-v7-0-753e928f37ae@oss.qualcomm.com/ Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com> Signed-off-by: Akash Kumar <akash.kumar@oss.qualcomm.com>

On Shikra CQS/CQM platforms, usb-role-switch is handled by PM4125 on primary Type-C port and Cypress PD controller CYPD6129 on second Type-C port. On Shikra IQS platform, usb-role-switch is handled by Cypress PD controller CYPD6129 on both Type-C ports. Since those changes are not yet present, enabling both USB controllers in device mode. Link: https://lore.kernel.org/all/20260811-usb-shikra-v7-v7-0-753e928f37ae@oss.qualcomm.com/ Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Signed-off-by: Akash Kumar <akash.kumar@oss.qualcomm.com>

…roller Add the device-tree binding documentation for the Cypress cypd6129 and cypd6229 dual Type-C PD controllers. These are used on Shikra CQM/CQS/IQS platforms to handle usb-role-switch for the USB Type-C ports over an I2C interface, similarly to the existing cypd4226 binding. cypd6229 is a variant of cypd6129 and is described with a "cypress,cypd6129" fallback compatible string. Link: https://lore.kernel.org/all/20260820145036.2035641-4-akash.kumar@oss.qualcomm.com/ Signed-off-by: Akash Kumar <akash.kumar@oss.qualcomm.com>

Add cypd6129 and cypd6229 compatible strings to the of_device_id match table so the driver binds to boards describing these Cypress PD controllers in their device tree. No other driver changes are needed since the chip is accessed through the same generic UCSI/HPI I2C register protocol as the existing cypd4226 support. Link: https://lore.kernel.org/all/20260820145036.2035641-4-akash.kumar@oss.qualcomm.com/ Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com> Signed-off-by: Akash Kumar <akash.kumar@oss.qualcomm.com>

…ype-C ports On Shikra CQS/CQM platforms, usb-role-switch is handled by PM4125 on the primary Type-C port and Cypress PD controller CYPD6129 on the second Type-C port. On Shikra IQS platform, usb-role-switch is handled by Cypress PD controller CYPD6129 on both Type-C ports. Add the CYPD6129 typec node under i2c3, wire its connector endpoints to the corresponding DWC3 controller ports via remote-endpoint phandles, and switch the associated USB controllers to OTG mode so role switching can take effect. Link: https://lore.kernel.org/all/20260820145036.2035641-4-akash.kumar@oss.qualcomm.com/ Signed-off-by: Akash Kumar <akash.kumar@oss.qualcomm.com>

qswat-orbit-external · 2026-08-24T09:21:29Z

Merge Check Failed: CR Not Eligible for Merge

CR 4652998 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity:kernel.qli.2.0
CR:4652998
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

qlijarvis · 2026-08-25T14:54:50Z

PR #1001 — validate-patch

PR:#1001

Verdict	Issues	Detailed Report
❌	0	Full report

Final Summary

Lore link present: Partial — 5/8 commits have lore links; 3/8 are Revert commits (no link expected)
Lore link matches PR commits: No — Commits 6 & 7 link to wrong patch in series (both point to 3/3 instead of 1/3 and 2/3 respectively)
Upstream patch status: Decision Pending — Both series (Aug 11 v7 and Aug 20 v1/v2) are under review; no merge or NAK signals found
PR present in qcom-next/topics: Fail - 5/8 commit(s) are missing from both qcom-next and topics

Verdict: ❌ — click to expand
🔍 Patch Validation
PR:#1001 (8 commits)
Upstream commits: Multiple lore.kernel.org links
Verdict: ❌ FAIL
Summary by Commit
Commit 1/8: Revert "FROMLIST: arm64: dts: qcom: Add changes for usb on IQS platform"
Type: Revert commit (no lore link expected)
Author: Akash Kumar
Verdict:⚠️ PARTIAL — Revert commits do not require lore validation, but missing from qcom-next/topics
Commit 2/8: Revert "FROMLIST: arm64: dts: qcom: Add USB changes for Shikra"
Type: Revert commit (no lore link expected)
Author: Akash Kumar
Verdict:⚠️ PARTIAL — Revert commits do not require lore validation, but missing from qcom-next/topics
Commit 3/8: Revert "PENDING: arm64: dts: qcom: Add typec role"
Type: Revert of PENDING commit (no lore link expected)
Author: Akash Kumar
Verdict:⚠️ PARTIAL — PENDING commits have no upstream; revert is valid but missing from qcom-next/topics
Commit 4/8: FROMLIST: arm64: dts: qcom: Add support for usb nodes on Shikra
Check Status Note
Lore link present ✅ https://lore.kernel.org/all/20260811-usb-shikra-v7-v7-0-753e928f37ae@oss.qualcomm.com/
Subject matches upstream ✅ Matches lore patch v7 1/2
Body preserves rationale ✅ "Add support for both USB controllers and their respective phys on Shikra"
Authorship preserved ✅ Krishna Kurapati (original author)
Signed-off-by chain ✅ Krishna Kurapati → Akash Kumar (submitter)
Diff content ✅ Faithful to lore patch
qcom-next/topics presence ✅ Present in topics
Upstream status: ⏳ Decision Pending — Posted Aug 11, 2026 (v7); no merge/NAK signals found in thread
Verdict: ✅ PASS
Commit 5/8: FROMLIST: arm64: dts: qcom: Enable USB controllers on Shikra platforms
Check Status Note
Lore link present ✅ https://lore.kernel.org/all/20260811-usb-shikra-v7-v7-0-753e928f37ae@oss.qualcomm.com/
Subject matches upstream ✅ Matches lore patch v7 2/2
Body preserves rationale ✅ Enables USB on CQM/CQS/IQS platforms
Authorship preserved ✅ Krishna Kurapati (original author)
Signed-off-by chain ✅ Krishna Kurapati → Akash Kumar (submitter)
Diff content ✅ Faithful to lore patch
qcom-next/topics presence ✅ Present in topics
Upstream status: ⏳ Decision Pending — Posted Aug 11, 2026 (v7); no merge/NAK signals found in thread
Verdict: ✅ PASS
Commit 6/8: FROMLIST: dt-bindings: usb: Add Cypress cypd6129/cypd6229 Type-C controller
Check Status Note
Lore link present ❌ Links to wrong message-ID
Subject matches upstream ✅ Matches lore patch 1/3
Body preserves rationale ✅ Describes cypd6129/cypd6229 controllers
Authorship preserved ✅ Akash Kumar (original author)
Diff content ❌ 107 lines in PR vs 99 lines in lore v1
qcom-next/topics presence ❌ Missing from both qcom-next and topics
Issues:
Wrong lore link: PR links to 20260820145036.2035641-4-akash.kumar@oss.qualcomm.com (patch 3/3 "Wire up usb-role-switch"), but the commit content matches patch 1/3 (20260820145036.2035641-2-akash.kumar@oss.qualcomm.com)
Content mismatch: PR patch has 107 lines; lore v1 has 99 lines. The lore thread contains a v2 revision posted Aug 21, 2026 which may match the PR content, but the Link: tag points to v1.
Missing from integration: Not present in qcom-next or topics branches
Upstream status: ⏳ Decision Pending — Posted Aug 20, 2026 (v1), revised Aug 21 (v2); no merge/NAK signals
Verdict: ❌ FAIL — Wrong lore link (points to patch 3/3 instead of 1/3); possible content mismatch with v1
Commit 7/8: FROMLIST: usb: typec: ucsi: ccg: Add support for cypd6129/cypd6229
Check Status Note
Lore link present ❌ Links to wrong message-ID
Subject matches upstream ✅ Matches lore patch 2/3
Body preserves rationale ✅ Adds cypd6129/cypd6229 support to ucsi_ccg driver
Authorship preserved ✅ Akash Kumar (original author)
Diff content ⚠️ Cannot verify without extracting full lore patch
qcom-next/topics presence ❌ Missing from both qcom-next and topics
Issues:
Wrong lore link: PR links to 20260820145036.2035641-4-akash.kumar@oss.qualcomm.com (patch 3/3), but the commit content matches patch 2/3 (20260820145036.2035641-3-akash.kumar@oss.qualcomm.com)
Missing from integration: Not present in qcom-next or topics branches
Upstream status: ⏳ Decision Pending — Posted Aug 20, 2026; no merge/NAK signals
Verdict: ❌ FAIL — Wrong lore link (points to patch 3/3 instead of 2/3)
Commit 8/8: FROMLIST: arm64: dts: qcom: shikra: Wire up usb-role-switch for USB Type-C ports
Check Status Note
Lore link present ✅ https://lore.kernel.org/all/20260820145036.2035641-4-akash.kumar@oss.qualcomm.com/
Subject matches upstream ✅ Matches lore patch 3/3
Body preserves rationale ✅ Wires up cypd6129/cypd6229 to USB controllers
Authorship preserved ✅ Akash Kumar (original author)
Diff content ⚠️ Cannot fully verify without extracting lore patch
qcom-next/topics presence ⚠️ Partial — subject/partial tree evidence found
Upstream status: ⏳ Decision Pending — Posted Aug 20, 2026; no merge/NAK signals
Verdict:⚠️ PARTIAL — Lore link correct, but only partial presence in qcom-next/topics
Critical Issues
Commits 6 & 7: Wrong lore links
Both commits link to patch 3/3 (20260820145036.2035641-4-akash.kumar@oss.qualcomm.com)
Commit 6 should link to patch 1/3 (20260820145036.2035641-2-akash.kumar@oss.qualcomm.com)
Commit 7 should link to patch 2/3 (20260820145036.2035641-3-akash.kumar@oss.qualcomm.com)
Commit 6: Possible content mismatch
PR patch has 107 lines; lore v1 has 99 lines
Lore thread shows v2 revision posted Aug 21, 2026
If PR contains v2 content, Link: tag should point to v2 message-ID
Integration presence failures (from integration_presence_report.md):
5/8 commits missing from both qcom-next and topics
Only commits 4 & 5 are present in topics
Commits 1, 2, 3, 6, 7 are completely missing
Commit 8 shows only partial presence
Recommendation
DO NOT MERGE until the following corrections are made:
Fix lore links in commits 6 & 7:
Commit 6: Link: https://lore.kernel.org/all/20260820145036.2035641-2-akash.kumar@oss.qualcomm.com/
Commit 7: Link: https://lore.kernel.org/all/20260820145036.2035641-3-akash.kumar@oss.qualcomm.com/
Verify commit 6 content:
If PR contains v2 content (107 lines), update Link: to v2 message-ID
If PR should contain v1 content (99 lines), reconcile the diff
Address integration presence failures:
Investigate why 5/8 commits are missing from qcom-next/topics
Revert commits (1-3) may be acceptable as missing if they're removing content
New content commits (6-8) should be present in topics before merging to qcom-next
Final Summary
Lore link present: Partial — 5/8 commits have lore links; 3/8 are Revert commits (no link expected)
Lore link matches PR commits: No — Commits 6 & 7 link to wrong patch in series (both point to 3/3 instead of 1/3 and 2/3 respectively)
Upstream patch status: Decision Pending — Both series (Aug 11 v7 and Aug 20 v1/v2) are under review; no merge or NAK signals found
PR present in qcom-next/topics: Fail — 5/8 commits missing from both qcom-next and topics (per integration_presence_report.md)
Deterministic Integration Presence
Integration Presence Report
This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.
Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 3c1e80ceb9fb6978aa94bc0624e7c0003f3b4f6e
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched
Commit Subject qcom-next topics Final
1/8 [PATCH 1/8] Revert "FROMLIST: arm64: dts: qcom: Add changes for usb missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
2/8 [PATCH 2/8] Revert "FROMLIST: arm64: dts: qcom: Add USB changes for missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
3/8 [PATCH 3/8] Revert "PENDING: arm64: dts: qcom: Add typec role missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
4/8 [PATCH 4/8] FROMLIST: arm64: dts: qcom: Add support for usb nodes on partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
5/8 [PATCH 5/8] FROMLIST: arm64: dts: qcom: Enable USB controllers on partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
6/8 [PATCH 6/8] FROMLIST: dt-bindings: usb: Add Cypress cypd6129/cypd6229 missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
7/8 [PATCH 7/8] FROMLIST: usb: typec: ucsi: ccg: Add support for missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
8/8 [PATCH 8/8] FROMLIST: arm64: dts: qcom: shikra: Wire up partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
Final Status
overall_status: FAIL
present_commits: 2/8
partial_commits: 1/8
missing_commits: 5/8
topics_checked_for_commits: 8/8
final_summary: PR present in qcom-next/topics: Fail - 5/8 commit(s) are missing from both qcom-next and topics

qlijarvis · 2026-08-25T14:54:52Z

PR #1001 — checker-log-analyzer

PR:#1001
Checker run:https://github.com/qualcomm-linux/kernel-config/actions/runs/32646776820

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	4 commits with errors (missing Signed-off-by, commit reference format, undocumented DT string)
dt-binding-check	✅	Passed
dtb-check	❌	Missing binding for `qcom,shikra-qmp-usb3-dp-phy`, interrupt-names mismatch
sparse-check	✅	Passed
check-uapi-headers	✅	Passed
check-patch-compliance	❌	8 commits missing required prefix
tag-check	❌	3 Revert commits missing prefix before "Revert"

Detailed report: Full report

Checker analysis — click to expand
🤖 CI Checker Analysis (checker-log-analyzer)
PR:#1001 - USB Type-C support for Shikra platform
Source:https://github.com/qualcomm-linux/kernel-config/actions/runs/32646776820
Checker Result Summary
checkpatch ❌ 4 commits with errors (missing Signed-off-by, commit reference format, undocumented DT string)
dt-binding-check ✅ Passed
dtb-check ❌ Missing binding for qcom,shikra-qmp-usb3-dp-phy, interrupt-names mismatch
sparse-check ✅ Passed
check-uapi-headers ✅ Passed
check-patch-compliance ❌ 8 commits missing required prefix
tag-check ❌ 3 Revert commits missing prefix before "Revert"
❌ checkpatch
Root cause: Multiple commits have missing Signed-off-by lines and formatting issues.
Failure details:
Commit b0fb5f3 ("Revert "FROMLIST: arm64: dts: qcom: Add changes for usb on IQS platform"")
ERROR: Missing Signed-off-by: line(s)
Commit 6b70ea0 ("Revert "FROMLIST: arm64: dts: qcom: Add USB changes for Shikra"")
ERROR: Missing Signed-off-by: line(s)
Commit 206f2c9 ("Revert "PENDING: arm64: dts: qcom: Add typec role switching changes to shikra"")
ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")'
#8: introduced by commit 102ec26f93ef3d6010a7693a061bcec8838fc536:
Commit 4e3c131 ("arm64: dts: qcom: Add support for usb nodes on Shikra")
WARNING: DT compatible string "qcom,shikra-qmp-usb3-dp-phy" appears un-documented
#47: FILE: arch/arm64/boot/dts/qcom/shikra.dtsi:1259:
+ compatible = "qcom,shikra-qmp-usb3-dp-phy";
Fix:
Add Signed-off-by to Revert commits:
git rebase -i dc0f4d4280a7 # mark commits b0fb5f3d, 6b70ea052bbc as 'edit'
git commit --amend -s --no-edit
git rebase --continue
Fix commit reference format in commit 206f2c9:
git rebase -i dc0f4d4280a7 # mark commit 206f2c9985d6 as 'edit'# Edit commit message to use proper format:# commit 102ec26f93ef ("PENDING: arm64: dts: qcom: Add typec role switching changes to shikra")
git commit --amend
git rebase --continue
Document DT compatible string:
Add a DT binding YAML for qcom,shikra-qmp-usb3-dp-phy in Documentation/devicetree/bindings/phy/ or update an existing QMP PHY binding to include this compatible string.
Reproduce locally:
./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git dc0f4d4280a7..92c6f5c2f6cd
❌ dtb-check
Root cause: Missing DT binding schema for qcom,shikra-qmp-usb3-dp-phy and interrupt-names mismatch in USB DWC3 node.
Failure details:
arch/arm64/boot/dts/qcom/shikra-*.dtb: /soc@0/phy@1615000: failed to match any schema with compatible: ['qcom,shikra-qmp-usb3-dp-phy']
arch/arm64/boot/dts/qcom/shikra-*.dtb: usb@4c00000 (qcom,shikra-dwc3): interrupt-names:2: 'qusb2_phy' was expected
from schema $id: http://devicetree.org/schemas/usb/qcom,snps-dwc3.yaml
Fix:
Add DT binding for qcom,shikra-qmp-usb3-dp-phy:
Create or update Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml to include:
compatible:
items:
- enum:
- qcom,shikra-qmp-usb3-dp-phy# ... other variants
- const: qcom,qmp-usb3-dp-phy
Fix interrupt-names in USB DWC3 node:
The qcom,snps-dwc3.yaml binding expects interrupt-names to include 'qusb2_phy' at index 2. Check arch/arm64/boot/dts/qcom/shikra.dtsi USB node and ensure the interrupt-names array matches the binding requirements.
Reproduce locally:
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/shikra-cqm-evk.dtb
❌ check-patch-compliance
Root cause: All 8 commits are missing the required subject-line prefix recognized by the compliance checker.
Failure details:
The checker flagged all commits:
Commits 1-3: Revert "FROMLIST: ..." and Revert "PENDING: ..." — missing prefix before "Revert"
Commits 4-8: Have FROMLIST: prefix but checker still failed (likely due to Revert commits causing overall failure)
Fix:
The three Revert commits need a prefix before the word "Revert":
git rebase -i dc0f4d4280a7 # mark commits b0fb5f3d, 6b70ea052bbc, 206f2c9985d6 as 'reword'# Change subjects to:
FROMLIST: Revert "FROMLIST: arm64: dts: qcom: Add changes for usb on IQS platform"
FROMLIST: Revert "FROMLIST: arm64: dts: qcom: Add USB changes for Shikra"
FROMLIST: Revert "PENDING: arm64: dts: qcom: Add typec role switching changes to shikra"
git rebase --continue
Note: The checker only accepts FROMLIST:, FROMGIT:, UPSTREAM:, and BACKPORT: prefixes. It does not accept PENDING: or QCLINUX: — this is a known limitation for vendor-only commits.
Reproduce locally:
# For each commit:
b4 am --single-message -C -l -3 <lore-link> -o /tmp/out
❌ tag-check
Root cause: Three Revert commits are missing the required subject-line prefix before the word "Revert".
Failure details:
Commits missing prefix:
b0fb5f3: Revert "FROMLIST: arm64: dts: qcom: Add changes for usb on IQS platform"
6b70ea0: Revert "FROMLIST: arm64: dts: qcom: Add USB changes for Shikra"
206f2c9: Revert "PENDING: arm64: dts: qcom: Add typec role switching changes to shikra"
Fix:
All Revert commits must carry a prefix before the word "Revert":
git rebase -i dc0f4d4280a7 # mark the three Revert commits as 'reword'# Update subjects to:
FROMLIST: Revert "FROMLIST: arm64: dts: qcom: Add changes for usb on IQS platform"
FROMLIST: Revert "FROMLIST: arm64: dts: qcom: Add USB changes for Shikra"
FROMLIST: Revert "PENDING: arm64: dts: qcom: Add typec role switching changes to shikra"
git rebase --continue
Choose the appropriate prefix based on the revert's origin:
If the revert itself was posted to lore → FROMLIST:
If the revert is in a maintainer tree → FROMGIT:
If the revert is merged into mainline → UPSTREAM:
Verdict
6 blockers must be fixed before merge:
✅ Critical: Add Signed-off-by lines to 2 Revert commits (b0fb5f3, 6b70ea0)
✅ Critical: Add prefix before "Revert" in 3 commits (fixes both check-patch-compliance and tag-check)
✅ Critical: Fix commit reference format in commit 206f2c9
⚠️High: Add DT binding YAML for qcom,shikra-qmp-usb3-dp-phy (fixes both checkpatch WARNING and dtb-check failure)
⚠️High: Fix interrupt-names in USB DWC3 node to match binding expectations
ℹ️ Info: Commits 4-8 already have FROMLIST: prefix — no additional action needed for those
Recommended action sequence:
Interactive rebase to fix all commit messages (Signed-off-by, prefix, reference format)
Add DT binding YAML for the new PHY compatible string
Fix interrupt-names in the USB DWC3 node
Re-run CI to verify all checkers pass

qlijarvis · 2026-08-25T17:27:39Z

PR #1001 — validate-patch

PR:#1001

Verdict	Issues	Detailed Report
❌	0	Full report

Final Summary

Lore link present: Yes for commits 4-8 (FROMLIST patches); N/A for commits 1-3 (revert commits)
Lore link matches PR commits: Partial — commits 4-5 match their lore source correctly; commits 6-8 link to v1 series but v2 exists (wrong revision)
Upstream patch status: ⏳ Decision Pending for all FROMLIST commits — both series (Krishna's v7 and Akash's v2) are under review with Reviewed-by/Acked-by tags but no merge confirmation yet
PR present in qcom-next/topics: Fail - 5/8 commit(s) are missing from both qcom-next and topics

Verdict: ❌ — click to expand
🔍 Patch Validation
PR:#1001 - Add usb-role-switch support for USB Type-C ports on Shikra (8 commits)
Upstream commits: Multiple lore links (see per-commit analysis below)
Verdict: ❌ FAIL
Per-Commit Analysis
Commit 1/8: Revert "FROMLIST: arm64: dts: qcom: Add changes for usb on IQS platform"
Lore link: N/A (revert commit)
Verdict:⚠️ PARTIAL
Check Status Note
Lore link present N/A Revert commits do not require lore links
Authorship ✅ Akash Kumar (submitter)
Revert format ✅ Properly formatted revert
Integration presence: ❌ Missing from qcom-next and topics
Issues:
Revert commit is missing from qcom-next/topics, indicating this is new work not yet integrated
Commit 2/8: Revert "FROMLIST: arm64: dts: qcom: Add USB changes for Shikra"
Lore link: N/A (revert commit)
Verdict:⚠️ PARTIAL
Check Status Note
Lore link present N/A Revert commits do not require lore links
Authorship ✅ Akash Kumar (submitter)
Revert format ✅ Properly formatted revert
Integration presence: ❌ Missing from qcom-next and topics
Issues:
Revert commit is missing from qcom-next/topics, indicating this is new work not yet integrated
Commit 3/8: Revert "PENDING: arm64: dts: qcom: Add typec role switching changes to shikra"
Lore link: N/A (revert of PENDING commit)
Verdict:⚠️ PARTIAL
Check Status Note
Lore link present N/A Reverting a PENDING commit (vendor-only)
Authorship ✅ Akash Kumar (submitter)
Revert format ✅ Properly formatted revert with detailed explanation
Integration presence: ❌ Missing from qcom-next and topics
Issues:
Revert commit is missing from qcom-next/topics, indicating this is new work not yet integrated
Commit 4/8: FROMLIST: arm64: dts: qcom: Add support for usb nodes on Shikra
Lore link:https://lore.kernel.org/all/20260811-usb-shikra-v7-v7-0-753e928f37ae@oss.qualcomm.com/
Upstream: [PATCH v7 1/2] from Krishna Kurapati's series
Verdict: ✅ PASS
Commit Message
Check Status Note
Subject matches upstream ✅ Matches lore patch subject with FROMLIST prefix
Body preserves rationale ✅ Preserves upstream commit message
Fixes tag present/correct N/A No Fixes tag in upstream
Authorship preserved ✅ From: Krishna Kurapati (matches lore author)
Backport note N/A FROMLIST, not a backport
Co-developed-by usage ✅ Not used
Signed-off-by chain ✅ Krishna Kurapati → Akash Kumar (submitter)
Diff
File Status Notes
arch/arm64/boot/dts/qcom/shikra.dtsi ✅ USB controller and PHY nodes added
Upstream patch status: ⏳ Decision Pending — v7 series posted Aug 11, 2026; has Reviewed-by tags from Konrad Dybcio and Manivannan Sadhasivam; no merge confirmation yet
Integration presence: ✅ Present in topics (all added lines verified)
Commit 5/8: FROMLIST: arm64: dts: qcom: Enable USB controllers on Shikra platforms
Lore link:https://lore.kernel.org/all/20260811-usb-shikra-v7-v7-0-753e928f37ae@oss.qualcomm.com/
Upstream: [PATCH v7 2/2] from Krishna Kurapati's series
Verdict: ✅ PASS
Commit Message
Check Status Note
Subject matches upstream ✅ Matches lore patch subject with FROMLIST prefix
Body preserves rationale ✅ Preserves upstream commit message
Fixes tag present/correct N/A No Fixes tag in upstream
Authorship preserved ✅ From: Krishna Kurapati (matches lore author)
Backport note N/A FROMLIST, not a backport
Co-developed-by usage ✅ Not used
Signed-off-by chain ✅ Krishna Kurapati → Dmitry Baryshkov (reviewer) → Akash Kumar (submitter)
Diff
File Status Notes
arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts ✅ USB enablement for CQM platform
arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts ✅ USB enablement for CQS platform
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts ✅ USB enablement for IQS platform
Upstream patch status: ⏳ Decision Pending — v7 series posted Aug 11, 2026; has Reviewed-by tags from Manivannan Sadhasivam and Dmitry Baryshkov; no merge confirmation yet
Integration presence: ✅ Present in topics (all added lines verified)
Commit 6/8: FROMLIST: dt-bindings: usb: Add Cypress cypd6129/cypd6229 Type-C controller
Lore link:https://lore.kernel.org/all/20260820145036.2035641-4-akash.kumar@oss.qualcomm.com/
Upstream: [PATCH 1/3] from Akash Kumar's series
Verdict: ❌ FAIL
Commit Message
Check Status Note
Subject matches upstream ✅ Matches lore patch subject with FROMLIST prefix
Body preserves rationale ✅ Preserves upstream commit message
Fixes tag present/correct N/A No Fixes tag in upstream
Authorship preserved ✅ From: Akash Kumar (matches lore author)
Backport note N/A FROMLIST, not a backport
Diff
File Status Notes
Documentation/devicetree/bindings/usb/cypress,cypd6129.yaml ⚠️ New binding file
Issues:
❌ Wrong lore revision linked: PR links to message-ID 20260820145036.2035641-4-akash.kumar@oss.qualcomm.com which is from the v1 series. The lore thread shows a v2 series was posted with updates. The PR should link to the latest revision.
❌ Acked-by tag missing: Lore thread shows Acked-by: Conor Dooley <conor.dooley@microchip.com> for the dt-binding patch, but this tag is not present in the PR commit message.
Upstream patch status: ⏳ Decision Pending — v2 series posted Aug 20, 2026; has Acked-by from Conor Dooley (dt-binding maintainer); no merge confirmation yet
Integration presence: ❌ Missing from both qcom-next and topics
Commit 7/8: FROMLIST: usb: typec: ucsi: ccg: Add support for cypd6129/cypd6229
Lore link:https://lore.kernel.org/all/20260820145036.2035641-4-akash.kumar@oss.qualcomm.com/
Upstream: [PATCH 2/3] from Akash Kumar's series
Verdict: ❌ FAIL
Commit Message
Check Status Note
Subject matches upstream ✅ Matches lore patch subject with FROMLIST prefix
Body preserves rationale ✅ Preserves upstream commit message
Fixes tag present/correct N/A No Fixes tag in upstream
Authorship preserved ✅ From: Akash Kumar (matches lore author)
Backport note N/A FROMLIST, not a backport
Diff
File Status Notes
drivers/usb/typec/ucsi/ucsi_ccg.c ✅ Compatible string additions
Issues:
❌ Wrong lore revision linked: PR links to message-ID 20260820145036.2035641-4-akash.kumar@oss.qualcomm.com which is from the v1 series. The lore thread shows a v2 series was posted. The PR should link to the latest revision.
⚠️Reviewed-by tag present but may be from v1: The commit has Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com> which appears in the lore thread, but should be verified against the v2 series.
Upstream patch status: ⏳ Decision Pending — v2 series posted Aug 20, 2026; has Reviewed-by from Abel Vesa; no merge confirmation yet
Integration presence: ❌ Missing from both qcom-next and topics
Commit 8/8: FROMLIST: arm64: dts: qcom: shikra: Wire up usb-role-switch for USB Type-C ports
Lore link:https://lore.kernel.org/all/20260820145036.2035641-4-akash.kumar@oss.qualcomm.com/
Upstream: [PATCH 3/3] from Akash Kumar's series
Verdict: ❌ FAIL
Commit Message
Check Status Note
Subject matches upstream ✅ Matches lore patch subject with FROMLIST prefix
Body preserves rationale ✅ Preserves upstream commit message
Fixes tag present/correct N/A No Fixes tag in upstream
Authorship preserved ✅ From: Akash Kumar (matches lore author)
Backport note N/A FROMLIST, not a backport
Diff
File Status Notes
arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts ⚠️ CYPD6129 typec node and role-switch wiring
arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts ⚠️ CYPD6129 typec node and role-switch wiring
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts ⚠️ CYPD6129 typec node and role-switch wiring
Issues:
❌ Wrong lore revision linked: PR links to message-ID 20260820145036.2035641-4-akash.kumar@oss.qualcomm.com which is from the v1 series. The lore thread shows a v2 series was posted. The PR should link to the latest revision.
Upstream patch status: ⏳ Decision Pending — v2 series posted Aug 20, 2026; under review; no merge confirmation yet
Integration presence:⚠️ Partial in topics (subject or partial tree evidence found, but full change not verified)
Overall Issues
❌ CRITICAL: Wrong lore revision linked (commits 6-8) — The PR links to the v1 series message-ID 20260820145036.2035641-4-akash.kumar@oss.qualcomm.com, but the lore thread shows a v2 series was posted. The Link: tag should point to the latest revision's message-ID.
❌ CRITICAL: Missing Acked-by tag (commit 6) — The dt-binding patch received Acked-by: Conor Dooley <conor.dooley@microchip.com> in the lore thread, but this tag is missing from the PR commit message. This is a maintainer sign-off and must be included.
❌ CRITICAL: Integration presence failure — 5 out of 8 commits are missing from both qcom-next and topics:
Commits 1-3 (reverts): Missing
Commit 6 (dt-binding): Missing
Commit 7 (driver): Missing
Commit 8 (dts): Partial presence only
⚠️ WARNING: Revert commits not in integration tree — The three revert commits (1-3) are not present in qcom-next or topics, which suggests they are reverting commits that exist only in a downstream branch or are part of this PR's preparation work. This is acceptable if the reverted commits were never merged upstream, but should be verified.
Verdict
❌ FAIL — Do not merge without corrections
This PR has critical issues that must be fixed before merging:
Update lore links for commits 6-8 to point to the v2 series message-IDs (not the v1 series)
Add missing Acked-by tag from Conor Dooley to commit 6
Verify integration presence — 5/8 commits are missing from qcom-next/topics, which is a validation failure per the skill requirements
Final Summary
Lore link present: Yes for commits 4-8 (FROMLIST patches); N/A for commits 1-3 (revert commits)
Lore link matches PR commits: Partial — commits 4-5 match their lore source correctly; commits 6-8 link to v1 series but v2 exists (wrong revision)
Upstream patch status: ⏳ Decision Pending for all FROMLIST commits — both series (Krishna's v7 and Akash's v2) are under review with Reviewed-by/Acked-by tags but no merge confirmation yet
PR present in qcom-next/topics: Fail — 5/8 commits missing from both qcom-next and topics (commits 1-3, 6-7 fully missing; commit 8 partial)
Deterministic Integration Presence
Integration Presence Report
This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.
Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 3c1e80ceb9fb6978aa94bc0624e7c0003f3b4f6e
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched
Commit Subject qcom-next topics Final
1/8 [PATCH 1/8] Revert "FROMLIST: arm64: dts: qcom: Add changes for usb missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
2/8 [PATCH 2/8] Revert "FROMLIST: arm64: dts: qcom: Add USB changes for missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
3/8 [PATCH 3/8] Revert "PENDING: arm64: dts: qcom: Add typec role missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
4/8 [PATCH 4/8] FROMLIST: arm64: dts: qcom: Add support for usb nodes on partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
5/8 [PATCH 5/8] FROMLIST: arm64: dts: qcom: Enable USB controllers on partial - subject or partial tree evidence found, but full change was not verified present - all checked added lines are present present
6/8 [PATCH 6/8] FROMLIST: dt-bindings: usb: Add Cypress cypd6129/cypd6229 missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
7/8 [PATCH 7/8] FROMLIST: usb: typec: ucsi: ccg: Add support for missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
8/8 [PATCH 8/8] FROMLIST: arm64: dts: qcom: shikra: Wire up partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
Final Status
overall_status: FAIL
present_commits: 2/8
partial_commits: 1/8
missing_commits: 5/8
topics_checked_for_commits: 8/8
final_summary: PR present in qcom-next/topics: Fail - 5/8 commit(s) are missing from both qcom-next and topics

qlijarvis · 2026-08-25T17:27:41Z

PR #1001 — checker-log-analyzer

PR:#1001
Checker run:https://github.com/qualcomm-linux/kernel-config/actions/runs/32711180083

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	4 commits with errors: 3 missing Signed-off-by, 1 commit reference format, 1 undocumented DT compatible
dt-binding-check	✅	Passed
dtb-check	❌	Missing binding for qcom,shikra-qmp-usb3-dp-phy; interrupt-names mismatch for USB nodes
sparse-check	✅	Passed
check-uapi-headers	✅	Passed
check-patch-compliance	❌	3 Revert commits missing prefix; 2 commits with invalid lore links; 3 commits with content mismatch
tag-check	❌	3 Revert commits missing required prefix

Detailed report: Full report

Checker analysis — click to expand
🤖 CI Checker Analysis (checker-log-analyzer)
PR:#1001 - USB Type-C support for Shikra platform
Source:https://github.com/qualcomm-linux/kernel-config/actions/runs/32711180083
Checker Result Summary
checkpatch ❌ 4 commits with errors: 3 missing Signed-off-by, 1 commit reference format, 1 undocumented DT compatible
dt-binding-check ✅ Passed
dtb-check ❌ Missing binding for qcom,shikra-qmp-usb3-dp-phy; interrupt-names mismatch for USB nodes
sparse-check ✅ Passed
check-uapi-headers ✅ Passed
check-patch-compliance ❌ 3 Revert commits missing prefix; 2 commits with invalid lore links; 3 commits with content mismatch
tag-check ❌ 3 Revert commits missing required prefix
❌ checkpatch
Root cause: Multiple formatting and style violations across 4 commits.
Failure details:
Commit b0fb5f3 - Revert "FROMLIST: arm64: dts: qcom: Add changes for usb on IQS platform"
ERROR: Missing Signed-off-by: line(s)
Commit 6b70ea0 - Revert "FROMLIST: arm64: dts: qcom: Add USB changes for Shikra"
ERROR: Missing Signed-off-by: line(s)
Commit 206f2c9 - Revert "PENDING: arm64: dts: qcom: Add typec role switching changes to shikra"
ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")'
#8: introduced by commit 102ec26f93ef3d6010a7693a061bcec8838fc536:
Commit 8f0b0f6 - FROMLIST: arm64: dts: qcom: Add support for usb nodes on Shikra
WARNING: DT compatible string "qcom,shikra-qmp-usb3-dp-phy" appears un-documented
#50: FILE: arch/arm64/boot/dts/qcom/shikra.dtsi:1259:
+ compatible = "qcom,shikra-qmp-usb3-dp-phy";
Fix:
For commits b0fb5f3 and 6b70ea0 - Add Signed-off-by: trailer:
git rebase -i dc0f4d4280a7 # mark commits as 'edit'
git commit --amend -s --no-edit
git rebase --continue
For commit 206f2c9 - Fix commit reference format in body:
git rebase -i dc0f4d4280a7 # mark commit as 'edit'# Edit commit message to use: commit 102ec26f93ef ("PENDING: arm64: dts: qcom: Add typec role switching changes to shikra")
git commit --amend
git rebase --continue
For commit 8f0b0f6 - Add DT binding documentation for qcom,shikra-qmp-usb3-dp-phy or add the compatible string to an existing binding YAML file in Documentation/devicetree/bindings/phy/.
Reproduce locally:
./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git dc0f4d4280a7..8ef72925dc32
❌ dtb-check
Root cause: Missing DT binding schema for qcom,shikra-qmp-usb3-dp-phy and interrupt-names array mismatch for USB controller nodes.
Failure details:
arch/arm64/boot/dts/qcom/shikra-cqm-evk.dtb: /soc@0/phy@1615000: failed to match any schema with compatible: ['qcom,shikra-qmp-usb3-dp-phy']
usb@4c00000 (qcom,shikra-dwc3): interrupt-names:2: 'qusb2_phy' was expected
usb@4c00000 (qcom,shikra-dwc3): interrupt-names:3: 'hs_phy_irq' was expected
usb@4c00000 (qcom,shikra-dwc3): interrupt-names:4: 'ss_phy_irq' was expected
usb@4e00000 (qcom,shikra-dwc3): interrupt-names:2: 'qusb2_phy' was expected
usb@4e00000 (qcom,shikra-dwc3): interrupt-names:3: 'hs_phy_irq' was expected
usb@4e00000 (qcom,shikra-dwc3): interrupt-names:4: 'ss_phy_irq' was expected
usb@4e00000 (qcom,shikra-dwc3): interrupt-names: ['dwc_usb3', 'pwr_event', 'hs_phy_irq', 'dp_hs_phy_irq', 'dm_hs_phy_irq', 'ss_phy_irq'] is too long
This pattern repeats across all Shikra DTB files (cqm-evk, cqs-evk, and their camera variants).
Fix:
Missing PHY binding - Create Documentation/devicetree/bindings/phy/qcom,shikra-qmp-usb3-dp-phy.yaml with proper schema definition for the qcom,shikra-qmp-usb3-dp-phy compatible string.
interrupt-names mismatch - The USB controller nodes have interrupt-names that don't match the qcom,snps-dwc3.yaml binding schema. The binding expects specific interrupt names at specific positions:
Position 2 should be qusb2_phy but the DTS has hs_phy_irq
Position 3 should be hs_phy_irq but the DTS has dp_hs_phy_irq
Position 4 should be ss_phy_irq but the DTS has dm_hs_phy_irq
The array is also too long (6 entries vs expected maximum)
Either:
Update the DTS files to match the binding's expected interrupt-names order, OR
Update the qcom,snps-dwc3.yaml binding to allow the qcom,shikra-dwc3 compatible with this specific interrupt-names pattern
Reproduce locally:
make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/shikra-cqm-evk.dtb
❌ check-patch-compliance
Root cause: Revert commits missing required prefix; invalid lore.kernel.org links; content mismatch with upstream patches.
Failure details:
Prefix violations (3 commits):
Checking commit: Revert "FROMLIST: arm64: dts: qcom: Add changes for usb on IQS platform"
Commit summary does not start with a required prefix
Checking commit: Revert "FROMLIST: arm64: dts: qcom: Add USB changes for Shikra"
Commit summary does not start with a required prefix
Checking commit: Revert "PENDING: arm64: dts: qcom: Add typec role switching changes to shikra"
Commit summary does not start with a required prefix
Invalid lore links (2 commits):
Checking commit: FROMLIST: arm64: dts: qcom: Add support for usb nodes on Shikra
Something seems wrong with the provided link. Please verify it
Try: b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260811-usb-shikra-v7-v7-0-753e928f37ae@oss.qualcomm.com/
Checking commit: FROMLIST: arm64: dts: qcom: Enable USB controllers on Shikra platforms
Something seems wrong with the provided link. Please verify it
Try: b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260811-usb-shikra-v7-v7-0-753e928f37ae@oss.qualcomm.com/
Content mismatch (3 commits):
Checking commit: FROMLIST: dt-bindings: usb: Add Cypress cypd6129/cypd6229 Type-C controller
Change is different from the one mentioned in Link
Checking commit: FROMLIST: usb: typec: ucsi: ccg: Add support for cypd6129/cypd6229
Change is different from the one mentioned in Link
Checking commit: FROMLIST: arm64: dts: qcom: shikra: Wire up usb-role-switch for USB Type-C ports
Change is different from the one mentioned in Link
Fix:
Revert commits prefix - Add FROMLIST: or UPSTREAM: prefix before Revert:
git rebase -i dc0f4d4280a7
# For each Revert commit, mark as 'reword'# Change subject from:# Revert "FROMLIST: ..."# To:# FROMLIST: Revert "FROMLIST: ..."# or# UPSTREAM: Revert "FROMLIST: ..."
Invalid lore links - The link https://lore.kernel.org/all/20260811-usb-shikra-v7-v7-0-753e928f37ae@oss.qualcomm.com/ appears to be a cover letter (v7-0-). Individual patches need individual message-ID links. Update the Link: trailer in each commit to point to the specific patch message-ID, not the cover letter.
Content mismatch - Verify the differences between the PR patches and upstream:
b4 am --single-message -C -l -3 <individual-patch-link> -o /tmp/upstream
git format-patch -1 <commit-sha> --stdout > /tmp/pr-patch
diff <(grep -E '^[+-][^+-]' /tmp/pr-patch)<(grep -E '^[+-][^+-]' /tmp/upstream/*.mbx)
If differences are intentional adaptations (e.g., context changes, prerequisite differences), document them in the commit message. If differences are unintended, align the patch with upstream.
Reproduce locally:
cd kernel-checkers
./check-patch-compliance.sh dc0f4d4280a7 8ef72925dc32
❌ tag-check
Root cause: Three Revert commits do not start with a required subject-line prefix.
Failure details:
Commits missing prefix:
b0fb5f3d7f27 - Revert "FROMLIST: arm64: dts: qcom: Add changes for usb on IQS platform"
6b70ea052bbc - Revert "FROMLIST: arm64: dts: qcom: Add USB changes for Shikra"
206f2c9985d6 - Revert "PENDING: arm64: dts: qcom: Add typec role switching changes to shikra"
All branches except qcom-next and qcom-next-staging require every commit subject to start with one of:
FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:
Fix:
git rebase -i dc0f4d4280a7
# Mark the three Revert commits as 'reword'# Change subjects to:# FROMLIST: Revert "FROMLIST: arm64: dts: qcom: Add changes for usb on IQS platform"# FROMLIST: Revert "FROMLIST: arm64: dts: qcom: Add USB changes for Shikra"# FROMLIST: Revert "PENDING: arm64: dts: qcom: Add typec role switching changes to shikra"# or use UPSTREAM: if these reverts are from mainline
git rebase --continue
Verdict
6 blockers must be fixed before merge:
Add Signed-off-by: to 2 Revert commits
Fix commit reference format in 1 Revert commit body
Add DT binding for qcom,shikra-qmp-usb3-dp-phy or document in existing binding
Fix USB controller interrupt-names mismatch (either update DTS or binding schema)
Add required prefix (FROMLIST:/UPSTREAM:) to 3 Revert commit subjects
Fix lore.kernel.org links (use individual patch message-IDs, not cover letter) and resolve content mismatches for 5 commits

Akash Kumar (akakum-oss) added 3 commits August 21, 2026 18:54

Revert "FROMLIST: arm64: dts: qcom: Add changes for usb on IQS platform"
b0fb5f3
This reverts commit 1c76289.

Revert "FROMLIST: arm64: dts: qcom: Add USB changes for Shikra"
6b70ea0
This reverts commit 90ffd3d.

akakum-qualcomm requested review from a team, Shivendra Pratap (quicAspratap), Rajendra (rrnayak) and Salendarsingh Gaud (sgaud-quic)August 23, 2026 14:51

Shiraz Hashim (shashim-quic) requested changes Aug 23, 2026
View reviewed changes

Kriskura176767and others added 5 commits August 24, 2026 13:57

akakum-qualcomm force-pushed the shikra-revert-719-reapply branch from 92c6f5c to 8ef7292Compare August 24, 2026 09:21

akakum-qualcomm requested a review from Shiraz Hashim (shashim-quic)August 24, 2026 09:21

qcomlnxci requested a review from a teamAugust 24, 2026 09:22

Uh oh!

Conversation

akakum-qualcomm commented Aug 23, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qswat-orbit-externalBot commented Aug 23, 2026

Uh oh!

Shiraz Hashim (shashim-quic) left a comment

Choose a reason for hiding this comment

Uh oh!

qswat-orbit-externalBot commented Aug 24, 2026

Uh oh!

qswat-orbit-externalBot commented Aug 24, 2026

Uh oh!

qlijarvis commented Aug 25, 2026

PR #1001 — validate-patch

Final Summary

🔍 Patch Validation

Summary by Commit

Commit 1/8: Revert "FROMLIST: arm64: dts: qcom: Add changes for usb on IQS platform"

Commit 2/8: Revert "FROMLIST: arm64: dts: qcom: Add USB changes for Shikra"

Commit 3/8: Revert "PENDING: arm64: dts: qcom: Add typec role"

Commit 4/8: FROMLIST: arm64: dts: qcom: Add support for usb nodes on Shikra

Commit 5/8: FROMLIST: arm64: dts: qcom: Enable USB controllers on Shikra platforms

Commit 6/8: FROMLIST: dt-bindings: usb: Add Cypress cypd6129/cypd6229 Type-C controller

Commit 7/8: FROMLIST: usb: typec: ucsi: ccg: Add support for cypd6129/cypd6229

Commit 8/8: FROMLIST: arm64: dts: qcom: shikra: Wire up usb-role-switch for USB Type-C ports

Critical Issues

Recommendation

Final Summary

Deterministic Integration Presence

Integration Presence Report

Final Status

Uh oh!

qlijarvis commented Aug 25, 2026

PR #1001 — checker-log-analyzer

🤖 CI Checker Analysis (checker-log-analyzer)

❌ checkpatch

❌ dtb-check

❌ check-patch-compliance

❌ tag-check

Verdict

Uh oh!

qlijarvis commented Aug 25, 2026

PR #1001 — validate-patch

Final Summary

🔍 Patch Validation

Per-Commit Analysis

Commit 1/8: Revert "FROMLIST: arm64: dts: qcom: Add changes for usb on IQS platform"

Commit 2/8: Revert "FROMLIST: arm64: dts: qcom: Add USB changes for Shikra"

Commit 3/8: Revert "PENDING: arm64: dts: qcom: Add typec role switching changes to shikra"

Commit 4/8: FROMLIST: arm64: dts: qcom: Add support for usb nodes on Shikra

Commit Message

Diff

Commit 5/8: FROMLIST: arm64: dts: qcom: Enable USB controllers on Shikra platforms

Commit Message

Diff

Commit 6/8: FROMLIST: dt-bindings: usb: Add Cypress cypd6129/cypd6229 Type-C controller

Commit Message

Diff

Commit 7/8: FROMLIST: usb: typec: ucsi: ccg: Add support for cypd6129/cypd6229

Commit Message

Diff

Commit 8/8: FROMLIST: arm64: dts: qcom: shikra: Wire up usb-role-switch for USB Type-C ports

Commit Message

Diff

Overall Issues

Verdict

Final Summary

Deterministic Integration Presence

Integration Presence Report

Final Status

Uh oh!

qlijarvis commented Aug 25, 2026

PR #1001 — checker-log-analyzer

🤖 CI Checker Analysis (checker-log-analyzer)

❌ checkpatch

❌ dtb-check

❌ check-patch-compliance

❌ tag-check

akakum-qualcomm commented Aug 23, 2026•
edited
Loading