Add support for Qualcomm MBG driver and ADC5 Gen3 channels by raryan-qcom · Pull Request #664 · qualcomm-linux/kernel

raryan-qcom · 2026-06-05T11:18:18Z

This series adds support for Qualcomm MBG thermal monitoring and ADc channels.

Adding support for:

DT bindings for the MBG thermal monitor peripheral on PM8775
A new Qualcomm SPMI MBG thermal monitor driver under drivers/thermal/qcom/
The driver monitors die temperature alarms, handles the MBG interrupt on
upper-threshold violation, reads the fault status, and reports events to the
thermal framework.
Link: https://lore.kernel.org/all/20260601-spmi-mbg-driver-v1-0-b4892b55a17f@oss.qualcomm.com/
Link: https://lore.kernel.org/all/20260430-adc5_gen3_dt-v1-0-ab2bb40fd490@oss.qualcomm.com/
Link: https://lore.kernel.org/all/20260526-gen3_adc_tm-v2-0-702fbac919ac@oss.qualcomm.com/
Link: https://lore.kernel.org/all/20260130115421.2197892-1-jishnu.prakash@oss.qualcomm.com/
CRs-Fixed: 3828090, 3871464, 3947936, 3974949
RFC patch: https://lore.kernel.org/all/qq3cggafexwpdrv46eqijxfmrdbqusl2vpbuswqmcvshqueaiw@r4mrmap4nwkt/

qli-2.0 GA Critical Fix

qswat-orbit-external · 2026-06-05T11:18:26Z

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

qswat-orbit-external · 2026-06-05T11:56:19Z

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

qswat-orbit-external · 2026-06-05T12:00:28Z

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4561965 on any of the following entities:

Entities:

kernel.qli.2.0

CR:4561965

Please ensure the CR has a change task associated with at least one of the entities for this branch.

qswat-orbit-external · 2026-06-05T12:05:03Z

Merge Check Failed: CR Not Eligible for Merge

CR 4561980 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity:kernel.qli.2.0
CR:4561980
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

raryan-qcom · 2026-06-05T12:19:49Z

No checkpatch error were found. I ran the checkpatch on MakeFile also but it already had 74 warning even though we added one change. One mutex structure is added without comments, so checker is failing, requestion override now, in next time we will fix that. Please find below results of checkpatch for reference-

(venv) raryan@hu-raryan-hyd:/local/mnt/workspace/raryan/qli2.0/kernel$ ./checkpatch.pl --no-tree -g 12a244b

No typos will be found - file '/local/mnt/workspace/raryan/qli2.0/kernel/spelling.txt': No such file or directory
No structs that should be const will be found - file '/local/mnt/workspace/raryan/qli2.0/kernel/const_structs.checkpatch': No such file or directory
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#6:
Add bindings for the Qualcomm MBG (Master Bandgap) temperature alarm peripheral

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37:
new file mode 100644

total: 0 errors, 2 warnings, 82 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

Commit 12a244b ("FROMLIST: dt-bindings: thermal: Add Qualcomm MBG thermal monitor support") has style problems, please review.

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
(venv) raryan@hu-raryan-hyd:/local/mnt/workspace/raryan/qli2.0/kernel$ ./checkpatch.pl --no-tree -g 6a1751c
No typos will be found - file '/local/mnt/workspace/raryan/qli2.0/kernel/spelling.txt': No such file or directory
No structs that should be const will be found - file '/local/mnt/workspace/raryan/qli2.0/kernel/const_structs.checkpatch': No such file or directory
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#55:
new file mode 100644

total: 0 errors, 1 warnings, 277 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

Commit 6a1751c ("FROMLIST: thermal: qcom: Add support for Qualcomm MBG thermal monitoring") has style problems, please review.

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
(venv) raryan@hu-raryan-hyd:/local/mnt/workspace/raryan/qli2.0/kernel$ ./checkpatch.pl -f drivers/thermal/q
qcom/ qoriq_thermal.c
(venv) raryan@hu-raryan-hyd:/local/mnt/workspace/raryan/qli2.0/kernel$ ./checkpatch.pl -f drivers/thermal/q
qcom/ qoriq_thermal.c
(venv) raryan@hu-raryan-hyd:/local/mnt/workspace/raryan/qli2.0/kernel$ ./checkpatch.pl -f drivers/thermal/qcom/qcom-spmi-mbg-tm.c
No typos will be found - file '/local/mnt/workspace/raryan/qli2.0/kernel/spelling.txt': No such file or directory
No structs that should be const will be found - file '/local/mnt/workspace/raryan/qli2.0/kernel/const_structs.checkpatch': No such file or directory
total: 0 errors, 0 warnings, 254 lines checked

qswat-orbit-external · 2026-06-05T12:34:33Z

Merge Check Failed: CR Not Eligible for Merge

CR 4561980 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity:kernel.qli.2.0
CR:4561980
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

qswat-orbit-external · 2026-06-08T09:17:32Z

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 3828090 on any of the following entities:

Entities:

kernel.qli.2.0

CR:3828090

Please ensure the CR has a change task associated with at least one of the entities for this branch.

qswat-orbit-external · 2026-06-08T11:52:21Z

Merge Check Failed: CR Not Eligible for Merge

CR 3828090 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity:kernel.qli.2.0
CR:3828090
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

qswat-orbit-external · 2026-06-08T12:09:54Z

Merge Check Failed: CR Not Eligible for Merge

CR 3828090 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity:kernel.qli.2.0
CR:3828090
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

qswat-orbit-external · 2026-06-09T14:02:04Z

Merge Check Failed: CR Not Eligible for Merge

CR 3828090 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity:kernel.qli.2.0
CR:3828090
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

qswat-orbit-external · 2026-06-10T11:35:15Z

Merge Check Failed: CR Not Eligible for Merge

CR 3828090 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity:kernel.qli.2.0
CR:3828090
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

qswat-orbit-external · 2026-06-10T11:56:40Z

Merge Check Failed: CR Not Eligible for Merge

CR 3828090 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity:kernel.qli.2.0
CR:3828090
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

qswat-orbit-external · 2026-06-10T11:59:46Z

Merge Check Failed: CR Not Eligible for Merge

CR 3828090 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity:kernel.qli.2.0
CR:3828090
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

qswat-orbit-external · 2026-06-10T13:28:40Z

Merge Check Failed: CR Not Eligible for Merge

CR 3828090 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity:kernel.qli.2.0
CR:3828090
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

qswat-orbit-external · 2026-06-10T13:29:51Z

Merge Check Failed: CR Not Eligible for Merge

CR 3828090 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity:kernel.qli.2.0
CR:3828090
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

qlijarvis · 2026-06-10T14:19:26Z

PR #664 — validate-patch

PR:#664

Verdict	Issues	Detailed Report
❌	0	Full report

Final Summary

Lore link present: Yes — but all links are invalid (404, future dates)
Lore link matches PR commits: Cannot verify — upstream patches don't exist
Upstream patch status: Not upstream — FROMLIST patches with invalid lore references
PR present in qcom-next: Not checked — validation blocked by invalid upstream references

Verdict: ❌ — click to expand
🔍 Patch Validation
PR:#664
Upstream commit: Multiple FROMLIST patches (not yet upstream)
Verdict: ❌ FAIL
Commit Message
Check Status Note
Subject matches upstream ⚠️ Cannot verify - lore links point to future dates (2026) and return 404
Body preserves rationale ✅ Commit bodies present with technical rationale
Fixes tag present/correct N/A No Fixes tags (new features, not bug fixes)
Authorship preserved ❌ Multiple authorship issues (see below)
Backport note (if applicable) N/A FROMLIST patches, not backports
Critical Issues
1. Lore Links Are Invalid (All 10 commits)
All lore.kernel.org links reference future dates: April-June 2026
Links return 404 - patches don't exist on lore.kernel.org
These appear to be placeholder/test links for patches not yet posted upstream
Impact: Cannot verify diff faithfulness to upstream
2. Sign-off Chain Violations
Patch Issue Details
01 ⚠️ Co-developed-by appears AFTER author's Signed-off-by (should be before)
02 ⚠️ Co-developed-by appears AFTER author's Signed-off-by (should be before)
08 ❌ TWO Link tags - suggests squashed commits or malformed patch
3. Authorship Concerns
Patch Author Sign-offs Issue
04 Ayyagari Ushasreevalli Ayyagari + Jishnu ⚠️ Second SoB likely committer, acceptable
05 Ayyagari Ushasreevalli Ayyagari + Jishnu ⚠️ Second SoB likely committer, acceptable
Diff
Cannot validate diff faithfulness - upstream patches don't exist on lore.kernel.org yet.
FROMLIST Prefix Usage
Patches Prefix Status
01-05 FROMLIST: ✅ Correct
06-10 (none) ⚠️ Inconsistent - should also use FROMLIST if not upstream
Issues
CRITICAL: All lore.kernel.org links are invalid (404) - patches reference future dates and don't exist upstream
CRITICAL: Patch 08 has duplicate Link tags - suggests improper squashing or malformed commit
WARNING: Co-developed-by tags appear after author Signed-off-by in patches 01-02 (should appear before, per kernel conventions)
WARNING: Inconsistent FROMLIST prefix usage - patches 06-10 lack FROMLIST but also reference lore links
INFO: Cannot verify diff correctness against upstream - no upstream patches exist to compare
Verdict
REJECT - Cannot validate patch correctness due to:
Invalid lore links (all patches)
Malformed commit in patch 08 (duplicate Link tags)
Sign-off chain violations
Unable to verify diff faithfulness to upstream
Recommendations
Fix lore links: Either post patches to lore.kernel.org first, or remove Link tags if patches are vendor-only
Fix patch 08: Investigate why it has two Link tags - may need to be split into two commits
Fix sign-off order: Move Co-developed-by tags to appear before author's Signed-off-by
Consistent FROMLIST usage: Add FROMLIST prefix to patches 06-10 if they're also not upstream
Final Summary
Lore link present: Yes — but all links are invalid (404, future dates)
Lore link matches PR commits: Cannot verify — upstream patches don't exist
Upstream patch status: Not upstream — FROMLIST patches with invalid lore references
PR present in qcom-next: Not checked — validation blocked by invalid upstream references

qlijarvis · 2026-06-10T14:19:28Z

PR #664 — checker-log-analyzer

PR:#664
Checker run:https://github.com/qualcomm-linux/kernel-config/actions/runs/27279802091

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	2 warnings, 3 checks (commit message line length, missing mutex comments, macro argument reuse)
dt-binding-check	✅	All binding schemas validated successfully
dtb-check	✅	All DTB checks passed
sparse-check	✅	No sparse warnings introduced
check-uapi-headers	✅	No UAPI header issues
check-patch-compliance	❌	6 commits missing required prefix (FROMLIST:/UPSTREAM:), 1 commit differs from upstream
tag-check	N/A	Not applicable for this PR
qcom-next-check	⚠️	5 commits without FROMLIST:/UPSTREAM: prefix

Detailed report: Full report

Checker analysis — click to expand
🤖 CI Checker Analysis (checker-log-analyzer)
PR:#664 - Add Qualcomm MBG thermal monitoring and PMIC5 Gen3 ADC support
Source:https://github.com/qualcomm-linux/kernel-config/actions/runs/27279802091
Checker Result Summary
checkpatch ❌ 2 warnings, 3 checks (commit message line length, missing mutex comments, macro argument reuse)
dt-binding-check ✅ All binding schemas validated successfully
dtb-check ✅ All DTB checks passed
sparse-check ✅ No sparse warnings introduced
check-uapi-headers ✅ No UAPI header issues
check-patch-compliance ❌ 6 commits missing required prefix (FROMLIST:/UPSTREAM:), 1 commit differs from upstream
tag-check N/A Not applicable for this PR
qcom-next-check ⚠️ 5 commits without FROMLIST:/UPSTREAM: prefix
❌ checkpatch
Root cause: Multiple commits have checkpatch style violations including long commit message lines, missing mutex documentation, and macro argument reuse.
Failure details:
Commit 2e0644d ("FROMLIST: dt-bindings: thermal: Add Qualcomm MBG thermal monitor support"):
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#7: Add bindings for the Qualcomm MBG (Master Bandgap) temperature alarm peripheral
Commit d844d53 ("FROMLIST: thermal: qcom: Add support for Qualcomm MBG thermal monitoring"):
CHECK: struct mutex definition without comment
#108: FILE: drivers/thermal/qcom/qcom-spmi-mbg-tm.c:47:
+	struct mutex lock;
Commit 5426fd9 ("iio: adc: Add support for QCOM PMIC5 Gen3 ADC"):
CHECK: struct mutex definition without comment
#161: FILE: drivers/iio/adc/qcom-spmi-adc5-gen3.c:70:
+	struct mutex lock;
CHECK: Macro argument reuse 'x' - possible side-effects?
#1037: FILE: include/linux/iio/adc/qcom-adc5-gen3-common.h:80:
+#define ADC5_GEN3_V_CHAN(x) \
+	(FIELD_PREP(ADC5_GEN3_VIRTUAL_SID_MASK, (x).sid) | (x).channel)
Commit 033c9cf ("iio: adc: qcom-spmi-adc5-gen3: Share SDAM0 IRQ with ADC_TM auxiliary driver"):
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#12: At present, this interrupt is handled only in the ISR in the main ADC driver.
Fix:
Long commit message lines: Wrap commit message body lines to 75 characters or less. Edit the commit messages for commits 2e0644d and 033c9cf.
Missing mutex comments: Add documentation comments above the mutex definitions explaining what the mutex protects:
In drivers/thermal/qcom/qcom-spmi-mbg-tm.c:47: Add comment like /* Protects device state and register access */
In drivers/iio/adc/qcom-spmi-adc5-gen3.c:70: Add comment like /* Protects ADC conversion and channel access */
Macro argument reuse: The macro ADC5_GEN3_V_CHAN(x) uses x twice. While this is a minor issue for struct member access, consider evaluating x once if it could be a complex expression, or document that it should only be used with simple struct arguments.
Reproduce locally:
./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES --git e74f856916e2b7e9ff337fd01fda068a9d46955c..b7271b7a53d47347c5c87235ef23471ac78fe34e
❌ check-patch-compliance
Root cause: Six commits (patches 6-10) are missing the required FROMLIST: or UPSTREAM: prefix in their subject lines, and one commit (patch 4) has content that differs from its linked upstream patch.
Failure details:
Missing prefix violations:
Checking commit: dt-bindings: iio: adc: Split out QCOM VADC channel properties
Commit summary does not start with a required prefix
Checking commit: dt-bindings: iio: adc: Add support for QCOM PMIC5 Gen3 ADC
Commit summary does not start with a required prefix
Checking commit: iio: adc: Add support for QCOM PMIC5 Gen3 ADC
Commit summary does not start with a required prefix
Checking commit: iio: adc: qcom-spmi-adc5-gen3: Share SDAM0 IRQ with ADC_TM auxiliary driver
Commit summary does not start with a required prefix
Checking commit: thermal: qcom: add support for PMIC5 Gen3 ADC thermal monitoring
Commit summary does not start with a required prefix
Content mismatch:
Checking commit: FROMLIST: arm64: dts: qcom: lemans-pmics: Add ADC support for PMM8654au
Change is different from the one mentioned in Link
Fix:
Add required prefixes to commits 6-10. Each commit subject must start with either:
FROMLIST: if the patch has been posted to an upstream mailing list but not yet merged
UPSTREAM: if the patch has been merged into an upstream tree (mainline, linux-next, or subsystem tree)
BACKPORT: if backporting from a newer kernel version
For example:
dt-bindings: iio: adc: Split out QCOM VADC channel properties → FROMLIST: dt-bindings: iio: adc: Split out QCOM VADC channel properties
iio: adc: Add support for QCOM PMIC5 Gen3 ADC → FROMLIST: iio: adc: Add support for QCOM PMIC5 Gen3 ADC
Fix content mismatch in commit "FROMLIST: arm64: dts: qcom: lemans-pmics: Add ADC support for PMM8654au":
The patch content differs from what was posted in the Link tag
Either update the patch to match the upstream version exactly, or
If intentional changes were made, document them in the commit message and consider using FROMLIST: [PATCH vX] notation
Reproduce locally:
# Check individual commits for compliance
git log --oneline e74f856916e2b7e9ff337fd01fda068a9d46955c..8d44291a4ee2af8a5fe310b8e129f637049cd4cc
# Verify each commit has proper prefix and matches upstream
Verdict
2 blockers must be fixed before merge:
check-patch-compliance failures: 6 commits need FROMLIST:/UPSTREAM: prefix added to subject lines, and 1 commit needs content synchronized with its upstream Link or the discrepancy explained.
checkpatch style issues: While technically non-blocking (warnings/checks, not errors), these should be addressed:
Wrap 2 commit message lines to ≤75 characters
Add documentation comments for 2 mutex definitions
Consider fixing or documenting the macro argument reuse
Recommended action: Rebase the PR to fix commit messages (add prefixes, wrap long lines, add mutex comments), then force-push to re-trigger CI.

Shiraz Hashim (shashim-quic)

dt-bindings: iio: adc: Split out QCOM VADC channel properties

prefix all commits with valid tags (FROMLIST etc.)

qswat-orbit-external · 2026-06-10T15:05:18Z

Merge Check Failed: CR Not Eligible for Merge

CR 3828090 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity:kernel.qli.2.0
CR:3828090
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

qswat-orbit-external · 2026-06-13T08:37:35Z

Merge Check Failed: CR Not Eligible for Merge

CR 3871464 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity:kernel.qli.2.0
CR:3871464
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

qlijarvis · 2026-06-13T10:54:11Z

PR #664 — validate-patch

PR:#664

Verdict	Issues	Detailed Report
⚠️	3	Full report

Final Summary

Lore link present: Yes — all 10 patches have lore.kernel.org links
Lore link matches PR commits: Cannot verify — links reference future dates (2026) and are not accessible
Upstream patch status: Cannot determine — patches marked FROMLIST but links are not accessible; likely not yet posted or test data
PR present in qcom-next: Not checked — FROMLIST patches are not expected in qcom-next until merged upstream

Verdict: ⚠️ — click to expand
🔍 Patch Validation
PR:#664
Series: 10-patch FROMLIST series for PMIC5 Gen3 ADC and MBG thermal support
Verdict:⚠️ PARTIAL
Summary
This PR contains 10 FROMLIST patches adding support for Qualcomm PMIC5 Gen3 ADC and MBG thermal monitoring. All patches include lore.kernel.org links, but the links reference future dates (2026) and cannot be verified against actual upstream postings. One patch (08/10) has a tag ordering issue.
Commit Message Analysis
Patch Check Status Note
01/10 Subject format ✅ FROMLIST prefix correct
01/10 Authorship ✅ Satya Priya Kakitapalli, proper Co-developed-by
01/10 Link tag ⚠️ Link present but references future date (2026-06-01)
02/10 Subject format ✅ FROMLIST prefix correct
02/10 Authorship ✅ Satya Priya Kakitapalli, proper Co-developed-by
02/10 Link tag ⚠️ Link present but references future date (2026-06-01)
03/10 Subject format ✅ FROMLIST prefix correct
03/10 Authorship ✅ Jishnu Prakash
03/10 Link tag ⚠️ Link present but references future date (2026-04-30)
04/10 Subject format ✅ FROMLIST prefix correct
04/10 Authorship ✅ Ayyagari Ushasreevalli
04/10 Link tag ⚠️ Link present but references future date (2026-04-30)
05/10 Subject format ✅ FROMLIST prefix correct
05/10 Authorship ✅ Ayyagari Ushasreevalli
05/10 Link tag ⚠️ Link present but references future date (2026-04-30)
06/10 Subject format ✅ FROMLIST prefix correct
06/10 Authorship ✅ Jishnu Prakash
06/10 Link tag ⚠️ Link present but references future date (2026-01-30)
07/10 Subject format ✅ FROMLIST prefix correct
07/10 Authorship ✅ Jishnu Prakash
07/10 Link tag ⚠️ Link present but references future date (2026-01-30)
08/10 Subject format ✅ FROMLIST prefix correct
08/10 Authorship ✅ Jishnu Prakash
08/10 Link tag ❌ Two Link tags; second one after Signed-off-by (incorrect placement)
09/10 Subject format ✅ FROMLIST prefix correct
09/10 Authorship ✅ Jishnu Prakash
09/10 Link tag ⚠️ Link present but references future date (2026-05-26)
10/10 Subject format ✅ FROMLIST prefix correct
10/10 Authorship ✅ Jishnu Prakash
10/10 Link tag ⚠️ Link present but references future date (2026-05-26)
Issues
Critical:
Patch 08/10: Contains two Link tags, with the second one placed after Signed-off-by. This violates kernel commit message conventions where Link tags must appear before Signed-off-by tags. The two links are:
https://lore.kernel.org/all/20260130115421.2197892-4-jishnu.prakash@oss.qualcomm.com/
https://lore.kernel.org/all/20260130115421.2197892-5-jishnu.prakash@oss.qualcomm.com/
This suggests patch 08/10 may be a squashed commit combining two upstream patches (patches 4 and 5 from the upstream series). If this is intentional, both Link tags should be moved before the Signed-off-by tag.
Warning:
All lore.kernel.org links reference future dates (ranging from 2026-01-30 to 2026-06-01), making them unverifiable. These links cannot be fetched to confirm the patches match their upstream versions.
Minor:
Patch 01/10: Missing space after comma in commit body: "peripheral,the MBG" should be "peripheral, the MBG"
Diff Analysis
Cannot perform detailed diff comparison against upstream because lore links are not accessible (future dates). However, structural analysis shows:
Aspect Status Notes
File paths ✅ All paths follow kernel conventions
New files ✅ Appropriate for new driver support
SPDX headers ✅ Present in all new files
Code structure ✅ Follows kernel coding style
Kconfig/Makefile ✅ Properly integrated
Verdict
PARTIAL PASS - The patches follow kernel conventions and have proper FROMLIST prefixes, but cannot be fully validated due to:
Must fix: Patch 08/10 has incorrect Link tag placement (after Signed-off-by)
Cannot verify: Lore links reference future dates and are not accessible for diff comparison
Minor: Typo in patch 01/10 commit message
Recommendations
Fix patch 08/10: Move the second Link tag before the Signed-off-by line, or if this is a squashed commit, consider splitting it back into two separate commits to match the upstream series structure.
Verify lore links: Confirm these patches have actually been posted to the mailing lists. If not yet posted, consider removing the Link tags or updating them once the patches are actually submitted upstream.
Fix typo: In patch 01/10, add space after comma: "peripheral, the MBG"
Final Summary
Lore link present: Yes — all 10 patches have lore.kernel.org links
Lore link matches PR commits: Cannot verify — links reference future dates (2026) and are not accessible
Upstream patch status: Cannot determine — patches marked FROMLIST but links are not accessible; likely not yet posted or test data
PR present in qcom-next: Not checked — FROMLIST patches are not expected in qcom-next until merged upstream

qlijarvis · 2026-06-13T10:54:12Z

PR #664 — checker-log-analyzer

PR:#664
Checker run:https://github.com/qualcomm-linux/kernel-config/actions/runs/27464074047

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	Merge conflict - cannot run
dt-binding-check	❌	Merge conflict - cannot run
dtb-check	❌	Merge conflict - cannot run
sparse-check	❌	Merge conflict - cannot run
check-uapi-headers	❌	Merge conflict - cannot run
check-patch-compliance	❌	Merge conflict - cannot run
tag-check	✅	All commits use FROMLIST: prefix
qcom-next-check	✅	FROMLIST: commits only

Detailed report: Full report

Checker analysis — click to expand
🤖 CI Checker Analysis (checker-log-analyzer)
PR:#664 - FROMLIST: Add Qualcomm MBG thermal monitoring and ADC5 Gen3 support (10 patches)
Source:https://github.com/qualcomm-linux/kernel-config/actions/runs/27464074047
Checker Result Summary
checkpatch ❌ Merge conflict - cannot run
dt-binding-check ❌ Merge conflict - cannot run
dtb-check ❌ Merge conflict - cannot run
sparse-check ❌ Merge conflict - cannot run
check-uapi-headers ❌ Merge conflict - cannot run
check-patch-compliance ❌ Merge conflict - cannot run
tag-check ✅ All commits use FROMLIST: prefix
qcom-next-check ✅ FROMLIST: commits only
❌ All Checkers (Merge Conflict)
Root cause: PR #664 cannot be merged into the baseline branch qcom-6.18.y due to a content conflict in arch/arm64/boot/dts/qcom/lemans-pmics.dtsi.
Failure details:
2026-06-13T10:39:53.1929402Z Auto-merging arch/arm64/boot/dts/qcom/lemans-pmics.dtsi
2026-06-13T10:39:53.1931162Z CONFLICT (content): Merge conflict in arch/arm64/boot/dts/qcom/lemans-pmics.dtsi
2026-06-13T10:39:53.2556227Z Automatic merge failed; fix conflicts and then commit the result.
2026-06-13T10:39:53.2610377Z Merge failed or conflicts detected. Aborting merge.
2026-06-13T10:39:53.4170116Z ##[error]Process completed with exit code 3.
All six checker jobs (checkpatch, dt-binding-check, dtb-check, sparse-check, check-uapi-headers, check-patch-compliance) failed at the merge stage before any actual validation could run.
Analysis:
The PR adds ADC5 Gen3 support and thermal monitoring to arch/arm64/boot/dts/qcom/lemans-pmics.dtsi, including:
New ADC nodes for PMM8654au PMICs (pmm8654au_0 through pmm8654au_3)
RTC node for pmm8654au_0
io-channels properties for thermal sensors
Include for qcom-adc5-gen3.h header
The conflict indicates that the baseline branch qcom-6.18.y has diverged from the state this PR was based on. Changes to lemans-pmics.dtsi have been merged into qcom-6.18.y since this PR branch was created, causing overlapping modifications.
Fix:
The PR author needs to rebase the PR branch onto the latest qcom-6.18.y:
# In the PR branch
git fetch origin qcom-6.18.y
git rebase origin/qcom-6.18.y
# Resolve conflicts in arch/arm64/boot/dts/qcom/lemans-pmics.dtsi# The conflict will likely involve:# - Placement of new ADC nodes# - Ordering of device nodes within PMICs# - Potential duplicate additions if similar changes landed# After resolving conflicts
git add arch/arm64/boot/dts/qcom/lemans-pmics.dtsi
git rebase --continue
# Force push the rebased branch
git push --force-with-lease
Reproduce locally:
git clone https://github.com/qualcomm-linux/kernel.git
cd kernel
git checkout qcom-6.18.y
git fetch origin pull/664/head:pr-664
git merge --no-commit pr-664
# Conflict will appear in arch/arm64/boot/dts/qcom/lemans-pmics.dtsi
Verdict
1 blocker to fix: Merge conflict in arch/arm64/boot/dts/qcom/lemans-pmics.dtsi must be resolved by rebasing PR #664 onto the latest qcom-6.18.y baseline. Once rebased, all checkers will be able to run and validate the patches.

Salendarsingh Gaud (sgaud-quic) · 2026-06-13T11:39:36Z

raryan-qcom rebase PR on tip, to resolve merge conflicts

Salendarsingh Gaud (sgaud-quic) · 2026-06-13T16:22:27Z

raryan-qcom please rebase on tip instead of merging qcom-6.18.y to your branch.

Add bindings for the Qualcomm MBG (Master Bandgap) temperature alarm peripheral found on the PM8775 PMIC. Unlike the existing SPMI temp alarm peripheral,the MBG peripheral supports both hot and cold threshold monitoring across two programmable levels (LVL1 and LVL2), with interrupt status reported via a fault status register over SPMI. Link: https://lore.kernel.org/all/20260601-spmi-mbg-driver-v1-1-b4892b55a17f@oss.qualcomm.com/ Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com> Co-developed-by: Sachin Gupta <sachin.gupta@oss.qualcomm.com> Signed-off-by: Sachin Gupta <sachin.gupta@oss.qualcomm.com>

Add driver for the Qualcomm MBG thermal monitoring device. It monitors the die temperature, and when there is a level 1 upper threshold violation, it receives an interrupt over spmi. The driver reads the fault status register and notifies thermal accordingly. Link: https://lore.kernel.org/all/20260601-spmi-mbg-driver-v1-2-b4892b55a17f@oss.qualcomm.com/ Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com> Co-developed-by: Sachin Gupta <sachin.gupta@oss.qualcomm.com> Signed-off-by: Sachin Gupta <sachin.gupta@oss.qualcomm.com>

Add macro definitions for virtual channels (combination of ADC channel number and PMIC SID number), to be used in devicetree by clients of ADC5 GEN3 device and in the "reg" property of ADC channels. Link: https://lore.kernel.org/all/20260430-adc5_gen3_dt-v1-1-ab2bb40fd490@oss.qualcomm.com/ Signed-off-by: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>

Add ADC nodes for the four PMM8654au PMICs (pmm8654au_0 through pmm8654au_3) on the Lemans platform. Each ADC node exposes the following ADC channels: - DIE_TEMP: PMIC die temperature channel - VPH_PWR: Battery/supply voltage channel Also add the io-channels and io-channel-names properties under the temp-alarm nodes so that they can get temperature reading from the ADC die_temp channels. Link: https://lore.kernel.org/all/20260430-adc5_gen3_dt-v1-2-ab2bb40fd490@oss.qualcomm.com/ Signed-off-by: Ayyagari Ushasreevalli <aushasre@qti.qualcomm.com> Signed-off-by: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>

Add ADC nodes for PMM8620AU PMIC instances (SID 0 and SID 2) present on the Monaco platform. Each ADC node exposes the following ADC channels: - DIE_TEMP: PMIC die temperature channel - VPH_PWR: Battery/supply voltage channel Link: https://lore.kernel.org/all/20260430-adc5_gen3_dt-v1-3-ab2bb40fd490@oss.qualcomm.com/ Signed-off-by: Ayyagari Ushasreevalli <aushasre@qti.qualcomm.com> Signed-off-by: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>

Split out the common channel properties for QCOM VADC devices into a separate file so that it can be included as a reference for devices using them. This will be needed for the upcoming ADC5 Gen3 binding support patch, as ADC5 Gen3 also uses all of these common properties. Link: https://lore.kernel.org/all/20260130115421.2197892-2-jishnu.prakash@oss.qualcomm.com/ Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Signed-off-by: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>

For the PMIC5-Gen3 type PMICs, ADC peripheral is present in HW for the following PMICs: PMK8550, PM8550, PM8550B and PM8550VX PMICs. It is similar to PMIC5-Gen2, with SW communication to ADCs on all PMICs going through PBS(Programmable Boot Sequence) firmware through a single register interface. This interface is implemented on SDAM (Shared Direct Access Memory) peripherals on the master PMIC PMK8550 rather than a dedicated ADC peripheral. Add documentation for PMIC5 Gen3 ADC and update SPMI PMIC bindings to allow ADC5 Gen3 as adc@ subnode. Link: https://lore.kernel.org/all/20260130115421.2197892-3-jishnu.prakash@oss.qualcomm.com/ Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Signed-off-by: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com> Acked-by: Lee Jones <lee@kernel.org>

qlijarvis · 2026-06-14T02:21:34Z

PR #664 — validate-patch

PR:#664

Verdict	Issues	Detailed Report
⚠️	0	Full report

Final Summary

Lore link present: Yes — all 10 patches have Link: tags to lore.kernel.org
Lore link matches PR commits: Cannot verify — links reference future dates (2026) and are not accessible
Upstream patch status: Not yet upstream — FROMLIST prefix indicates staged for submission but not posted/accepted
PR present in qcom-next: Not checked — FROMLIST patches for future upstream submission

Verdict: ⚠️ — click to expand
🔍 Patch Validation
PR:#664
Upstream commit: Multiple FROMLIST patches (10 commits)
Verdict:⚠️ PARTIAL
Summary
This PR contains 10 FROMLIST patches related to Qualcomm thermal monitoring and ADC support. All patches include lore.kernel.org links, but these links reference future dates (2026) and are not currently accessible for verification.
Commit Message Analysis
Patch Subject Status Issues
01/10 dt-bindings: thermal: Add Qualcomm MBG thermal monitor support ⚠️ Missing space: "peripheral,the" → "peripheral, the"
02/10 thermal: qcom: Add support for Qualcomm MBG thermal monitoring ✅ Clean
03/10 arm64: dts: qcom: Add header file for ADC5 Gen3 channel macros ✅ Clean
04/10 arm64: dts: qcom: lemans-pmics: Add ADC support for PMM8654au ✅ Clean
05/10 arm64: dts: qcom: monaco-pmics: Add ADC support for PMM8620AU ✅ Clean
06/10 dt-bindings: iio: adc: Split out QCOM VADC channel properties ✅ Has Reviewed-by and Acked-by tags
07/10 dt-bindings: iio: adc: Add support for QCOM PMIC5 Gen3 ADC ✅ Has Acked-by and Reviewed-by tags
08/10 iio: adc: Add support for QCOM PMIC5 Gen3 ADC ⚠️ Two Link: tags (second after SoB)
09/10 iio: adc: qcom-spmi-adc5-gen3: Share SDAM0 IRQ ✅ Has Reviewed-by tag
10/10 thermal: qcom: add support for PMIC5 Gen3 ADC thermal monitoring ✅ Clean
Authorship & Tag Hygiene
Check Status Notes
Author emails valid ✅ All use @quicinc.com, @qti.qualcomm.com, or @oss.qualcomm.com
Signed-off-by present ✅ All patches have proper SoB tags
Co-developed-by format ✅ Patches 01-02 use Co-developed-by correctly
Reviewer tags ✅ Patches 06, 07, 09 have review tags
Link tag placement ⚠️ Patch 08 has second Link after SoB (non-standard)
Lore Link Verification
Status: ❌ CANNOT VERIFY
All lore.kernel.org links reference future dates and are inaccessible:
20260601-spmi-mbg-driver-v1-* (June 1, 2026)
20260430-adc5_gen3_dt-v1-* (April 30, 2026)
20260130115421.2197892-* (January 30, 2026)
20260526-gen3_adc_tm-v2-* (May 26, 2026)
Interpretation: These appear to be pre-submission patches staged for future upstream posting, not yet available on lore.
Issues
Minor:
Patch 01: Missing space in body: "peripheral,the" should be "peripheral, the"
Patch 08: Unusual dual Link: tag with second one after Signed-off-by (may be intentional for combined patches)
All patches: Lore links not verifiable (future dates)
Diff Validation
Cannot compare diffs against upstream since lore links are inaccessible. FROMLIST prefix indicates these are pre-submission patches.
Verdict
⚠️ CONDITIONAL APPROVAL
Rationale:
Commit messages follow kernel conventions (one minor spacing issue)
Proper authorship and sign-off chains maintained
Appropriate review tags present on binding patches
FROMLIST prefix correctly indicates pre-submission status
Cannot verify diff faithfulness due to inaccessible upstream links
Required before merge:
Fix spacing in patch 01: "peripheral,the" → "peripheral, the"
Clarify/verify dual Link: tag in patch 08 is intentional
Recommended:
Add PR description note that these are pre-submission patches
Confirm lore links will become valid upon upstream posting
Final Summary
Lore link present: Yes — all 10 patches have Link: tags to lore.kernel.org
Lore link matches PR commits: Cannot verify — links reference future dates (2026) and are not accessible
Upstream patch status: Not yet upstream — FROMLIST prefix indicates staged for submission but not posted/accepted
PR present in qcom-next: Not checked — FROMLIST patches for future upstream submission

qlijarvis · 2026-06-14T02:21:35Z

PR #664 — checker-log-analyzer

PR:#664
Checker run:https://github.com/qualcomm-linux/kernel-config/actions/runs/27484836290

Checker	Result	Summary
Checker	Result	Summary
checkpatch	⚠️	2 CHECK warnings (non-blocking style issues)
dt-binding-check	✅	All bindings validated successfully
dtb-check	✅	All device trees validated successfully
sparse-check	✅	No sparse warnings detected
check-uapi-headers	✅	No UAPI header changes detected
check-patch-compliance	❌	2 commits failed: invalid lore link + patch mismatch
tag-check	✅	All commits properly tagged with FROMLIST:
qcom-next-check	✅	FROMLIST: commits only (appropriate for this PR)

Detailed report: Full report

Checker analysis — click to expand
🤖 CI Checker Analysis (checker-log-analyzer)
PR:#664 - FROMLIST: thermal/iio: Add Qualcomm MBG thermal monitor and PMIC5 Gen3 ADC support
Source:https://github.com/qualcomm-linux/kernel-config/actions/runs/27484836290
Checker Result Summary
checkpatch ⚠️ 2 CHECK warnings (non-blocking style issues)
dt-binding-check ✅ All bindings validated successfully
dtb-check ✅ All device trees validated successfully
sparse-check ✅ No sparse warnings detected
check-uapi-headers ✅ No UAPI header changes detected
check-patch-compliance ❌ 2 commits failed: invalid lore link + patch mismatch
tag-check ✅ All commits properly tagged with FROMLIST:
qcom-next-check ✅ FROMLIST: commits only (appropriate for this PR)
❌ check-patch-compliance
Root cause: Two commits have lore.kernel.org link issues preventing automated patch verification.
Failure details:
Commit 8/10:FROMLIST: iio: adc: Add support for QCOM PMIC5 Gen3 ADC (9be3953)
Something seems wrong with the provided link. Please verify it
Try below command to run locally-
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260130115421.2197892-4-jishnu.prakash@oss.qualcomm.com/
https://lore.kernel.org/all/20260130115421.2197892-5-jishnu.prakash@oss.qualcomm.com/
This commit has two Link: tags pointing to patches 4 and 5 from the same series. The checker cannot handle multiple links and fails validation.
Commit 10/10:FROMLIST: thermal: qcom: add support for PMIC5 Gen3 ADC thermal monitoring (db4bcbf)
Change is different from the one mentioned in Link
The patch content in the PR differs from the upstream lore patch at:
https://lore.kernel.org/all/20260526-gen3_adc_tm-v2-2-702fbac919ac@oss.qualcomm.com/
Fix:
For commit 8/10 (9be3953):
This commit appears to combine two upstream patches (patches 4 and 5 from the series)
Option A (Recommended): Split this commit into two separate commits, each with a single Link: tag matching the upstream patches
Option B: Keep as a single commit but remove one Link: tag and add a note in the commit message explaining it combines two upstream patches
For commit 10/10 (db4bcbf):
Compare the PR patch against the upstream lore patch to identify differences
Option A: If the differences are intentional (e.g., backport adaptations), document them in the commit message
Option B: If the differences are unintentional, update the patch to match the upstream version exactly
Option C: If this is a newer version, update the Link: tag to point to the correct upstream version
Reproduce locally:
# Verify commit 8/10 links
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260130115421.2197892-4-jishnu.prakash@oss.qualcomm.com/
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260130115421.2197892-5-jishnu.prakash@oss.qualcomm.com/
# Verify commit 10/10 matches upstream
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20260526-gen3_adc_tm-v2-2-702fbac919ac@oss.qualcomm.com/
git diff HEAD <downloaded-patch># Run full compliance checkcd kernel && bash ../kernel-checkers/check-patch-compliance.sh \
--kernel-src . \
--base 9740e45b352ca1e5d7f40f5754b977d3533dc8b4 \
--head db4bcbf07a2e0f3f726a92924c444ad69127e52e
⚠️ checkpatch (non-blocking)
Root cause: Two commits have minor style CHECK warnings that are informational only.
Failure details:
Commit 2/10:FROMLIST: thermal: qcom: Add support for Qualcomm MBG thermal monitoring (1044739)
CHECK: struct mutex definition without comment
#108: FILE: drivers/thermal/qcom/qcom-spmi-mbg-tm.c:47:
+	struct mutex lock;
Commit 8/10:FROMLIST: iio: adc: Add support for QCOM PMIC5 Gen3 ADC (9be3953)
CHECK: struct mutex definition without comment
#161: FILE: drivers/iio/adc/qcom-spmi-adc5-gen3.c:70:
+	struct mutex lock;
CHECK: Macro argument reuse 'x' - possible side-effects?
#1037: FILE: include/linux/iio/adc/qcom-adc5-gen3-common.h:80:
+#define ADC5_GEN3_V_CHAN(x) \
+	(FIELD_PREP(ADC5_GEN3_VIRTUAL_SID_MASK, (x).sid) | (x).channel)
Fix:
These are CHECK-level warnings (not errors or warnings), which are typically informational and often acceptable in kernel code. However, if you want to address them:
Add comments above the mutex definitions explaining their purpose:
/* Protects device state during temperature reads */structmutexlock;
For the macro argument reuse, this is a false positive since x is a struct being accessed, not evaluated multiple times. This can be safely ignored or documented with a comment.
Note: These checkpatch CHECKs do not block merge and are commonly seen in upstream kernel patches. The checker exited with code 1 due to the presence of style issues, but CHECK-level findings are advisory only.
Reproduce locally:
cd kernel
./scripts/checkpatch.pl --strict --summary-file --ignore FILE_PATH_CHANGES \
--git 9740e45b352ca1e5d7f40f5754b977d3533dc8b4..db4bcbf07a2e0f3f726a92924c444ad69127e52e
Verdict
2 blockers must be fixed before merge:
Commit 8/10: Resolve multiple Link: tags issue (split commit or remove duplicate link)
Commit 10/10: Reconcile patch differences with upstream lore version
The checkpatch warnings are non-blocking style suggestions. All other checkers (dt-binding-check, dtb-check, sparse-check, check-uapi-headers) passed successfully.

The ADC architecture on PMIC5 Gen3 is similar to that on PMIC5 Gen2, with all SW communication to ADC going through PMK8550 which communicates with other PMICs through PBS. One major difference is that the register interface used here is that of an SDAM (Shared Direct Access Memory) peripheral present on PMK8550. There may be more than one SDAM used for ADC5 Gen3 and each has eight channels, which may be used for either immediate reads (same functionality as previous PMIC5 and PMIC5 Gen2 ADC peripherals) or recurring measurements (same as ADC_TM functionality). By convention, we reserve the first channel of the first SDAM for all immediate reads and use the remaining channels across all SDAMs for ADC_TM monitoring functionality. Add support for PMIC5 Gen3 ADC driver for immediate read functionality. ADC_TM is implemented as an auxiliary thermal driver under this ADC driver. Link: https://lore.kernel.org/all/20260130115421.2197892-4-jishnu.prakash@oss.qualcomm.com/ Signed-off-by: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>

…auxiliary driver The SDAM0 IRQ can be triggered for both EOC (end of conversion) events for immediate ADC reads done in this driver and for threshold violation events, based on ADC_TM thresholds configured from the auxiliary ADC_TM driver on TM channels on the first SDAM. At present, this interrupt is handled only in the ISR in the main ADC driver.When the ISR is triggered for an ADC_TM event, this driver notifies the ADC_TM driver by calling a notifier callback exposed from it for this purpose. To simplify the interrupt handling in both drivers, share the interrupt between the drivers. With this, ADC_TM interrupts on SDAM0 will be handled directly in the ADC_TM driver, so remove the notifier callback and all TM interrupt handling in the main ADC ISR. Link: https://lore.kernel.org/all/20260526-gen3_adc_tm-v2-1-702fbac919ac@oss.qualcomm.com/ Signed-off-by: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com> Reviewed-by: Jonathan Cameron <jic23@kernel.org>

…oring Add support for ADC_TM part of PMIC5 Gen3. This is an auxiliary driver under the Gen3 ADC driver, which implements the threshold setting and interrupt generating functionalities of QCOM ADC_TM drivers, used to support thermal trip points. Link: https://lore.kernel.org/all/20260526-gen3_adc_tm-v2-2-702fbac919ac@oss.qualcomm.com/ Signed-off-by: Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>

qlijarvis · 2026-06-15T06:08:10Z

PR #664 — validate-patch

PR:#664

Verdict	Issues	Detailed Report
⚠️	3	Full report

Final Summary

Lore link present: Yes — all 10 commits include Link: tags pointing to lore.kernel.org
Lore link matches PR commits: Cannot verify — lore links are inaccessible (HTTP 000); patches may not be posted yet or are pending review
Upstream patch status: In review (presumed) — FROMLIST prefix indicates patches are from mailing list; review tags from Krzysztof Kozlowski, Jonathan Cameron, and Lee Jones suggest active review
PR present in qcom-next: Not checked — per constraints, no kernel tree access

Recommendation: Fix the two typos in commit messages (01/10 and 09/10) before merge. Verify lore links are accessible and patches match once they are publicly available on lore.kernel.org.

Verdict: ⚠️ — click to expand
🔍 Patch Validation
PR:#664 - FROMLIST: Add PMIC5 Gen3 ADC and thermal monitoring support
Upstream commit: N/A (10-patch series marked FROMLIST)
Verdict:⚠️ PARTIAL
Commit Message Analysis
Commit Check Status Note
01/10 Subject format ✅ Proper FROMLIST prefix
01/10 Body clarity ⚠️ Typo: "peripheral,the" → "peripheral, the"
01/10 Link tag ✅ Lore link present
01/10 Authorship ✅ Preserved with Co-developed-by
02/10 Subject format ✅ Proper FROMLIST prefix
02/10 Body clarity ✅ Clear description
03-05/10 DT patches ✅ Well-formatted
06-08/10 IIO/binding patches ✅ Comprehensive descriptions
09/10 Body clarity ⚠️ Typo: "driver.When" → "driver. When"
10/10 Thermal driver ✅ Clear description
Tag Hygiene
Check Status Note
Signed-off-by chain ✅ All commits properly signed
Co-developed-by ✅ Correctly paired with SoB (commits 1-2)
Review tags ✅ Krzysztof Kozlowski, Jonathan Cameron, Lee Jones
Link tags ✅ All 10 commits have lore.kernel.org links
Fixes tags N/A Not applicable (new feature)
Diff Structure
File Category Status Notes
DT bindings (YAML) ✅ Proper SPDX headers (GPL-2.0-only OR BSD-2-Clause)
DT source files ✅ Clean additions for Lemans/Monaco platforms
Driver code (C) ✅ Proper SPDX GPL-2.0-only headers
Kconfig/Makefile ✅ Consistent formatting
Header files ✅ Include guards and proper structure
Issues
Minor formatting issues:
Commit 01/10 - Missing space in commit message: "peripheral,the" should be "peripheral, the"
Commit 09/10 - Missing space in commit message: "driver.When" should be "driver. When"
Lore link accessibility:
All 10 lore.kernel.org links are present but currently inaccessible (HTTP 000)
Links point to dates in May-June 2026, suggesting patches may not be posted yet or are in review
Cannot verify diff faithfulness to upstream without accessible lore patches
Verdict
Merge with minor fixes recommended. The patch series is well-structured with proper FROMLIST prefixes, comprehensive commit messages, correct authorship chains, and review tags from maintainers. Two minor typos in commit messages should be fixed before merge. Cannot verify diff faithfulness to lore patches due to link inaccessibility.
Final Summary
Lore link present: Yes — all 10 commits include Link: tags pointing to lore.kernel.org
Lore link matches PR commits: Cannot verify — lore links are inaccessible (HTTP 000); patches may not be posted yet or are pending review
Upstream patch status: In review (presumed) — FROMLIST prefix indicates patches are from mailing list; review tags from Krzysztof Kozlowski, Jonathan Cameron, and Lee Jones suggest active review
PR present in qcom-next: Not checked — per constraints, no kernel tree access
Recommendation: Fix the two typos in commit messages (01/10 and 09/10) before merge. Verify lore links are accessible and patches match once they are publicly available on lore.kernel.org.

qlijarvis · 2026-06-15T06:08:11Z

PR #664 — checker-log-analyzer

PR:#664
Checker run:https://github.com/qualcomm-linux/kernel-config/actions/runs/27525737009

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	3 CHECK warnings across 2 commits
dt-binding-check	✅	All bindings validated successfully
dtb-check	✅	All DTB validations passed
sparse-check	✅	No sparse warnings
check-uapi-headers	✅	No UAPI header changes
check-patch-compliance	❌	1 commit differs from upstream lore link
tag-check	N/A	All commits properly tagged with FROMLIST:
qcom-next-check	✅	FROMLIST: commits only

Detailed report: Full report

Checker analysis — click to expand
🤖 CI Checker Analysis (checker-log-analyzer)
PR:#664 - FROMLIST: Add Qualcomm MBG thermal monitor and PMIC5 Gen3 ADC support
Source:https://github.com/qualcomm-linux/kernel-config/actions/runs/27525737009
Checker Result Summary
checkpatch ❌ 3 CHECK warnings across 2 commits
dt-binding-check ✅ All bindings validated successfully
dtb-check ✅ All DTB validations passed
sparse-check ✅ No sparse warnings
check-uapi-headers ✅ No UAPI header changes
check-patch-compliance ❌ 1 commit differs from upstream lore link
tag-check N/A All commits properly tagged with FROMLIST:
qcom-next-check ✅ FROMLIST: commits only
❌ checkpatch
Root cause: Missing documentation comments for mutex struct members in two driver files.
Failure details:
Commit 1044739 - drivers/thermal/qcom/qcom-spmi-mbg-tm.c:47
CHECK: struct mutex definition without comment
#108: FILE: drivers/thermal/qcom/qcom-spmi-mbg-tm.c:47:
+	struct mutex lock;
Commit 64a88aa - drivers/iio/adc/qcom-spmi-adc5-gen3.c:70
CHECK: struct mutex definition without comment
#160: FILE: drivers/iio/adc/qcom-spmi-adc5-gen3.c:70:
+	struct mutex lock;
CHECK: Macro argument reuse 'x' - possible side-effects?
#1036: FILE: include/linux/iio/adc/qcom-adc5-gen3-common.h:80:
+#define ADC5_GEN3_V_CHAN(x) \
+	(FIELD_PREP(ADC5_GEN3_VIRTUAL_SID_MASK, (x).sid) | (x).channel)
Fix:
Add kernel-doc style comments above the mutex fields explaining their purpose:
In drivers/thermal/qcom/qcom-spmi-mbg-tm.c:47: Document what the lock protects
In drivers/iio/adc/qcom-spmi-adc5-gen3.c:70: Document what the lock protects
For the macro argument reuse warning in include/linux/iio/adc/qcom-adc5-gen3-common.h:80:
This is a false positive if x is always a simple struct reference
Can be ignored if the macro is only used with struct literals/variables
Or refactor to use a compound statement with a temporary variable if side effects are possible
Reproduce locally:
./scripts/checkpatch.pl --strict --git 9740e45b352ca1e5d7f40f5754b977d3533dc8b4..a38a761ee7fb5190731f842f848aeb9628a43903
❌ check-patch-compliance
Root cause: Commit a38a761ee7fb ("FROMLIST: thermal: qcom: add support for PMIC5 Gen3 ADC thermal monitoring") differs from the upstream patch referenced in its Link tag.
Failure details:
Checking commit: FROMLIST: thermal: qcom: add support for PMIC5 Gen3 ADC thermal monitoring
Change is different from the one mentioned in Link
The commit references:
Link: https://lore.kernel.org/all/20260526-gen3_adc_tm-v2-2-702fbac919ac@oss.qualcomm.com/
Fix:
This checker validates that FROMLIST patches match their upstream lore.kernel.org references exactly. The failure indicates one of:
Local modifications were made - If intentional changes were applied to the upstream patch, either:
Remove the Link: tag and change prefix from FROMLIST: to BACKPORT: or remove prefix entirely
Or ensure the patch matches the upstream version exactly
Wrong Link reference - Verify the Link URL points to the correct version of the patch
Upstream was updated - If the upstream patch was revised after this PR was created, update the local commit to match the latest upstream version
Reproduce locally:
# Clone kernel-checkers repo
git clone https://github.com/qualcomm-linux/kernel-checkers.git
# Run the compliance checker
bash kernel-checkers/check-patch-compliance.sh \
--kernel-src . \
--base 9740e45b352ca1e5d7f40f5754b977d3533dc8b4 \
--head a38a761ee7fb5190731f842f848aeb9628a43903
Verdict
2 blockers must be fixed before merge:
checkpatch: Add mutex documentation comments (3 CHECK warnings)
check-patch-compliance: Resolve mismatch between local commit and upstream lore link for commit a38a761
All other checkers (dt-binding-check, dtb-check, sparse-check, check-uapi-headers) passed successfully.

qcomlnxci · 2026-06-15T06:38:23Z

Test Matrix

Test Case	lemans-evk	monaco-evk	qcs615-ride	qcs6490-rb3gen2	qcs8300-ride	qcs9100-ride-r3	x1e80100-crd
BT_FW_KMD_Service	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	◻️
BT_ON_OFF	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	◻️
BT_SCAN	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	◻️
CPUFreq_Validation	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	◻️
CPU_affinity	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	◻️
DSP_AudioPD	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	⚠️ skip	◻️
Ethernet	⚠️ skip	✅ Pass	◻️	⚠️ skip	⚠️ skip	⚠️ skip	◻️
Freq_Scaling	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	◻️
GIC	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	◻️
IPA	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	◻️
Interrupts	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	◻️
OpenCV	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	◻️
PCIe	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	◻️
Probe_Failure_Check	❌ Fail	❌ Fail	◻️	❌ Fail	❌ Fail	❌ Fail	◻️
RMNET	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	◻️
UFS_Validation	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	◻️
USBHost	❌ Fail	❌ Fail	◻️	❌ Fail	❌ Fail	❌ Fail	◻️
WiFi_Firmware_Driver	❌ Fail	❌ Fail	◻️	✅ Pass	✅ Pass	✅ Pass	◻️
WiFi_OnOff	✅ Pass	❌ Fail	◻️	✅ Pass	✅ Pass	✅ Pass	◻️
adsp_remoteproc	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	❌ Fail	◻️
cdsp_remoteproc	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	❌ Fail	◻️
gpdsp_remoteproc	✅ Pass	✅ Pass	◻️	⚠️ skip	✅ Pass	❌ Fail	◻️
hotplug	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	◻️
irq	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	◻️
kaslr	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	◻️
pinctrl	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	◻️
qcom_hwrng	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	◻️
remoteproc	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	❌ Fail	◻️
rngtest	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	◻️
shmbridge	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	◻️
smmu	❌ Fail	✅ Pass	◻️	✅ Pass	✅ Pass	❌ Fail	◻️
watchdog	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	◻️
wpss_remoteproc	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass	◻️

qcomlnxci · 2026-06-15T06:38:28Z

Test jobs on a38a761

qcomlnxci · 2026-06-15T12:29:20Z

Test jobs on a38a761

qcomlnxci · 2026-06-15T12:29:41Z

Test Matrix

Test Case	lemans-evk	monaco-evk	qcs615-ride	qcs6490-rb3gen2	qcs8300-ride	qcs9100-ride-r3	x1e80100-crd
BT_FW_KMD_Service	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
BT_ON_OFF	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
BT_SCAN	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
CPUFreq_Validation	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
CPU_affinity	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
DSP_AudioPD	✅ Pass	✅ Pass	⚠️ skip	✅ Pass	✅ Pass	⚠️ skip	◻️
Ethernet	⚠️ skip	✅ Pass	⚠️ skip	⚠️ skip	⚠️ skip	⚠️ skip	◻️
Freq_Scaling	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
GIC	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
IPA	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
Interrupts	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
OpenCV	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
PCIe	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
Probe_Failure_Check	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	◻️
RMNET	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
UFS_Validation	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
USBHost	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	◻️
WiFi_Firmware_Driver	❌ Fail	❌ Fail	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
WiFi_OnOff	✅ Pass	❌ Fail	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
adsp_remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	❌ Fail	◻️
cdsp_remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	❌ Fail	◻️
gpdsp_remoteproc	✅ Pass	✅ Pass	⚠️ skip	⚠️ skip	✅ Pass	❌ Fail	◻️
hotplug	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
irq	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
kaslr	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
pinctrl	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
qcom_hwrng	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	❌ Fail	◻️
rngtest	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
shmbridge	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
smmu	❌ Fail	✅ Pass	❌ Fail	✅ Pass	✅ Pass	❌ Fail	◻️
watchdog	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
wpss_remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️

raryan-qcom requested review from a team, Nicolas Dechesne (ndechesne), Salendarsingh Gaud (sgaud-quic) and yijiyang June 5, 2026 11:18

raryan-qcom force-pushed the for-mbgthermal branch from 8244fd7 to 4cb5a0bCompare June 8, 2026 12:09

raryan-qcom changed the title ~~FROMLIST: thermal: qcom: Add support for Qualcomm MBG thermal monitoring~~qli-2.0 GA Critical Fix: FROMLIST: thermal: qcom: Add support for Qualcomm MBG thermal monitoringJun 10, 2026

raryan-qcom changed the title ~~qli-2.0 GA Critical Fix: FROMLIST: thermal: qcom: Add support for Qualcomm MBG thermal monitoring~~FROMLIST: thermal: qcom: Add support for Qualcomm MBG thermal monitoringJun 10, 2026

raryan-qcom changed the title ~~FROMLIST: thermal: qcom: Add support for Qualcomm MBG thermal monitoring~~Add support for Qualcomm MBG driver and ADC5 Gen3 channelsJun 10, 2026

Salendarsingh Gaud (sgaud-quic) added this to the qli-2.0 GA pull-request freeze milestone Jun 10, 2026

raryan-qcom force-pushed the for-mbgthermal branch from 4cb5a0b to b8f2de0Compare June 10, 2026 13:28

Shiraz Hashim (shashim-quic) requested changes Jun 10, 2026
View reviewed changes

raryan-qcom force-pushed the for-mbgthermal branch from b8f2de0 to 6cb3be5Compare June 10, 2026 15:05

Shiraz Hashim (shashim-quic) previously approved these changes Jun 13, 2026
View reviewed changes

qcomlnxci requested a review from a teamJune 13, 2026 10:23

raryan-qcom dismissed Shiraz Hashim (shashim-quic)’s stale review via 32620efJune 13, 2026 12:45

Satya Priya Kakitapalliand others added 7 commits June 13, 2026 22:47

raryan-qcom force-pushed the for-mbgthermal branch from 32620ef to db4bcbfCompare June 13, 2026 17:29

jprakash-qc added 3 commits June 15, 2026 10:46

raryan-qcom force-pushed the for-mbgthermal branch from db4bcbf to a38a761Compare June 15, 2026 05:18

Shiraz Hashim (shashim-quic) approved these changes Jun 15, 2026
View reviewed changes

Salendarsingh Gaud (sgaud-quic) merged commit fc49005 into qualcomm-linux:qcom-6.18.yJun 17, 2026
6 of 8 checks passed

Uh oh!

Conversation

raryan-qcom commented Jun 5, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qswat-orbit-externalBot commented Jun 5, 2026

Uh oh!

qswat-orbit-externalBot commented Jun 5, 2026

Uh oh!

qswat-orbit-externalBot commented Jun 5, 2026

Uh oh!

qswat-orbit-externalBot commented Jun 5, 2026

Uh oh!

raryan-qcom commented Jun 5, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qswat-orbit-externalBot commented Jun 5, 2026

Uh oh!

qswat-orbit-externalBot commented Jun 8, 2026

Uh oh!

qswat-orbit-externalBot commented Jun 8, 2026

Uh oh!

qswat-orbit-externalBot commented Jun 8, 2026

Uh oh!

qswat-orbit-externalBot commented Jun 9, 2026

Uh oh!

qswat-orbit-externalBot commented Jun 10, 2026

Uh oh!

qswat-orbit-externalBot commented Jun 10, 2026

Uh oh!

qswat-orbit-externalBot commented Jun 10, 2026

Uh oh!

qswat-orbit-externalBot commented Jun 10, 2026

Uh oh!

qswat-orbit-externalBot commented Jun 10, 2026

Uh oh!

qlijarvis commented Jun 10, 2026

PR #664 — validate-patch

Final Summary

🔍 Patch Validation

Commit Message

Critical Issues

Diff

FROMLIST Prefix Usage

Issues

Verdict

Recommendations

Final Summary

Uh oh!

qlijarvis commented Jun 10, 2026

PR #664 — checker-log-analyzer

🤖 CI Checker Analysis (checker-log-analyzer)

❌ checkpatch

❌ check-patch-compliance

Verdict

Uh oh!

Shiraz Hashim (shashim-quic) left a comment

Choose a reason for hiding this comment

Uh oh!

qswat-orbit-externalBot commented Jun 10, 2026

Uh oh!

qswat-orbit-externalBot commented Jun 13, 2026

Uh oh!

qlijarvis commented Jun 13, 2026

PR #664 — validate-patch

Final Summary

🔍 Patch Validation

Summary

Commit Message Analysis

Issues

Diff Analysis

Verdict

Recommendations

Final Summary

Uh oh!

qlijarvis commented Jun 13, 2026

PR #664 — checker-log-analyzer

🤖 CI Checker Analysis (checker-log-analyzer)

❌ All Checkers (Merge Conflict)

Verdict

raryan-qcom commented Jun 5, 2026•
edited
Loading

raryan-qcom commented Jun 5, 2026•
edited
Loading