Revert: Bluetooth: support Bluetooth over both USB and UART by shuaz-shuai · Pull Request #813 · qualcomm-linux/kernel

shuaz-shuai · 2026-07-09T06:20:48Z

This reverts commit 1e1f55d, reversing changes made to 8b14607.

bt will depend m.2 solution: #614
CRs-Fixed: 4602678

qswat-orbit-external · 2026-07-09T06:20:56Z

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

qlijarvis · 2026-07-09T07:13:08Z

PR #813 — validate-patch

PR:#813

Verdict	Issues	Detailed Report
❌	0	Full report

Final Summary

Lore link present: No — no lore.kernel.org link found in commit message
Lore link matches PR commits: N/A — no lore link to compare against
Upstream patch status: N/A — Revert commit; original commit appears to be vendor-only (WORKAROUND prefix found in qcom-next)
PR present in qcom-next: No — revert commit not found in qcom-next; original commit f918c7227d93 with WORKAROUND prefix exists

Recommendation: This appears to be reverting a vendor-only WORKAROUND commit. The commit message should be updated to:

QCLINUX: Revert "Bluetooth: support Bluetooth over both USB and UART (#364)"
This reverts commit 1e1f55dc6119182e68eb7b762a3becc5c3126514.
[Explanation of why the revert is needed - to be provided by the author]
Fixes: 1e1f55dc6119 ("Bluetooth: support Bluetooth over both USB and UART (#364)")

Verdict: ❌ — click to expand
🔍 Patch Validation
PR:#813 - Revert "Bluetooth: support Bluetooth over both USB and UART (#364)"
Upstream commit: N/A (Revert commit with no lore link)
Verdict: ❌ FAIL
Step 1 — Parse the PR and Check for Lore Link
Analysis: This is a Revert commit that reverts commit 1e1f55dc6119182e68eb7b762a3becc5c3126514. The commit message contains:
Subject: Revert "Bluetooth: support Bluetooth over both USB and UART (#364)"
Body: References the commit being reverted and the base commit
No lore.kernel.org link found in the commit message
According to the skill instructions, Revert commits should have a prefix before "Revert" (e.g., UPSTREAM: Revert, FROMLIST: Revert, etc.), and the lore source should be the original posting being reverted.
Files changed:
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
drivers/bluetooth/hci_qca.c
drivers/power/sequencing/pwrseq-qcom-wcn.c
Commit Message
Check Status Note
Subject matches upstream ❌ No prefix (UPSTREAM:/FROMLIST:/BACKPORT:/etc.) before "Revert"
Body preserves rationale ❌ No explanation for why the revert is needed
Fixes tag present/correct ❌ No Fixes tag (should reference the commit being reverted)
Authorship preserved N/A Revert commit - author is the person performing the revert
Backport note (if applicable) N/A Not a backport
Link to original patch ❌ No lore.kernel.org link to the original patch being reverted
Diff
File Status Notes
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts ⚠️ Removes vreg_wcn_bt_en regulator, restores bt-enable-gpios, reverts supply changes
drivers/bluetooth/hci_qca.c ⚠️ Removes WCN7850 from power control disable condition
drivers/power/sequencing/pwrseq-qcom-wcn.c ⚠️ Removes Bluetooth device matching logic for missing bt-enable GPIO
Upstream Patch Status
Original commit being reverted:1e1f55dc6119182e68eb7b762a3becc5c3126514
Cannot determine upstream status without a lore link. The commit being reverted appears to be PR #364 in the qualcomm-linux/kernel repository (based on the subject line reference).
qcom-next Presence
Search result:⚠️ Not found in qcom-next
The revert commit itself was not found in qcom-next. However, a related commit was found:
f918c7227d93 WORKAROUND: arm64: dts: qcom: hamoa-iot-evk: support Bluetooth over both USB and UART
This suggests the original change may have been a WORKAROUND: prefixed commit in qcom-next.
Issues
Missing commit prefix: Revert commits should have a prefix indicating the source (e.g., QCLINUX: Revert, WORKAROUND: Revert, etc.). The skill instructions state: "Revert commits should have prefix before Revert".
No lore link: No Link: tag pointing to the original lore.kernel.org posting of the commit being reverted. For vendor-only commits (QCLINUX/WORKAROUND), this may be expected, but the prefix should indicate this.
Missing revert rationale: The commit message does not explain why the revert is necessary. Best practice for revert commits includes:
What problem the original commit caused
Why reverting is the correct solution
Any alternative approaches considered
No Fixes tag: Should include Fixes: 1e1f55dc6119 ("Bluetooth: support Bluetooth over both USB and UART (#364)") to link the revert to the problematic commit.
Incomplete commit message: The reference to "(WORKAROUND: QCLINUX: Bluetooth: support Bluetooth over both USB and UART #364)" suggests this is reverting an internal PR, but there's no context about what that PR was or why it needs to be reverted.
Verdict
Do not merge without correction.
This revert commit lacks essential metadata and context:
Add appropriate prefix (likely QCLINUX: Revert or WORKAROUND: Revert based on the qcom-next search results)
Add detailed explanation of why the revert is needed
Add Fixes: tag referencing the commit being reverted
If the original commit has a lore link, include it; if it's vendor-only, the prefix should make this clear
Final Summary
Lore link present: No — no lore.kernel.org link found in commit message
Lore link matches PR commits: N/A — no lore link to compare against
Upstream patch status: N/A — Revert commit; original commit appears to be vendor-only (WORKAROUND prefix found in qcom-next)
PR present in qcom-next: No — revert commit not found in qcom-next; original commit f918c7227d93 with WORKAROUND prefix exists
Recommendation: This appears to be reverting a vendor-only WORKAROUND commit. The commit message should be updated to:
QCLINUX: Revert "Bluetooth: support Bluetooth over both USB and UART (#364)"
This reverts commit 1e1f55dc6119182e68eb7b762a3becc5c3126514.
[Explanation of why the revert is needed - to be provided by the author]
Fixes: 1e1f55dc6119 ("Bluetooth: support Bluetooth over both USB and UART (#364)")

qlijarvis · 2026-07-09T07:13:10Z

PR #813 — checker-log-analyzer

PR:#813
Checker run:https://github.com/qualcomm-linux/kernel-config/actions/runs/28998527653

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	Missing Signed-off-by
dt-binding-check	⏭️	No DT binding changes
dtb-check	✅	Passed
sparse-check	✅	Passed
check-uapi-headers	✅	No UAPI changes
check-patch-compliance	❌	Missing subject prefix
tag-check	❌	Missing subject prefix (mandatory for qcom-6.18.y)

Detailed report: Full report

Checker analysis — click to expand
🤖 CI Checker Analysis (checker-log-analyzer)
PR:#813 - Revert "Bluetooth: support Bluetooth over both USB and UART (#364)"
Source:https://github.com/qualcomm-linux/kernel-config/actions/runs/28998527653
Target branch:qcom-6.18.y
Checker Result Summary
checkpatch ❌ Missing Signed-off-by
dt-binding-check ⏭️ No DT binding changes
dtb-check ✅ Passed
sparse-check ✅ Passed
check-uapi-headers ✅ No UAPI changes
check-patch-compliance ❌ Missing subject prefix
tag-check ❌ Missing subject prefix (mandatory for qcom-6.18.y)
❌ checkpatch
Root cause: Commit 510089e is missing the required Signed-off-by: trailer.
Failure details:
ERROR: Missing Signed-off-by: line(s)
510089ef5ff888df090ed9e1931bbc992c00d039 total: 1 errors, 0 warnings, 0 checks, 83 lines checked
Commit 510089ef5ff8 ("Revert "Bluetooth: support Bluetooth over both USB and UART (#364)"") has style problems, please review.
Fix: Add the Signed-off-by: trailer to the commit message:
git commit --amend --signoff --no-edit
Reproduce locally:
./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git d372ecea17290e5a99f7f1045eced332f586fc15..510089ef5ff888df090ed9e1931bbc992c00d039
❌ check-patch-compliance
Root cause: Commit subject does not start with a required prefix (FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT:).
Failure details:
Checking commit: Revert "Bluetooth: support Bluetooth over both USB and UART (#364)"
Commit summary does not start with a required prefix
The commit subject is:
Revert "Bluetooth: support Bluetooth over both USB and UART (#364)"
This is a revert commit with no prefix before the word Revert.
Fix: Add an appropriate prefix before Revert. Since this is reverting a previous commit, use one of:
git rebase -i d372ecea17290e5a99f7f1045eced332f586fc15
# mark commit as 'edit'
git commit --amend -m "UPSTREAM: Revert \"Bluetooth: support Bluetooth over both USB and UART (#364)\""# or if the original commit was FROMLIST:
git commit --amend -m "FROMLIST: Revert \"Bluetooth: support Bluetooth over both USB and UART (#364)\""
git rebase --continue
Choose the prefix based on the status of the commit being reverted:
If the original commit was merged upstream → UPSTREAM:
If the original commit was posted to lore but not merged → FROMLIST:
If the original commit was in a maintainer tree → FROMGIT:
Reproduce locally:
# The check-patch-compliance checker validates prefix and Link: tags
bash ../kernel-checkers/check-patch-compliance.sh --kernel-src . \
--base d372ecea17290e5a99f7f1045eced332f586fc15 \
--head 510089ef5ff888df090ed9e1931bbc992c00d039
❌ tag-check
Root cause: Commit 510089e subject line does not start with a required prefix. This check is mandatory for target branch qcom-6.18.y (all branches except qcom-next and qcom-next-staging require subject prefixes).
Failure details:
The commit subject is:
Revert "Bluetooth: support Bluetooth over both USB and UART (#364)"
This lacks any of the required prefixes: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, or WORKAROUND:.
Fix: Same as check-patch-compliance above — add a prefix before Revert:
git rebase -i d372ecea17290e5a99f7f1045eced332f586fc15
# mark commit as 'edit'
git commit --amend -m "UPSTREAM: Revert \"Bluetooth: support Bluetooth over both USB and UART (#364)\""
git rebase --continue
Note: The tag-check is distinct from check-patch-compliance:
check-patch-compliance enforces a strict subset of prefixes and also validates Link: tags and author matching.
tag-check enforces that every commit on non-qcom-next branches has any valid prefix (including QCLINUX:, PENDING:, WORKAROUND: which check-patch-compliance rejects).
For this revert commit, both checks fail for the same reason: missing prefix.
Verdict
2 blockers must be fixed before merge:
Missing Signed-off-by: — Add with git commit --amend --signoff
Missing subject prefix — Add UPSTREAM: (or appropriate prefix) before Revert
Both issues can be fixed in a single git commit --amend:
git commit --amend --signoff -m "UPSTREAM: Revert \"Bluetooth: support Bluetooth over both USB and UART (#364)\""
Then force-push the updated commit to the PR branch.

Shiraz Hashim (shashim-quic) · 2026-07-09T07:28:10Z

This reverts commit 1e1f55d, reversing changes made to 8b14607.
bt will depend m.2 solution: #614

please add CRs-Fixed: to PR descrption . Make sure CR is rightly associated.

qswat-orbit-external · 2026-07-09T08:07:34Z

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4602678 on any of the following entities:

Entities:

kernel.qli.2.0

CR:4602678

Please ensure the CR has a change task associated with at least one of the entities for this branch.

qswat-orbit-external · 2026-07-09T08:14:21Z

Merge Check Failed: CR Not Eligible for Merge

CR 4602678 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity:kernel.qli.2.0
CR:4602678
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

This reverts commit 1e1f55d, reversing changes made to 8b14607. Signed-off-by: Shuai Zhang <shuai.zhang@oss.qualcomm.com>

shuaz-shuai · 2026-07-09T08:35:43Z

This reverts commit 1e1f55d, reversing changes made to 8b14607.
bt will depend m.2 solution: #614
please add CRs-Fixed: to PR descrption . Make sure CR is rightly associated.

Thanks for the reminder. I've updated it.

qlijarvis · 2026-07-09T09:24:00Z

PR #813 — validate-patch

PR:#813

Verdict	Issues	Detailed Report
❌	0	Full report

Final Summary

Lore link present: No — no lore.kernel.org link found in commit message
Lore link matches PR commits: N/A — no lore link to compare against
Upstream patch status: N/A — cannot verify without lore link; network restricted
PR present in qcom-next: Not checked — network restricted, unable to fetch qcom-next

This is a Revert commit without proper upstream attribution, commit prefix, or rationale. It cannot be validated using the validate-patch skill until a lore link is added or the commit is properly prefixed as QCLINUX: if it's vendor-only.

Verdict: ❌ — click to expand
🔍 Patch Validation
PR:#813 - Revert "Bluetooth: support Bluetooth over both USB and UART (#364)"
Upstream commit: N/A (no lore.kernel.org link found)
Verdict: ❌ FAIL
Analysis
Step 1 — Parse PR and Check for Lore Link
This is a Revert commit with subject: Revert "Bluetooth: support Bluetooth over both USB and UART (#364)"
The commit message contains:
Reverts commit 1e1f55dc6119182e68eb7b762a3becc5c3126514
Reverses changes made to 8b14607c4a15e7394b2b863881d78c28614667dc
No lore.kernel.org link present
No Link: tag
No Patch-mainline: tag
No commit prefix (UPSTREAM:, FROMLIST:, BACKPORT:, QCLINUX:, etc.)
Files changed:
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts
drivers/bluetooth/hci_qca.c
drivers/power/sequencing/pwrseq-qcom-wcn.c
Commit Message
Check Status Note
Subject matches upstream ❌ No upstream reference; plain Revert without prefix
Body preserves rationale ❌ No explanation for why the revert is needed
Fixes tag present/correct ❌ No Fixes tag (should reference the issue caused by the reverted commit)
Authorship preserved N/A Revert author is the submitter
Backport note (if applicable) N/A Not a backport
Commit prefix ❌ Missing prefix (should have UPSTREAM:/FROMLIST:/QCLINUX: before "Revert")
Diff
File Status Notes
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts ⚠️ Removes vreg_wcn_bt_en regulator, restores bt-enable-gpios, reverts supply changes
drivers/bluetooth/hci_qca.c ⚠️ Removes QCA_WCN7850 from power_ctrl_enabled check
drivers/power/sequencing/pwrseq-qcom-wcn.c ⚠️ Removes Bluetooth device matching logic
Issues
No lore.kernel.org link: The commit message lacks any reference to an upstream lore posting. For a Revert commit, the skill expects either:
A link to the upstream revert posting (if this revert was posted to LKML)
A commit prefix indicating the nature of the revert (UPSTREAM:/FROMLIST:/QCLINUX:)
Missing commit prefix: According to the skill's known prefix patterns, all commits should have a prefix:
UPSTREAM: Revert "..." if the revert is merged upstream
FROMLIST: Revert "..." if the revert is posted but not yet merged
QCLINUX: Revert "..." if this is a vendor-only revert
No rationale for revert: The commit message only states what is being reverted but provides no explanation of:
Why the original commit needs to be reverted
What issue it caused
Whether this is a temporary revert or permanent
Missing Fixes tag: A revert should typically include a Fixes: tag referencing the commit that introduced the problem (the commit being reverted).
Reference to PR number in subject: The subject includes (#364) which appears to be a GitHub PR reference. This is not standard kernel commit message format and should be removed or moved to the commit body.
Upstream Patch Status
Cannot verify — no lore link provided and network access restricted.
qcom-next Presence
Cannot verify — network access restricted, unable to clone or fetch qcom-next branch.
Verdict
❌ FAIL — This commit cannot be validated against lore.kernel.org because:
No lore.kernel.org link is present in the commit message
No commit prefix to indicate the nature of the revert
Missing rationale for why the revert is necessary
Non-standard subject line format with GitHub PR reference
Recommendation
Do not merge without corrections. The commit message must be updated to include:
Add a commit prefix before "Revert":
If this revert was posted upstream: UPSTREAM: Revert "..."
If this revert is posted but pending: FROMLIST: Revert "..."
If this is vendor-only: QCLINUX: Revert "..."
Add a lore.kernel.org link (if applicable):
Link: https://lore.kernel.org/r/<message-id>
Add rationale explaining why the revert is needed:
This reverts commit 1e1f55dc6119182e68eb7b762a3becc5c3126514.
The original commit caused [describe the issue: boot failure, regression,
incompatibility, etc.]. Reverting until [describe the fix or alternative].
Add a Fixes tag if the reverted commit introduced a regression:
Fixes: 1e1f55dc6119 ("Bluetooth: support Bluetooth over both USB and UART")
Remove GitHub PR reference from subject line — (#364) should be removed or moved to the commit body.
Final Summary
Lore link present: No — no lore.kernel.org link found in commit message
Lore link matches PR commits: N/A — no lore link to compare against
Upstream patch status: N/A — cannot verify without lore link; network restricted
PR present in qcom-next: Not checked — network restricted, unable to fetch qcom-next
This is a Revert commit without proper upstream attribution, commit prefix, or rationale. It cannot be validated using the validate-patch skill until a lore link is added or the commit is properly prefixed as QCLINUX: if it's vendor-only.

qlijarvis · 2026-07-09T09:24:02Z

PR #813 — checker-log-analyzer

PR:#813
Checker run:https://github.com/qualcomm-linux/kernel-config/actions/runs/29005182615

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	Passed
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	✅	Passed
sparse-check	✅	Passed
check-uapi-headers	✅	Passed (no UAPI changes)
check-patch-compliance	❌	Missing required prefix
tag-check	❌	Subject prefix required

Detailed report: Full report

Checker analysis — click to expand
🤖 CI Checker Analysis (checker-log-analyzer)
PR:#813 - Revert "Bluetooth: support Bluetooth over both USB and UART (#364)"
Source:https://github.com/qualcomm-linux/kernel-config/actions/runs/29005182615
Checker Result Summary
checkpatch ✅ Passed
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ✅ Passed
sparse-check ✅ Passed
check-uapi-headers ✅ Passed (no UAPI changes)
check-patch-compliance ❌ Missing required prefix
tag-check ❌ Subject prefix required
❌ check-patch-compliance
Root cause: The commit subject line does not start with a required prefix tag.
Failure details:
Checking commit: Revert "Bluetooth: support Bluetooth over both USB and UART (#364)"
Commit summary does not start with a required prefix
The commit is a revert but lacks the mandatory prefix before the word Revert. The check-patch-compliance checker requires all commits to start with one of: FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT:.
Fix:
Add an appropriate prefix before Revert based on the origin of the original commit being reverted:
git rebase -i <base_sha># mark commit as 'edit'
git commit --amend -m "UPSTREAM: Revert \"Bluetooth: support Bluetooth over both USB and UART (#364)\""# or if the original was from a mailing list:
git commit --amend -m "FROMLIST: Revert \"Bluetooth: support Bluetooth over both USB and UART (#364)\""
git rebase --continue
Choose the prefix based on where the original commit came from:
If the original commit was merged into Linus's mainline → UPSTREAM:
If the original commit was posted to lore but not yet merged → FROMLIST:
If the original commit was in a maintainer tree → FROMGIT:
Reproduce locally:
cd kernel-checkers
./check-patch-compliance.sh <base_sha><head_sha>
❌ tag-check
Root cause: Subject line missing required prefix tag (applies to all branches except qcom-next/qcom-next-staging).
Failure details:
Commit cd50164fb16e565d0583b8fda5ba7751b8f87516:
Subject: Revert "Bluetooth: support Bluetooth over both USB and UART (#364)"
This commit subject does not start with any of the required prefix tags. All commits merged into branches other than qcom-next or qcom-next-staging must start with one of:
FROMLIST: (posted to mailing list)
FROMGIT: (from maintainer tree)
UPSTREAM: (merged into mainline)
BACKPORT: (backported with modifications)
QCLINUX: (vendor-only)
PENDING: (work-in-progress)
WORKAROUND: (temporary fix)
For revert commits, the prefix must appear before the word Revert.
Fix:
git rebase -i <base_sha># mark commit as 'edit'
git commit --amend -m "UPSTREAM: Revert \"Bluetooth: support Bluetooth over both USB and UART (#364)\""
git rebase --continue
Reproduce locally:
git log <base>..<head> --format="%H %s"|whileread sha subject;doif!echo"$subject"| grep -qE '^(FROMLIST|FROMGIT|UPSTREAM|BACKPORT|QCLINUX|PENDING|WORKAROUND):'&&!echo"$subject"| grep -qE '^(FROMLIST|FROMGIT|UPSTREAM|BACKPORT): Revert';thenecho"MISSING prefix in commit $sha: $subject"fidone
Verdict
2 blockers must be fixed before merge:
Add a required prefix tag to the commit subject (e.g., UPSTREAM: or FROMLIST: before Revert)
This single fix will resolve both the check-patch-compliance and tag-check failures
The fix is straightforward: amend the commit message to include the appropriate prefix. All other checkers passed successfully.

shuaz-shuai requested review from a team, Kaushal Kumar (quic-kaushalk), Rajendra (rrnayak) and Shiraz Hashim (shashim-quic)July 9, 2026 06:20

yepurisiddu mentioned this pull request Jul 9, 2026
UPSTREAM: Add power sequencing support for WCN39xx WiFi/BT chips #760
Closed

Revert "Bluetooth: support Bluetooth over both USB and UART (#364)"
cd50164
This reverts commit 1e1f55d, reversing changes made to 8b14607. Signed-off-by: Shuai Zhang <shuai.zhang@oss.qualcomm.com>

shuaz-shuai force-pushed the revert_pr364 branch from 510089e to cd50164Compare July 9, 2026 08:32

shuaz-shuai marked this pull request as draft July 9, 2026 09:19

shuaz-shuai closed this Jul 10, 2026

Uh oh!

Conversation

shuaz-shuai commented Jul 9, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qswat-orbit-externalBot commented Jul 9, 2026

Uh oh!

qlijarvis commented Jul 9, 2026

PR #813 — validate-patch

Final Summary

🔍 Patch Validation

Step 1 — Parse the PR and Check for Lore Link

Commit Message

Diff

Upstream Patch Status

qcom-next Presence

Issues

Verdict

Final Summary

Uh oh!

qlijarvis commented Jul 9, 2026

PR #813 — checker-log-analyzer

🤖 CI Checker Analysis (checker-log-analyzer)

❌ checkpatch

❌ check-patch-compliance

❌ tag-check

Verdict

Uh oh!

Shiraz Hashim (shashim-quic) commented Jul 9, 2026

Uh oh!

qswat-orbit-externalBot commented Jul 9, 2026

Uh oh!

qswat-orbit-externalBot commented Jul 9, 2026

Uh oh!

shuaz-shuai commented Jul 9, 2026

Uh oh!

qlijarvis commented Jul 9, 2026

PR #813 — validate-patch

Final Summary

🔍 Patch Validation

Analysis

Commit Message

Diff

Issues

Upstream Patch Status

qcom-next Presence

Verdict

Recommendation

Final Summary

Uh oh!

qlijarvis commented Jul 9, 2026

PR #813 — checker-log-analyzer

🤖 CI Checker Analysis (checker-log-analyzer)

❌ check-patch-compliance

❌ tag-check

Verdict

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shuaz-shuai commented Jul 9, 2026•
edited
Loading