Skip to content

UPSTREAM: wifi: ath10k: Support for FTM TLV test commands - #912

Closed
linghuiwu (linghuiwu-star) wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
linghuiwu-star:backport-ath10k-ftm-tlv
Closed

UPSTREAM: wifi: ath10k: Support for FTM TLV test commands#912
linghuiwu (linghuiwu-star) wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
linghuiwu-star:backport-ath10k-ftm-tlv

Conversation

@linghuiwu-star

@linghuiwu-starlinghuiwu (linghuiwu-star) commented Aug 6, 2026

Copy link
Copy Markdown

Existing tools like myftm use 'legacy' test command API. Similarly to ath11k and ath12k, we want to support raw TLV payload submitted from the test tool. This requires segmenting the TLV payload and encapsulating it within a WMI command. The opposite operation needs to be done upon corresponding event receiving.
Backport upstream ath10k FTM TLV test command support to qcom-6.18.y.

Tested-on: WCN3990 hw1.0 WLAN.HL.3.3.7.c2-00931-QCAHLSWMTPLZ-1

Link: https://patch.msgid.link/20251020153759.407516-1-loic.poulain@oss.qualcomm.com

(cherry picked from commit 54be197)

CRs-Fixed: 4635866

Existing tools like myftm use 'legacy' test command API. Similarly
to ath11k and ath12k, we want to support raw TLV payload submitted
from the test tool. This requires segmenting the TLV payload and
encapsulating it within a WMI command. The opposite operation needs
to be done upon corresponding event receiving.
Tested-on: WCN3990 hw1.0 WLAN.HL.3.3.7.c2-00931-QCAHLSWMTPLZ-1
Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
Link: https://patch.msgid.link/20251020153759.407516-1-loic.poulain@oss.qualcomm.com
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
(cherry picked from commit 54be197)
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

1 similar comment
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qlijarvis

Copy link
Copy Markdown

PR #912 — validate-patch

PR:#912

VerdictIssuesDetailed Report
1Full report

Final Summary

  1. Lore link present: Yes - https://patch.msgid.link/20251020153759.407516-1-loic.poulain@oss.qualcomm.com
  2. Lore link matches PR commits: Yes - diff content is identical (verified by md5sum: 6ff56fc6e41b7beaddd7978c62d0c6b7), commit message preserved verbatim, authorship correct
  3. Upstream patch status: ✅ Upstreamed - merged into mainline Linux as commit 54be197, tagged in v6.19, v6.19-rc1, v6.19-rc2, v6.19-rc4, v6.19-rc5
  4. PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR:#912 - wifi: ath10k: Support for FTM TLV test commands
Upstream commit:https://patch.msgid.link/20251020153759.407516-1-loic.poulain@oss.qualcomm.com
Verdict: ❌ FAIL

Commit Message

CheckStatusNote
Subject matches upstreamIdentical to upstream commit 54be197
Body preserves rationaleComplete body preserved verbatim
Fixes tag present/correctN/ANo Fixes tag in upstream or PR
Authorship preservedAuthor matches upstream: Loic Poulain loic.poulain@oss.qualcomm.com
Backport note (if applicable)Cherry-pick note present: (cherry picked from commit 54be197109762d2a3c2b23d44e960ce7a43a3798)

Diff

FileStatusNotes
drivers/net/wireless/ath/ath10k/core.hIdentical to upstream (md5: 6ff56fc6e41b7beaddd7978c62d0c6b7)
drivers/net/wireless/ath/ath10k/testmode.cIdentical to upstream
drivers/net/wireless/ath/ath10k/testmode_i.hIdentical to upstream
drivers/net/wireless/ath/ath10k/wmi.hIdentical to upstream

Issues

  • Missing vendor prefix: The commit subject lacks the required UPSTREAM: prefix. According to kernel tree conventions, commits cherry-picked from mainline Linux must be prefixed with UPSTREAM: to indicate their origin. The subject should be: UPSTREAM: wifi: ath10k: Support for FTM TLV test commands

Verdict

Reject - The commit is a faithful cherry-pick from mainline Linux v6.19 (commit 54be197), but it's missing the mandatory UPSTREAM: prefix in the subject line. This prefix is required to clearly identify the commit's origin and distinguish it from vendor-specific changes.

Final Summary

  1. Lore link present: Yes - https://patch.msgid.link/20251020153759.407516-1-loic.poulain@oss.qualcomm.com
  2. Lore link matches PR commits: Yes - diff content is identical (verified by md5sum: 6ff56fc6e41b7beaddd7978c62d0c6b7), commit message preserved verbatim, authorship correct
  3. Upstream patch status: ✅ Upstreamed - merged into mainline Linux as commit 54be197, tagged in v6.19, v6.19-rc1, v6.19-rc2, v6.19-rc4, v6.19-rc5
  4. PR present in qcom-next/topics: Yes - present in qcom-next as 54be197 (exact patch-id match per integration_presence_report.md)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 8d5dbc1b17adf8fe86a41adcda686785e73f5414
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

CommitSubjectqcom-nexttopicsFinal
1/1[PATCH] wifi: ath10k: Support for FTM TLV test commandspresent - exact patch-id match at 54be197skipped - not checked because qcom-next already contains the changepresent

Final Status

overall_status: PASS
present_commits: 1/1
partial_commits: 0/1
missing_commits: 0/1
topics_checked_for_commits: 0/1
final_summary: PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics

@qlijarvis

Copy link
Copy Markdown

PR #912 — checker-log-analyzer

PR:#912
Checker run:https://github.com/qualcomm-linux/kernel-config/actions/runs/31088050640

CheckerResultSummary
CheckerResultSummary
checkpatchNo style issues
dt-binding-check⏭️Skipped (no DT binding changes)
dtb-check⏭️Skipped (no DTS changes)
sparse-checkPassed (pre-existing warnings only)
check-uapi-headersPassed
check-patch-complianceMissing required subject prefix
tag-checkMissing required subject prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR:#912 - wifi: ath10k: Support for FTM TLV test commands
Source:https://github.com/qualcomm-linux/kernel-config/actions/runs/31088050640
Target branch:qcom-6.18.y

CheckerResultSummary
checkpatchNo style issues
dt-binding-check⏭️Skipped (no DT binding changes)
dtb-check⏭️Skipped (no DTS changes)
sparse-checkPassed (pre-existing warnings only)
check-uapi-headersPassed
check-patch-complianceMissing required subject prefix
tag-checkMissing required subject prefix

❌ check-patch-compliance

Root cause: Commit subject does not start with a required prefix tag.

Failure details:

Checking commit: wifi: ath10k: Support for FTM TLV test commands
Commit summary does not start with a required prefix

The check-patch-compliance checker requires all commits to start with one of these prefixes:

  • FROMLIST: (posted to mailing list)
  • FROMGIT: (from maintainer tree)
  • UPSTREAM: (merged into mainline)
  • BACKPORT: (backported with modifications)

The commit message contains:

  • Link: tag present: https://patch.msgid.link/20251020153759.407516-1-loic.poulain@oss.qualcomm.com
  • ✅ Cherry-pick note: (cherry picked from commit 54be197109762d2a3c2b23d44e960ce7a43a3798)
  • ❌ Subject prefix: missing

Fix:

Since this patch was cherry-picked from upstream commit 54be197109762d2a3c2b23d44e960ce7a43a3798, the correct prefix is UPSTREAM:.

git rebase -i HEAD~1 # mark commit as 'edit'
git commit --amend -m "UPSTREAM: wifi: ath10k: Support for FTM TLV test commandsExisting tools like myftm use 'legacy' test command API. Similarlyto ath11k and ath12k, we want to support raw TLV payload submittedfrom the test tool. This requires segmenting the TLV payload andencapsulating it within a WMI command. The opposite operation needsto be done upon corresponding event receiving.Tested-on: WCN3990 hw1.0 WLAN.HL.3.3.7.c2-00931-QCAHLSWMTPLZ-1Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>Link: https://patch.msgid.link/20251020153759.407516-1-loic.poulain@oss.qualcomm.comSigned-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>(cherry picked from commit 54be197109762d2a3c2b23d44e960ce7a43a3798)"
git rebase --continue

Reproduce locally:

cd kernel-checkers
./check-patch-compliance.sh --kernel-src /path/to/kernel --base-sha <base> --head-sha 8d5379bdb3d7

❌ tag-check

Root cause: Subject prefix is mandatory for branch qcom-6.18.y but missing.

Failure details:

Commit 8d5379bdb3d7 ("wifi: ath10k: Support for FTM TLV test commands"): subject line does not start with a required prefix.

All branches except qcom-next and qcom-next-staging require one of:

  • FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

Since this PR targets qcom-6.18.y (not qcom-next or qcom-next-staging), the tag-check applies and every commit must have a subject prefix.

Fix:

Same as above — add UPSTREAM: prefix to the subject line since this is a cherry-pick from upstream commit 54be197109762d2a3c2b23d44e960ce7a43a3798.


Verdict

1 blocker must be fixed before merge:

The commit subject must be updated to include the UPSTREAM: prefix. This is a simple metadata fix that requires amending the commit message — no code changes needed.

After fixing, the subject should read:

UPSTREAM: wifi: ath10k: Support for FTM TLV test commands

All other checkers passed successfully. The patch itself has no coding style, build, or compliance issues beyond the missing subject prefix.

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Casehamoa-iot-evk-multimedialemans-evk-multimediamonaco-evk-multimediaqcs615-ride-multimediaqcs6490-rb3gen2-multimediaqcs8300-ride-multimediaqcs9100-ride-r3-multimediashikra-iqs-evk-multimedia
Audio_Card_Registration✅ Pass✅ Pass✅ Pass⚠️ skip⚠️ skip⚠️ skip⚠️ skip◻️
BT_FW_KMD_Service✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass◻️
BT_ON_OFF✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass◻️
BT_SCAN✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass◻️
CPUFreq_Validation✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass◻️
CPU_affinity✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass◻️
DSP_AudioPD✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass◻️
Ethernet⚠️ skip⚠️ skip⚠️ skip⚠️ skip⚠️ skip⚠️ skip⚠️ skip◻️
Freq_Scaling✅ Pass✅ Pass✅ Pass✅ Pass❌ Fail✅ Pass✅ Pass◻️
GIC✅ Pass✅ Pass✅ Pass✅ Pass❌ Fail✅ Pass✅ Pass◻️
IPA✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass◻️
Interrupts✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass◻️
OpenCV✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass◻️
PCIe✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass◻️
Probe_Failure_Check❌ Fail❌ Fail❌ Fail❌ Fail❌ Fail❌ Fail❌ Fail◻️
RMNET✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass◻️
UFS_Validation✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass◻️
USBHost✅ Pass✅ Pass✅ Pass❌ Fail❌ Fail❌ Fail❌ Fail◻️
WiFi_Firmware_Driver❌ Fail✅ Pass❌ Fail✅ Pass✅ Pass✅ Pass✅ Pass◻️
WiFi_OnOff❌ Fail✅ Pass❌ Fail✅ Pass✅ Pass✅ Pass✅ Pass◻️
adsp_remoteproc✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass◻️
cdsp_remoteproc✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass◻️
gpdsp_remoteproc⚠️ skip✅ Pass✅ Pass⚠️ skip⚠️ skip✅ Pass✅ Pass◻️
hotplug✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass◻️
irq✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass◻️
kaslr✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass◻️
pinctrl✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass◻️
qcom_hwrng✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass◻️
remoteproc✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass◻️
rngtest✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass◻️
shmbridge✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass◻️
smmu❌ Fail❌ Fail✅ Pass❌ Fail✅ Pass✅ Pass❌ Fail◻️
watchdog✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass◻️
wpss_remoteproc✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass✅ Pass◻️

@linghuiwu-star

Copy link
Copy Markdown
Author

PR912 added into PR990 , So Closed here

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@linghuiwu-star@qlijarvis@qcomlnxci@shashim-quic