Skip to content

fix: update shmbridge testcase - #446

Closed
vnarapar wants to merge 1 commit into
qualcomm-linux:mainfrom
vnarapar:shmbridge
Closed

fix: update shmbridge testcase#446
vnarapar wants to merge 1 commit into
qualcomm-linux:mainfrom
vnarapar:shmbridge

Conversation

@vnarapar

@vnaraparvnarapar commented May 8, 2026

Copy link
Copy Markdown
Contributor

This test validates the presence, registration, and correct runtime state of the qcom_scm driver on the target device

smuppand
Srikanth Muppandam (smuppand) requested changes May 11, 2026
View reviewed changes

@smuppandSrikanth Muppandam (smuppand) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The direction is good: this expands shmbridge from a simple qcom_scm presence/log check into stronger runtime validation for sysfs, DT, platform driver registration, binding, attributes, and uevent information.

A few changes are needed

Comment threadRunner/suites/Kernel/Baseport/shmbridge/run.sh Outdated
Comment threadRunner/suites/Kernel/Baseport/shmbridge/run.sh
Comment threadRunner/suites/Kernel/Baseport/shmbridge/run.sh
Comment threadRunner/suites/Kernel/Baseport/shmbridge/run.sh
Comment threadRunner/suites/Kernel/Baseport/shmbridge/run.sh Outdated
Comment threadRunner/suites/Kernel/Baseport/shmbridge/run.sh
Comment threadRunner/suites/Kernel/Baseport/shmbridge/run.sh
Comment threadRunner/suites/Kernel/Baseport/shmbridge/README.md Outdated
smuppand
Srikanth Muppandam (smuppand) requested changes May 13, 2026
View reviewed changes
Comment threadRunner/suites/Kernel/Baseport/shmbridge/run.sh Outdated
Comment threadRunner/suites/Kernel/Baseport/shmbridge/run.sh Outdated
Comment threadRunner/suites/Kernel/Baseport/shmbridge/run.sh
Comment threadRunner/suites/Kernel/Baseport/shmbridge/run.sh
Comment threadRunner/suites/Kernel/Baseport/shmbridge/README.md Outdated
Comment threadRunner/suites/Kernel/Baseport/shmbridge/README.md Outdated
Comment threadRunner/suites/Kernel/Baseport/shmbridge/README.md
@vnarapar
vnaraparforce-pushed the shmbridge branch 2 times, most recently from 07c1148 to 53fe1d3CompareMay 18, 2026 09:22
smuppand
Srikanth Muppandam (smuppand) requested changes May 18, 2026
View reviewed changes
Comment threadRunner/suites/Kernel/Baseport/shmbridge/run.sh Outdated
Comment threadRunner/suites/Kernel/Baseport/shmbridge/run.sh Outdated
Comment threadRunner/suites/Kernel/Baseport/shmbridge/run.sh Outdated
smuppand
Srikanth Muppandam (smuppand) requested changes May 22, 2026
View reviewed changes

@smuppandSrikanth Muppandam (smuppand) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few updates are needed for the readme. Once those are taken care of, we can proceed with the merge.

Comment threadRunner/suites/Kernel/Baseport/shmbridge/README.md
Comment threadRunner/suites/Kernel/Baseport/shmbridge/README.md
@smuppand

Srikanth Muppandam (smuppand) commented May 22, 2026

Copy link
Copy Markdown
Contributor

vnarapar Could you update the commit message to include the reason for these changes?

@vnarapar
fix: update shmbridge testcase
a26254e
Fix to update the shmbridge testscript to move away from dmesg based
validation
This test validates the presence, registration, and correct runtime state of the
qcom_scm driver on the target device
Signed-off-by: Vamsee Narapareddi <vnarapar@qti.qualcomm.com>
@vnarapar

vnarapar commented May 27, 2026

Copy link
Copy Markdown
ContributorAuthor

vnarapar Could you update the commit message to include the reason for these changes?

Updated the commit

@smuppand

Srikanth Muppandam (smuppand) commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

vnarapar, please rebase and apply the small fixes mentioned above.

@github-actions

github-actionsBot commented Jul 8, 2026

Copy link
Copy Markdown

@ualcomm/qualcomm-linux-testing.triage This pull request has been marked as stale due to 30 days of inactivity and will automatically close after an additional 5 days.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smuppandSrikanth Muppandam (smuppand)Awaiting requested review from smuppand

Assignees

No one assigned

Labels

Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vnarapar@smuppand