Uh oh!
There was an error while loading. Please reload this page.
Support for Shikra added for Video - #551
Open
abbajaj806 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Abhishek Bajaj <abbajaj@qti.qualcomm.com>
Srikanth Muppandam (smuppand)
requested changes
Aug 25, 2026
| if [ -s "$tmp" ]; then | ||
| if ! cmp -s "$cfg" "$tmp" 2>/dev/null; then | ||
| mv "$tmp" "$cfg" |
Contributor
There was a problem hiding this comment.
Do not overwrite source or user-provided configurations
| tok="$1" | ||
| [ -z "$tok" ] && return 1 | ||
| ua="$(uname -a 2>/dev/null)" |
Contributor
There was a problem hiding this comment.
Please align this with the Shikra audio approach from #544
Detect the board from resolved runtime device-tree model/compatible data. Keep this separate from, or integrate it carefully with, video_detect_platform().
| ;; | ||
| esac | ||
| if command -v video_apply_level_override_for_target >/dev/null 2>&1; then |
Contributor
There was a problem hiding this comment.
Restrict the override to intended encoder configurations. Apply it only when mode=encode and the canonical codec is h264 or hevc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for Shikra added for Video