Uh oh!
There was an error while loading. Please reload this page.
Bug fix: update infer_data_source with a tdiff tolerance and add extra columns to be renamed - #39
Open
emmleroy wants to merge 8 commits into
Open
Bug fix: update infer_data_source with a tdiff tolerance and add extra columns to be renamed#39emmleroy wants to merge 8 commits into
emmleroy wants to merge 8 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## master #39 +/- ##
==========================================
+ Coverage 91.82% 92.19% +0.36%
==========================================
Files 24 24 Lines 1260 1255 -5 ==========================================
Hits 1157 1157 + Misses 103 98 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…ndas int since older data might be missing these column values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several MOD-UFP files from the database have a dominant sampling interval of 58s or 59s, rather than 60s. This updates infer_data_source() with a 2-second tolerance around the expected dominant_tdiff values.
A couple old column names need to be added to COLUMN_DEFINITIONS: (opcn3_temp --> opc_temp, opcn3_rh --> opc_rh, operating_state --> dd_operating_state).
Bug fix: neph_bin0/opc_bin0 ratio check should occur when neph_bin0>=10, not when opc_bin0>=10 (following fw-modulair v17?)
Fix: some int64 columns need to be nullable (fw, dd_operating_state, dd_measurement_state) for older data that doesn't have these values; changed dtype to float64
Speed-up flag-aware resampling by changing to a vectorized version
Bump pre-release version to rc4