Skip to content

Bug fix: update infer_data_source with a tdiff tolerance and add extra columns to be renamed - #39

Open
emmleroy wants to merge 8 commits into
masterfrom
emmleroy-v1.0.0
Open

Bug fix: update infer_data_source with a tdiff tolerance and add extra columns to be renamed#39
emmleroy wants to merge 8 commits into
masterfrom
emmleroy-v1.0.0

Conversation

@emmleroy

@emmleroyemmleroy commented Jul 30, 2026

Copy link
Copy Markdown
Contributor
  1. Several MOD-UFP files from the database have a dominant sampling interval of 58s or 59s, rather than 60s. This updates infer_data_source() with a 2-second tolerance around the expected dominant_tdiff values.

  2. A couple old column names need to be added to COLUMN_DEFINITIONS: (opcn3_temp --> opc_temp, opcn3_rh --> opc_rh, operating_state --> dd_operating_state).

  3. Bug fix: neph_bin0/opc_bin0 ratio check should occur when neph_bin0>=10, not when opc_bin0>=10 (following fw-modulair v17?)

  4. Fix: some int64 columns need to be nullable (fw, dd_operating_state, dd_measurement_state) for older data that doesn't have these values; changed dtype to float64

  5. Speed-up flag-aware resampling by changing to a vectorized version

  6. Bump pre-release version to rc4

@emmleroy
emmleroy requested a review from dhhaganJuly 30, 2026 17:01
@codecov

codecovBot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.19%. Comparing base (20f6aa3) to head (f7d9b35).
⚠️ Report is 2 commits behind head on master.

Files with missing linesPatch %Lines
quantaq_cli/toolkit/resample.py94.44%1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@## master #39 +/- ##
==========================================
+ Coverage 91.82% 92.19% +0.36% 
==========================================
Files 24 24 Lines 1260 1255 -5 ==========================================
Hits 1157 1157 + Misses 103 98 -5 
FlagCoverage Δ
unittests92.19% <95.45%> (+0.36%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing linesCoverage Δ
quantaq_cli/schema.py93.05% <ø> (-1.39%)⬇️
quantaq_cli/utilities.py82.85% <100.00%> (+0.24%)⬆️
quantaq_cli/variables.py90.00% <ø> (ø)
quantaq_cli/toolkit/resample.py94.59% <94.44%> (+7.09%)⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@emmleroy