Drain In-Flight Encodes on Export Errors

[lightninglu10]

Summary

Failed exports now always observe and drain in-flight encoder work while preserving the primary render or pending error, preventing late unhandled rejections from poisoning later exports.

Technical details

• Uses one pending-encode drain authority for normal, error, and abort exits.
• The normal path continues to propagate encoder errors.
• A primary render or pending error wins over a secondary encode failure.
• Abort continues to surface AbortError and discard an encoder error.
• Sample closure, frame ordering, render/encode overlap, progress timing, and keyframe selection remain unchanged.

Test plan

• Run the 14 focused race, ordering, keyframe, abort, progress, and sample-closure tests.
• Run the 26 neighboring export tests.
• Run the static check and production build.
• Run the portable Node, Chrome, edit-operation, lifecycle, and media/audio contracts.

Open items

Intentionally stacked on v1-editor-hardening / PR #25. This is review-only until that base lands or integrates; do not retarget it to main.

[codepress-reviewer-dev]

Starting initial review of ae89a47c from baseline 1f8df903... 👀

View automation run

[codepress-reviewer-dev]

Approved. The shared first-failure latch and single drain authority give this concurrency fix a coherent ownership boundary: every in-flight encode is observed and its sample is closed, while error precedence remains stable across render, audio, encoder, abort, and cleanup races.

The focused coverage exercises the meaningful overlap and ordering cases, including late encoder failures during render errors and aborts. I found no actionable correctness or production-safety concerns in the intrinsic diff.

_{Reviewed `1f8df903`...`ae89a47c`. Diff collection and GitHub posting were handled by the automation.}

View automation run

[codepress-reviewer-dev]

Review head 9cf093b81410d4b176c33f1f3b3ad19c12beb0ce; round 2; 3 reviewed file(s), 0 pending/skipped file(s). 0 subsystem record(s) retained; 0 omitted.

View automation run

[codepress-reviewer-dev]

Starting new changes review of 9cf093b8 from baseline ae89a47c... 👀

View automation run

[codepress-reviewer-dev]

Approved. The shared first-failure latch, separate cleanup latch, and non-rejecting encode settlement provide a coherent ownership boundary for this concurrency path: every in-flight encode is observed and its sample is closed, while primary error precedence remains stable across render, audio, encoder, abort, and cleanup races.

I also reviewed the complete expanded loop test file. Its race matrix and focused cases cover the meaningful source-order, late-rejection, drain, listener-cleanup, progress, ordering, keyframe, and sample-closure paths. I found no actionable correctness or production-safety concerns in the incremental diff.

_{Reviewed `ae89a47c`...`9cf093b8`. Diff collection and GitHub posting were handled by the automation.}

View automation run