bd-bpt089zw: resolving the last comment no longer leaves an empty pill or a stuck glow (q2-preview)

[cscheid]

Summary

In hub-client's q2-preview, resolving the last comment on a block (the ✓ in the comment bubble) left two artifacts behind: a small empty pill where the bubble was, and a block "glow" that never cleared — not after moving the mouse away, not after clicking elsewhere.

Both are state-lifecycle bugs in CommentWrapper (ts-packages/preview-renderer/src/q2-preview/custom/CommentBlock.tsx). Blocks are keyed by index, so the bubble component instance and its state survive the commit round-trip, and nothing reset it:

1. Empty pill. selfExpanded outlived the last comment, so the bubble rendered its expanded branch with zero rows. Fix: a layout effect collapses the self-expanded state when the comment count reaches zero with no inline input open (the one legitimate empty-and-expanded state: + just clicked). Layout, so the pill is never painted.
2. Stuck glow. The block-wrapper glow was set from the bubble's own onMouseEnter/onMouseLeave. The resolve re-render unmounts the button under the pointer; Chrome re-evaluates :hover after layout without boundary events, and the next mouseout comes from the new hovered node, which the bubble is not an ancestor of — so the bubble's leave never fired. Fix: derive the glow on the wrapper's mousemove (containment of e.target) and clear it on the wrapper's mouseleave; a layout effect re-derives it from geometry (last pointer position vs the re-measured bubble rect) whenever the bubble changes shape, so a stationary pointer gets the right answer in both directions.

Both fields date from Comments v1 (#441); not a regression from the rich-bubble work.

Tests

CommentBlock.resolveLast.integration.test.tsx — 8 jsdom tests (T1–T7 + T6b), each verified failing before the fix (T7 against the clear-only variant of the geometric re-check). Full preview-renderer integration (56 files) and unit (43 files) suites green; cargo xtask verify green.

End-to-end

Verified in Chrome against a local vite dev server: after ✓ with the pointer stationary, the chrome collapses to the hover-only + and the glow is on only because the pointer actually rests inside that +; after a real move away, wrapper box-shadow is none and no chrome remains. DOM probe output is recorded in the plan.

Plan: claude-notes/plans/2026-09-09-preview-comment-resolve-artifacts.md · Strand: bd-bpt089zw

🤖 Generated with Claude Code

https://claude.ai/code/session_01AwSEXztTeiRxA2NMhud9pe

[posit-snyk-bot]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.