fix(ci): Add ability to run full test suite on PRs - #6718
Conversation
ed97582 to
f6015ba
Compare
f6015ba to
f246511
Compare
f246511 to
c1b23ec
Compare
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| ref: ${{ inputs.merge_sha }} | ||
| persist-credentials: false | ||
|
|
||
| - name: Install Ubuntu packages |
|
This is a useful capability but I recommend going even further i.e. make running tests a required check / pre-condition for merging a PR. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 89b3bec974
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Prepare LocalStack S3 | ||
| run: pipenv run ./prepare_tests.sh | ||
| working-directory: ./quickwit/quickwit-cli/tests |
There was a problem hiding this comment.
On a fresh ubuntu-24.04 runner, this step executes before any LocalStack service has been started, so prepare_tests.sh invokes awslocal s3 mb against an unavailable endpoint and exits nonzero. The only Docker startup occurs in the subsequent make test-all target, meaning the workflow stops here without running the suite; start Compose first or remove this redundant preparation step.
AGENTS.md reference: AGENTS.md:L142-L145
Useful? React with 👍 / 👎.
Description
Add a maintainer-triggered
/ci-run-all-testscommand that runsmake test-allagainst the test merge commit for a pull request and reports thefull-test-suitestatus on the PR head.The workflow supports fork PRs without exposing secrets and documents the command in the contribution guide.
How was this PR tested?
The full test suite passed 3,022 all-feature tests and 10 failpoint tests.