Skip to content

chore(version bump): Swagger-ui-react to 5.32.14 & pick up patched axios - #6763

Merged
dayaffe merged 2 commits into
mainfrom
dayaffe/bump-swagger-ui-react
Sep 3, 2026
Merged

dayaffe merged 2 commits into
mainfrom
dayaffe/bump-swagger-ui-react

Conversation

@dayaffe

@dayaffe dayaffe commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Description

Bumps swagger-ui-react from 5.32.0 to 5.32.14 since we need to do that anyway and doing so the UI lockfile picks up a patched axios (1.15.2 → 1.20.0) through the dependency chain:

swagger-ui-react 5.32.14 → swagger-client 3.38.0 → @swagger-api/apidom-reference 1.12.0 → axios ^1.18.0

axios is not a direct dependency of the UI — it enters transitively via
swagger-client. The currently pinned 1.15.2 sits inside the affected ranges of 10
published advisories, notably GHSA-gcfj-64vw-6mp9 (high; affected >=1.15.2, <1.18.0).
The same ranges are also why dependency-review fails on #6433, whose lockfile regen
carries axios 1.16.1 into its diff.

Notable transitive updates, all inside the swagger-ui-react subtree: the
@swagger-api/apidom-* family 1.10.2 → 1.12.0, immutable 3.8.3 → 4.3.9,
react-redux 9.2.0 → 9.3.0, form-data 4.0.5 → 4.0.6.

swagger-ui-react 5.32.14 upgrades swagger-client to 3.38, which pulls
@swagger-api/apidom-reference 1.12 and with it axios ^1.18 (resolves to
1.20.0), closing 10 open axios advisories in the UI lockfile, most notably
GHSA-gcfj-64vw-6mp9 (high), and unblocking dependency-review on #6433.

Generated with GLM-5.3
@dayaffe
dayaffe force-pushed the dayaffe/bump-swagger-ui-react branch from e1ac378 to 9640cf7 Compare September 3, 2026 18:29
@dayaffe dayaffe changed the title Bump swagger-ui-react to 5.32.14 to pick up patched axios chore(version bump): Swagger-ui-react to 5.32.14 to pick up patched axios Sep 3, 2026
@dayaffe

dayaffe commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

/ci-run-all-tests

@dayaffe
dayaffe marked this pull request as ready for review September 3, 2026 19:02
@dayaffe
dayaffe requested a review from a team as a code owner September 3, 2026 19:02
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-03T19:17:10.120960Z 6666647 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dayaffe dayaffe changed the title chore(version bump): Swagger-ui-react to 5.32.14 to pick up patched axios chore(version bump): Swagger-ui-react to 5.32.14 & pick up patched axios Sep 3, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9640cf7fd9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread quickwit/quickwit-ui/yarn.lock Outdated
Comment on lines 4131 to 4132
dompurify@3.2.7, dompurify@3.3.1, dompurify@^3.4.13:
version "3.3.1"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Honor Swagger UI's required DOMPurify version

On every Yarn 1 install, the root resolutions entry still forces DOMPurify 3.3.1, so this newly added ^3.4.13 request is incorrectly coalesced into a lock entry whose installed version is below the declared minimum. As a result, the /ui API documentation runs Swagger UI 5.32.14 against an unsupported sanitizer version and misses the DOMPurify upgrade bundled with that release; remove or raise the resolution and regenerate the lockfile.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed

swagger-ui-react 5.32.14 requires dompurify ^3.4.13, but the root
resolutions pin (kept to force monaco-editor's stale 3.2.7 exact pin
upward) still forced 3.3.1, coalescing the new requirement below its
declared minimum. Raises the pin to 3.4.14 (latest), satisfying both.

Addresses the Codex review comment on this PR.
@dayaffe

dayaffe commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

/ci-run-all-tests

@dayaffe

dayaffe commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 66666470a3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@dayaffe
dayaffe merged commit 5719b63 into main Sep 3, 2026
12 checks passed
@dayaffe
dayaffe deleted the dayaffe/bump-swagger-ui-react branch September 3, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants