wrong host passed to dependencies

[antoine-sachet]

The host passed at top level is passed to the dependencies. This causes the install to fail when the dependency host should be different.

Consider:

• Package A on bitbucket. Its DESCRIPTION has a Remotes field with github::antoine-sachet/packageB

• Package B on github.

Installing package A with install_bitbucket("bbuser/packageA") fails!

Indeed, with the host in ... being passed to the dependencies, I end up with a github_remote with host = "api.bitbucket.org/2.0". Incidentally, this results in #322.

This issue was introduced by #145 ... It's a bad idea to pass the host to dependencies. I thought the correct way to specify the dependencies' hosts was through the "Remotes" field of the DESCRIPTION?

This is also to some extent a security concern. My credentials are passed to a dependency's host if the corresponding XXX_remote() matches the arguments of install_YYY().

[antoine-sachet]

Basically, any package with a dependency hosted with another service will fail to install. All the remote prefixes like bitbucket::, github::, gitlab::, etc prefixes are broken.

In my case, installing a github dependency from a bitbucket package, I simply end up with a github_remote with bitbucket as the host.

It is even worse in the case of e.g. a gitlab package with a dependency on a github package, because not only would the host be wrong, but the wrong auth_token would be sent.