Loops docs (#120): resolve review findings before Phase 2 is built #125

Description

@radroid

#120 merged as 3d91c5754 after four independent reviews. All four returned no merge blockers — the docs are internally sound enough to merge, and every load-bearing [V] claim about the tree reproduced exactly. These are the findings that survived, all of which land before anyone builds Phase 2 from the plan, not before merge.

A. Contradictions across the document set

  1. The deference cap's precondition is asserted, disputed and refuted in three files. This is the single load-bearing correction of the final revision, and it did not propagate. BACKEND.md:334-337 flags "reject arming without a deadline" as an unresolved change to §3's contract; PLAN.md:135-136, :316-320, :489-503 state the deadline bound with no caveat; TESTS.md:94 case 15 treats a null deadline as supported. Worse, BACKEND.md:288-290 and guard 10b at :529 make deadlineAtMs == null mean no deference at all, so a deadline-less loop fires on top of a healthy self-pacing thread — the exact case BACKEND.md:47 declares impossible. Untested in both directions under a stated 100%-branch gate (TESTS.md:387).
  2. Console precedence reverses the report's own recommendation, undeclared.FINDINGS.md:269 records it as the user's requirement and p7-console-shapes.html:292 (Shape A, the recommended shape) both say opening a loop lands on the console; PLAN.md:193-195 decides the opposite and attributes the rejection to [Feature]: supervise long-running threads — turns complete while background subagents are still working, and nothing restarts the run #38 only.
  3. Phase 4 acceptance contradicts the guard table.PLAN.md:383 says master-toggle-off ⇒ "no fiber" and "stand down at next tick" — a tick requires a fiber. p4-settings.html:286-287 ships the wrong half in user-facing help text.
  4. Grace boundary disagrees between adjacent cases.TESTS.md:60-61 (11e) exclusive vs :87 (11k) inclusive; guard 10b is inclusive, so 11e is the wrong one.
  5. PLAN.md:104 D2 says "never session.status" without BACKEND's scoping — PLAN never mentions idleMs/busyIdleMs, so a reader building from PLAN alone drops the long-tool-call case.
  6. The superseded-design pointer (docs/coil/loop/DESIGN.md:3-7) names feat: native subagent & workflow observability pingdotgg/t3code#5219 and feat: scheduled tasks (automations) pingdotgg/t3code#3638 as the premises that "did not survive" — both re-checks actually came back confirming. The three premises that moved are in FINDINGS.md:20-91.

B. Designed but unscoped

  1. store.global.enabled is the headline kill switch with no data model, no route and no test.BACKEND.md:210-273 defines only LoopRecord and Blocker; §10's four routes never touch global settings. Sequencing consequence: Phase 2 ships "default off behind the master toggle" but only Phase 4 can flip it — phases 2 and 3 are unswitchable as ordered.
  2. Push notifications and mobile surfacing are designed in the report (report.src.html:1175-1187) and named in scope (PLAN.md:140-141) but have no phase, no seam line, no acceptance criteria and no tests. PLAN.md:480 cites push-copy assertions that do not exist.
  3. Sidebar/mobile row chrome: deferred in the report, priced at 0 rows in PLAN, asserted as a requirement in p8-mobile.html:655-657. A budget on the mobile row is a mobile seam row.
  4. gate_off is declared user-visible and starred in TESTS.md:68, but appears in no prototype and has no source test.

C. Tooling

  1. build-report.mjs can silently drop a prototype. The guard at :77 only fires when zero markers match; a single drifted marker (the hint regex terminates on > and splits on |) emits a report missing that frame, invisible in the browser and in a 15k-line diff. Reproduced: 7 inlined, no error. There is also no check that every file in prototypes/ is referenced. Fix: assert the count.
  2. docs/coil/loop/DESIGN.md contains a /Users/<username>/… path (pre-existing, already public).

Considered and rejected: adding report.html linguist-generated -diff to .gitattributes. .gitattributes is upstream-owned, so it would buy a diff-noise improvement at the cost of a permanent seam row — the wrong trade for this fork, especially since a fork-only path cannot conflict during a rebase anyway.

D. Already stale — arriving in the current upstream sync

Both anchored facts changed upstream after the docs' merge-base cebac353d, and both weaken a stated rationale:

  • f70eeeeb0 (fix(clients): move settled pinned threads into the settled section pingdotgg/t3code#7969, 2026-08-23) inverted pin-vs-settle. Upstream now reads "Settled and snoozed threads remain in their respective shelves even when pinned" — order moved from snooze>pin>settled to snooze>settled>pin. Loop-as-pinned-thread (D3) no longer keeps a settled loop visible.
  • c7222ca4d (feat(claude): compact old threads before they burn through usage pingdotgg/t3code#8144, 2026-08-25) added a second blocking dialogonUserDialog with supportedDialogKinds: ["resume_return"] routes into the same blocking Deferred as AskUserQuestion, and fires on session resume. The loop's own nudge can therefore manufacture a pending user-input that the plan's pending-input guard then treats as a hard skip.
  • Churn figures in UPSTREAM-DELTA.md:209-215 (RightPanelTabs.tsx now +265/-86, not +13) and :52 (Sidebar.logic.ts now +22/-7, not unchanged) have moved. PLAN.md's churn/risk figures reproduce only against the older base a4cc1367b, not the stated cebac353d.

The 2-row answer to #112 and the 3-row phase 1–4 total both still hold.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
       blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
      }
      } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
      })();
      (function(){
      try {
      var __m = "github.com";
      var __re = new RegExp('^' + "github\\.com" + '
      
      Skip to content

      Loops docs (#120): resolve review findings before Phase 2 is built #125

      Description

      @radroid

      #120 merged as 3d91c5754 after four independent reviews. All four returned no merge blockers — the docs are internally sound enough to merge, and every load-bearing [V] claim about the tree reproduced exactly. These are the findings that survived, all of which land before anyone builds Phase 2 from the plan, not before merge.

      A. Contradictions across the document set

      1. The deference cap's precondition is asserted, disputed and refuted in three files. This is the single load-bearing correction of the final revision, and it did not propagate. BACKEND.md:334-337 flags "reject arming without a deadline" as an unresolved change to §3's contract; PLAN.md:135-136, :316-320, :489-503 state the deadline bound with no caveat; TESTS.md:94 case 15 treats a null deadline as supported. Worse, BACKEND.md:288-290 and guard 10b at :529 make deadlineAtMs == null mean no deference at all, so a deadline-less loop fires on top of a healthy self-pacing thread — the exact case BACKEND.md:47 declares impossible. Untested in both directions under a stated 100%-branch gate (TESTS.md:387).
      2. Console precedence reverses the report's own recommendation, undeclared.FINDINGS.md:269 records it as the user's requirement and p7-console-shapes.html:292 (Shape A, the recommended shape) both say opening a loop lands on the console; PLAN.md:193-195 decides the opposite and attributes the rejection to [Feature]: supervise long-running threads — turns complete while background subagents are still working, and nothing restarts the run #38 only.
      3. Phase 4 acceptance contradicts the guard table.PLAN.md:383 says master-toggle-off ⇒ "no fiber" and "stand down at next tick" — a tick requires a fiber. p4-settings.html:286-287 ships the wrong half in user-facing help text.
      4. Grace boundary disagrees between adjacent cases.TESTS.md:60-61 (11e) exclusive vs :87 (11k) inclusive; guard 10b is inclusive, so 11e is the wrong one.
      5. PLAN.md:104 D2 says "never session.status" without BACKEND's scoping — PLAN never mentions idleMs/busyIdleMs, so a reader building from PLAN alone drops the long-tool-call case.
      6. The superseded-design pointer (docs/coil/loop/DESIGN.md:3-7) names feat: native subagent & workflow observability pingdotgg/t3code#5219 and feat: scheduled tasks (automations) pingdotgg/t3code#3638 as the premises that "did not survive" — both re-checks actually came back confirming. The three premises that moved are in FINDINGS.md:20-91.

      B. Designed but unscoped

      1. store.global.enabled is the headline kill switch with no data model, no route and no test.BACKEND.md:210-273 defines only LoopRecord and Blocker; §10's four routes never touch global settings. Sequencing consequence: Phase 2 ships "default off behind the master toggle" but only Phase 4 can flip it — phases 2 and 3 are unswitchable as ordered.
      2. Push notifications and mobile surfacing are designed in the report (report.src.html:1175-1187) and named in scope (PLAN.md:140-141) but have no phase, no seam line, no acceptance criteria and no tests. PLAN.md:480 cites push-copy assertions that do not exist.
      3. Sidebar/mobile row chrome: deferred in the report, priced at 0 rows in PLAN, asserted as a requirement in p8-mobile.html:655-657. A budget on the mobile row is a mobile seam row.
      4. gate_off is declared user-visible and starred in TESTS.md:68, but appears in no prototype and has no source test.

      C. Tooling

      1. build-report.mjs can silently drop a prototype. The guard at :77 only fires when zero markers match; a single drifted marker (the hint regex terminates on > and splits on |) emits a report missing that frame, invisible in the browser and in a 15k-line diff. Reproduced: 7 inlined, no error. There is also no check that every file in prototypes/ is referenced. Fix: assert the count.
      2. docs/coil/loop/DESIGN.md contains a /Users/<username>/… path (pre-existing, already public).

      Considered and rejected: adding report.html linguist-generated -diff to .gitattributes. .gitattributes is upstream-owned, so it would buy a diff-noise improvement at the cost of a permanent seam row — the wrong trade for this fork, especially since a fork-only path cannot conflict during a rebase anyway.

      D. Already stale — arriving in the current upstream sync

      Both anchored facts changed upstream after the docs' merge-base cebac353d, and both weaken a stated rationale:

      • f70eeeeb0 (fix(clients): move settled pinned threads into the settled section pingdotgg/t3code#7969, 2026-08-23) inverted pin-vs-settle. Upstream now reads "Settled and snoozed threads remain in their respective shelves even when pinned" — order moved from snooze>pin>settled to snooze>settled>pin. Loop-as-pinned-thread (D3) no longer keeps a settled loop visible.
      • c7222ca4d (feat(claude): compact old threads before they burn through usage pingdotgg/t3code#8144, 2026-08-25) added a second blocking dialogonUserDialog with supportedDialogKinds: ["resume_return"] routes into the same blocking Deferred as AskUserQuestion, and fires on session resume. The loop's own nudge can therefore manufacture a pending user-input that the plan's pending-input guard then treats as a hard skip.
      • Churn figures in UPSTREAM-DELTA.md:209-215 (RightPanelTabs.tsx now +265/-86, not +13) and :52 (Sidebar.logic.ts now +22/-7, not unchanged) have moved. PLAN.md's churn/risk figures reproduce only against the older base a4cc1367b, not the stated cebac353d.

      The 2-row answer to #112 and the 3-row phase 1–4 total both still hold.

      Metadata

      Metadata

      Assignees

      No one assigned

        Labels

        No labels
        No labels

        Projects

        No projects

          Milestone

          No milestone

          Relationships

          None yet

          Development

          No branches or pull requests

          Issue actions

          , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
          Skip to content

          Loops docs (#120): resolve review findings before Phase 2 is built #125

          Description

          @radroid

          #120 merged as 3d91c5754 after four independent reviews. All four returned no merge blockers — the docs are internally sound enough to merge, and every load-bearing [V] claim about the tree reproduced exactly. These are the findings that survived, all of which land before anyone builds Phase 2 from the plan, not before merge.

          A. Contradictions across the document set

          1. The deference cap's precondition is asserted, disputed and refuted in three files. This is the single load-bearing correction of the final revision, and it did not propagate. BACKEND.md:334-337 flags "reject arming without a deadline" as an unresolved change to §3's contract; PLAN.md:135-136, :316-320, :489-503 state the deadline bound with no caveat; TESTS.md:94 case 15 treats a null deadline as supported. Worse, BACKEND.md:288-290 and guard 10b at :529 make deadlineAtMs == null mean no deference at all, so a deadline-less loop fires on top of a healthy self-pacing thread — the exact case BACKEND.md:47 declares impossible. Untested in both directions under a stated 100%-branch gate (TESTS.md:387).
          2. Console precedence reverses the report's own recommendation, undeclared.FINDINGS.md:269 records it as the user's requirement and p7-console-shapes.html:292 (Shape A, the recommended shape) both say opening a loop lands on the console; PLAN.md:193-195 decides the opposite and attributes the rejection to [Feature]: supervise long-running threads — turns complete while background subagents are still working, and nothing restarts the run #38 only.
          3. Phase 4 acceptance contradicts the guard table.PLAN.md:383 says master-toggle-off ⇒ "no fiber" and "stand down at next tick" — a tick requires a fiber. p4-settings.html:286-287 ships the wrong half in user-facing help text.
          4. Grace boundary disagrees between adjacent cases.TESTS.md:60-61 (11e) exclusive vs :87 (11k) inclusive; guard 10b is inclusive, so 11e is the wrong one.
          5. PLAN.md:104 D2 says "never session.status" without BACKEND's scoping — PLAN never mentions idleMs/busyIdleMs, so a reader building from PLAN alone drops the long-tool-call case.
          6. The superseded-design pointer (docs/coil/loop/DESIGN.md:3-7) names feat: native subagent & workflow observability pingdotgg/t3code#5219 and feat: scheduled tasks (automations) pingdotgg/t3code#3638 as the premises that "did not survive" — both re-checks actually came back confirming. The three premises that moved are in FINDINGS.md:20-91.

          B. Designed but unscoped

          1. store.global.enabled is the headline kill switch with no data model, no route and no test.BACKEND.md:210-273 defines only LoopRecord and Blocker; §10's four routes never touch global settings. Sequencing consequence: Phase 2 ships "default off behind the master toggle" but only Phase 4 can flip it — phases 2 and 3 are unswitchable as ordered.
          2. Push notifications and mobile surfacing are designed in the report (report.src.html:1175-1187) and named in scope (PLAN.md:140-141) but have no phase, no seam line, no acceptance criteria and no tests. PLAN.md:480 cites push-copy assertions that do not exist.
          3. Sidebar/mobile row chrome: deferred in the report, priced at 0 rows in PLAN, asserted as a requirement in p8-mobile.html:655-657. A budget on the mobile row is a mobile seam row.
          4. gate_off is declared user-visible and starred in TESTS.md:68, but appears in no prototype and has no source test.

          C. Tooling

          1. build-report.mjs can silently drop a prototype. The guard at :77 only fires when zero markers match; a single drifted marker (the hint regex terminates on > and splits on |) emits a report missing that frame, invisible in the browser and in a 15k-line diff. Reproduced: 7 inlined, no error. There is also no check that every file in prototypes/ is referenced. Fix: assert the count.
          2. docs/coil/loop/DESIGN.md contains a /Users/<username>/… path (pre-existing, already public).

          Considered and rejected: adding report.html linguist-generated -diff to .gitattributes. .gitattributes is upstream-owned, so it would buy a diff-noise improvement at the cost of a permanent seam row — the wrong trade for this fork, especially since a fork-only path cannot conflict during a rebase anyway.

          D. Already stale — arriving in the current upstream sync

          Both anchored facts changed upstream after the docs' merge-base cebac353d, and both weaken a stated rationale:

          • f70eeeeb0 (fix(clients): move settled pinned threads into the settled section pingdotgg/t3code#7969, 2026-08-23) inverted pin-vs-settle. Upstream now reads "Settled and snoozed threads remain in their respective shelves even when pinned" — order moved from snooze>pin>settled to snooze>settled>pin. Loop-as-pinned-thread (D3) no longer keeps a settled loop visible.
          • c7222ca4d (feat(claude): compact old threads before they burn through usage pingdotgg/t3code#8144, 2026-08-25) added a second blocking dialogonUserDialog with supportedDialogKinds: ["resume_return"] routes into the same blocking Deferred as AskUserQuestion, and fires on session resume. The loop's own nudge can therefore manufacture a pending user-input that the plan's pending-input guard then treats as a hard skip.
          • Churn figures in UPSTREAM-DELTA.md:209-215 (RightPanelTabs.tsx now +265/-86, not +13) and :52 (Sidebar.logic.ts now +22/-7, not unchanged) have moved. PLAN.md's churn/risk figures reproduce only against the older base a4cc1367b, not the stated cebac353d.

          The 2-row answer to #112 and the 3-row phase 1–4 total both still hold.

          Metadata

          Metadata

          Assignees

          No one assigned

            Labels

            No labels
            No labels

            Projects

            No projects

              Milestone

              No milestone

              Relationships

              None yet

              Development

              No branches or pull requests

              Issue actions

              , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
              Skip to content

              Loops docs (#120): resolve review findings before Phase 2 is built #125

              Description

              @radroid

              #120 merged as 3d91c5754 after four independent reviews. All four returned no merge blockers — the docs are internally sound enough to merge, and every load-bearing [V] claim about the tree reproduced exactly. These are the findings that survived, all of which land before anyone builds Phase 2 from the plan, not before merge.

              A. Contradictions across the document set

              1. The deference cap's precondition is asserted, disputed and refuted in three files. This is the single load-bearing correction of the final revision, and it did not propagate. BACKEND.md:334-337 flags "reject arming without a deadline" as an unresolved change to §3's contract; PLAN.md:135-136, :316-320, :489-503 state the deadline bound with no caveat; TESTS.md:94 case 15 treats a null deadline as supported. Worse, BACKEND.md:288-290 and guard 10b at :529 make deadlineAtMs == null mean no deference at all, so a deadline-less loop fires on top of a healthy self-pacing thread — the exact case BACKEND.md:47 declares impossible. Untested in both directions under a stated 100%-branch gate (TESTS.md:387).
              2. Console precedence reverses the report's own recommendation, undeclared.FINDINGS.md:269 records it as the user's requirement and p7-console-shapes.html:292 (Shape A, the recommended shape) both say opening a loop lands on the console; PLAN.md:193-195 decides the opposite and attributes the rejection to [Feature]: supervise long-running threads — turns complete while background subagents are still working, and nothing restarts the run #38 only.
              3. Phase 4 acceptance contradicts the guard table.PLAN.md:383 says master-toggle-off ⇒ "no fiber" and "stand down at next tick" — a tick requires a fiber. p4-settings.html:286-287 ships the wrong half in user-facing help text.
              4. Grace boundary disagrees between adjacent cases.TESTS.md:60-61 (11e) exclusive vs :87 (11k) inclusive; guard 10b is inclusive, so 11e is the wrong one.
              5. PLAN.md:104 D2 says "never session.status" without BACKEND's scoping — PLAN never mentions idleMs/busyIdleMs, so a reader building from PLAN alone drops the long-tool-call case.
              6. The superseded-design pointer (docs/coil/loop/DESIGN.md:3-7) names feat: native subagent & workflow observability pingdotgg/t3code#5219 and feat: scheduled tasks (automations) pingdotgg/t3code#3638 as the premises that "did not survive" — both re-checks actually came back confirming. The three premises that moved are in FINDINGS.md:20-91.

              B. Designed but unscoped

              1. store.global.enabled is the headline kill switch with no data model, no route and no test.BACKEND.md:210-273 defines only LoopRecord and Blocker; §10's four routes never touch global settings. Sequencing consequence: Phase 2 ships "default off behind the master toggle" but only Phase 4 can flip it — phases 2 and 3 are unswitchable as ordered.
              2. Push notifications and mobile surfacing are designed in the report (report.src.html:1175-1187) and named in scope (PLAN.md:140-141) but have no phase, no seam line, no acceptance criteria and no tests. PLAN.md:480 cites push-copy assertions that do not exist.
              3. Sidebar/mobile row chrome: deferred in the report, priced at 0 rows in PLAN, asserted as a requirement in p8-mobile.html:655-657. A budget on the mobile row is a mobile seam row.
              4. gate_off is declared user-visible and starred in TESTS.md:68, but appears in no prototype and has no source test.

              C. Tooling

              1. build-report.mjs can silently drop a prototype. The guard at :77 only fires when zero markers match; a single drifted marker (the hint regex terminates on > and splits on |) emits a report missing that frame, invisible in the browser and in a 15k-line diff. Reproduced: 7 inlined, no error. There is also no check that every file in prototypes/ is referenced. Fix: assert the count.
              2. docs/coil/loop/DESIGN.md contains a /Users/<username>/… path (pre-existing, already public).

              Considered and rejected: adding report.html linguist-generated -diff to .gitattributes. .gitattributes is upstream-owned, so it would buy a diff-noise improvement at the cost of a permanent seam row — the wrong trade for this fork, especially since a fork-only path cannot conflict during a rebase anyway.

              D. Already stale — arriving in the current upstream sync

              Both anchored facts changed upstream after the docs' merge-base cebac353d, and both weaken a stated rationale:

              • f70eeeeb0 (fix(clients): move settled pinned threads into the settled section pingdotgg/t3code#7969, 2026-08-23) inverted pin-vs-settle. Upstream now reads "Settled and snoozed threads remain in their respective shelves even when pinned" — order moved from snooze>pin>settled to snooze>settled>pin. Loop-as-pinned-thread (D3) no longer keeps a settled loop visible.
              • c7222ca4d (feat(claude): compact old threads before they burn through usage pingdotgg/t3code#8144, 2026-08-25) added a second blocking dialogonUserDialog with supportedDialogKinds: ["resume_return"] routes into the same blocking Deferred as AskUserQuestion, and fires on session resume. The loop's own nudge can therefore manufacture a pending user-input that the plan's pending-input guard then treats as a hard skip.
              • Churn figures in UPSTREAM-DELTA.md:209-215 (RightPanelTabs.tsx now +265/-86, not +13) and :52 (Sidebar.logic.ts now +22/-7, not unchanged) have moved. PLAN.md's churn/risk figures reproduce only against the older base a4cc1367b, not the stated cebac353d.

              The 2-row answer to #112 and the 3-row phase 1–4 total both still hold.

              Metadata

              Metadata

              Assignees

              No one assigned

                Labels

                No labels
                No labels

                Projects

                No projects

                  Milestone

                  No milestone

                  Relationships

                  None yet

                  Development

                  No branches or pull requests

                  Issue actions

                  , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
                  Skip to content

                  Loops docs (#120): resolve review findings before Phase 2 is built #125

                  Description

                  @radroid

                  #120 merged as 3d91c5754 after four independent reviews. All four returned no merge blockers — the docs are internally sound enough to merge, and every load-bearing [V] claim about the tree reproduced exactly. These are the findings that survived, all of which land before anyone builds Phase 2 from the plan, not before merge.

                  A. Contradictions across the document set

                  1. The deference cap's precondition is asserted, disputed and refuted in three files. This is the single load-bearing correction of the final revision, and it did not propagate. BACKEND.md:334-337 flags "reject arming without a deadline" as an unresolved change to §3's contract; PLAN.md:135-136, :316-320, :489-503 state the deadline bound with no caveat; TESTS.md:94 case 15 treats a null deadline as supported. Worse, BACKEND.md:288-290 and guard 10b at :529 make deadlineAtMs == null mean no deference at all, so a deadline-less loop fires on top of a healthy self-pacing thread — the exact case BACKEND.md:47 declares impossible. Untested in both directions under a stated 100%-branch gate (TESTS.md:387).
                  2. Console precedence reverses the report's own recommendation, undeclared.FINDINGS.md:269 records it as the user's requirement and p7-console-shapes.html:292 (Shape A, the recommended shape) both say opening a loop lands on the console; PLAN.md:193-195 decides the opposite and attributes the rejection to [Feature]: supervise long-running threads — turns complete while background subagents are still working, and nothing restarts the run #38 only.
                  3. Phase 4 acceptance contradicts the guard table.PLAN.md:383 says master-toggle-off ⇒ "no fiber" and "stand down at next tick" — a tick requires a fiber. p4-settings.html:286-287 ships the wrong half in user-facing help text.
                  4. Grace boundary disagrees between adjacent cases.TESTS.md:60-61 (11e) exclusive vs :87 (11k) inclusive; guard 10b is inclusive, so 11e is the wrong one.
                  5. PLAN.md:104 D2 says "never session.status" without BACKEND's scoping — PLAN never mentions idleMs/busyIdleMs, so a reader building from PLAN alone drops the long-tool-call case.
                  6. The superseded-design pointer (docs/coil/loop/DESIGN.md:3-7) names feat: native subagent & workflow observability pingdotgg/t3code#5219 and feat: scheduled tasks (automations) pingdotgg/t3code#3638 as the premises that "did not survive" — both re-checks actually came back confirming. The three premises that moved are in FINDINGS.md:20-91.

                  B. Designed but unscoped

                  1. store.global.enabled is the headline kill switch with no data model, no route and no test.BACKEND.md:210-273 defines only LoopRecord and Blocker; §10's four routes never touch global settings. Sequencing consequence: Phase 2 ships "default off behind the master toggle" but only Phase 4 can flip it — phases 2 and 3 are unswitchable as ordered.
                  2. Push notifications and mobile surfacing are designed in the report (report.src.html:1175-1187) and named in scope (PLAN.md:140-141) but have no phase, no seam line, no acceptance criteria and no tests. PLAN.md:480 cites push-copy assertions that do not exist.
                  3. Sidebar/mobile row chrome: deferred in the report, priced at 0 rows in PLAN, asserted as a requirement in p8-mobile.html:655-657. A budget on the mobile row is a mobile seam row.
                  4. gate_off is declared user-visible and starred in TESTS.md:68, but appears in no prototype and has no source test.

                  C. Tooling

                  1. build-report.mjs can silently drop a prototype. The guard at :77 only fires when zero markers match; a single drifted marker (the hint regex terminates on > and splits on |) emits a report missing that frame, invisible in the browser and in a 15k-line diff. Reproduced: 7 inlined, no error. There is also no check that every file in prototypes/ is referenced. Fix: assert the count.
                  2. docs/coil/loop/DESIGN.md contains a /Users/<username>/… path (pre-existing, already public).

                  Considered and rejected: adding report.html linguist-generated -diff to .gitattributes. .gitattributes is upstream-owned, so it would buy a diff-noise improvement at the cost of a permanent seam row — the wrong trade for this fork, especially since a fork-only path cannot conflict during a rebase anyway.

                  D. Already stale — arriving in the current upstream sync

                  Both anchored facts changed upstream after the docs' merge-base cebac353d, and both weaken a stated rationale:

                  • f70eeeeb0 (fix(clients): move settled pinned threads into the settled section pingdotgg/t3code#7969, 2026-08-23) inverted pin-vs-settle. Upstream now reads "Settled and snoozed threads remain in their respective shelves even when pinned" — order moved from snooze>pin>settled to snooze>settled>pin. Loop-as-pinned-thread (D3) no longer keeps a settled loop visible.
                  • c7222ca4d (feat(claude): compact old threads before they burn through usage pingdotgg/t3code#8144, 2026-08-25) added a second blocking dialogonUserDialog with supportedDialogKinds: ["resume_return"] routes into the same blocking Deferred as AskUserQuestion, and fires on session resume. The loop's own nudge can therefore manufacture a pending user-input that the plan's pending-input guard then treats as a hard skip.
                  • Churn figures in UPSTREAM-DELTA.md:209-215 (RightPanelTabs.tsx now +265/-86, not +13) and :52 (Sidebar.logic.ts now +22/-7, not unchanged) have moved. PLAN.md's churn/risk figures reproduce only against the older base a4cc1367b, not the stated cebac353d.

                  The 2-row answer to #112 and the 3-row phase 1–4 total both still hold.

                  Metadata

                  Metadata

                  Assignees

                  No one assigned

                    Labels

                    No labels
                    No labels

                    Projects

                    No projects

                      Milestone

                      No milestone

                      Relationships

                      None yet

                      Development

                      No branches or pull requests

                      Issue actions

                      , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
                      Skip to content

                      Loops docs (#120): resolve review findings before Phase 2 is built #125

                      Description

                      @radroid

                      #120 merged as 3d91c5754 after four independent reviews. All four returned no merge blockers — the docs are internally sound enough to merge, and every load-bearing [V] claim about the tree reproduced exactly. These are the findings that survived, all of which land before anyone builds Phase 2 from the plan, not before merge.

                      A. Contradictions across the document set

                      1. The deference cap's precondition is asserted, disputed and refuted in three files. This is the single load-bearing correction of the final revision, and it did not propagate. BACKEND.md:334-337 flags "reject arming without a deadline" as an unresolved change to §3's contract; PLAN.md:135-136, :316-320, :489-503 state the deadline bound with no caveat; TESTS.md:94 case 15 treats a null deadline as supported. Worse, BACKEND.md:288-290 and guard 10b at :529 make deadlineAtMs == null mean no deference at all, so a deadline-less loop fires on top of a healthy self-pacing thread — the exact case BACKEND.md:47 declares impossible. Untested in both directions under a stated 100%-branch gate (TESTS.md:387).
                      2. Console precedence reverses the report's own recommendation, undeclared.FINDINGS.md:269 records it as the user's requirement and p7-console-shapes.html:292 (Shape A, the recommended shape) both say opening a loop lands on the console; PLAN.md:193-195 decides the opposite and attributes the rejection to [Feature]: supervise long-running threads — turns complete while background subagents are still working, and nothing restarts the run #38 only.
                      3. Phase 4 acceptance contradicts the guard table.PLAN.md:383 says master-toggle-off ⇒ "no fiber" and "stand down at next tick" — a tick requires a fiber. p4-settings.html:286-287 ships the wrong half in user-facing help text.
                      4. Grace boundary disagrees between adjacent cases.TESTS.md:60-61 (11e) exclusive vs :87 (11k) inclusive; guard 10b is inclusive, so 11e is the wrong one.
                      5. PLAN.md:104 D2 says "never session.status" without BACKEND's scoping — PLAN never mentions idleMs/busyIdleMs, so a reader building from PLAN alone drops the long-tool-call case.
                      6. The superseded-design pointer (docs/coil/loop/DESIGN.md:3-7) names feat: native subagent & workflow observability pingdotgg/t3code#5219 and feat: scheduled tasks (automations) pingdotgg/t3code#3638 as the premises that "did not survive" — both re-checks actually came back confirming. The three premises that moved are in FINDINGS.md:20-91.

                      B. Designed but unscoped

                      1. store.global.enabled is the headline kill switch with no data model, no route and no test.BACKEND.md:210-273 defines only LoopRecord and Blocker; §10's four routes never touch global settings. Sequencing consequence: Phase 2 ships "default off behind the master toggle" but only Phase 4 can flip it — phases 2 and 3 are unswitchable as ordered.
                      2. Push notifications and mobile surfacing are designed in the report (report.src.html:1175-1187) and named in scope (PLAN.md:140-141) but have no phase, no seam line, no acceptance criteria and no tests. PLAN.md:480 cites push-copy assertions that do not exist.
                      3. Sidebar/mobile row chrome: deferred in the report, priced at 0 rows in PLAN, asserted as a requirement in p8-mobile.html:655-657. A budget on the mobile row is a mobile seam row.
                      4. gate_off is declared user-visible and starred in TESTS.md:68, but appears in no prototype and has no source test.

                      C. Tooling

                      1. build-report.mjs can silently drop a prototype. The guard at :77 only fires when zero markers match; a single drifted marker (the hint regex terminates on > and splits on |) emits a report missing that frame, invisible in the browser and in a 15k-line diff. Reproduced: 7 inlined, no error. There is also no check that every file in prototypes/ is referenced. Fix: assert the count.
                      2. docs/coil/loop/DESIGN.md contains a /Users/<username>/… path (pre-existing, already public).

                      Considered and rejected: adding report.html linguist-generated -diff to .gitattributes. .gitattributes is upstream-owned, so it would buy a diff-noise improvement at the cost of a permanent seam row — the wrong trade for this fork, especially since a fork-only path cannot conflict during a rebase anyway.

                      D. Already stale — arriving in the current upstream sync

                      Both anchored facts changed upstream after the docs' merge-base cebac353d, and both weaken a stated rationale:

                      • f70eeeeb0 (fix(clients): move settled pinned threads into the settled section pingdotgg/t3code#7969, 2026-08-23) inverted pin-vs-settle. Upstream now reads "Settled and snoozed threads remain in their respective shelves even when pinned" — order moved from snooze>pin>settled to snooze>settled>pin. Loop-as-pinned-thread (D3) no longer keeps a settled loop visible.
                      • c7222ca4d (feat(claude): compact old threads before they burn through usage pingdotgg/t3code#8144, 2026-08-25) added a second blocking dialogonUserDialog with supportedDialogKinds: ["resume_return"] routes into the same blocking Deferred as AskUserQuestion, and fires on session resume. The loop's own nudge can therefore manufacture a pending user-input that the plan's pending-input guard then treats as a hard skip.
                      • Churn figures in UPSTREAM-DELTA.md:209-215 (RightPanelTabs.tsx now +265/-86, not +13) and :52 (Sidebar.logic.ts now +22/-7, not unchanged) have moved. PLAN.md's churn/risk figures reproduce only against the older base a4cc1367b, not the stated cebac353d.

                      The 2-row answer to #112 and the 3-row phase 1–4 total both still hold.

                      Metadata

                      Metadata

                      Assignees

                      No one assigned

                        Labels

                        No labels
                        No labels

                        Projects

                        No projects

                          Milestone

                          No milestone

                          Relationships

                          None yet

                          Development

                          No branches or pull requests

                          Issue actions

                          , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
                          Skip to content

                          Loops docs (#120): resolve review findings before Phase 2 is built #125

                          Description

                          @radroid

                          #120 merged as 3d91c5754 after four independent reviews. All four returned no merge blockers — the docs are internally sound enough to merge, and every load-bearing [V] claim about the tree reproduced exactly. These are the findings that survived, all of which land before anyone builds Phase 2 from the plan, not before merge.

                          A. Contradictions across the document set

                          1. The deference cap's precondition is asserted, disputed and refuted in three files. This is the single load-bearing correction of the final revision, and it did not propagate. BACKEND.md:334-337 flags "reject arming without a deadline" as an unresolved change to §3's contract; PLAN.md:135-136, :316-320, :489-503 state the deadline bound with no caveat; TESTS.md:94 case 15 treats a null deadline as supported. Worse, BACKEND.md:288-290 and guard 10b at :529 make deadlineAtMs == null mean no deference at all, so a deadline-less loop fires on top of a healthy self-pacing thread — the exact case BACKEND.md:47 declares impossible. Untested in both directions under a stated 100%-branch gate (TESTS.md:387).
                          2. Console precedence reverses the report's own recommendation, undeclared.FINDINGS.md:269 records it as the user's requirement and p7-console-shapes.html:292 (Shape A, the recommended shape) both say opening a loop lands on the console; PLAN.md:193-195 decides the opposite and attributes the rejection to [Feature]: supervise long-running threads — turns complete while background subagents are still working, and nothing restarts the run #38 only.
                          3. Phase 4 acceptance contradicts the guard table.PLAN.md:383 says master-toggle-off ⇒ "no fiber" and "stand down at next tick" — a tick requires a fiber. p4-settings.html:286-287 ships the wrong half in user-facing help text.
                          4. Grace boundary disagrees between adjacent cases.TESTS.md:60-61 (11e) exclusive vs :87 (11k) inclusive; guard 10b is inclusive, so 11e is the wrong one.
                          5. PLAN.md:104 D2 says "never session.status" without BACKEND's scoping — PLAN never mentions idleMs/busyIdleMs, so a reader building from PLAN alone drops the long-tool-call case.
                          6. The superseded-design pointer (docs/coil/loop/DESIGN.md:3-7) names feat: native subagent & workflow observability pingdotgg/t3code#5219 and feat: scheduled tasks (automations) pingdotgg/t3code#3638 as the premises that "did not survive" — both re-checks actually came back confirming. The three premises that moved are in FINDINGS.md:20-91.

                          B. Designed but unscoped

                          1. store.global.enabled is the headline kill switch with no data model, no route and no test.BACKEND.md:210-273 defines only LoopRecord and Blocker; §10's four routes never touch global settings. Sequencing consequence: Phase 2 ships "default off behind the master toggle" but only Phase 4 can flip it — phases 2 and 3 are unswitchable as ordered.
                          2. Push notifications and mobile surfacing are designed in the report (report.src.html:1175-1187) and named in scope (PLAN.md:140-141) but have no phase, no seam line, no acceptance criteria and no tests. PLAN.md:480 cites push-copy assertions that do not exist.
                          3. Sidebar/mobile row chrome: deferred in the report, priced at 0 rows in PLAN, asserted as a requirement in p8-mobile.html:655-657. A budget on the mobile row is a mobile seam row.
                          4. gate_off is declared user-visible and starred in TESTS.md:68, but appears in no prototype and has no source test.

                          C. Tooling

                          1. build-report.mjs can silently drop a prototype. The guard at :77 only fires when zero markers match; a single drifted marker (the hint regex terminates on > and splits on |) emits a report missing that frame, invisible in the browser and in a 15k-line diff. Reproduced: 7 inlined, no error. There is also no check that every file in prototypes/ is referenced. Fix: assert the count.
                          2. docs/coil/loop/DESIGN.md contains a /Users/<username>/… path (pre-existing, already public).

                          Considered and rejected: adding report.html linguist-generated -diff to .gitattributes. .gitattributes is upstream-owned, so it would buy a diff-noise improvement at the cost of a permanent seam row — the wrong trade for this fork, especially since a fork-only path cannot conflict during a rebase anyway.

                          D. Already stale — arriving in the current upstream sync

                          Both anchored facts changed upstream after the docs' merge-base cebac353d, and both weaken a stated rationale:

                          • f70eeeeb0 (fix(clients): move settled pinned threads into the settled section pingdotgg/t3code#7969, 2026-08-23) inverted pin-vs-settle. Upstream now reads "Settled and snoozed threads remain in their respective shelves even when pinned" — order moved from snooze>pin>settled to snooze>settled>pin. Loop-as-pinned-thread (D3) no longer keeps a settled loop visible.
                          • c7222ca4d (feat(claude): compact old threads before they burn through usage pingdotgg/t3code#8144, 2026-08-25) added a second blocking dialogonUserDialog with supportedDialogKinds: ["resume_return"] routes into the same blocking Deferred as AskUserQuestion, and fires on session resume. The loop's own nudge can therefore manufacture a pending user-input that the plan's pending-input guard then treats as a hard skip.
                          • Churn figures in UPSTREAM-DELTA.md:209-215 (RightPanelTabs.tsx now +265/-86, not +13) and :52 (Sidebar.logic.ts now +22/-7, not unchanged) have moved. PLAN.md's churn/risk figures reproduce only against the older base a4cc1367b, not the stated cebac353d.

                          The 2-row answer to #112 and the 3-row phase 1–4 total both still hold.

                          Metadata

                          Metadata

                          Assignees

                          No one assigned

                            Labels

                            No labels
                            No labels

                            Projects

                            No projects

                              Milestone

                              No milestone

                              Relationships

                              None yet

                              Development

                              No branches or pull requests

                              Issue actions

                              , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
                              Skip to content

                              Loops docs (#120): resolve review findings before Phase 2 is built #125

                              Description

                              @radroid

                              #120 merged as 3d91c5754 after four independent reviews. All four returned no merge blockers — the docs are internally sound enough to merge, and every load-bearing [V] claim about the tree reproduced exactly. These are the findings that survived, all of which land before anyone builds Phase 2 from the plan, not before merge.

                              A. Contradictions across the document set

                              1. The deference cap's precondition is asserted, disputed and refuted in three files. This is the single load-bearing correction of the final revision, and it did not propagate. BACKEND.md:334-337 flags "reject arming without a deadline" as an unresolved change to §3's contract; PLAN.md:135-136, :316-320, :489-503 state the deadline bound with no caveat; TESTS.md:94 case 15 treats a null deadline as supported. Worse, BACKEND.md:288-290 and guard 10b at :529 make deadlineAtMs == null mean no deference at all, so a deadline-less loop fires on top of a healthy self-pacing thread — the exact case BACKEND.md:47 declares impossible. Untested in both directions under a stated 100%-branch gate (TESTS.md:387).
                              2. Console precedence reverses the report's own recommendation, undeclared.FINDINGS.md:269 records it as the user's requirement and p7-console-shapes.html:292 (Shape A, the recommended shape) both say opening a loop lands on the console; PLAN.md:193-195 decides the opposite and attributes the rejection to [Feature]: supervise long-running threads — turns complete while background subagents are still working, and nothing restarts the run #38 only.
                              3. Phase 4 acceptance contradicts the guard table.PLAN.md:383 says master-toggle-off ⇒ "no fiber" and "stand down at next tick" — a tick requires a fiber. p4-settings.html:286-287 ships the wrong half in user-facing help text.
                              4. Grace boundary disagrees between adjacent cases.TESTS.md:60-61 (11e) exclusive vs :87 (11k) inclusive; guard 10b is inclusive, so 11e is the wrong one.
                              5. PLAN.md:104 D2 says "never session.status" without BACKEND's scoping — PLAN never mentions idleMs/busyIdleMs, so a reader building from PLAN alone drops the long-tool-call case.
                              6. The superseded-design pointer (docs/coil/loop/DESIGN.md:3-7) names feat: native subagent & workflow observability pingdotgg/t3code#5219 and feat: scheduled tasks (automations) pingdotgg/t3code#3638 as the premises that "did not survive" — both re-checks actually came back confirming. The three premises that moved are in FINDINGS.md:20-91.

                              B. Designed but unscoped

                              1. store.global.enabled is the headline kill switch with no data model, no route and no test.BACKEND.md:210-273 defines only LoopRecord and Blocker; §10's four routes never touch global settings. Sequencing consequence: Phase 2 ships "default off behind the master toggle" but only Phase 4 can flip it — phases 2 and 3 are unswitchable as ordered.
                              2. Push notifications and mobile surfacing are designed in the report (report.src.html:1175-1187) and named in scope (PLAN.md:140-141) but have no phase, no seam line, no acceptance criteria and no tests. PLAN.md:480 cites push-copy assertions that do not exist.
                              3. Sidebar/mobile row chrome: deferred in the report, priced at 0 rows in PLAN, asserted as a requirement in p8-mobile.html:655-657. A budget on the mobile row is a mobile seam row.
                              4. gate_off is declared user-visible and starred in TESTS.md:68, but appears in no prototype and has no source test.

                              C. Tooling

                              1. build-report.mjs can silently drop a prototype. The guard at :77 only fires when zero markers match; a single drifted marker (the hint regex terminates on > and splits on |) emits a report missing that frame, invisible in the browser and in a 15k-line diff. Reproduced: 7 inlined, no error. There is also no check that every file in prototypes/ is referenced. Fix: assert the count.
                              2. docs/coil/loop/DESIGN.md contains a /Users/<username>/… path (pre-existing, already public).

                              Considered and rejected: adding report.html linguist-generated -diff to .gitattributes. .gitattributes is upstream-owned, so it would buy a diff-noise improvement at the cost of a permanent seam row — the wrong trade for this fork, especially since a fork-only path cannot conflict during a rebase anyway.

                              D. Already stale — arriving in the current upstream sync

                              Both anchored facts changed upstream after the docs' merge-base cebac353d, and both weaken a stated rationale:

                              • f70eeeeb0 (fix(clients): move settled pinned threads into the settled section pingdotgg/t3code#7969, 2026-08-23) inverted pin-vs-settle. Upstream now reads "Settled and snoozed threads remain in their respective shelves even when pinned" — order moved from snooze>pin>settled to snooze>settled>pin. Loop-as-pinned-thread (D3) no longer keeps a settled loop visible.
                              • c7222ca4d (feat(claude): compact old threads before they burn through usage pingdotgg/t3code#8144, 2026-08-25) added a second blocking dialogonUserDialog with supportedDialogKinds: ["resume_return"] routes into the same blocking Deferred as AskUserQuestion, and fires on session resume. The loop's own nudge can therefore manufacture a pending user-input that the plan's pending-input guard then treats as a hard skip.
                              • Churn figures in UPSTREAM-DELTA.md:209-215 (RightPanelTabs.tsx now +265/-86, not +13) and :52 (Sidebar.logic.ts now +22/-7, not unchanged) have moved. PLAN.md's churn/risk figures reproduce only against the older base a4cc1367b, not the stated cebac353d.

                              The 2-row answer to #112 and the 3-row phase 1–4 total both still hold.

                              Metadata

                              Metadata

                              Assignees

                              No one assigned

                                Labels

                                No labels
                                No labels

                                Projects

                                No projects

                                  Milestone

                                  No milestone

                                  Relationships

                                  None yet

                                  Development

                                  No branches or pull requests

                                  Issue actions