fix(server): reconcile crash-frozen running turns to interrupted on boot (#5)#13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radroid merged 1 commit into from
Jul 25, 2026
Merged

fix(server): reconcile crash-frozen running turns to interrupted on boot (#5) #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
296 changes: 296 additions & 0 deletions apps/server/src/orchestration/Layers/CrashRecoveryReconciler.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,296 @@
import {
CommandId,
DEFAULT_PROVIDER_INTERACTION_MODE,
ProjectId,
ProviderInstanceId,
ThreadId,
TurnId,
type OrchestrationCommand,
type OrchestrationEvent,
} from "@t3tools/contracts";
import * as NodeServices from "@effect/platform-node/NodeServices";
import * as Effect from "effect/Effect";
import * as Layer from "effect/Layer";
import * as ManagedRuntime from "effect/ManagedRuntime";
import * as Stream from "effect/Stream";
import { describe, expect, it } from "vite-plus/test";

import { OrchestrationCommandReceiptRepositoryLive } from "../../persistence/Layers/OrchestrationCommandReceipts.ts";
import { OrchestrationEventStoreLive } from "../../persistence/Layers/OrchestrationEventStore.ts";
import { ProjectionTurnRepositoryLive } from "../../persistence/Layers/ProjectionTurns.ts";
import { SqlitePersistenceMemory } from "../../persistence/Layers/Sqlite.ts";
import { ProjectionTurnRepository } from "../../persistence/Services/ProjectionTurns.ts";
import * as RepositoryIdentityResolver from "../../project/RepositoryIdentityResolver.ts";
import { ServerConfig } from "../../config.ts";
import { OrchestrationEngineLive } from "./OrchestrationEngine.ts";
import { OrchestrationProjectionPipelineLive } from "./ProjectionPipeline.ts";
import { OrchestrationProjectionSnapshotQueryLive } from "./ProjectionSnapshotQuery.ts";
import { OrchestrationEngineService } from "../Services/OrchestrationEngine.ts";
import { ProjectionSnapshotQuery } from "../Services/ProjectionSnapshotQuery.ts";
import { reconcileInterruptedTurnsOnBoot } from "./CrashRecoveryReconciler.ts";

const MODEL_SELECTION = {
instanceId: ProviderInstanceId.make("codex"),
model: "gpt-5-codex",
};

async function createReconcilerSystem() {
const ServerConfigLayer = ServerConfig.layerTest(process.cwd(), {
prefix: "t3-crash-recovery-reconciler-test-",
});
const orchestrationLayer = Layer.mergeAll(
OrchestrationEngineLive.pipe(
Layer.provide(OrchestrationProjectionSnapshotQueryLive),
Layer.provide(OrchestrationProjectionPipelineLive),
),
OrchestrationProjectionSnapshotQueryLive,
ProjectionTurnRepositoryLive,
).pipe(
Layer.provide(OrchestrationEventStoreLive),
Layer.provide(OrchestrationCommandReceiptRepositoryLive),
Layer.provide(RepositoryIdentityResolver.layer),
Layer.provide(SqlitePersistenceMemory),
Layer.provideMerge(ServerConfigLayer),
Layer.provideMerge(NodeServices.layer),
);
const runtime = ManagedRuntime.make(orchestrationLayer);
const engine = await runtime.runPromise(Effect.service(OrchestrationEngineService));
const snapshotQuery = await runtime.runPromise(Effect.service(ProjectionSnapshotQuery));
const turnRepository = await runtime.runPromise(Effect.service(ProjectionTurnRepository));

return {
dispatch: (command: OrchestrationCommand) => runtime.runPromise(engine.dispatch(command)),
readModel: () => runtime.runPromise(snapshotQuery.getSnapshot()),
reconcile: () => runtime.runPromise(reconcileInterruptedTurnsOnBoot),
getTurn: (threadId: string, turnId: string) =>
runtime.runPromise(
turnRepository.getByTurnId({
threadId: ThreadId.make(threadId),
turnId: TurnId.make(turnId),
}),
),
readEvents: () =>
runtime.runPromise(
Stream.runCollect(engine.readEvents(0)).pipe(
Effect.map((chunk): OrchestrationEvent[] => Array.from(chunk)),
),
),
dispose: () => runtime.dispose(),
};
}

type ReconcilerSystem = Awaited<ReturnType<typeof createReconcilerSystem>>;

async function seedProject(system: ReconcilerSystem, projectId: string) {
await system.dispatch({
type: "project.create",
commandId: CommandId.make(`cmd-project-${projectId}`),
projectId: ProjectId.make(projectId),
title: `Project ${projectId}`,
workspaceRoot: `/tmp/${projectId}`,
defaultModelSelection: MODEL_SELECTION,
createdAt: "2026-01-01T00:00:00.000Z",
});
}

async function seedThread(system: ReconcilerSystem, projectId: string, threadId: string) {
await system.dispatch({
type: "thread.create",
commandId: CommandId.make(`cmd-thread-${threadId}`),
threadId: ThreadId.make(threadId),
projectId: ProjectId.make(projectId),
title: `Thread ${threadId}`,
modelSelection: MODEL_SELECTION,
interactionMode: DEFAULT_PROVIDER_INTERACTION_MODE,
runtimeMode: "full-access",
branch: null,
worktreePath: null,
createdAt: "2026-01-01T00:00:01.000Z",
});
}

async function setSession(
system: ReconcilerSystem,
threadId: string,
status: "running" | "stopped",
activeTurnId: string | null,
updatedAt: string,
) {
await system.dispatch({
type: "thread.session.set",
commandId: CommandId.make(`cmd-session-${threadId}-${status}-${updatedAt}`),
threadId: ThreadId.make(threadId),
session: {
threadId: ThreadId.make(threadId),
status,
providerName: "claudeAgent",
providerInstanceId: ProviderInstanceId.make("codex"),
runtimeMode: "full-access",
activeTurnId: activeTurnId === null ? null : TurnId.make(activeTurnId),
lastError: null,
updatedAt,
},
createdAt: updatedAt,
});
}

/** Seed a thread frozen mid-turn the way an ungraceful crash leaves it. */
async function seedCrashedThread(
system: ReconcilerSystem,
projectId: string,
threadId: string,
turnId: string,
) {
await seedThread(system, projectId, threadId);
await setSession(system, threadId, "running", turnId, "2026-01-01T00:00:02.000Z");
}

describe("reconcileInterruptedTurnsOnBoot", () => {
it("leaves a crashed thread with a running turn / active session (precondition)", async () => {
const system = await createReconcilerSystem();
try {
await seedProject(system, "project-1");
await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

const snapshot = await system.readModel();
const thread = snapshot.threads.find((entry) => entry.id === "thread-1");
expect(thread?.latestTurn?.state).toBe("running");
expect(thread?.session?.status).toBe("running");
expect(thread?.session?.activeTurnId).toBe("turn-1");

const turn = await system.getTurn("thread-1", "turn-1");
expect(turn._tag).toBe("Some");
if (turn._tag === "Some") {
expect(turn.value.state).toBe("running");
expect(turn.value.completedAt).toBeNull();
}
} finally {
await system.dispose();
}
});

it("settles a crashed thread to interrupted and stops the session", async () => {
const system = await createReconcilerSystem();
try {
await seedProject(system, "project-1");
await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

const result = await system.reconcile();
expect(result.reconciledCount).toBe(1);

const snapshot = await system.readModel();
const thread = snapshot.threads.find((entry) => entry.id === "thread-1");
expect(thread?.session?.status).toBe("stopped");
expect(thread?.session?.activeTurnId).toBeNull();

const turn = await system.getTurn("thread-1", "turn-1");
expect(turn._tag).toBe("Some");
if (turn._tag === "Some") {
expect(turn.value.state).toBe("interrupted");
expect(turn.value.completedAt).not.toBeNull();
}
} finally {
await system.dispose();
}
});

it("is idempotent: a second boot reconciles nothing and leaves projections unchanged", async () => {
const system = await createReconcilerSystem();
try {
await seedProject(system, "project-1");
await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

const first = await system.reconcile();
expect(first.reconciledCount).toBe(1);

const eventsAfterFirst = await system.readEvents();
const snapshotAfterFirst = await system.readModel();

const second = await system.reconcile();
expect(second.reconciledCount).toBe(0);

const eventsAfterSecond = await system.readEvents();
expect(eventsAfterSecond.length).toBe(eventsAfterFirst.length);

const snapshotAfterSecond = await system.readModel();
const threadFirst = snapshotAfterFirst.threads.find((entry) => entry.id === "thread-1");
const threadSecond = snapshotAfterSecond.threads.find((entry) => entry.id === "thread-1");
expect(threadSecond?.session?.status).toBe(threadFirst?.session?.status);
expect(threadSecond?.session?.activeTurnId).toBe(threadFirst?.session?.activeTurnId ?? null);

const turn = await system.getTurn("thread-1", "turn-1");
if (turn._tag === "Some") {
expect(turn.value.state).toBe("interrupted");
}
} finally {
await system.dispose();
}
});

it("only reconciles crashed threads, not already-settled ones (multi-thread selectivity)", async () => {
const system = await createReconcilerSystem();
try {
await seedProject(system, "project-1");
await seedCrashedThread(system, "project-1", "thread-a", "turn-a");
await seedCrashedThread(system, "project-1", "thread-b", "turn-b");

// An already-settled thread: it ran a turn and the session was cleanly stopped.
await seedThread(system, "project-1", "thread-settled");
await setSession(system, "thread-settled", "running", "turn-s", "2026-01-01T00:00:03.000Z");
await setSession(system, "thread-settled", "stopped", null, "2026-01-01T00:00:04.000Z");

const settledTurnBefore = await system.getTurn("thread-settled", "turn-s");
expect(settledTurnBefore._tag).toBe("Some");

const result = await system.reconcile();
expect(result.reconciledCount).toBe(2);

const crashedTurns: ReadonlyArray<readonly [string, string]> = [
["thread-a", "turn-a"],
["thread-b", "turn-b"],
];
for (const [threadId, turnId] of crashedTurns) {
const turn = await system.getTurn(threadId, turnId);
if (turn._tag === "Some") {
expect(turn.value.state).toBe("interrupted");
expect(turn.value.completedAt).not.toBeNull();
}
}

// The already-settled thread must be untouched (same completedAt).
const settledTurnAfter = await system.getTurn("thread-settled", "turn-s");
if (settledTurnBefore._tag === "Some" && settledTurnAfter._tag === "Some") {
expect(settledTurnAfter.value.state).toBe("interrupted");
expect(settledTurnAfter.value.completedAt).toBe(settledTurnBefore.value.completedAt);
}
} finally {
await system.dispose();
}
});

it("appends a durable thread.session-set event that survives a projection rebuild", async () => {
const system = await createReconcilerSystem();
try {
await seedProject(system, "project-1");
await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

await system.reconcile();

const events = await system.readEvents();
const stopEvents = events.filter(
(event): event is Extract<OrchestrationEvent, { type: "thread.session-set" }> =>
event.type === "thread.session-set" &&
event.payload.threadId === "thread-1" &&
event.payload.session.status === "stopped",
);
expect(stopEvents.length).toBe(1);
const stopEvent = stopEvents[0];
if (stopEvent) {
expect(stopEvent.payload.session.activeTurnId).toBeNull();
expect(String(stopEvent.commandId).startsWith("t3-crash-recovery:")).toBe(true);
}
} finally {
await system.dispose();
}
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix(server): reconcile crash-frozen running turns to interrupted on boot (#5)#13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

radroid
merged 1 commit into

from

Jul 25, 2026
 Merged


fix(server): reconcile crash-frozen running turns to interrupted on boot (#5)
#13
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


296 changes: 296 additions & 0 deletions
apps/server/src/orchestration/Layers/CrashRecoveryReconciler.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,296 @@
import {
 CommandId,
 DEFAULT_PROVIDER_INTERACTION_MODE,
 ProjectId,
 ProviderInstanceId,
 ThreadId,
 TurnId,
 type OrchestrationCommand,
 type OrchestrationEvent,
} from "@t3tools/contracts";
import * as NodeServices from "@effect/platform-node/NodeServices";
import * as Effect from "effect/Effect";
import * as Layer from "effect/Layer";
import * as ManagedRuntime from "effect/ManagedRuntime";
import * as Stream from "effect/Stream";
import { describe, expect, it } from "vite-plus/test";

import { OrchestrationCommandReceiptRepositoryLive } from "../../persistence/Layers/OrchestrationCommandReceipts.ts";
import { OrchestrationEventStoreLive } from "../../persistence/Layers/OrchestrationEventStore.ts";
import { ProjectionTurnRepositoryLive } from "../../persistence/Layers/ProjectionTurns.ts";
import { SqlitePersistenceMemory } from "../../persistence/Layers/Sqlite.ts";
import { ProjectionTurnRepository } from "../../persistence/Services/ProjectionTurns.ts";
import * as RepositoryIdentityResolver from "../../project/RepositoryIdentityResolver.ts";
import { ServerConfig } from "../../config.ts";
import { OrchestrationEngineLive } from "./OrchestrationEngine.ts";
import { OrchestrationProjectionPipelineLive } from "./ProjectionPipeline.ts";
import { OrchestrationProjectionSnapshotQueryLive } from "./ProjectionSnapshotQuery.ts";
import { OrchestrationEngineService } from "../Services/OrchestrationEngine.ts";
import { ProjectionSnapshotQuery } from "../Services/ProjectionSnapshotQuery.ts";
import { reconcileInterruptedTurnsOnBoot } from "./CrashRecoveryReconciler.ts";

const MODEL_SELECTION = {
 instanceId: ProviderInstanceId.make("codex"),
 model: "gpt-5-codex",
};

async function createReconcilerSystem() {
 const ServerConfigLayer = ServerConfig.layerTest(process.cwd(), {
 prefix: "t3-crash-recovery-reconciler-test-",
 });
 const orchestrationLayer = Layer.mergeAll(
 OrchestrationEngineLive.pipe(
 Layer.provide(OrchestrationProjectionSnapshotQueryLive),
 Layer.provide(OrchestrationProjectionPipelineLive),
 ),
 OrchestrationProjectionSnapshotQueryLive,
 ProjectionTurnRepositoryLive,
 ).pipe(
 Layer.provide(OrchestrationEventStoreLive),
 Layer.provide(OrchestrationCommandReceiptRepositoryLive),
 Layer.provide(RepositoryIdentityResolver.layer),
 Layer.provide(SqlitePersistenceMemory),
 Layer.provideMerge(ServerConfigLayer),
 Layer.provideMerge(NodeServices.layer),
 );
 const runtime = ManagedRuntime.make(orchestrationLayer);
 const engine = await runtime.runPromise(Effect.service(OrchestrationEngineService));
 const snapshotQuery = await runtime.runPromise(Effect.service(ProjectionSnapshotQuery));
 const turnRepository = await runtime.runPromise(Effect.service(ProjectionTurnRepository));

 return {
 dispatch: (command: OrchestrationCommand) => runtime.runPromise(engine.dispatch(command)),
 readModel: () => runtime.runPromise(snapshotQuery.getSnapshot()),
 reconcile: () => runtime.runPromise(reconcileInterruptedTurnsOnBoot),
 getTurn: (threadId: string, turnId: string) =>
 runtime.runPromise(
 turnRepository.getByTurnId({
 threadId: ThreadId.make(threadId),
 turnId: TurnId.make(turnId),
 }),
 ),
 readEvents: () =>
 runtime.runPromise(
 Stream.runCollect(engine.readEvents(0)).pipe(
 Effect.map((chunk): OrchestrationEvent[] => Array.from(chunk)),
 ),
 ),
 dispose: () => runtime.dispose(),
 };
}

type ReconcilerSystem = Awaited<ReturnType<typeof createReconcilerSystem>>;

async function seedProject(system: ReconcilerSystem, projectId: string) {
 await system.dispatch({
 type: "project.create",
 commandId: CommandId.make(`cmd-project-${projectId}`),
 projectId: ProjectId.make(projectId),
 title: `Project ${projectId}`,
 workspaceRoot: `/tmp/${projectId}`,
 defaultModelSelection: MODEL_SELECTION,
 createdAt: "2026-01-01T00:00:00.000Z",
 });
}

async function seedThread(system: ReconcilerSystem, projectId: string, threadId: string) {
 await system.dispatch({
 type: "thread.create",
 commandId: CommandId.make(`cmd-thread-${threadId}`),
 threadId: ThreadId.make(threadId),
 projectId: ProjectId.make(projectId),
 title: `Thread ${threadId}`,
 modelSelection: MODEL_SELECTION,
 interactionMode: DEFAULT_PROVIDER_INTERACTION_MODE,
 runtimeMode: "full-access",
 branch: null,
 worktreePath: null,
 createdAt: "2026-01-01T00:00:01.000Z",
 });
}

async function setSession(
 system: ReconcilerSystem,
 threadId: string,
 status: "running" | "stopped",
 activeTurnId: string | null,
 updatedAt: string,
) {
 await system.dispatch({
 type: "thread.session.set",
 commandId: CommandId.make(`cmd-session-${threadId}-${status}-${updatedAt}`),
 threadId: ThreadId.make(threadId),
 session: {
 threadId: ThreadId.make(threadId),
 status,
 providerName: "claudeAgent",
 providerInstanceId: ProviderInstanceId.make("codex"),
 runtimeMode: "full-access",
 activeTurnId: activeTurnId === null ? null : TurnId.make(activeTurnId),
 lastError: null,
 updatedAt,
 },
 createdAt: updatedAt,
 });
}

/** Seed a thread frozen mid-turn the way an ungraceful crash leaves it. */
async function seedCrashedThread(
 system: ReconcilerSystem,
 projectId: string,
 threadId: string,
 turnId: string,
) {
 await seedThread(system, projectId, threadId);
 await setSession(system, threadId, "running", turnId, "2026-01-01T00:00:02.000Z");
}

describe("reconcileInterruptedTurnsOnBoot", () => {
 it("leaves a crashed thread with a running turn / active session (precondition)", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 const snapshot = await system.readModel();
 const thread = snapshot.threads.find((entry) => entry.id === "thread-1");
 expect(thread?.latestTurn?.state).toBe("running");
 expect(thread?.session?.status).toBe("running");
 expect(thread?.session?.activeTurnId).toBe("turn-1");

 const turn = await system.getTurn("thread-1", "turn-1");
 expect(turn._tag).toBe("Some");
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("running");
 expect(turn.value.completedAt).toBeNull();
 }
 } finally {
 await system.dispose();
 }
 });

 it("settles a crashed thread to interrupted and stops the session", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 const result = await system.reconcile();
 expect(result.reconciledCount).toBe(1);

 const snapshot = await system.readModel();
 const thread = snapshot.threads.find((entry) => entry.id === "thread-1");
 expect(thread?.session?.status).toBe("stopped");
 expect(thread?.session?.activeTurnId).toBeNull();

 const turn = await system.getTurn("thread-1", "turn-1");
 expect(turn._tag).toBe("Some");
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("interrupted");
 expect(turn.value.completedAt).not.toBeNull();
 }
 } finally {
 await system.dispose();
 }
 });

 it("is idempotent: a second boot reconciles nothing and leaves projections unchanged", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 const first = await system.reconcile();
 expect(first.reconciledCount).toBe(1);

 const eventsAfterFirst = await system.readEvents();
 const snapshotAfterFirst = await system.readModel();

 const second = await system.reconcile();
 expect(second.reconciledCount).toBe(0);

 const eventsAfterSecond = await system.readEvents();
 expect(eventsAfterSecond.length).toBe(eventsAfterFirst.length);

 const snapshotAfterSecond = await system.readModel();
 const threadFirst = snapshotAfterFirst.threads.find((entry) => entry.id === "thread-1");
 const threadSecond = snapshotAfterSecond.threads.find((entry) => entry.id === "thread-1");
 expect(threadSecond?.session?.status).toBe(threadFirst?.session?.status);
 expect(threadSecond?.session?.activeTurnId).toBe(threadFirst?.session?.activeTurnId ?? null);

 const turn = await system.getTurn("thread-1", "turn-1");
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("interrupted");
 }
 } finally {
 await system.dispose();
 }
 });

 it("only reconciles crashed threads, not already-settled ones (multi-thread selectivity)", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-a", "turn-a");
 await seedCrashedThread(system, "project-1", "thread-b", "turn-b");

 // An already-settled thread: it ran a turn and the session was cleanly stopped.
 await seedThread(system, "project-1", "thread-settled");
 await setSession(system, "thread-settled", "running", "turn-s", "2026-01-01T00:00:03.000Z");
 await setSession(system, "thread-settled", "stopped", null, "2026-01-01T00:00:04.000Z");

 const settledTurnBefore = await system.getTurn("thread-settled", "turn-s");
 expect(settledTurnBefore._tag).toBe("Some");

 const result = await system.reconcile();
 expect(result.reconciledCount).toBe(2);

 const crashedTurns: ReadonlyArray<readonly [string, string]> = [
 ["thread-a", "turn-a"],
 ["thread-b", "turn-b"],
 ];
 for (const [threadId, turnId] of crashedTurns) {
 const turn = await system.getTurn(threadId, turnId);
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("interrupted");
 expect(turn.value.completedAt).not.toBeNull();
 }
 }

 // The already-settled thread must be untouched (same completedAt).
 const settledTurnAfter = await system.getTurn("thread-settled", "turn-s");
 if (settledTurnBefore._tag === "Some" && settledTurnAfter._tag === "Some") {
 expect(settledTurnAfter.value.state).toBe("interrupted");
 expect(settledTurnAfter.value.completedAt).toBe(settledTurnBefore.value.completedAt);
 }
 } finally {
 await system.dispose();
 }
 });

 it("appends a durable thread.session-set event that survives a projection rebuild", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 await system.reconcile();

 const events = await system.readEvents();
 const stopEvents = events.filter(
 (event): event is Extract<OrchestrationEvent, { type: "thread.session-set" }> =>
 event.type === "thread.session-set" &&
 event.payload.threadId === "thread-1" &&
 event.payload.session.status === "stopped",
 );
 expect(stopEvents.length).toBe(1);
 const stopEvent = stopEvents[0];
 if (stopEvent) {
 expect(stopEvent.payload.session.activeTurnId).toBeNull();
 expect(String(stopEvent.commandId).startsWith("t3-crash-recovery:")).toBe(true);
 }
 } finally {
 await system.dispose();
 }
 });
});
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(server): reconcile crash-frozen running turns to interrupted on boot (#5)#13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

radroid
merged 1 commit into

from

Jul 25, 2026
 Merged


fix(server): reconcile crash-frozen running turns to interrupted on boot (#5)
#13
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


296 changes: 296 additions & 0 deletions
apps/server/src/orchestration/Layers/CrashRecoveryReconciler.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,296 @@
import {
 CommandId,
 DEFAULT_PROVIDER_INTERACTION_MODE,
 ProjectId,
 ProviderInstanceId,
 ThreadId,
 TurnId,
 type OrchestrationCommand,
 type OrchestrationEvent,
} from "@t3tools/contracts";
import * as NodeServices from "@effect/platform-node/NodeServices";
import * as Effect from "effect/Effect";
import * as Layer from "effect/Layer";
import * as ManagedRuntime from "effect/ManagedRuntime";
import * as Stream from "effect/Stream";
import { describe, expect, it } from "vite-plus/test";

import { OrchestrationCommandReceiptRepositoryLive } from "../../persistence/Layers/OrchestrationCommandReceipts.ts";
import { OrchestrationEventStoreLive } from "../../persistence/Layers/OrchestrationEventStore.ts";
import { ProjectionTurnRepositoryLive } from "../../persistence/Layers/ProjectionTurns.ts";
import { SqlitePersistenceMemory } from "../../persistence/Layers/Sqlite.ts";
import { ProjectionTurnRepository } from "../../persistence/Services/ProjectionTurns.ts";
import * as RepositoryIdentityResolver from "../../project/RepositoryIdentityResolver.ts";
import { ServerConfig } from "../../config.ts";
import { OrchestrationEngineLive } from "./OrchestrationEngine.ts";
import { OrchestrationProjectionPipelineLive } from "./ProjectionPipeline.ts";
import { OrchestrationProjectionSnapshotQueryLive } from "./ProjectionSnapshotQuery.ts";
import { OrchestrationEngineService } from "../Services/OrchestrationEngine.ts";
import { ProjectionSnapshotQuery } from "../Services/ProjectionSnapshotQuery.ts";
import { reconcileInterruptedTurnsOnBoot } from "./CrashRecoveryReconciler.ts";

const MODEL_SELECTION = {
 instanceId: ProviderInstanceId.make("codex"),
 model: "gpt-5-codex",
};

async function createReconcilerSystem() {
 const ServerConfigLayer = ServerConfig.layerTest(process.cwd(), {
 prefix: "t3-crash-recovery-reconciler-test-",
 });
 const orchestrationLayer = Layer.mergeAll(
 OrchestrationEngineLive.pipe(
 Layer.provide(OrchestrationProjectionSnapshotQueryLive),
 Layer.provide(OrchestrationProjectionPipelineLive),
 ),
 OrchestrationProjectionSnapshotQueryLive,
 ProjectionTurnRepositoryLive,
 ).pipe(
 Layer.provide(OrchestrationEventStoreLive),
 Layer.provide(OrchestrationCommandReceiptRepositoryLive),
 Layer.provide(RepositoryIdentityResolver.layer),
 Layer.provide(SqlitePersistenceMemory),
 Layer.provideMerge(ServerConfigLayer),
 Layer.provideMerge(NodeServices.layer),
 );
 const runtime = ManagedRuntime.make(orchestrationLayer);
 const engine = await runtime.runPromise(Effect.service(OrchestrationEngineService));
 const snapshotQuery = await runtime.runPromise(Effect.service(ProjectionSnapshotQuery));
 const turnRepository = await runtime.runPromise(Effect.service(ProjectionTurnRepository));

 return {
 dispatch: (command: OrchestrationCommand) => runtime.runPromise(engine.dispatch(command)),
 readModel: () => runtime.runPromise(snapshotQuery.getSnapshot()),
 reconcile: () => runtime.runPromise(reconcileInterruptedTurnsOnBoot),
 getTurn: (threadId: string, turnId: string) =>
 runtime.runPromise(
 turnRepository.getByTurnId({
 threadId: ThreadId.make(threadId),
 turnId: TurnId.make(turnId),
 }),
 ),
 readEvents: () =>
 runtime.runPromise(
 Stream.runCollect(engine.readEvents(0)).pipe(
 Effect.map((chunk): OrchestrationEvent[] => Array.from(chunk)),
 ),
 ),
 dispose: () => runtime.dispose(),
 };
}

type ReconcilerSystem = Awaited<ReturnType<typeof createReconcilerSystem>>;

async function seedProject(system: ReconcilerSystem, projectId: string) {
 await system.dispatch({
 type: "project.create",
 commandId: CommandId.make(`cmd-project-${projectId}`),
 projectId: ProjectId.make(projectId),
 title: `Project ${projectId}`,
 workspaceRoot: `/tmp/${projectId}`,
 defaultModelSelection: MODEL_SELECTION,
 createdAt: "2026-01-01T00:00:00.000Z",
 });
}

async function seedThread(system: ReconcilerSystem, projectId: string, threadId: string) {
 await system.dispatch({
 type: "thread.create",
 commandId: CommandId.make(`cmd-thread-${threadId}`),
 threadId: ThreadId.make(threadId),
 projectId: ProjectId.make(projectId),
 title: `Thread ${threadId}`,
 modelSelection: MODEL_SELECTION,
 interactionMode: DEFAULT_PROVIDER_INTERACTION_MODE,
 runtimeMode: "full-access",
 branch: null,
 worktreePath: null,
 createdAt: "2026-01-01T00:00:01.000Z",
 });
}

async function setSession(
 system: ReconcilerSystem,
 threadId: string,
 status: "running" | "stopped",
 activeTurnId: string | null,
 updatedAt: string,
) {
 await system.dispatch({
 type: "thread.session.set",
 commandId: CommandId.make(`cmd-session-${threadId}-${status}-${updatedAt}`),
 threadId: ThreadId.make(threadId),
 session: {
 threadId: ThreadId.make(threadId),
 status,
 providerName: "claudeAgent",
 providerInstanceId: ProviderInstanceId.make("codex"),
 runtimeMode: "full-access",
 activeTurnId: activeTurnId === null ? null : TurnId.make(activeTurnId),
 lastError: null,
 updatedAt,
 },
 createdAt: updatedAt,
 });
}

/** Seed a thread frozen mid-turn the way an ungraceful crash leaves it. */
async function seedCrashedThread(
 system: ReconcilerSystem,
 projectId: string,
 threadId: string,
 turnId: string,
) {
 await seedThread(system, projectId, threadId);
 await setSession(system, threadId, "running", turnId, "2026-01-01T00:00:02.000Z");
}

describe("reconcileInterruptedTurnsOnBoot", () => {
 it("leaves a crashed thread with a running turn / active session (precondition)", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 const snapshot = await system.readModel();
 const thread = snapshot.threads.find((entry) => entry.id === "thread-1");
 expect(thread?.latestTurn?.state).toBe("running");
 expect(thread?.session?.status).toBe("running");
 expect(thread?.session?.activeTurnId).toBe("turn-1");

 const turn = await system.getTurn("thread-1", "turn-1");
 expect(turn._tag).toBe("Some");
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("running");
 expect(turn.value.completedAt).toBeNull();
 }
 } finally {
 await system.dispose();
 }
 });

 it("settles a crashed thread to interrupted and stops the session", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 const result = await system.reconcile();
 expect(result.reconciledCount).toBe(1);

 const snapshot = await system.readModel();
 const thread = snapshot.threads.find((entry) => entry.id === "thread-1");
 expect(thread?.session?.status).toBe("stopped");
 expect(thread?.session?.activeTurnId).toBeNull();

 const turn = await system.getTurn("thread-1", "turn-1");
 expect(turn._tag).toBe("Some");
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("interrupted");
 expect(turn.value.completedAt).not.toBeNull();
 }
 } finally {
 await system.dispose();
 }
 });

 it("is idempotent: a second boot reconciles nothing and leaves projections unchanged", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 const first = await system.reconcile();
 expect(first.reconciledCount).toBe(1);

 const eventsAfterFirst = await system.readEvents();
 const snapshotAfterFirst = await system.readModel();

 const second = await system.reconcile();
 expect(second.reconciledCount).toBe(0);

 const eventsAfterSecond = await system.readEvents();
 expect(eventsAfterSecond.length).toBe(eventsAfterFirst.length);

 const snapshotAfterSecond = await system.readModel();
 const threadFirst = snapshotAfterFirst.threads.find((entry) => entry.id === "thread-1");
 const threadSecond = snapshotAfterSecond.threads.find((entry) => entry.id === "thread-1");
 expect(threadSecond?.session?.status).toBe(threadFirst?.session?.status);
 expect(threadSecond?.session?.activeTurnId).toBe(threadFirst?.session?.activeTurnId ?? null);

 const turn = await system.getTurn("thread-1", "turn-1");
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("interrupted");
 }
 } finally {
 await system.dispose();
 }
 });

 it("only reconciles crashed threads, not already-settled ones (multi-thread selectivity)", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-a", "turn-a");
 await seedCrashedThread(system, "project-1", "thread-b", "turn-b");

 // An already-settled thread: it ran a turn and the session was cleanly stopped.
 await seedThread(system, "project-1", "thread-settled");
 await setSession(system, "thread-settled", "running", "turn-s", "2026-01-01T00:00:03.000Z");
 await setSession(system, "thread-settled", "stopped", null, "2026-01-01T00:00:04.000Z");

 const settledTurnBefore = await system.getTurn("thread-settled", "turn-s");
 expect(settledTurnBefore._tag).toBe("Some");

 const result = await system.reconcile();
 expect(result.reconciledCount).toBe(2);

 const crashedTurns: ReadonlyArray<readonly [string, string]> = [
 ["thread-a", "turn-a"],
 ["thread-b", "turn-b"],
 ];
 for (const [threadId, turnId] of crashedTurns) {
 const turn = await system.getTurn(threadId, turnId);
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("interrupted");
 expect(turn.value.completedAt).not.toBeNull();
 }
 }

 // The already-settled thread must be untouched (same completedAt).
 const settledTurnAfter = await system.getTurn("thread-settled", "turn-s");
 if (settledTurnBefore._tag === "Some" && settledTurnAfter._tag === "Some") {
 expect(settledTurnAfter.value.state).toBe("interrupted");
 expect(settledTurnAfter.value.completedAt).toBe(settledTurnBefore.value.completedAt);
 }
 } finally {
 await system.dispose();
 }
 });

 it("appends a durable thread.session-set event that survives a projection rebuild", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 await system.reconcile();

 const events = await system.readEvents();
 const stopEvents = events.filter(
 (event): event is Extract<OrchestrationEvent, { type: "thread.session-set" }> =>
 event.type === "thread.session-set" &&
 event.payload.threadId === "thread-1" &&
 event.payload.session.status === "stopped",
 );
 expect(stopEvents.length).toBe(1);
 const stopEvent = stopEvents[0];
 if (stopEvent) {
 expect(stopEvent.payload.session.activeTurnId).toBeNull();
 expect(String(stopEvent.commandId).startsWith("t3-crash-recovery:")).toBe(true);
 }
 } finally {
 await system.dispose();
 }
 });
});
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(server): reconcile crash-frozen running turns to interrupted on boot (#5)#13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

radroid
merged 1 commit into

from

Jul 25, 2026
 Merged


fix(server): reconcile crash-frozen running turns to interrupted on boot (#5)
#13
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


296 changes: 296 additions & 0 deletions
apps/server/src/orchestration/Layers/CrashRecoveryReconciler.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,296 @@
import {
 CommandId,
 DEFAULT_PROVIDER_INTERACTION_MODE,
 ProjectId,
 ProviderInstanceId,
 ThreadId,
 TurnId,
 type OrchestrationCommand,
 type OrchestrationEvent,
} from "@t3tools/contracts";
import * as NodeServices from "@effect/platform-node/NodeServices";
import * as Effect from "effect/Effect";
import * as Layer from "effect/Layer";
import * as ManagedRuntime from "effect/ManagedRuntime";
import * as Stream from "effect/Stream";
import { describe, expect, it } from "vite-plus/test";

import { OrchestrationCommandReceiptRepositoryLive } from "../../persistence/Layers/OrchestrationCommandReceipts.ts";
import { OrchestrationEventStoreLive } from "../../persistence/Layers/OrchestrationEventStore.ts";
import { ProjectionTurnRepositoryLive } from "../../persistence/Layers/ProjectionTurns.ts";
import { SqlitePersistenceMemory } from "../../persistence/Layers/Sqlite.ts";
import { ProjectionTurnRepository } from "../../persistence/Services/ProjectionTurns.ts";
import * as RepositoryIdentityResolver from "../../project/RepositoryIdentityResolver.ts";
import { ServerConfig } from "../../config.ts";
import { OrchestrationEngineLive } from "./OrchestrationEngine.ts";
import { OrchestrationProjectionPipelineLive } from "./ProjectionPipeline.ts";
import { OrchestrationProjectionSnapshotQueryLive } from "./ProjectionSnapshotQuery.ts";
import { OrchestrationEngineService } from "../Services/OrchestrationEngine.ts";
import { ProjectionSnapshotQuery } from "../Services/ProjectionSnapshotQuery.ts";
import { reconcileInterruptedTurnsOnBoot } from "./CrashRecoveryReconciler.ts";

const MODEL_SELECTION = {
 instanceId: ProviderInstanceId.make("codex"),
 model: "gpt-5-codex",
};

async function createReconcilerSystem() {
 const ServerConfigLayer = ServerConfig.layerTest(process.cwd(), {
 prefix: "t3-crash-recovery-reconciler-test-",
 });
 const orchestrationLayer = Layer.mergeAll(
 OrchestrationEngineLive.pipe(
 Layer.provide(OrchestrationProjectionSnapshotQueryLive),
 Layer.provide(OrchestrationProjectionPipelineLive),
 ),
 OrchestrationProjectionSnapshotQueryLive,
 ProjectionTurnRepositoryLive,
 ).pipe(
 Layer.provide(OrchestrationEventStoreLive),
 Layer.provide(OrchestrationCommandReceiptRepositoryLive),
 Layer.provide(RepositoryIdentityResolver.layer),
 Layer.provide(SqlitePersistenceMemory),
 Layer.provideMerge(ServerConfigLayer),
 Layer.provideMerge(NodeServices.layer),
 );
 const runtime = ManagedRuntime.make(orchestrationLayer);
 const engine = await runtime.runPromise(Effect.service(OrchestrationEngineService));
 const snapshotQuery = await runtime.runPromise(Effect.service(ProjectionSnapshotQuery));
 const turnRepository = await runtime.runPromise(Effect.service(ProjectionTurnRepository));

 return {
 dispatch: (command: OrchestrationCommand) => runtime.runPromise(engine.dispatch(command)),
 readModel: () => runtime.runPromise(snapshotQuery.getSnapshot()),
 reconcile: () => runtime.runPromise(reconcileInterruptedTurnsOnBoot),
 getTurn: (threadId: string, turnId: string) =>
 runtime.runPromise(
 turnRepository.getByTurnId({
 threadId: ThreadId.make(threadId),
 turnId: TurnId.make(turnId),
 }),
 ),
 readEvents: () =>
 runtime.runPromise(
 Stream.runCollect(engine.readEvents(0)).pipe(
 Effect.map((chunk): OrchestrationEvent[] => Array.from(chunk)),
 ),
 ),
 dispose: () => runtime.dispose(),
 };
}

type ReconcilerSystem = Awaited<ReturnType<typeof createReconcilerSystem>>;

async function seedProject(system: ReconcilerSystem, projectId: string) {
 await system.dispatch({
 type: "project.create",
 commandId: CommandId.make(`cmd-project-${projectId}`),
 projectId: ProjectId.make(projectId),
 title: `Project ${projectId}`,
 workspaceRoot: `/tmp/${projectId}`,
 defaultModelSelection: MODEL_SELECTION,
 createdAt: "2026-01-01T00:00:00.000Z",
 });
}

async function seedThread(system: ReconcilerSystem, projectId: string, threadId: string) {
 await system.dispatch({
 type: "thread.create",
 commandId: CommandId.make(`cmd-thread-${threadId}`),
 threadId: ThreadId.make(threadId),
 projectId: ProjectId.make(projectId),
 title: `Thread ${threadId}`,
 modelSelection: MODEL_SELECTION,
 interactionMode: DEFAULT_PROVIDER_INTERACTION_MODE,
 runtimeMode: "full-access",
 branch: null,
 worktreePath: null,
 createdAt: "2026-01-01T00:00:01.000Z",
 });
}

async function setSession(
 system: ReconcilerSystem,
 threadId: string,
 status: "running" | "stopped",
 activeTurnId: string | null,
 updatedAt: string,
) {
 await system.dispatch({
 type: "thread.session.set",
 commandId: CommandId.make(`cmd-session-${threadId}-${status}-${updatedAt}`),
 threadId: ThreadId.make(threadId),
 session: {
 threadId: ThreadId.make(threadId),
 status,
 providerName: "claudeAgent",
 providerInstanceId: ProviderInstanceId.make("codex"),
 runtimeMode: "full-access",
 activeTurnId: activeTurnId === null ? null : TurnId.make(activeTurnId),
 lastError: null,
 updatedAt,
 },
 createdAt: updatedAt,
 });
}

/** Seed a thread frozen mid-turn the way an ungraceful crash leaves it. */
async function seedCrashedThread(
 system: ReconcilerSystem,
 projectId: string,
 threadId: string,
 turnId: string,
) {
 await seedThread(system, projectId, threadId);
 await setSession(system, threadId, "running", turnId, "2026-01-01T00:00:02.000Z");
}

describe("reconcileInterruptedTurnsOnBoot", () => {
 it("leaves a crashed thread with a running turn / active session (precondition)", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 const snapshot = await system.readModel();
 const thread = snapshot.threads.find((entry) => entry.id === "thread-1");
 expect(thread?.latestTurn?.state).toBe("running");
 expect(thread?.session?.status).toBe("running");
 expect(thread?.session?.activeTurnId).toBe("turn-1");

 const turn = await system.getTurn("thread-1", "turn-1");
 expect(turn._tag).toBe("Some");
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("running");
 expect(turn.value.completedAt).toBeNull();
 }
 } finally {
 await system.dispose();
 }
 });

 it("settles a crashed thread to interrupted and stops the session", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 const result = await system.reconcile();
 expect(result.reconciledCount).toBe(1);

 const snapshot = await system.readModel();
 const thread = snapshot.threads.find((entry) => entry.id === "thread-1");
 expect(thread?.session?.status).toBe("stopped");
 expect(thread?.session?.activeTurnId).toBeNull();

 const turn = await system.getTurn("thread-1", "turn-1");
 expect(turn._tag).toBe("Some");
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("interrupted");
 expect(turn.value.completedAt).not.toBeNull();
 }
 } finally {
 await system.dispose();
 }
 });

 it("is idempotent: a second boot reconciles nothing and leaves projections unchanged", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 const first = await system.reconcile();
 expect(first.reconciledCount).toBe(1);

 const eventsAfterFirst = await system.readEvents();
 const snapshotAfterFirst = await system.readModel();

 const second = await system.reconcile();
 expect(second.reconciledCount).toBe(0);

 const eventsAfterSecond = await system.readEvents();
 expect(eventsAfterSecond.length).toBe(eventsAfterFirst.length);

 const snapshotAfterSecond = await system.readModel();
 const threadFirst = snapshotAfterFirst.threads.find((entry) => entry.id === "thread-1");
 const threadSecond = snapshotAfterSecond.threads.find((entry) => entry.id === "thread-1");
 expect(threadSecond?.session?.status).toBe(threadFirst?.session?.status);
 expect(threadSecond?.session?.activeTurnId).toBe(threadFirst?.session?.activeTurnId ?? null);

 const turn = await system.getTurn("thread-1", "turn-1");
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("interrupted");
 }
 } finally {
 await system.dispose();
 }
 });

 it("only reconciles crashed threads, not already-settled ones (multi-thread selectivity)", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-a", "turn-a");
 await seedCrashedThread(system, "project-1", "thread-b", "turn-b");

 // An already-settled thread: it ran a turn and the session was cleanly stopped.
 await seedThread(system, "project-1", "thread-settled");
 await setSession(system, "thread-settled", "running", "turn-s", "2026-01-01T00:00:03.000Z");
 await setSession(system, "thread-settled", "stopped", null, "2026-01-01T00:00:04.000Z");

 const settledTurnBefore = await system.getTurn("thread-settled", "turn-s");
 expect(settledTurnBefore._tag).toBe("Some");

 const result = await system.reconcile();
 expect(result.reconciledCount).toBe(2);

 const crashedTurns: ReadonlyArray<readonly [string, string]> = [
 ["thread-a", "turn-a"],
 ["thread-b", "turn-b"],
 ];
 for (const [threadId, turnId] of crashedTurns) {
 const turn = await system.getTurn(threadId, turnId);
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("interrupted");
 expect(turn.value.completedAt).not.toBeNull();
 }
 }

 // The already-settled thread must be untouched (same completedAt).
 const settledTurnAfter = await system.getTurn("thread-settled", "turn-s");
 if (settledTurnBefore._tag === "Some" && settledTurnAfter._tag === "Some") {
 expect(settledTurnAfter.value.state).toBe("interrupted");
 expect(settledTurnAfter.value.completedAt).toBe(settledTurnBefore.value.completedAt);
 }
 } finally {
 await system.dispose();
 }
 });

 it("appends a durable thread.session-set event that survives a projection rebuild", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 await system.reconcile();

 const events = await system.readEvents();
 const stopEvents = events.filter(
 (event): event is Extract<OrchestrationEvent, { type: "thread.session-set" }> =>
 event.type === "thread.session-set" &&
 event.payload.threadId === "thread-1" &&
 event.payload.session.status === "stopped",
 );
 expect(stopEvents.length).toBe(1);
 const stopEvent = stopEvents[0];
 if (stopEvent) {
 expect(stopEvent.payload.session.activeTurnId).toBeNull();
 expect(String(stopEvent.commandId).startsWith("t3-crash-recovery:")).toBe(true);
 }
 } finally {
 await system.dispose();
 }
 });
});
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix(server): reconcile crash-frozen running turns to interrupted on boot (#5)#13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

radroid
merged 1 commit into

from

Jul 25, 2026
 Merged


fix(server): reconcile crash-frozen running turns to interrupted on boot (#5)
#13
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


296 changes: 296 additions & 0 deletions
apps/server/src/orchestration/Layers/CrashRecoveryReconciler.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,296 @@
import {
 CommandId,
 DEFAULT_PROVIDER_INTERACTION_MODE,
 ProjectId,
 ProviderInstanceId,
 ThreadId,
 TurnId,
 type OrchestrationCommand,
 type OrchestrationEvent,
} from "@t3tools/contracts";
import * as NodeServices from "@effect/platform-node/NodeServices";
import * as Effect from "effect/Effect";
import * as Layer from "effect/Layer";
import * as ManagedRuntime from "effect/ManagedRuntime";
import * as Stream from "effect/Stream";
import { describe, expect, it } from "vite-plus/test";

import { OrchestrationCommandReceiptRepositoryLive } from "../../persistence/Layers/OrchestrationCommandReceipts.ts";
import { OrchestrationEventStoreLive } from "../../persistence/Layers/OrchestrationEventStore.ts";
import { ProjectionTurnRepositoryLive } from "../../persistence/Layers/ProjectionTurns.ts";
import { SqlitePersistenceMemory } from "../../persistence/Layers/Sqlite.ts";
import { ProjectionTurnRepository } from "../../persistence/Services/ProjectionTurns.ts";
import * as RepositoryIdentityResolver from "../../project/RepositoryIdentityResolver.ts";
import { ServerConfig } from "../../config.ts";
import { OrchestrationEngineLive } from "./OrchestrationEngine.ts";
import { OrchestrationProjectionPipelineLive } from "./ProjectionPipeline.ts";
import { OrchestrationProjectionSnapshotQueryLive } from "./ProjectionSnapshotQuery.ts";
import { OrchestrationEngineService } from "../Services/OrchestrationEngine.ts";
import { ProjectionSnapshotQuery } from "../Services/ProjectionSnapshotQuery.ts";
import { reconcileInterruptedTurnsOnBoot } from "./CrashRecoveryReconciler.ts";

const MODEL_SELECTION = {
 instanceId: ProviderInstanceId.make("codex"),
 model: "gpt-5-codex",
};

async function createReconcilerSystem() {
 const ServerConfigLayer = ServerConfig.layerTest(process.cwd(), {
 prefix: "t3-crash-recovery-reconciler-test-",
 });
 const orchestrationLayer = Layer.mergeAll(
 OrchestrationEngineLive.pipe(
 Layer.provide(OrchestrationProjectionSnapshotQueryLive),
 Layer.provide(OrchestrationProjectionPipelineLive),
 ),
 OrchestrationProjectionSnapshotQueryLive,
 ProjectionTurnRepositoryLive,
 ).pipe(
 Layer.provide(OrchestrationEventStoreLive),
 Layer.provide(OrchestrationCommandReceiptRepositoryLive),
 Layer.provide(RepositoryIdentityResolver.layer),
 Layer.provide(SqlitePersistenceMemory),
 Layer.provideMerge(ServerConfigLayer),
 Layer.provideMerge(NodeServices.layer),
 );
 const runtime = ManagedRuntime.make(orchestrationLayer);
 const engine = await runtime.runPromise(Effect.service(OrchestrationEngineService));
 const snapshotQuery = await runtime.runPromise(Effect.service(ProjectionSnapshotQuery));
 const turnRepository = await runtime.runPromise(Effect.service(ProjectionTurnRepository));

 return {
 dispatch: (command: OrchestrationCommand) => runtime.runPromise(engine.dispatch(command)),
 readModel: () => runtime.runPromise(snapshotQuery.getSnapshot()),
 reconcile: () => runtime.runPromise(reconcileInterruptedTurnsOnBoot),
 getTurn: (threadId: string, turnId: string) =>
 runtime.runPromise(
 turnRepository.getByTurnId({
 threadId: ThreadId.make(threadId),
 turnId: TurnId.make(turnId),
 }),
 ),
 readEvents: () =>
 runtime.runPromise(
 Stream.runCollect(engine.readEvents(0)).pipe(
 Effect.map((chunk): OrchestrationEvent[] => Array.from(chunk)),
 ),
 ),
 dispose: () => runtime.dispose(),
 };
}

type ReconcilerSystem = Awaited<ReturnType<typeof createReconcilerSystem>>;

async function seedProject(system: ReconcilerSystem, projectId: string) {
 await system.dispatch({
 type: "project.create",
 commandId: CommandId.make(`cmd-project-${projectId}`),
 projectId: ProjectId.make(projectId),
 title: `Project ${projectId}`,
 workspaceRoot: `/tmp/${projectId}`,
 defaultModelSelection: MODEL_SELECTION,
 createdAt: "2026-01-01T00:00:00.000Z",
 });
}

async function seedThread(system: ReconcilerSystem, projectId: string, threadId: string) {
 await system.dispatch({
 type: "thread.create",
 commandId: CommandId.make(`cmd-thread-${threadId}`),
 threadId: ThreadId.make(threadId),
 projectId: ProjectId.make(projectId),
 title: `Thread ${threadId}`,
 modelSelection: MODEL_SELECTION,
 interactionMode: DEFAULT_PROVIDER_INTERACTION_MODE,
 runtimeMode: "full-access",
 branch: null,
 worktreePath: null,
 createdAt: "2026-01-01T00:00:01.000Z",
 });
}

async function setSession(
 system: ReconcilerSystem,
 threadId: string,
 status: "running" | "stopped",
 activeTurnId: string | null,
 updatedAt: string,
) {
 await system.dispatch({
 type: "thread.session.set",
 commandId: CommandId.make(`cmd-session-${threadId}-${status}-${updatedAt}`),
 threadId: ThreadId.make(threadId),
 session: {
 threadId: ThreadId.make(threadId),
 status,
 providerName: "claudeAgent",
 providerInstanceId: ProviderInstanceId.make("codex"),
 runtimeMode: "full-access",
 activeTurnId: activeTurnId === null ? null : TurnId.make(activeTurnId),
 lastError: null,
 updatedAt,
 },
 createdAt: updatedAt,
 });
}

/** Seed a thread frozen mid-turn the way an ungraceful crash leaves it. */
async function seedCrashedThread(
 system: ReconcilerSystem,
 projectId: string,
 threadId: string,
 turnId: string,
) {
 await seedThread(system, projectId, threadId);
 await setSession(system, threadId, "running", turnId, "2026-01-01T00:00:02.000Z");
}

describe("reconcileInterruptedTurnsOnBoot", () => {
 it("leaves a crashed thread with a running turn / active session (precondition)", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 const snapshot = await system.readModel();
 const thread = snapshot.threads.find((entry) => entry.id === "thread-1");
 expect(thread?.latestTurn?.state).toBe("running");
 expect(thread?.session?.status).toBe("running");
 expect(thread?.session?.activeTurnId).toBe("turn-1");

 const turn = await system.getTurn("thread-1", "turn-1");
 expect(turn._tag).toBe("Some");
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("running");
 expect(turn.value.completedAt).toBeNull();
 }
 } finally {
 await system.dispose();
 }
 });

 it("settles a crashed thread to interrupted and stops the session", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 const result = await system.reconcile();
 expect(result.reconciledCount).toBe(1);

 const snapshot = await system.readModel();
 const thread = snapshot.threads.find((entry) => entry.id === "thread-1");
 expect(thread?.session?.status).toBe("stopped");
 expect(thread?.session?.activeTurnId).toBeNull();

 const turn = await system.getTurn("thread-1", "turn-1");
 expect(turn._tag).toBe("Some");
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("interrupted");
 expect(turn.value.completedAt).not.toBeNull();
 }
 } finally {
 await system.dispose();
 }
 });

 it("is idempotent: a second boot reconciles nothing and leaves projections unchanged", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 const first = await system.reconcile();
 expect(first.reconciledCount).toBe(1);

 const eventsAfterFirst = await system.readEvents();
 const snapshotAfterFirst = await system.readModel();

 const second = await system.reconcile();
 expect(second.reconciledCount).toBe(0);

 const eventsAfterSecond = await system.readEvents();
 expect(eventsAfterSecond.length).toBe(eventsAfterFirst.length);

 const snapshotAfterSecond = await system.readModel();
 const threadFirst = snapshotAfterFirst.threads.find((entry) => entry.id === "thread-1");
 const threadSecond = snapshotAfterSecond.threads.find((entry) => entry.id === "thread-1");
 expect(threadSecond?.session?.status).toBe(threadFirst?.session?.status);
 expect(threadSecond?.session?.activeTurnId).toBe(threadFirst?.session?.activeTurnId ?? null);

 const turn = await system.getTurn("thread-1", "turn-1");
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("interrupted");
 }
 } finally {
 await system.dispose();
 }
 });

 it("only reconciles crashed threads, not already-settled ones (multi-thread selectivity)", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-a", "turn-a");
 await seedCrashedThread(system, "project-1", "thread-b", "turn-b");

 // An already-settled thread: it ran a turn and the session was cleanly stopped.
 await seedThread(system, "project-1", "thread-settled");
 await setSession(system, "thread-settled", "running", "turn-s", "2026-01-01T00:00:03.000Z");
 await setSession(system, "thread-settled", "stopped", null, "2026-01-01T00:00:04.000Z");

 const settledTurnBefore = await system.getTurn("thread-settled", "turn-s");
 expect(settledTurnBefore._tag).toBe("Some");

 const result = await system.reconcile();
 expect(result.reconciledCount).toBe(2);

 const crashedTurns: ReadonlyArray<readonly [string, string]> = [
 ["thread-a", "turn-a"],
 ["thread-b", "turn-b"],
 ];
 for (const [threadId, turnId] of crashedTurns) {
 const turn = await system.getTurn(threadId, turnId);
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("interrupted");
 expect(turn.value.completedAt).not.toBeNull();
 }
 }

 // The already-settled thread must be untouched (same completedAt).
 const settledTurnAfter = await system.getTurn("thread-settled", "turn-s");
 if (settledTurnBefore._tag === "Some" && settledTurnAfter._tag === "Some") {
 expect(settledTurnAfter.value.state).toBe("interrupted");
 expect(settledTurnAfter.value.completedAt).toBe(settledTurnBefore.value.completedAt);
 }
 } finally {
 await system.dispose();
 }
 });

 it("appends a durable thread.session-set event that survives a projection rebuild", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 await system.reconcile();

 const events = await system.readEvents();
 const stopEvents = events.filter(
 (event): event is Extract<OrchestrationEvent, { type: "thread.session-set" }> =>
 event.type === "thread.session-set" &&
 event.payload.threadId === "thread-1" &&
 event.payload.session.status === "stopped",
 );
 expect(stopEvents.length).toBe(1);
 const stopEvent = stopEvents[0];
 if (stopEvent) {
 expect(stopEvent.payload.session.activeTurnId).toBeNull();
 expect(String(stopEvent.commandId).startsWith("t3-crash-recovery:")).toBe(true);
 }
 } finally {
 await system.dispose();
 }
 });
});
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(server): reconcile crash-frozen running turns to interrupted on boot (#5)#13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

radroid
merged 1 commit into

from

Jul 25, 2026
 Merged


fix(server): reconcile crash-frozen running turns to interrupted on boot (#5)
#13
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


296 changes: 296 additions & 0 deletions
apps/server/src/orchestration/Layers/CrashRecoveryReconciler.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,296 @@
import {
 CommandId,
 DEFAULT_PROVIDER_INTERACTION_MODE,
 ProjectId,
 ProviderInstanceId,
 ThreadId,
 TurnId,
 type OrchestrationCommand,
 type OrchestrationEvent,
} from "@t3tools/contracts";
import * as NodeServices from "@effect/platform-node/NodeServices";
import * as Effect from "effect/Effect";
import * as Layer from "effect/Layer";
import * as ManagedRuntime from "effect/ManagedRuntime";
import * as Stream from "effect/Stream";
import { describe, expect, it } from "vite-plus/test";

import { OrchestrationCommandReceiptRepositoryLive } from "../../persistence/Layers/OrchestrationCommandReceipts.ts";
import { OrchestrationEventStoreLive } from "../../persistence/Layers/OrchestrationEventStore.ts";
import { ProjectionTurnRepositoryLive } from "../../persistence/Layers/ProjectionTurns.ts";
import { SqlitePersistenceMemory } from "../../persistence/Layers/Sqlite.ts";
import { ProjectionTurnRepository } from "../../persistence/Services/ProjectionTurns.ts";
import * as RepositoryIdentityResolver from "../../project/RepositoryIdentityResolver.ts";
import { ServerConfig } from "../../config.ts";
import { OrchestrationEngineLive } from "./OrchestrationEngine.ts";
import { OrchestrationProjectionPipelineLive } from "./ProjectionPipeline.ts";
import { OrchestrationProjectionSnapshotQueryLive } from "./ProjectionSnapshotQuery.ts";
import { OrchestrationEngineService } from "../Services/OrchestrationEngine.ts";
import { ProjectionSnapshotQuery } from "../Services/ProjectionSnapshotQuery.ts";
import { reconcileInterruptedTurnsOnBoot } from "./CrashRecoveryReconciler.ts";

const MODEL_SELECTION = {
 instanceId: ProviderInstanceId.make("codex"),
 model: "gpt-5-codex",
};

async function createReconcilerSystem() {
 const ServerConfigLayer = ServerConfig.layerTest(process.cwd(), {
 prefix: "t3-crash-recovery-reconciler-test-",
 });
 const orchestrationLayer = Layer.mergeAll(
 OrchestrationEngineLive.pipe(
 Layer.provide(OrchestrationProjectionSnapshotQueryLive),
 Layer.provide(OrchestrationProjectionPipelineLive),
 ),
 OrchestrationProjectionSnapshotQueryLive,
 ProjectionTurnRepositoryLive,
 ).pipe(
 Layer.provide(OrchestrationEventStoreLive),
 Layer.provide(OrchestrationCommandReceiptRepositoryLive),
 Layer.provide(RepositoryIdentityResolver.layer),
 Layer.provide(SqlitePersistenceMemory),
 Layer.provideMerge(ServerConfigLayer),
 Layer.provideMerge(NodeServices.layer),
 );
 const runtime = ManagedRuntime.make(orchestrationLayer);
 const engine = await runtime.runPromise(Effect.service(OrchestrationEngineService));
 const snapshotQuery = await runtime.runPromise(Effect.service(ProjectionSnapshotQuery));
 const turnRepository = await runtime.runPromise(Effect.service(ProjectionTurnRepository));

 return {
 dispatch: (command: OrchestrationCommand) => runtime.runPromise(engine.dispatch(command)),
 readModel: () => runtime.runPromise(snapshotQuery.getSnapshot()),
 reconcile: () => runtime.runPromise(reconcileInterruptedTurnsOnBoot),
 getTurn: (threadId: string, turnId: string) =>
 runtime.runPromise(
 turnRepository.getByTurnId({
 threadId: ThreadId.make(threadId),
 turnId: TurnId.make(turnId),
 }),
 ),
 readEvents: () =>
 runtime.runPromise(
 Stream.runCollect(engine.readEvents(0)).pipe(
 Effect.map((chunk): OrchestrationEvent[] => Array.from(chunk)),
 ),
 ),
 dispose: () => runtime.dispose(),
 };
}

type ReconcilerSystem = Awaited<ReturnType<typeof createReconcilerSystem>>;

async function seedProject(system: ReconcilerSystem, projectId: string) {
 await system.dispatch({
 type: "project.create",
 commandId: CommandId.make(`cmd-project-${projectId}`),
 projectId: ProjectId.make(projectId),
 title: `Project ${projectId}`,
 workspaceRoot: `/tmp/${projectId}`,
 defaultModelSelection: MODEL_SELECTION,
 createdAt: "2026-01-01T00:00:00.000Z",
 });
}

async function seedThread(system: ReconcilerSystem, projectId: string, threadId: string) {
 await system.dispatch({
 type: "thread.create",
 commandId: CommandId.make(`cmd-thread-${threadId}`),
 threadId: ThreadId.make(threadId),
 projectId: ProjectId.make(projectId),
 title: `Thread ${threadId}`,
 modelSelection: MODEL_SELECTION,
 interactionMode: DEFAULT_PROVIDER_INTERACTION_MODE,
 runtimeMode: "full-access",
 branch: null,
 worktreePath: null,
 createdAt: "2026-01-01T00:00:01.000Z",
 });
}

async function setSession(
 system: ReconcilerSystem,
 threadId: string,
 status: "running" | "stopped",
 activeTurnId: string | null,
 updatedAt: string,
) {
 await system.dispatch({
 type: "thread.session.set",
 commandId: CommandId.make(`cmd-session-${threadId}-${status}-${updatedAt}`),
 threadId: ThreadId.make(threadId),
 session: {
 threadId: ThreadId.make(threadId),
 status,
 providerName: "claudeAgent",
 providerInstanceId: ProviderInstanceId.make("codex"),
 runtimeMode: "full-access",
 activeTurnId: activeTurnId === null ? null : TurnId.make(activeTurnId),
 lastError: null,
 updatedAt,
 },
 createdAt: updatedAt,
 });
}

/** Seed a thread frozen mid-turn the way an ungraceful crash leaves it. */
async function seedCrashedThread(
 system: ReconcilerSystem,
 projectId: string,
 threadId: string,
 turnId: string,
) {
 await seedThread(system, projectId, threadId);
 await setSession(system, threadId, "running", turnId, "2026-01-01T00:00:02.000Z");
}

describe("reconcileInterruptedTurnsOnBoot", () => {
 it("leaves a crashed thread with a running turn / active session (precondition)", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 const snapshot = await system.readModel();
 const thread = snapshot.threads.find((entry) => entry.id === "thread-1");
 expect(thread?.latestTurn?.state).toBe("running");
 expect(thread?.session?.status).toBe("running");
 expect(thread?.session?.activeTurnId).toBe("turn-1");

 const turn = await system.getTurn("thread-1", "turn-1");
 expect(turn._tag).toBe("Some");
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("running");
 expect(turn.value.completedAt).toBeNull();
 }
 } finally {
 await system.dispose();
 }
 });

 it("settles a crashed thread to interrupted and stops the session", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 const result = await system.reconcile();
 expect(result.reconciledCount).toBe(1);

 const snapshot = await system.readModel();
 const thread = snapshot.threads.find((entry) => entry.id === "thread-1");
 expect(thread?.session?.status).toBe("stopped");
 expect(thread?.session?.activeTurnId).toBeNull();

 const turn = await system.getTurn("thread-1", "turn-1");
 expect(turn._tag).toBe("Some");
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("interrupted");
 expect(turn.value.completedAt).not.toBeNull();
 }
 } finally {
 await system.dispose();
 }
 });

 it("is idempotent: a second boot reconciles nothing and leaves projections unchanged", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 const first = await system.reconcile();
 expect(first.reconciledCount).toBe(1);

 const eventsAfterFirst = await system.readEvents();
 const snapshotAfterFirst = await system.readModel();

 const second = await system.reconcile();
 expect(second.reconciledCount).toBe(0);

 const eventsAfterSecond = await system.readEvents();
 expect(eventsAfterSecond.length).toBe(eventsAfterFirst.length);

 const snapshotAfterSecond = await system.readModel();
 const threadFirst = snapshotAfterFirst.threads.find((entry) => entry.id === "thread-1");
 const threadSecond = snapshotAfterSecond.threads.find((entry) => entry.id === "thread-1");
 expect(threadSecond?.session?.status).toBe(threadFirst?.session?.status);
 expect(threadSecond?.session?.activeTurnId).toBe(threadFirst?.session?.activeTurnId ?? null);

 const turn = await system.getTurn("thread-1", "turn-1");
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("interrupted");
 }
 } finally {
 await system.dispose();
 }
 });

 it("only reconciles crashed threads, not already-settled ones (multi-thread selectivity)", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-a", "turn-a");
 await seedCrashedThread(system, "project-1", "thread-b", "turn-b");

 // An already-settled thread: it ran a turn and the session was cleanly stopped.
 await seedThread(system, "project-1", "thread-settled");
 await setSession(system, "thread-settled", "running", "turn-s", "2026-01-01T00:00:03.000Z");
 await setSession(system, "thread-settled", "stopped", null, "2026-01-01T00:00:04.000Z");

 const settledTurnBefore = await system.getTurn("thread-settled", "turn-s");
 expect(settledTurnBefore._tag).toBe("Some");

 const result = await system.reconcile();
 expect(result.reconciledCount).toBe(2);

 const crashedTurns: ReadonlyArray<readonly [string, string]> = [
 ["thread-a", "turn-a"],
 ["thread-b", "turn-b"],
 ];
 for (const [threadId, turnId] of crashedTurns) {
 const turn = await system.getTurn(threadId, turnId);
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("interrupted");
 expect(turn.value.completedAt).not.toBeNull();
 }
 }

 // The already-settled thread must be untouched (same completedAt).
 const settledTurnAfter = await system.getTurn("thread-settled", "turn-s");
 if (settledTurnBefore._tag === "Some" && settledTurnAfter._tag === "Some") {
 expect(settledTurnAfter.value.state).toBe("interrupted");
 expect(settledTurnAfter.value.completedAt).toBe(settledTurnBefore.value.completedAt);
 }
 } finally {
 await system.dispose();
 }
 });

 it("appends a durable thread.session-set event that survives a projection rebuild", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 await system.reconcile();

 const events = await system.readEvents();
 const stopEvents = events.filter(
 (event): event is Extract<OrchestrationEvent, { type: "thread.session-set" }> =>
 event.type === "thread.session-set" &&
 event.payload.threadId === "thread-1" &&
 event.payload.session.status === "stopped",
 );
 expect(stopEvents.length).toBe(1);
 const stopEvent = stopEvents[0];
 if (stopEvent) {
 expect(stopEvent.payload.session.activeTurnId).toBeNull();
 expect(String(stopEvent.commandId).startsWith("t3-crash-recovery:")).toBe(true);
 }
 } finally {
 await system.dispose();
 }
 });
});
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(server): reconcile crash-frozen running turns to interrupted on boot (#5)#13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

radroid
merged 1 commit into

from

Jul 25, 2026
 Merged


fix(server): reconcile crash-frozen running turns to interrupted on boot (#5)
#13
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


296 changes: 296 additions & 0 deletions
apps/server/src/orchestration/Layers/CrashRecoveryReconciler.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,296 @@
import {
 CommandId,
 DEFAULT_PROVIDER_INTERACTION_MODE,
 ProjectId,
 ProviderInstanceId,
 ThreadId,
 TurnId,
 type OrchestrationCommand,
 type OrchestrationEvent,
} from "@t3tools/contracts";
import * as NodeServices from "@effect/platform-node/NodeServices";
import * as Effect from "effect/Effect";
import * as Layer from "effect/Layer";
import * as ManagedRuntime from "effect/ManagedRuntime";
import * as Stream from "effect/Stream";
import { describe, expect, it } from "vite-plus/test";

import { OrchestrationCommandReceiptRepositoryLive } from "../../persistence/Layers/OrchestrationCommandReceipts.ts";
import { OrchestrationEventStoreLive } from "../../persistence/Layers/OrchestrationEventStore.ts";
import { ProjectionTurnRepositoryLive } from "../../persistence/Layers/ProjectionTurns.ts";
import { SqlitePersistenceMemory } from "../../persistence/Layers/Sqlite.ts";
import { ProjectionTurnRepository } from "../../persistence/Services/ProjectionTurns.ts";
import * as RepositoryIdentityResolver from "../../project/RepositoryIdentityResolver.ts";
import { ServerConfig } from "../../config.ts";
import { OrchestrationEngineLive } from "./OrchestrationEngine.ts";
import { OrchestrationProjectionPipelineLive } from "./ProjectionPipeline.ts";
import { OrchestrationProjectionSnapshotQueryLive } from "./ProjectionSnapshotQuery.ts";
import { OrchestrationEngineService } from "../Services/OrchestrationEngine.ts";
import { ProjectionSnapshotQuery } from "../Services/ProjectionSnapshotQuery.ts";
import { reconcileInterruptedTurnsOnBoot } from "./CrashRecoveryReconciler.ts";

const MODEL_SELECTION = {
 instanceId: ProviderInstanceId.make("codex"),
 model: "gpt-5-codex",
};

async function createReconcilerSystem() {
 const ServerConfigLayer = ServerConfig.layerTest(process.cwd(), {
 prefix: "t3-crash-recovery-reconciler-test-",
 });
 const orchestrationLayer = Layer.mergeAll(
 OrchestrationEngineLive.pipe(
 Layer.provide(OrchestrationProjectionSnapshotQueryLive),
 Layer.provide(OrchestrationProjectionPipelineLive),
 ),
 OrchestrationProjectionSnapshotQueryLive,
 ProjectionTurnRepositoryLive,
 ).pipe(
 Layer.provide(OrchestrationEventStoreLive),
 Layer.provide(OrchestrationCommandReceiptRepositoryLive),
 Layer.provide(RepositoryIdentityResolver.layer),
 Layer.provide(SqlitePersistenceMemory),
 Layer.provideMerge(ServerConfigLayer),
 Layer.provideMerge(NodeServices.layer),
 );
 const runtime = ManagedRuntime.make(orchestrationLayer);
 const engine = await runtime.runPromise(Effect.service(OrchestrationEngineService));
 const snapshotQuery = await runtime.runPromise(Effect.service(ProjectionSnapshotQuery));
 const turnRepository = await runtime.runPromise(Effect.service(ProjectionTurnRepository));

 return {
 dispatch: (command: OrchestrationCommand) => runtime.runPromise(engine.dispatch(command)),
 readModel: () => runtime.runPromise(snapshotQuery.getSnapshot()),
 reconcile: () => runtime.runPromise(reconcileInterruptedTurnsOnBoot),
 getTurn: (threadId: string, turnId: string) =>
 runtime.runPromise(
 turnRepository.getByTurnId({
 threadId: ThreadId.make(threadId),
 turnId: TurnId.make(turnId),
 }),
 ),
 readEvents: () =>
 runtime.runPromise(
 Stream.runCollect(engine.readEvents(0)).pipe(
 Effect.map((chunk): OrchestrationEvent[] => Array.from(chunk)),
 ),
 ),
 dispose: () => runtime.dispose(),
 };
}

type ReconcilerSystem = Awaited<ReturnType<typeof createReconcilerSystem>>;

async function seedProject(system: ReconcilerSystem, projectId: string) {
 await system.dispatch({
 type: "project.create",
 commandId: CommandId.make(`cmd-project-${projectId}`),
 projectId: ProjectId.make(projectId),
 title: `Project ${projectId}`,
 workspaceRoot: `/tmp/${projectId}`,
 defaultModelSelection: MODEL_SELECTION,
 createdAt: "2026-01-01T00:00:00.000Z",
 });
}

async function seedThread(system: ReconcilerSystem, projectId: string, threadId: string) {
 await system.dispatch({
 type: "thread.create",
 commandId: CommandId.make(`cmd-thread-${threadId}`),
 threadId: ThreadId.make(threadId),
 projectId: ProjectId.make(projectId),
 title: `Thread ${threadId}`,
 modelSelection: MODEL_SELECTION,
 interactionMode: DEFAULT_PROVIDER_INTERACTION_MODE,
 runtimeMode: "full-access",
 branch: null,
 worktreePath: null,
 createdAt: "2026-01-01T00:00:01.000Z",
 });
}

async function setSession(
 system: ReconcilerSystem,
 threadId: string,
 status: "running" | "stopped",
 activeTurnId: string | null,
 updatedAt: string,
) {
 await system.dispatch({
 type: "thread.session.set",
 commandId: CommandId.make(`cmd-session-${threadId}-${status}-${updatedAt}`),
 threadId: ThreadId.make(threadId),
 session: {
 threadId: ThreadId.make(threadId),
 status,
 providerName: "claudeAgent",
 providerInstanceId: ProviderInstanceId.make("codex"),
 runtimeMode: "full-access",
 activeTurnId: activeTurnId === null ? null : TurnId.make(activeTurnId),
 lastError: null,
 updatedAt,
 },
 createdAt: updatedAt,
 });
}

/** Seed a thread frozen mid-turn the way an ungraceful crash leaves it. */
async function seedCrashedThread(
 system: ReconcilerSystem,
 projectId: string,
 threadId: string,
 turnId: string,
) {
 await seedThread(system, projectId, threadId);
 await setSession(system, threadId, "running", turnId, "2026-01-01T00:00:02.000Z");
}

describe("reconcileInterruptedTurnsOnBoot", () => {
 it("leaves a crashed thread with a running turn / active session (precondition)", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 const snapshot = await system.readModel();
 const thread = snapshot.threads.find((entry) => entry.id === "thread-1");
 expect(thread?.latestTurn?.state).toBe("running");
 expect(thread?.session?.status).toBe("running");
 expect(thread?.session?.activeTurnId).toBe("turn-1");

 const turn = await system.getTurn("thread-1", "turn-1");
 expect(turn._tag).toBe("Some");
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("running");
 expect(turn.value.completedAt).toBeNull();
 }
 } finally {
 await system.dispose();
 }
 });

 it("settles a crashed thread to interrupted and stops the session", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 const result = await system.reconcile();
 expect(result.reconciledCount).toBe(1);

 const snapshot = await system.readModel();
 const thread = snapshot.threads.find((entry) => entry.id === "thread-1");
 expect(thread?.session?.status).toBe("stopped");
 expect(thread?.session?.activeTurnId).toBeNull();

 const turn = await system.getTurn("thread-1", "turn-1");
 expect(turn._tag).toBe("Some");
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("interrupted");
 expect(turn.value.completedAt).not.toBeNull();
 }
 } finally {
 await system.dispose();
 }
 });

 it("is idempotent: a second boot reconciles nothing and leaves projections unchanged", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 const first = await system.reconcile();
 expect(first.reconciledCount).toBe(1);

 const eventsAfterFirst = await system.readEvents();
 const snapshotAfterFirst = await system.readModel();

 const second = await system.reconcile();
 expect(second.reconciledCount).toBe(0);

 const eventsAfterSecond = await system.readEvents();
 expect(eventsAfterSecond.length).toBe(eventsAfterFirst.length);

 const snapshotAfterSecond = await system.readModel();
 const threadFirst = snapshotAfterFirst.threads.find((entry) => entry.id === "thread-1");
 const threadSecond = snapshotAfterSecond.threads.find((entry) => entry.id === "thread-1");
 expect(threadSecond?.session?.status).toBe(threadFirst?.session?.status);
 expect(threadSecond?.session?.activeTurnId).toBe(threadFirst?.session?.activeTurnId ?? null);

 const turn = await system.getTurn("thread-1", "turn-1");
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("interrupted");
 }
 } finally {
 await system.dispose();
 }
 });

 it("only reconciles crashed threads, not already-settled ones (multi-thread selectivity)", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-a", "turn-a");
 await seedCrashedThread(system, "project-1", "thread-b", "turn-b");

 // An already-settled thread: it ran a turn and the session was cleanly stopped.
 await seedThread(system, "project-1", "thread-settled");
 await setSession(system, "thread-settled", "running", "turn-s", "2026-01-01T00:00:03.000Z");
 await setSession(system, "thread-settled", "stopped", null, "2026-01-01T00:00:04.000Z");

 const settledTurnBefore = await system.getTurn("thread-settled", "turn-s");
 expect(settledTurnBefore._tag).toBe("Some");

 const result = await system.reconcile();
 expect(result.reconciledCount).toBe(2);

 const crashedTurns: ReadonlyArray<readonly [string, string]> = [
 ["thread-a", "turn-a"],
 ["thread-b", "turn-b"],
 ];
 for (const [threadId, turnId] of crashedTurns) {
 const turn = await system.getTurn(threadId, turnId);
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("interrupted");
 expect(turn.value.completedAt).not.toBeNull();
 }
 }

 // The already-settled thread must be untouched (same completedAt).
 const settledTurnAfter = await system.getTurn("thread-settled", "turn-s");
 if (settledTurnBefore._tag === "Some" && settledTurnAfter._tag === "Some") {
 expect(settledTurnAfter.value.state).toBe("interrupted");
 expect(settledTurnAfter.value.completedAt).toBe(settledTurnBefore.value.completedAt);
 }
 } finally {
 await system.dispose();
 }
 });

 it("appends a durable thread.session-set event that survives a projection rebuild", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 await system.reconcile();

 const events = await system.readEvents();
 const stopEvents = events.filter(
 (event): event is Extract<OrchestrationEvent, { type: "thread.session-set" }> =>
 event.type === "thread.session-set" &&
 event.payload.threadId === "thread-1" &&
 event.payload.session.status === "stopped",
 );
 expect(stopEvents.length).toBe(1);
 const stopEvent = stopEvents[0];
 if (stopEvent) {
 expect(stopEvent.payload.session.activeTurnId).toBeNull();
 expect(String(stopEvent.commandId).startsWith("t3-crash-recovery:")).toBe(true);
 }
 } finally {
 await system.dispose();
 }
 });
});
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix(server): reconcile crash-frozen running turns to interrupted on boot (#5)#13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

radroid
merged 1 commit into

from

Jul 25, 2026
 Merged


fix(server): reconcile crash-frozen running turns to interrupted on boot (#5)
#13
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


296 changes: 296 additions & 0 deletions
apps/server/src/orchestration/Layers/CrashRecoveryReconciler.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,296 @@
import {
 CommandId,
 DEFAULT_PROVIDER_INTERACTION_MODE,
 ProjectId,
 ProviderInstanceId,
 ThreadId,
 TurnId,
 type OrchestrationCommand,
 type OrchestrationEvent,
} from "@t3tools/contracts";
import * as NodeServices from "@effect/platform-node/NodeServices";
import * as Effect from "effect/Effect";
import * as Layer from "effect/Layer";
import * as ManagedRuntime from "effect/ManagedRuntime";
import * as Stream from "effect/Stream";
import { describe, expect, it } from "vite-plus/test";

import { OrchestrationCommandReceiptRepositoryLive } from "../../persistence/Layers/OrchestrationCommandReceipts.ts";
import { OrchestrationEventStoreLive } from "../../persistence/Layers/OrchestrationEventStore.ts";
import { ProjectionTurnRepositoryLive } from "../../persistence/Layers/ProjectionTurns.ts";
import { SqlitePersistenceMemory } from "../../persistence/Layers/Sqlite.ts";
import { ProjectionTurnRepository } from "../../persistence/Services/ProjectionTurns.ts";
import * as RepositoryIdentityResolver from "../../project/RepositoryIdentityResolver.ts";
import { ServerConfig } from "../../config.ts";
import { OrchestrationEngineLive } from "./OrchestrationEngine.ts";
import { OrchestrationProjectionPipelineLive } from "./ProjectionPipeline.ts";
import { OrchestrationProjectionSnapshotQueryLive } from "./ProjectionSnapshotQuery.ts";
import { OrchestrationEngineService } from "../Services/OrchestrationEngine.ts";
import { ProjectionSnapshotQuery } from "../Services/ProjectionSnapshotQuery.ts";
import { reconcileInterruptedTurnsOnBoot } from "./CrashRecoveryReconciler.ts";

const MODEL_SELECTION = {
 instanceId: ProviderInstanceId.make("codex"),
 model: "gpt-5-codex",
};

async function createReconcilerSystem() {
 const ServerConfigLayer = ServerConfig.layerTest(process.cwd(), {
 prefix: "t3-crash-recovery-reconciler-test-",
 });
 const orchestrationLayer = Layer.mergeAll(
 OrchestrationEngineLive.pipe(
 Layer.provide(OrchestrationProjectionSnapshotQueryLive),
 Layer.provide(OrchestrationProjectionPipelineLive),
 ),
 OrchestrationProjectionSnapshotQueryLive,
 ProjectionTurnRepositoryLive,
 ).pipe(
 Layer.provide(OrchestrationEventStoreLive),
 Layer.provide(OrchestrationCommandReceiptRepositoryLive),
 Layer.provide(RepositoryIdentityResolver.layer),
 Layer.provide(SqlitePersistenceMemory),
 Layer.provideMerge(ServerConfigLayer),
 Layer.provideMerge(NodeServices.layer),
 );
 const runtime = ManagedRuntime.make(orchestrationLayer);
 const engine = await runtime.runPromise(Effect.service(OrchestrationEngineService));
 const snapshotQuery = await runtime.runPromise(Effect.service(ProjectionSnapshotQuery));
 const turnRepository = await runtime.runPromise(Effect.service(ProjectionTurnRepository));

 return {
 dispatch: (command: OrchestrationCommand) => runtime.runPromise(engine.dispatch(command)),
 readModel: () => runtime.runPromise(snapshotQuery.getSnapshot()),
 reconcile: () => runtime.runPromise(reconcileInterruptedTurnsOnBoot),
 getTurn: (threadId: string, turnId: string) =>
 runtime.runPromise(
 turnRepository.getByTurnId({
 threadId: ThreadId.make(threadId),
 turnId: TurnId.make(turnId),
 }),
 ),
 readEvents: () =>
 runtime.runPromise(
 Stream.runCollect(engine.readEvents(0)).pipe(
 Effect.map((chunk): OrchestrationEvent[] => Array.from(chunk)),
 ),
 ),
 dispose: () => runtime.dispose(),
 };
}

type ReconcilerSystem = Awaited<ReturnType<typeof createReconcilerSystem>>;

async function seedProject(system: ReconcilerSystem, projectId: string) {
 await system.dispatch({
 type: "project.create",
 commandId: CommandId.make(`cmd-project-${projectId}`),
 projectId: ProjectId.make(projectId),
 title: `Project ${projectId}`,
 workspaceRoot: `/tmp/${projectId}`,
 defaultModelSelection: MODEL_SELECTION,
 createdAt: "2026-01-01T00:00:00.000Z",
 });
}

async function seedThread(system: ReconcilerSystem, projectId: string, threadId: string) {
 await system.dispatch({
 type: "thread.create",
 commandId: CommandId.make(`cmd-thread-${threadId}`),
 threadId: ThreadId.make(threadId),
 projectId: ProjectId.make(projectId),
 title: `Thread ${threadId}`,
 modelSelection: MODEL_SELECTION,
 interactionMode: DEFAULT_PROVIDER_INTERACTION_MODE,
 runtimeMode: "full-access",
 branch: null,
 worktreePath: null,
 createdAt: "2026-01-01T00:00:01.000Z",
 });
}

async function setSession(
 system: ReconcilerSystem,
 threadId: string,
 status: "running" | "stopped",
 activeTurnId: string | null,
 updatedAt: string,
) {
 await system.dispatch({
 type: "thread.session.set",
 commandId: CommandId.make(`cmd-session-${threadId}-${status}-${updatedAt}`),
 threadId: ThreadId.make(threadId),
 session: {
 threadId: ThreadId.make(threadId),
 status,
 providerName: "claudeAgent",
 providerInstanceId: ProviderInstanceId.make("codex"),
 runtimeMode: "full-access",
 activeTurnId: activeTurnId === null ? null : TurnId.make(activeTurnId),
 lastError: null,
 updatedAt,
 },
 createdAt: updatedAt,
 });
}

/** Seed a thread frozen mid-turn the way an ungraceful crash leaves it. */
async function seedCrashedThread(
 system: ReconcilerSystem,
 projectId: string,
 threadId: string,
 turnId: string,
) {
 await seedThread(system, projectId, threadId);
 await setSession(system, threadId, "running", turnId, "2026-01-01T00:00:02.000Z");
}

describe("reconcileInterruptedTurnsOnBoot", () => {
 it("leaves a crashed thread with a running turn / active session (precondition)", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 const snapshot = await system.readModel();
 const thread = snapshot.threads.find((entry) => entry.id === "thread-1");
 expect(thread?.latestTurn?.state).toBe("running");
 expect(thread?.session?.status).toBe("running");
 expect(thread?.session?.activeTurnId).toBe("turn-1");

 const turn = await system.getTurn("thread-1", "turn-1");
 expect(turn._tag).toBe("Some");
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("running");
 expect(turn.value.completedAt).toBeNull();
 }
 } finally {
 await system.dispose();
 }
 });

 it("settles a crashed thread to interrupted and stops the session", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 const result = await system.reconcile();
 expect(result.reconciledCount).toBe(1);

 const snapshot = await system.readModel();
 const thread = snapshot.threads.find((entry) => entry.id === "thread-1");
 expect(thread?.session?.status).toBe("stopped");
 expect(thread?.session?.activeTurnId).toBeNull();

 const turn = await system.getTurn("thread-1", "turn-1");
 expect(turn._tag).toBe("Some");
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("interrupted");
 expect(turn.value.completedAt).not.toBeNull();
 }
 } finally {
 await system.dispose();
 }
 });

 it("is idempotent: a second boot reconciles nothing and leaves projections unchanged", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 const first = await system.reconcile();
 expect(first.reconciledCount).toBe(1);

 const eventsAfterFirst = await system.readEvents();
 const snapshotAfterFirst = await system.readModel();

 const second = await system.reconcile();
 expect(second.reconciledCount).toBe(0);

 const eventsAfterSecond = await system.readEvents();
 expect(eventsAfterSecond.length).toBe(eventsAfterFirst.length);

 const snapshotAfterSecond = await system.readModel();
 const threadFirst = snapshotAfterFirst.threads.find((entry) => entry.id === "thread-1");
 const threadSecond = snapshotAfterSecond.threads.find((entry) => entry.id === "thread-1");
 expect(threadSecond?.session?.status).toBe(threadFirst?.session?.status);
 expect(threadSecond?.session?.activeTurnId).toBe(threadFirst?.session?.activeTurnId ?? null);

 const turn = await system.getTurn("thread-1", "turn-1");
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("interrupted");
 }
 } finally {
 await system.dispose();
 }
 });

 it("only reconciles crashed threads, not already-settled ones (multi-thread selectivity)", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-a", "turn-a");
 await seedCrashedThread(system, "project-1", "thread-b", "turn-b");

 // An already-settled thread: it ran a turn and the session was cleanly stopped.
 await seedThread(system, "project-1", "thread-settled");
 await setSession(system, "thread-settled", "running", "turn-s", "2026-01-01T00:00:03.000Z");
 await setSession(system, "thread-settled", "stopped", null, "2026-01-01T00:00:04.000Z");

 const settledTurnBefore = await system.getTurn("thread-settled", "turn-s");
 expect(settledTurnBefore._tag).toBe("Some");

 const result = await system.reconcile();
 expect(result.reconciledCount).toBe(2);

 const crashedTurns: ReadonlyArray<readonly [string, string]> = [
 ["thread-a", "turn-a"],
 ["thread-b", "turn-b"],
 ];
 for (const [threadId, turnId] of crashedTurns) {
 const turn = await system.getTurn(threadId, turnId);
 if (turn._tag === "Some") {
 expect(turn.value.state).toBe("interrupted");
 expect(turn.value.completedAt).not.toBeNull();
 }
 }

 // The already-settled thread must be untouched (same completedAt).
 const settledTurnAfter = await system.getTurn("thread-settled", "turn-s");
 if (settledTurnBefore._tag === "Some" && settledTurnAfter._tag === "Some") {
 expect(settledTurnAfter.value.state).toBe("interrupted");
 expect(settledTurnAfter.value.completedAt).toBe(settledTurnBefore.value.completedAt);
 }
 } finally {
 await system.dispose();
 }
 });

 it("appends a durable thread.session-set event that survives a projection rebuild", async () => {
 const system = await createReconcilerSystem();
 try {
 await seedProject(system, "project-1");
 await seedCrashedThread(system, "project-1", "thread-1", "turn-1");

 await system.reconcile();

 const events = await system.readEvents();
 const stopEvents = events.filter(
 (event): event is Extract<OrchestrationEvent, { type: "thread.session-set" }> =>
 event.type === "thread.session-set" &&
 event.payload.threadId === "thread-1" &&
 event.payload.session.status === "stopped",
 );
 expect(stopEvents.length).toBe(1);
 const stopEvent = stopEvents[0];
 if (stopEvent) {
 expect(stopEvent.payload.session.activeTurnId).toBeNull();
 expect(String(stopEvent.commandId).startsWith("t3-crash-recovery:")).toBe(true);
 }
 } finally {
 await system.dispose();
 }
 });
});
Loading