Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions .github/workflows/coil-release.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -389,6 +389,19 @@ jobs:
# process that resets the limit to its default of 4, so the serialisation would be a no-op.
- name: Build desktop bundle (serialised)
shell: bash
env:
# Issue #53. The web renderer's source maps were 37.4 MiB of a 189.66 MiB app.asar — the
# single largest line item in the bundle, and 20% of what every user downloads on every
# update. Nothing reads them: a `.map` is only parsed with --enable-source-maps, which the
# desktop backend passes through rather than sets (DesktopBackendConfiguration.ts), and
# renderer maps are DevTools-only.
#
# This is an EXISTING upstream variable (apps/web/vite.config.ts), which is why the biggest
# single win in the issue costs zero seam rows. First-party maps outside the renderer —
# bin.mjs.map and main.cjs.map, ~12 MiB — are deliberately still built and still shipped, so
# an operator who exports NODE_OPTIONS=--enable-source-maps keeps readable stack traces for
# our own code.
T3CODE_WEB_SOURCEMAP: "0"
run: |
set -uo pipefail

Expand DownExpand Up@@ -438,6 +451,29 @@ jobs:
echo "::error::build:desktop failed three times with transient process-startup errors." >&2
exit 1

# Issue #53. Kept in its own step so the exact glob list appears in the release log: the list is
# the risky part of the packaging change, and reading it back out of a failed build matters more
# than saving a step. scripts/coil/desktop-file-exclusions.mjs is the single source — it also
# feeds its own unit tests.
#
# A STEP OUTPUT, NOT $GITHUB_ENV, and that is deliberate. Upstream's own test asserts
# DESKTOP_FILE_EXCLUSIONS deep-equals exactly its one entry, so any job-wide export of this
# variable makes `vp test` fail in that job with a confusing 68-vs-1 array diff. An output is
# consumed by exactly the one step that names it below.
- name: Resolve desktop bundle exclusions
id: exclusions
shell: bash
run: |
set -euo pipefail
exclusions="$(node scripts/coil/desktop-file-exclusions.mjs)"
if [[ -z "$exclusions" ]]; then
echo "::error::scripts/coil/desktop-file-exclusions.mjs produced an empty list." >&2
exit 1
fi
echo "value=$exclusions" >> "$GITHUB_OUTPUT"
echo "Excluding from the asar:"
tr ',' '\n' <<< "$exclusions" | sed 's/^/ /'

- name: Build desktop artifact
shell: bash
env:
Expand DownExpand Up@@ -468,6 +504,9 @@ jobs:
# Keep this in step with DESKTOP_BUNDLE_IDENTIFIER in scripts/coil/mac-signature.ts; a test
# asserts the two agree, and the verify step below fails an artifact carrying the wrong id.
T3X_DESKTOP_APP_ID: dev.curlycloud.t3coil
# Issue #53. Takes the packaged asar from 189.66 MiB / 14,765 files to 99.02 MiB / 3,429.
# Scoped to this step on purpose — see the note on the step that produces it.
T3X_DESKTOP_FILE_EXCLUSIONS: ${{ steps.exclusions.outputs.value }}
run: |
set -euo pipefail
node scripts/build-desktop-artifact.ts \
Expand All@@ -492,6 +531,30 @@ jobs:
fi
echo "No app-update.yml packaged."

# Issue #53's compensating control, and the reason the exclusion list above is safe to grow.
#
# The fork now excludes roughly half the asar. The failure mode of one bad glob is a
# MODULE_NOT_FOUND thrown by a shipped app, on a path that may not run until a user signs in,
# days after a green release. So this reads the artifact that is about to be published, resolves
# every bare import in the packaged first-party bundles against what actually survived, and fails
# if any of them is not loadable — whether or not a fork glob can be blamed for it. Severity does
# not depend on attribution: a bundle that imports what it does not contain is broken either way,
# and an earlier draft that warned on unattributed gaps passed a build that could not start.
#
# Runs on BOTH platforms: the Windows bundle unpacks node_modules outside the asar (the checker
# merges app.asar.unpacked back in) and its graph differs (WSL backend, Linux fff binaries), so a
# mac-only check would not cover it.
- name: Verify the packaged bundle still resolves
shell: bash
run: |
set -euo pipefail
asar="$(find release -name "app.asar" -print -quit)"
if [[ -z "$asar" ]]; then
echo "::error::No app.asar found under release/. Nothing was verified." >&2
exit 1
fi
node scripts/coil/verify-desktop-bundle.mjs --asar "$asar"

# The machine-checkable form of "this update will not re-ask for permissions" (issue #70),
# made against the .app inside the shipped .dmg rather than a staging copy.
#
Expand Down
4 changes: 2 additions & 2 deletions docs/coil/SEAMS.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@

**The authoritative list of every upstream-owned file this fork edits.**

Measured, not asserted: **48 upstream-owned files, +2281 / -1068 lines**, against merge-base
Measured, not asserted: **48 upstream-owned files, +2302 / -1068 lines**, against merge-base
`78f462c4e` (upstream v0.0.33, the 2026-08-10 sync). Everything else the fork adds lives in new
files upstream has never seen and cannot conflict.

Expand DownExpand Up@@ -284,7 +284,7 @@ Sorted by risk, worst first.
| `apps/desktop/src/preload.ts` | +29/-0 | 14 | **406** | `showNotification` + `onNotificationActivated` on the exposed bridge, plus the `t3xUpdate` bridge object (get / subscribe / restart / dismiss) |
| `packages/contracts/src/settings.ts` | +7/-2 | 23 | **207** | `notifyOnNeedsInput` (**persisted schema**) + Claude `homePath` placeholder/description |
| `apps/mobile/modules/t3-composer-editor/ios/T3ComposerEditorView.swift` | +33/-0 | 6 | **198** | Shift+Return newline vs. bare Return submit |
| `scripts/build-desktop-artifact.ts` | +11/-1 | 15 | **180** | Issue #70: `DESKTOP_APP_ID` reads `process.env.T3X_DESKTOP_APP_ID` before falling back to upstream's `com.t3tools.t3code`, so the fork's app owns its own TCC permission rows instead of sharing them with upstream's nightly. Ten of the eleven added lines are the comment explaining that. An env hook rather than a changed literal on purpose: the literal would also have broken three upstream assertions in `build-desktop-artifact.test.ts` and cost a second row. Guarded from the fork side by `scripts/coil/mac-signature.test.ts` (the hook exists and the release workflow sets it) and by `scripts/coil/verify-mac-signature.ts` (the shipped artifact carries the expected identifier) |
| `scripts/build-desktop-artifact.ts` | +32/-1 | 15 | **180** | **Two env hooks, one displaced line, no new deletions.** Issue #70: `DESKTOP_APP_ID` reads `process.env.T3X_DESKTOP_APP_ID` before falling back to upstream's `com.t3tools.t3code`, so the fork's app owns its own TCC permission rows instead of sharing them with upstream's nightly. Issue #53: `DESKTOP_FILE_EXCLUSIONS` appends `process.env.T3X_DESKTOP_FILE_EXCLUSIONS` (comma-separated globs), taking the packaged asar from 189.66 MiB / 14,765 files to 99.02 MiB / 3,429 and the `.zip` users download by 20.1 MB. Most of the added lines are the comments explaining both. Env hooks rather than changed literals on purpose. For #53 the reason is not row count — `build-desktop-artifact.test.ts` is already a row (see #71 above) — but that the fork's list is **67 globs and grows**: an inline list would make every future size fix an edit to an upstream TEST assertion, resolved by hand at every sync. Through the environment, an unset environment packages precisely what upstream packages and upstream's `deepStrictEqual` keeps passing untouched. Guarded from the fork side by `scripts/coil/mac-signature.test.ts` and `scripts/coil/desktop-bundle-size.test.ts` (both hooks exist, the release workflow sets them, the exclusions never name a package the main process loads) and by two artifact checks: `verify-mac-signature.ts` and `verify-desktop-bundle.mjs` (the shipped app still resolves every import its own bundles make) |
| `apps/desktop/src/backend/DesktopBackendConfiguration.ts` | +29/-0 | 6 | **174** | Backend heap headroom (`NODE_OPTIONS`) |
| `apps/desktop/src/backend/DesktopBackendConfiguration.test.ts` | +42/-0 | 4 | **168** | Heap-headroom assertions |
| `apps/desktop/src/main.ts` | +9/-0 | 18 | **162** | `ElectronNotification` layer + the `T3xUpdateDelivery` layer |
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions .github/workflows/coil-release.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -389,6 +389,19 @@ jobs:
# process that resets the limit to its default of 4, so the serialisation would be a no-op.
- name: Build desktop bundle (serialised)
shell: bash
env:
# Issue #53. The web renderer's source maps were 37.4 MiB of a 189.66 MiB app.asar — the
# single largest line item in the bundle, and 20% of what every user downloads on every
# update. Nothing reads them: a `.map` is only parsed with --enable-source-maps, which the
# desktop backend passes through rather than sets (DesktopBackendConfiguration.ts), and
# renderer maps are DevTools-only.
#
# This is an EXISTING upstream variable (apps/web/vite.config.ts), which is why the biggest
# single win in the issue costs zero seam rows. First-party maps outside the renderer —
# bin.mjs.map and main.cjs.map, ~12 MiB — are deliberately still built and still shipped, so
# an operator who exports NODE_OPTIONS=--enable-source-maps keeps readable stack traces for
# our own code.
T3CODE_WEB_SOURCEMAP: "0"
run: |
set -uo pipefail

Expand DownExpand Up@@ -438,6 +451,29 @@ jobs:
echo "::error::build:desktop failed three times with transient process-startup errors." >&2
exit 1

# Issue #53. Kept in its own step so the exact glob list appears in the release log: the list is
# the risky part of the packaging change, and reading it back out of a failed build matters more
# than saving a step. scripts/coil/desktop-file-exclusions.mjs is the single source — it also
# feeds its own unit tests.
#
# A STEP OUTPUT, NOT $GITHUB_ENV, and that is deliberate. Upstream's own test asserts
# DESKTOP_FILE_EXCLUSIONS deep-equals exactly its one entry, so any job-wide export of this
# variable makes `vp test` fail in that job with a confusing 68-vs-1 array diff. An output is
# consumed by exactly the one step that names it below.
- name: Resolve desktop bundle exclusions
id: exclusions
shell: bash
run: |
set -euo pipefail
exclusions="$(node scripts/coil/desktop-file-exclusions.mjs)"
if [[ -z "$exclusions" ]]; then
echo "::error::scripts/coil/desktop-file-exclusions.mjs produced an empty list." >&2
exit 1
fi
echo "value=$exclusions" >> "$GITHUB_OUTPUT"
echo "Excluding from the asar:"
tr ',' '\n' <<< "$exclusions" | sed 's/^/ /'

- name: Build desktop artifact
shell: bash
env:
Expand DownExpand Up@@ -468,6 +504,9 @@ jobs:
# Keep this in step with DESKTOP_BUNDLE_IDENTIFIER in scripts/coil/mac-signature.ts; a test
# asserts the two agree, and the verify step below fails an artifact carrying the wrong id.
T3X_DESKTOP_APP_ID: dev.curlycloud.t3coil
# Issue #53. Takes the packaged asar from 189.66 MiB / 14,765 files to 99.02 MiB / 3,429.
# Scoped to this step on purpose — see the note on the step that produces it.
T3X_DESKTOP_FILE_EXCLUSIONS: ${{ steps.exclusions.outputs.value }}
run: |
set -euo pipefail
node scripts/build-desktop-artifact.ts \
Expand All@@ -492,6 +531,30 @@ jobs:
fi
echo "No app-update.yml packaged."

# Issue #53's compensating control, and the reason the exclusion list above is safe to grow.
#
# The fork now excludes roughly half the asar. The failure mode of one bad glob is a
# MODULE_NOT_FOUND thrown by a shipped app, on a path that may not run until a user signs in,
# days after a green release. So this reads the artifact that is about to be published, resolves
# every bare import in the packaged first-party bundles against what actually survived, and fails
# if any of them is not loadable — whether or not a fork glob can be blamed for it. Severity does
# not depend on attribution: a bundle that imports what it does not contain is broken either way,
# and an earlier draft that warned on unattributed gaps passed a build that could not start.
#
# Runs on BOTH platforms: the Windows bundle unpacks node_modules outside the asar (the checker
# merges app.asar.unpacked back in) and its graph differs (WSL backend, Linux fff binaries), so a
# mac-only check would not cover it.
- name: Verify the packaged bundle still resolves
shell: bash
run: |
set -euo pipefail
asar="$(find release -name "app.asar" -print -quit)"
if [[ -z "$asar" ]]; then
echo "::error::No app.asar found under release/. Nothing was verified." >&2
exit 1
fi
node scripts/coil/verify-desktop-bundle.mjs --asar "$asar"

# The machine-checkable form of "this update will not re-ask for permissions" (issue #70),
# made against the .app inside the shipped .dmg rather than a staging copy.
#
Expand Down
4 changes: 2 additions & 2 deletions docs/coil/SEAMS.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@

**The authoritative list of every upstream-owned file this fork edits.**

Measured, not asserted: **48 upstream-owned files, +2281 / -1068 lines**, against merge-base
Measured, not asserted: **48 upstream-owned files, +2302 / -1068 lines**, against merge-base
`78f462c4e` (upstream v0.0.33, the 2026-08-10 sync). Everything else the fork adds lives in new
files upstream has never seen and cannot conflict.

Expand DownExpand Up@@ -284,7 +284,7 @@ Sorted by risk, worst first.
| `apps/desktop/src/preload.ts` | +29/-0 | 14 | **406** | `showNotification` + `onNotificationActivated` on the exposed bridge, plus the `t3xUpdate` bridge object (get / subscribe / restart / dismiss) |
| `packages/contracts/src/settings.ts` | +7/-2 | 23 | **207** | `notifyOnNeedsInput` (**persisted schema**) + Claude `homePath` placeholder/description |
| `apps/mobile/modules/t3-composer-editor/ios/T3ComposerEditorView.swift` | +33/-0 | 6 | **198** | Shift+Return newline vs. bare Return submit |
| `scripts/build-desktop-artifact.ts` | +11/-1 | 15 | **180** | Issue #70: `DESKTOP_APP_ID` reads `process.env.T3X_DESKTOP_APP_ID` before falling back to upstream's `com.t3tools.t3code`, so the fork's app owns its own TCC permission rows instead of sharing them with upstream's nightly. Ten of the eleven added lines are the comment explaining that. An env hook rather than a changed literal on purpose: the literal would also have broken three upstream assertions in `build-desktop-artifact.test.ts` and cost a second row. Guarded from the fork side by `scripts/coil/mac-signature.test.ts` (the hook exists and the release workflow sets it) and by `scripts/coil/verify-mac-signature.ts` (the shipped artifact carries the expected identifier) |
| `scripts/build-desktop-artifact.ts` | +32/-1 | 15 | **180** | **Two env hooks, one displaced line, no new deletions.** Issue #70: `DESKTOP_APP_ID` reads `process.env.T3X_DESKTOP_APP_ID` before falling back to upstream's `com.t3tools.t3code`, so the fork's app owns its own TCC permission rows instead of sharing them with upstream's nightly. Issue #53: `DESKTOP_FILE_EXCLUSIONS` appends `process.env.T3X_DESKTOP_FILE_EXCLUSIONS` (comma-separated globs), taking the packaged asar from 189.66 MiB / 14,765 files to 99.02 MiB / 3,429 and the `.zip` users download by 20.1 MB. Most of the added lines are the comments explaining both. Env hooks rather than changed literals on purpose. For #53 the reason is not row count — `build-desktop-artifact.test.ts` is already a row (see #71 above) — but that the fork's list is **67 globs and grows**: an inline list would make every future size fix an edit to an upstream TEST assertion, resolved by hand at every sync. Through the environment, an unset environment packages precisely what upstream packages and upstream's `deepStrictEqual` keeps passing untouched. Guarded from the fork side by `scripts/coil/mac-signature.test.ts` and `scripts/coil/desktop-bundle-size.test.ts` (both hooks exist, the release workflow sets them, the exclusions never name a package the main process loads) and by two artifact checks: `verify-mac-signature.ts` and `verify-desktop-bundle.mjs` (the shipped app still resolves every import its own bundles make) |
| `apps/desktop/src/backend/DesktopBackendConfiguration.ts` | +29/-0 | 6 | **174** | Backend heap headroom (`NODE_OPTIONS`) |
| `apps/desktop/src/backend/DesktopBackendConfiguration.test.ts` | +42/-0 | 4 | **168** | Heap-headroom assertions |
| `apps/desktop/src/main.ts` | +9/-0 | 18 | **162** | `ElectronNotification` layer + the `T3xUpdateDelivery` layer |
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions .github/workflows/coil-release.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -389,6 +389,19 @@ jobs:
# process that resets the limit to its default of 4, so the serialisation would be a no-op.
- name: Build desktop bundle (serialised)
shell: bash
env:
# Issue #53. The web renderer's source maps were 37.4 MiB of a 189.66 MiB app.asar — the
# single largest line item in the bundle, and 20% of what every user downloads on every
# update. Nothing reads them: a `.map` is only parsed with --enable-source-maps, which the
# desktop backend passes through rather than sets (DesktopBackendConfiguration.ts), and
# renderer maps are DevTools-only.
#
# This is an EXISTING upstream variable (apps/web/vite.config.ts), which is why the biggest
# single win in the issue costs zero seam rows. First-party maps outside the renderer —
# bin.mjs.map and main.cjs.map, ~12 MiB — are deliberately still built and still shipped, so
# an operator who exports NODE_OPTIONS=--enable-source-maps keeps readable stack traces for
# our own code.
T3CODE_WEB_SOURCEMAP: "0"
run: |
set -uo pipefail

Expand DownExpand Up@@ -438,6 +451,29 @@ jobs:
echo "::error::build:desktop failed three times with transient process-startup errors." >&2
exit 1

# Issue #53. Kept in its own step so the exact glob list appears in the release log: the list is
# the risky part of the packaging change, and reading it back out of a failed build matters more
# than saving a step. scripts/coil/desktop-file-exclusions.mjs is the single source — it also
# feeds its own unit tests.
#
# A STEP OUTPUT, NOT $GITHUB_ENV, and that is deliberate. Upstream's own test asserts
# DESKTOP_FILE_EXCLUSIONS deep-equals exactly its one entry, so any job-wide export of this
# variable makes `vp test` fail in that job with a confusing 68-vs-1 array diff. An output is
# consumed by exactly the one step that names it below.
- name: Resolve desktop bundle exclusions
id: exclusions
shell: bash
run: |
set -euo pipefail
exclusions="$(node scripts/coil/desktop-file-exclusions.mjs)"
if [[ -z "$exclusions" ]]; then
echo "::error::scripts/coil/desktop-file-exclusions.mjs produced an empty list." >&2
exit 1
fi
echo "value=$exclusions" >> "$GITHUB_OUTPUT"
echo "Excluding from the asar:"
tr ',' '\n' <<< "$exclusions" | sed 's/^/ /'

- name: Build desktop artifact
shell: bash
env:
Expand DownExpand Up@@ -468,6 +504,9 @@ jobs:
# Keep this in step with DESKTOP_BUNDLE_IDENTIFIER in scripts/coil/mac-signature.ts; a test
# asserts the two agree, and the verify step below fails an artifact carrying the wrong id.
T3X_DESKTOP_APP_ID: dev.curlycloud.t3coil
# Issue #53. Takes the packaged asar from 189.66 MiB / 14,765 files to 99.02 MiB / 3,429.
# Scoped to this step on purpose — see the note on the step that produces it.
T3X_DESKTOP_FILE_EXCLUSIONS: ${{ steps.exclusions.outputs.value }}
run: |
set -euo pipefail
node scripts/build-desktop-artifact.ts \
Expand All@@ -492,6 +531,30 @@ jobs:
fi
echo "No app-update.yml packaged."

# Issue #53's compensating control, and the reason the exclusion list above is safe to grow.
#
# The fork now excludes roughly half the asar. The failure mode of one bad glob is a
# MODULE_NOT_FOUND thrown by a shipped app, on a path that may not run until a user signs in,
# days after a green release. So this reads the artifact that is about to be published, resolves
# every bare import in the packaged first-party bundles against what actually survived, and fails
# if any of them is not loadable — whether or not a fork glob can be blamed for it. Severity does
# not depend on attribution: a bundle that imports what it does not contain is broken either way,
# and an earlier draft that warned on unattributed gaps passed a build that could not start.
#
# Runs on BOTH platforms: the Windows bundle unpacks node_modules outside the asar (the checker
# merges app.asar.unpacked back in) and its graph differs (WSL backend, Linux fff binaries), so a
# mac-only check would not cover it.
- name: Verify the packaged bundle still resolves
shell: bash
run: |
set -euo pipefail
asar="$(find release -name "app.asar" -print -quit)"
if [[ -z "$asar" ]]; then
echo "::error::No app.asar found under release/. Nothing was verified." >&2
exit 1
fi
node scripts/coil/verify-desktop-bundle.mjs --asar "$asar"

# The machine-checkable form of "this update will not re-ask for permissions" (issue #70),
# made against the .app inside the shipped .dmg rather than a staging copy.
#
Expand Down
4 changes: 2 additions & 2 deletions docs/coil/SEAMS.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@

**The authoritative list of every upstream-owned file this fork edits.**

Measured, not asserted: **48 upstream-owned files, +2281 / -1068 lines**, against merge-base
Measured, not asserted: **48 upstream-owned files, +2302 / -1068 lines**, against merge-base
`78f462c4e` (upstream v0.0.33, the 2026-08-10 sync). Everything else the fork adds lives in new
files upstream has never seen and cannot conflict.

Expand DownExpand Up@@ -284,7 +284,7 @@ Sorted by risk, worst first.
| `apps/desktop/src/preload.ts` | +29/-0 | 14 | **406** | `showNotification` + `onNotificationActivated` on the exposed bridge, plus the `t3xUpdate` bridge object (get / subscribe / restart / dismiss) |
| `packages/contracts/src/settings.ts` | +7/-2 | 23 | **207** | `notifyOnNeedsInput` (**persisted schema**) + Claude `homePath` placeholder/description |
| `apps/mobile/modules/t3-composer-editor/ios/T3ComposerEditorView.swift` | +33/-0 | 6 | **198** | Shift+Return newline vs. bare Return submit |
| `scripts/build-desktop-artifact.ts` | +11/-1 | 15 | **180** | Issue #70: `DESKTOP_APP_ID` reads `process.env.T3X_DESKTOP_APP_ID` before falling back to upstream's `com.t3tools.t3code`, so the fork's app owns its own TCC permission rows instead of sharing them with upstream's nightly. Ten of the eleven added lines are the comment explaining that. An env hook rather than a changed literal on purpose: the literal would also have broken three upstream assertions in `build-desktop-artifact.test.ts` and cost a second row. Guarded from the fork side by `scripts/coil/mac-signature.test.ts` (the hook exists and the release workflow sets it) and by `scripts/coil/verify-mac-signature.ts` (the shipped artifact carries the expected identifier) |
| `scripts/build-desktop-artifact.ts` | +32/-1 | 15 | **180** | **Two env hooks, one displaced line, no new deletions.** Issue #70: `DESKTOP_APP_ID` reads `process.env.T3X_DESKTOP_APP_ID` before falling back to upstream's `com.t3tools.t3code`, so the fork's app owns its own TCC permission rows instead of sharing them with upstream's nightly. Issue #53: `DESKTOP_FILE_EXCLUSIONS` appends `process.env.T3X_DESKTOP_FILE_EXCLUSIONS` (comma-separated globs), taking the packaged asar from 189.66 MiB / 14,765 files to 99.02 MiB / 3,429 and the `.zip` users download by 20.1 MB. Most of the added lines are the comments explaining both. Env hooks rather than changed literals on purpose. For #53 the reason is not row count — `build-desktop-artifact.test.ts` is already a row (see #71 above) — but that the fork's list is **67 globs and grows**: an inline list would make every future size fix an edit to an upstream TEST assertion, resolved by hand at every sync. Through the environment, an unset environment packages precisely what upstream packages and upstream's `deepStrictEqual` keeps passing untouched. Guarded from the fork side by `scripts/coil/mac-signature.test.ts` and `scripts/coil/desktop-bundle-size.test.ts` (both hooks exist, the release workflow sets them, the exclusions never name a package the main process loads) and by two artifact checks: `verify-mac-signature.ts` and `verify-desktop-bundle.mjs` (the shipped app still resolves every import its own bundles make) |
| `apps/desktop/src/backend/DesktopBackendConfiguration.ts` | +29/-0 | 6 | **174** | Backend heap headroom (`NODE_OPTIONS`) |
| `apps/desktop/src/backend/DesktopBackendConfiguration.test.ts` | +42/-0 | 4 | **168** | Heap-headroom assertions |
| `apps/desktop/src/main.ts` | +9/-0 | 18 | **162** | `ElectronNotification` layer + the `T3xUpdateDelivery` layer |
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions .github/workflows/coil-release.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -389,6 +389,19 @@ jobs:
# process that resets the limit to its default of 4, so the serialisation would be a no-op.
- name: Build desktop bundle (serialised)
shell: bash
env:
# Issue #53. The web renderer's source maps were 37.4 MiB of a 189.66 MiB app.asar — the
# single largest line item in the bundle, and 20% of what every user downloads on every
# update. Nothing reads them: a `.map` is only parsed with --enable-source-maps, which the
# desktop backend passes through rather than sets (DesktopBackendConfiguration.ts), and
# renderer maps are DevTools-only.
#
# This is an EXISTING upstream variable (apps/web/vite.config.ts), which is why the biggest
# single win in the issue costs zero seam rows. First-party maps outside the renderer —
# bin.mjs.map and main.cjs.map, ~12 MiB — are deliberately still built and still shipped, so
# an operator who exports NODE_OPTIONS=--enable-source-maps keeps readable stack traces for
# our own code.
T3CODE_WEB_SOURCEMAP: "0"
run: |
set -uo pipefail

Expand DownExpand Up@@ -438,6 +451,29 @@ jobs:
echo "::error::build:desktop failed three times with transient process-startup errors." >&2
exit 1

# Issue #53. Kept in its own step so the exact glob list appears in the release log: the list is
# the risky part of the packaging change, and reading it back out of a failed build matters more
# than saving a step. scripts/coil/desktop-file-exclusions.mjs is the single source — it also
# feeds its own unit tests.
#
# A STEP OUTPUT, NOT $GITHUB_ENV, and that is deliberate. Upstream's own test asserts
# DESKTOP_FILE_EXCLUSIONS deep-equals exactly its one entry, so any job-wide export of this
# variable makes `vp test` fail in that job with a confusing 68-vs-1 array diff. An output is
# consumed by exactly the one step that names it below.
- name: Resolve desktop bundle exclusions
id: exclusions
shell: bash
run: |
set -euo pipefail
exclusions="$(node scripts/coil/desktop-file-exclusions.mjs)"
if [[ -z "$exclusions" ]]; then
echo "::error::scripts/coil/desktop-file-exclusions.mjs produced an empty list." >&2
exit 1
fi
echo "value=$exclusions" >> "$GITHUB_OUTPUT"
echo "Excluding from the asar:"
tr ',' '\n' <<< "$exclusions" | sed 's/^/ /'

- name: Build desktop artifact
shell: bash
env:
Expand DownExpand Up@@ -468,6 +504,9 @@ jobs:
# Keep this in step with DESKTOP_BUNDLE_IDENTIFIER in scripts/coil/mac-signature.ts; a test
# asserts the two agree, and the verify step below fails an artifact carrying the wrong id.
T3X_DESKTOP_APP_ID: dev.curlycloud.t3coil
# Issue #53. Takes the packaged asar from 189.66 MiB / 14,765 files to 99.02 MiB / 3,429.
# Scoped to this step on purpose — see the note on the step that produces it.
T3X_DESKTOP_FILE_EXCLUSIONS: ${{ steps.exclusions.outputs.value }}
run: |
set -euo pipefail
node scripts/build-desktop-artifact.ts \
Expand All@@ -492,6 +531,30 @@ jobs:
fi
echo "No app-update.yml packaged."

# Issue #53's compensating control, and the reason the exclusion list above is safe to grow.
#
# The fork now excludes roughly half the asar. The failure mode of one bad glob is a
# MODULE_NOT_FOUND thrown by a shipped app, on a path that may not run until a user signs in,
# days after a green release. So this reads the artifact that is about to be published, resolves
# every bare import in the packaged first-party bundles against what actually survived, and fails
# if any of them is not loadable — whether or not a fork glob can be blamed for it. Severity does
# not depend on attribution: a bundle that imports what it does not contain is broken either way,
# and an earlier draft that warned on unattributed gaps passed a build that could not start.
#
# Runs on BOTH platforms: the Windows bundle unpacks node_modules outside the asar (the checker
# merges app.asar.unpacked back in) and its graph differs (WSL backend, Linux fff binaries), so a
# mac-only check would not cover it.
- name: Verify the packaged bundle still resolves
shell: bash
run: |
set -euo pipefail
asar="$(find release -name "app.asar" -print -quit)"
if [[ -z "$asar" ]]; then
echo "::error::No app.asar found under release/. Nothing was verified." >&2
exit 1
fi
node scripts/coil/verify-desktop-bundle.mjs --asar "$asar"

# The machine-checkable form of "this update will not re-ask for permissions" (issue #70),
# made against the .app inside the shipped .dmg rather than a staging copy.
#
Expand Down
4 changes: 2 additions & 2 deletions docs/coil/SEAMS.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@

**The authoritative list of every upstream-owned file this fork edits.**

Measured, not asserted: **48 upstream-owned files, +2281 / -1068 lines**, against merge-base
Measured, not asserted: **48 upstream-owned files, +2302 / -1068 lines**, against merge-base
`78f462c4e` (upstream v0.0.33, the 2026-08-10 sync). Everything else the fork adds lives in new
files upstream has never seen and cannot conflict.

Expand DownExpand Up@@ -284,7 +284,7 @@ Sorted by risk, worst first.
| `apps/desktop/src/preload.ts` | +29/-0 | 14 | **406** | `showNotification` + `onNotificationActivated` on the exposed bridge, plus the `t3xUpdate` bridge object (get / subscribe / restart / dismiss) |
| `packages/contracts/src/settings.ts` | +7/-2 | 23 | **207** | `notifyOnNeedsInput` (**persisted schema**) + Claude `homePath` placeholder/description |
| `apps/mobile/modules/t3-composer-editor/ios/T3ComposerEditorView.swift` | +33/-0 | 6 | **198** | Shift+Return newline vs. bare Return submit |
| `scripts/build-desktop-artifact.ts` | +11/-1 | 15 | **180** | Issue #70: `DESKTOP_APP_ID` reads `process.env.T3X_DESKTOP_APP_ID` before falling back to upstream's `com.t3tools.t3code`, so the fork's app owns its own TCC permission rows instead of sharing them with upstream's nightly. Ten of the eleven added lines are the comment explaining that. An env hook rather than a changed literal on purpose: the literal would also have broken three upstream assertions in `build-desktop-artifact.test.ts` and cost a second row. Guarded from the fork side by `scripts/coil/mac-signature.test.ts` (the hook exists and the release workflow sets it) and by `scripts/coil/verify-mac-signature.ts` (the shipped artifact carries the expected identifier) |
| `scripts/build-desktop-artifact.ts` | +32/-1 | 15 | **180** | **Two env hooks, one displaced line, no new deletions.** Issue #70: `DESKTOP_APP_ID` reads `process.env.T3X_DESKTOP_APP_ID` before falling back to upstream's `com.t3tools.t3code`, so the fork's app owns its own TCC permission rows instead of sharing them with upstream's nightly. Issue #53: `DESKTOP_FILE_EXCLUSIONS` appends `process.env.T3X_DESKTOP_FILE_EXCLUSIONS` (comma-separated globs), taking the packaged asar from 189.66 MiB / 14,765 files to 99.02 MiB / 3,429 and the `.zip` users download by 20.1 MB. Most of the added lines are the comments explaining both. Env hooks rather than changed literals on purpose. For #53 the reason is not row count — `build-desktop-artifact.test.ts` is already a row (see #71 above) — but that the fork's list is **67 globs and grows**: an inline list would make every future size fix an edit to an upstream TEST assertion, resolved by hand at every sync. Through the environment, an unset environment packages precisely what upstream packages and upstream's `deepStrictEqual` keeps passing untouched. Guarded from the fork side by `scripts/coil/mac-signature.test.ts` and `scripts/coil/desktop-bundle-size.test.ts` (both hooks exist, the release workflow sets them, the exclusions never name a package the main process loads) and by two artifact checks: `verify-mac-signature.ts` and `verify-desktop-bundle.mjs` (the shipped app still resolves every import its own bundles make) |
| `apps/desktop/src/backend/DesktopBackendConfiguration.ts` | +29/-0 | 6 | **174** | Backend heap headroom (`NODE_OPTIONS`) |
| `apps/desktop/src/backend/DesktopBackendConfiguration.test.ts` | +42/-0 | 4 | **168** | Heap-headroom assertions |
| `apps/desktop/src/main.ts` | +9/-0 | 18 | **162** | `ElectronNotification` layer + the `T3xUpdateDelivery` layer |
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions .github/workflows/coil-release.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -389,6 +389,19 @@ jobs:
# process that resets the limit to its default of 4, so the serialisation would be a no-op.
- name: Build desktop bundle (serialised)
shell: bash
env:
# Issue #53. The web renderer's source maps were 37.4 MiB of a 189.66 MiB app.asar — the
# single largest line item in the bundle, and 20% of what every user downloads on every
# update. Nothing reads them: a `.map` is only parsed with --enable-source-maps, which the
# desktop backend passes through rather than sets (DesktopBackendConfiguration.ts), and
# renderer maps are DevTools-only.
#
# This is an EXISTING upstream variable (apps/web/vite.config.ts), which is why the biggest
# single win in the issue costs zero seam rows. First-party maps outside the renderer —
# bin.mjs.map and main.cjs.map, ~12 MiB — are deliberately still built and still shipped, so
# an operator who exports NODE_OPTIONS=--enable-source-maps keeps readable stack traces for
# our own code.
T3CODE_WEB_SOURCEMAP: "0"
run: |
set -uo pipefail

Expand DownExpand Up@@ -438,6 +451,29 @@ jobs:
echo "::error::build:desktop failed three times with transient process-startup errors." >&2
exit 1

# Issue #53. Kept in its own step so the exact glob list appears in the release log: the list is
# the risky part of the packaging change, and reading it back out of a failed build matters more
# than saving a step. scripts/coil/desktop-file-exclusions.mjs is the single source — it also
# feeds its own unit tests.
#
# A STEP OUTPUT, NOT $GITHUB_ENV, and that is deliberate. Upstream's own test asserts
# DESKTOP_FILE_EXCLUSIONS deep-equals exactly its one entry, so any job-wide export of this
# variable makes `vp test` fail in that job with a confusing 68-vs-1 array diff. An output is
# consumed by exactly the one step that names it below.
- name: Resolve desktop bundle exclusions
id: exclusions
shell: bash
run: |
set -euo pipefail
exclusions="$(node scripts/coil/desktop-file-exclusions.mjs)"
if [[ -z "$exclusions" ]]; then
echo "::error::scripts/coil/desktop-file-exclusions.mjs produced an empty list." >&2
exit 1
fi
echo "value=$exclusions" >> "$GITHUB_OUTPUT"
echo "Excluding from the asar:"
tr ',' '\n' <<< "$exclusions" | sed 's/^/ /'

- name: Build desktop artifact
shell: bash
env:
Expand DownExpand Up@@ -468,6 +504,9 @@ jobs:
# Keep this in step with DESKTOP_BUNDLE_IDENTIFIER in scripts/coil/mac-signature.ts; a test
# asserts the two agree, and the verify step below fails an artifact carrying the wrong id.
T3X_DESKTOP_APP_ID: dev.curlycloud.t3coil
# Issue #53. Takes the packaged asar from 189.66 MiB / 14,765 files to 99.02 MiB / 3,429.
# Scoped to this step on purpose — see the note on the step that produces it.
T3X_DESKTOP_FILE_EXCLUSIONS: ${{ steps.exclusions.outputs.value }}
run: |
set -euo pipefail
node scripts/build-desktop-artifact.ts \
Expand All@@ -492,6 +531,30 @@ jobs:
fi
echo "No app-update.yml packaged."

# Issue #53's compensating control, and the reason the exclusion list above is safe to grow.
#
# The fork now excludes roughly half the asar. The failure mode of one bad glob is a
# MODULE_NOT_FOUND thrown by a shipped app, on a path that may not run until a user signs in,
# days after a green release. So this reads the artifact that is about to be published, resolves
# every bare import in the packaged first-party bundles against what actually survived, and fails
# if any of them is not loadable — whether or not a fork glob can be blamed for it. Severity does
# not depend on attribution: a bundle that imports what it does not contain is broken either way,
# and an earlier draft that warned on unattributed gaps passed a build that could not start.
#
# Runs on BOTH platforms: the Windows bundle unpacks node_modules outside the asar (the checker
# merges app.asar.unpacked back in) and its graph differs (WSL backend, Linux fff binaries), so a
# mac-only check would not cover it.
- name: Verify the packaged bundle still resolves
shell: bash
run: |
set -euo pipefail
asar="$(find release -name "app.asar" -print -quit)"
if [[ -z "$asar" ]]; then
echo "::error::No app.asar found under release/. Nothing was verified." >&2
exit 1
fi
node scripts/coil/verify-desktop-bundle.mjs --asar "$asar"

# The machine-checkable form of "this update will not re-ask for permissions" (issue #70),
# made against the .app inside the shipped .dmg rather than a staging copy.
#
Expand Down
4 changes: 2 additions & 2 deletions docs/coil/SEAMS.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@

**The authoritative list of every upstream-owned file this fork edits.**

Measured, not asserted: **48 upstream-owned files, +2281 / -1068 lines**, against merge-base
Measured, not asserted: **48 upstream-owned files, +2302 / -1068 lines**, against merge-base
`78f462c4e` (upstream v0.0.33, the 2026-08-10 sync). Everything else the fork adds lives in new
files upstream has never seen and cannot conflict.

Expand DownExpand Up@@ -284,7 +284,7 @@ Sorted by risk, worst first.
| `apps/desktop/src/preload.ts` | +29/-0 | 14 | **406** | `showNotification` + `onNotificationActivated` on the exposed bridge, plus the `t3xUpdate` bridge object (get / subscribe / restart / dismiss) |
| `packages/contracts/src/settings.ts` | +7/-2 | 23 | **207** | `notifyOnNeedsInput` (**persisted schema**) + Claude `homePath` placeholder/description |
| `apps/mobile/modules/t3-composer-editor/ios/T3ComposerEditorView.swift` | +33/-0 | 6 | **198** | Shift+Return newline vs. bare Return submit |
| `scripts/build-desktop-artifact.ts` | +11/-1 | 15 | **180** | Issue #70: `DESKTOP_APP_ID` reads `process.env.T3X_DESKTOP_APP_ID` before falling back to upstream's `com.t3tools.t3code`, so the fork's app owns its own TCC permission rows instead of sharing them with upstream's nightly. Ten of the eleven added lines are the comment explaining that. An env hook rather than a changed literal on purpose: the literal would also have broken three upstream assertions in `build-desktop-artifact.test.ts` and cost a second row. Guarded from the fork side by `scripts/coil/mac-signature.test.ts` (the hook exists and the release workflow sets it) and by `scripts/coil/verify-mac-signature.ts` (the shipped artifact carries the expected identifier) |
| `scripts/build-desktop-artifact.ts` | +32/-1 | 15 | **180** | **Two env hooks, one displaced line, no new deletions.** Issue #70: `DESKTOP_APP_ID` reads `process.env.T3X_DESKTOP_APP_ID` before falling back to upstream's `com.t3tools.t3code`, so the fork's app owns its own TCC permission rows instead of sharing them with upstream's nightly. Issue #53: `DESKTOP_FILE_EXCLUSIONS` appends `process.env.T3X_DESKTOP_FILE_EXCLUSIONS` (comma-separated globs), taking the packaged asar from 189.66 MiB / 14,765 files to 99.02 MiB / 3,429 and the `.zip` users download by 20.1 MB. Most of the added lines are the comments explaining both. Env hooks rather than changed literals on purpose. For #53 the reason is not row count — `build-desktop-artifact.test.ts` is already a row (see #71 above) — but that the fork's list is **67 globs and grows**: an inline list would make every future size fix an edit to an upstream TEST assertion, resolved by hand at every sync. Through the environment, an unset environment packages precisely what upstream packages and upstream's `deepStrictEqual` keeps passing untouched. Guarded from the fork side by `scripts/coil/mac-signature.test.ts` and `scripts/coil/desktop-bundle-size.test.ts` (both hooks exist, the release workflow sets them, the exclusions never name a package the main process loads) and by two artifact checks: `verify-mac-signature.ts` and `verify-desktop-bundle.mjs` (the shipped app still resolves every import its own bundles make) |
| `apps/desktop/src/backend/DesktopBackendConfiguration.ts` | +29/-0 | 6 | **174** | Backend heap headroom (`NODE_OPTIONS`) |
| `apps/desktop/src/backend/DesktopBackendConfiguration.test.ts` | +42/-0 | 4 | **168** | Heap-headroom assertions |
| `apps/desktop/src/main.ts` | +9/-0 | 18 | **162** | `ElectronNotification` layer + the `T3xUpdateDelivery` layer |
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions .github/workflows/coil-release.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -389,6 +389,19 @@ jobs:
# process that resets the limit to its default of 4, so the serialisation would be a no-op.
- name: Build desktop bundle (serialised)
shell: bash
env:
# Issue #53. The web renderer's source maps were 37.4 MiB of a 189.66 MiB app.asar — the
# single largest line item in the bundle, and 20% of what every user downloads on every
# update. Nothing reads them: a `.map` is only parsed with --enable-source-maps, which the
# desktop backend passes through rather than sets (DesktopBackendConfiguration.ts), and
# renderer maps are DevTools-only.
#
# This is an EXISTING upstream variable (apps/web/vite.config.ts), which is why the biggest
# single win in the issue costs zero seam rows. First-party maps outside the renderer —
# bin.mjs.map and main.cjs.map, ~12 MiB — are deliberately still built and still shipped, so
# an operator who exports NODE_OPTIONS=--enable-source-maps keeps readable stack traces for
# our own code.
T3CODE_WEB_SOURCEMAP: "0"
run: |
set -uo pipefail

Expand DownExpand Up@@ -438,6 +451,29 @@ jobs:
echo "::error::build:desktop failed three times with transient process-startup errors." >&2
exit 1

# Issue #53. Kept in its own step so the exact glob list appears in the release log: the list is
# the risky part of the packaging change, and reading it back out of a failed build matters more
# than saving a step. scripts/coil/desktop-file-exclusions.mjs is the single source — it also
# feeds its own unit tests.
#
# A STEP OUTPUT, NOT $GITHUB_ENV, and that is deliberate. Upstream's own test asserts
# DESKTOP_FILE_EXCLUSIONS deep-equals exactly its one entry, so any job-wide export of this
# variable makes `vp test` fail in that job with a confusing 68-vs-1 array diff. An output is
# consumed by exactly the one step that names it below.
- name: Resolve desktop bundle exclusions
id: exclusions
shell: bash
run: |
set -euo pipefail
exclusions="$(node scripts/coil/desktop-file-exclusions.mjs)"
if [[ -z "$exclusions" ]]; then
echo "::error::scripts/coil/desktop-file-exclusions.mjs produced an empty list." >&2
exit 1
fi
echo "value=$exclusions" >> "$GITHUB_OUTPUT"
echo "Excluding from the asar:"
tr ',' '\n' <<< "$exclusions" | sed 's/^/ /'

- name: Build desktop artifact
shell: bash
env:
Expand DownExpand Up@@ -468,6 +504,9 @@ jobs:
# Keep this in step with DESKTOP_BUNDLE_IDENTIFIER in scripts/coil/mac-signature.ts; a test
# asserts the two agree, and the verify step below fails an artifact carrying the wrong id.
T3X_DESKTOP_APP_ID: dev.curlycloud.t3coil
# Issue #53. Takes the packaged asar from 189.66 MiB / 14,765 files to 99.02 MiB / 3,429.
# Scoped to this step on purpose — see the note on the step that produces it.
T3X_DESKTOP_FILE_EXCLUSIONS: ${{ steps.exclusions.outputs.value }}
run: |
set -euo pipefail
node scripts/build-desktop-artifact.ts \
Expand All@@ -492,6 +531,30 @@ jobs:
fi
echo "No app-update.yml packaged."

# Issue #53's compensating control, and the reason the exclusion list above is safe to grow.
#
# The fork now excludes roughly half the asar. The failure mode of one bad glob is a
# MODULE_NOT_FOUND thrown by a shipped app, on a path that may not run until a user signs in,
# days after a green release. So this reads the artifact that is about to be published, resolves
# every bare import in the packaged first-party bundles against what actually survived, and fails
# if any of them is not loadable — whether or not a fork glob can be blamed for it. Severity does
# not depend on attribution: a bundle that imports what it does not contain is broken either way,
# and an earlier draft that warned on unattributed gaps passed a build that could not start.
#
# Runs on BOTH platforms: the Windows bundle unpacks node_modules outside the asar (the checker
# merges app.asar.unpacked back in) and its graph differs (WSL backend, Linux fff binaries), so a
# mac-only check would not cover it.
- name: Verify the packaged bundle still resolves
shell: bash
run: |
set -euo pipefail
asar="$(find release -name "app.asar" -print -quit)"
if [[ -z "$asar" ]]; then
echo "::error::No app.asar found under release/. Nothing was verified." >&2
exit 1
fi
node scripts/coil/verify-desktop-bundle.mjs --asar "$asar"

# The machine-checkable form of "this update will not re-ask for permissions" (issue #70),
# made against the .app inside the shipped .dmg rather than a staging copy.
#
Expand Down
4 changes: 2 additions & 2 deletions docs/coil/SEAMS.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@

**The authoritative list of every upstream-owned file this fork edits.**

Measured, not asserted: **48 upstream-owned files, +2281 / -1068 lines**, against merge-base
Measured, not asserted: **48 upstream-owned files, +2302 / -1068 lines**, against merge-base
`78f462c4e` (upstream v0.0.33, the 2026-08-10 sync). Everything else the fork adds lives in new
files upstream has never seen and cannot conflict.

Expand DownExpand Up@@ -284,7 +284,7 @@ Sorted by risk, worst first.
| `apps/desktop/src/preload.ts` | +29/-0 | 14 | **406** | `showNotification` + `onNotificationActivated` on the exposed bridge, plus the `t3xUpdate` bridge object (get / subscribe / restart / dismiss) |
| `packages/contracts/src/settings.ts` | +7/-2 | 23 | **207** | `notifyOnNeedsInput` (**persisted schema**) + Claude `homePath` placeholder/description |
| `apps/mobile/modules/t3-composer-editor/ios/T3ComposerEditorView.swift` | +33/-0 | 6 | **198** | Shift+Return newline vs. bare Return submit |
| `scripts/build-desktop-artifact.ts` | +11/-1 | 15 | **180** | Issue #70: `DESKTOP_APP_ID` reads `process.env.T3X_DESKTOP_APP_ID` before falling back to upstream's `com.t3tools.t3code`, so the fork's app owns its own TCC permission rows instead of sharing them with upstream's nightly. Ten of the eleven added lines are the comment explaining that. An env hook rather than a changed literal on purpose: the literal would also have broken three upstream assertions in `build-desktop-artifact.test.ts` and cost a second row. Guarded from the fork side by `scripts/coil/mac-signature.test.ts` (the hook exists and the release workflow sets it) and by `scripts/coil/verify-mac-signature.ts` (the shipped artifact carries the expected identifier) |
| `scripts/build-desktop-artifact.ts` | +32/-1 | 15 | **180** | **Two env hooks, one displaced line, no new deletions.** Issue #70: `DESKTOP_APP_ID` reads `process.env.T3X_DESKTOP_APP_ID` before falling back to upstream's `com.t3tools.t3code`, so the fork's app owns its own TCC permission rows instead of sharing them with upstream's nightly. Issue #53: `DESKTOP_FILE_EXCLUSIONS` appends `process.env.T3X_DESKTOP_FILE_EXCLUSIONS` (comma-separated globs), taking the packaged asar from 189.66 MiB / 14,765 files to 99.02 MiB / 3,429 and the `.zip` users download by 20.1 MB. Most of the added lines are the comments explaining both. Env hooks rather than changed literals on purpose. For #53 the reason is not row count — `build-desktop-artifact.test.ts` is already a row (see #71 above) — but that the fork's list is **67 globs and grows**: an inline list would make every future size fix an edit to an upstream TEST assertion, resolved by hand at every sync. Through the environment, an unset environment packages precisely what upstream packages and upstream's `deepStrictEqual` keeps passing untouched. Guarded from the fork side by `scripts/coil/mac-signature.test.ts` and `scripts/coil/desktop-bundle-size.test.ts` (both hooks exist, the release workflow sets them, the exclusions never name a package the main process loads) and by two artifact checks: `verify-mac-signature.ts` and `verify-desktop-bundle.mjs` (the shipped app still resolves every import its own bundles make) |
| `apps/desktop/src/backend/DesktopBackendConfiguration.ts` | +29/-0 | 6 | **174** | Backend heap headroom (`NODE_OPTIONS`) |
| `apps/desktop/src/backend/DesktopBackendConfiguration.test.ts` | +42/-0 | 4 | **168** | Heap-headroom assertions |
| `apps/desktop/src/main.ts` | +9/-0 | 18 | **162** | `ElectronNotification` layer + the `T3xUpdateDelivery` layer |
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions .github/workflows/coil-release.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -389,6 +389,19 @@ jobs:
# process that resets the limit to its default of 4, so the serialisation would be a no-op.
- name: Build desktop bundle (serialised)
shell: bash
env:
# Issue #53. The web renderer's source maps were 37.4 MiB of a 189.66 MiB app.asar — the
# single largest line item in the bundle, and 20% of what every user downloads on every
# update. Nothing reads them: a `.map` is only parsed with --enable-source-maps, which the
# desktop backend passes through rather than sets (DesktopBackendConfiguration.ts), and
# renderer maps are DevTools-only.
#
# This is an EXISTING upstream variable (apps/web/vite.config.ts), which is why the biggest
# single win in the issue costs zero seam rows. First-party maps outside the renderer —
# bin.mjs.map and main.cjs.map, ~12 MiB — are deliberately still built and still shipped, so
# an operator who exports NODE_OPTIONS=--enable-source-maps keeps readable stack traces for
# our own code.
T3CODE_WEB_SOURCEMAP: "0"
run: |
set -uo pipefail

Expand DownExpand Up@@ -438,6 +451,29 @@ jobs:
echo "::error::build:desktop failed three times with transient process-startup errors." >&2
exit 1

# Issue #53. Kept in its own step so the exact glob list appears in the release log: the list is
# the risky part of the packaging change, and reading it back out of a failed build matters more
# than saving a step. scripts/coil/desktop-file-exclusions.mjs is the single source — it also
# feeds its own unit tests.
#
# A STEP OUTPUT, NOT $GITHUB_ENV, and that is deliberate. Upstream's own test asserts
# DESKTOP_FILE_EXCLUSIONS deep-equals exactly its one entry, so any job-wide export of this
# variable makes `vp test` fail in that job with a confusing 68-vs-1 array diff. An output is
# consumed by exactly the one step that names it below.
- name: Resolve desktop bundle exclusions
id: exclusions
shell: bash
run: |
set -euo pipefail
exclusions="$(node scripts/coil/desktop-file-exclusions.mjs)"
if [[ -z "$exclusions" ]]; then
echo "::error::scripts/coil/desktop-file-exclusions.mjs produced an empty list." >&2
exit 1
fi
echo "value=$exclusions" >> "$GITHUB_OUTPUT"
echo "Excluding from the asar:"
tr ',' '\n' <<< "$exclusions" | sed 's/^/ /'

- name: Build desktop artifact
shell: bash
env:
Expand DownExpand Up@@ -468,6 +504,9 @@ jobs:
# Keep this in step with DESKTOP_BUNDLE_IDENTIFIER in scripts/coil/mac-signature.ts; a test
# asserts the two agree, and the verify step below fails an artifact carrying the wrong id.
T3X_DESKTOP_APP_ID: dev.curlycloud.t3coil
# Issue #53. Takes the packaged asar from 189.66 MiB / 14,765 files to 99.02 MiB / 3,429.
# Scoped to this step on purpose — see the note on the step that produces it.
T3X_DESKTOP_FILE_EXCLUSIONS: ${{ steps.exclusions.outputs.value }}
run: |
set -euo pipefail
node scripts/build-desktop-artifact.ts \
Expand All@@ -492,6 +531,30 @@ jobs:
fi
echo "No app-update.yml packaged."

# Issue #53's compensating control, and the reason the exclusion list above is safe to grow.
#
# The fork now excludes roughly half the asar. The failure mode of one bad glob is a
# MODULE_NOT_FOUND thrown by a shipped app, on a path that may not run until a user signs in,
# days after a green release. So this reads the artifact that is about to be published, resolves
# every bare import in the packaged first-party bundles against what actually survived, and fails
# if any of them is not loadable — whether or not a fork glob can be blamed for it. Severity does
# not depend on attribution: a bundle that imports what it does not contain is broken either way,
# and an earlier draft that warned on unattributed gaps passed a build that could not start.
#
# Runs on BOTH platforms: the Windows bundle unpacks node_modules outside the asar (the checker
# merges app.asar.unpacked back in) and its graph differs (WSL backend, Linux fff binaries), so a
# mac-only check would not cover it.
- name: Verify the packaged bundle still resolves
shell: bash
run: |
set -euo pipefail
asar="$(find release -name "app.asar" -print -quit)"
if [[ -z "$asar" ]]; then
echo "::error::No app.asar found under release/. Nothing was verified." >&2
exit 1
fi
node scripts/coil/verify-desktop-bundle.mjs --asar "$asar"

# The machine-checkable form of "this update will not re-ask for permissions" (issue #70),
# made against the .app inside the shipped .dmg rather than a staging copy.
#
Expand Down
4 changes: 2 additions & 2 deletions docs/coil/SEAMS.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@

**The authoritative list of every upstream-owned file this fork edits.**

Measured, not asserted: **48 upstream-owned files, +2281 / -1068 lines**, against merge-base
Measured, not asserted: **48 upstream-owned files, +2302 / -1068 lines**, against merge-base
`78f462c4e` (upstream v0.0.33, the 2026-08-10 sync). Everything else the fork adds lives in new
files upstream has never seen and cannot conflict.

Expand DownExpand Up@@ -284,7 +284,7 @@ Sorted by risk, worst first.
| `apps/desktop/src/preload.ts` | +29/-0 | 14 | **406** | `showNotification` + `onNotificationActivated` on the exposed bridge, plus the `t3xUpdate` bridge object (get / subscribe / restart / dismiss) |
| `packages/contracts/src/settings.ts` | +7/-2 | 23 | **207** | `notifyOnNeedsInput` (**persisted schema**) + Claude `homePath` placeholder/description |
| `apps/mobile/modules/t3-composer-editor/ios/T3ComposerEditorView.swift` | +33/-0 | 6 | **198** | Shift+Return newline vs. bare Return submit |
| `scripts/build-desktop-artifact.ts` | +11/-1 | 15 | **180** | Issue #70: `DESKTOP_APP_ID` reads `process.env.T3X_DESKTOP_APP_ID` before falling back to upstream's `com.t3tools.t3code`, so the fork's app owns its own TCC permission rows instead of sharing them with upstream's nightly. Ten of the eleven added lines are the comment explaining that. An env hook rather than a changed literal on purpose: the literal would also have broken three upstream assertions in `build-desktop-artifact.test.ts` and cost a second row. Guarded from the fork side by `scripts/coil/mac-signature.test.ts` (the hook exists and the release workflow sets it) and by `scripts/coil/verify-mac-signature.ts` (the shipped artifact carries the expected identifier) |
| `scripts/build-desktop-artifact.ts` | +32/-1 | 15 | **180** | **Two env hooks, one displaced line, no new deletions.** Issue #70: `DESKTOP_APP_ID` reads `process.env.T3X_DESKTOP_APP_ID` before falling back to upstream's `com.t3tools.t3code`, so the fork's app owns its own TCC permission rows instead of sharing them with upstream's nightly. Issue #53: `DESKTOP_FILE_EXCLUSIONS` appends `process.env.T3X_DESKTOP_FILE_EXCLUSIONS` (comma-separated globs), taking the packaged asar from 189.66 MiB / 14,765 files to 99.02 MiB / 3,429 and the `.zip` users download by 20.1 MB. Most of the added lines are the comments explaining both. Env hooks rather than changed literals on purpose. For #53 the reason is not row count — `build-desktop-artifact.test.ts` is already a row (see #71 above) — but that the fork's list is **67 globs and grows**: an inline list would make every future size fix an edit to an upstream TEST assertion, resolved by hand at every sync. Through the environment, an unset environment packages precisely what upstream packages and upstream's `deepStrictEqual` keeps passing untouched. Guarded from the fork side by `scripts/coil/mac-signature.test.ts` and `scripts/coil/desktop-bundle-size.test.ts` (both hooks exist, the release workflow sets them, the exclusions never name a package the main process loads) and by two artifact checks: `verify-mac-signature.ts` and `verify-desktop-bundle.mjs` (the shipped app still resolves every import its own bundles make) |
| `apps/desktop/src/backend/DesktopBackendConfiguration.ts` | +29/-0 | 6 | **174** | Backend heap headroom (`NODE_OPTIONS`) |
| `apps/desktop/src/backend/DesktopBackendConfiguration.test.ts` | +42/-0 | 4 | **168** | Heap-headroom assertions |
| `apps/desktop/src/main.ts` | +9/-0 | 18 | **162** | `ElectronNotification` layer + the `T3xUpdateDelivery` layer |
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions .github/workflows/coil-release.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -389,6 +389,19 @@ jobs:
# process that resets the limit to its default of 4, so the serialisation would be a no-op.
- name: Build desktop bundle (serialised)
shell: bash
env:
# Issue #53. The web renderer's source maps were 37.4 MiB of a 189.66 MiB app.asar — the
# single largest line item in the bundle, and 20% of what every user downloads on every
# update. Nothing reads them: a `.map` is only parsed with --enable-source-maps, which the
# desktop backend passes through rather than sets (DesktopBackendConfiguration.ts), and
# renderer maps are DevTools-only.
#
# This is an EXISTING upstream variable (apps/web/vite.config.ts), which is why the biggest
# single win in the issue costs zero seam rows. First-party maps outside the renderer —
# bin.mjs.map and main.cjs.map, ~12 MiB — are deliberately still built and still shipped, so
# an operator who exports NODE_OPTIONS=--enable-source-maps keeps readable stack traces for
# our own code.
T3CODE_WEB_SOURCEMAP: "0"
run: |
set -uo pipefail

Expand DownExpand Up@@ -438,6 +451,29 @@ jobs:
echo "::error::build:desktop failed three times with transient process-startup errors." >&2
exit 1

# Issue #53. Kept in its own step so the exact glob list appears in the release log: the list is
# the risky part of the packaging change, and reading it back out of a failed build matters more
# than saving a step. scripts/coil/desktop-file-exclusions.mjs is the single source — it also
# feeds its own unit tests.
#
# A STEP OUTPUT, NOT $GITHUB_ENV, and that is deliberate. Upstream's own test asserts
# DESKTOP_FILE_EXCLUSIONS deep-equals exactly its one entry, so any job-wide export of this
# variable makes `vp test` fail in that job with a confusing 68-vs-1 array diff. An output is
# consumed by exactly the one step that names it below.
- name: Resolve desktop bundle exclusions
id: exclusions
shell: bash
run: |
set -euo pipefail
exclusions="$(node scripts/coil/desktop-file-exclusions.mjs)"
if [[ -z "$exclusions" ]]; then
echo "::error::scripts/coil/desktop-file-exclusions.mjs produced an empty list." >&2
exit 1
fi
echo "value=$exclusions" >> "$GITHUB_OUTPUT"
echo "Excluding from the asar:"
tr ',' '\n' <<< "$exclusions" | sed 's/^/ /'

- name: Build desktop artifact
shell: bash
env:
Expand DownExpand Up@@ -468,6 +504,9 @@ jobs:
# Keep this in step with DESKTOP_BUNDLE_IDENTIFIER in scripts/coil/mac-signature.ts; a test
# asserts the two agree, and the verify step below fails an artifact carrying the wrong id.
T3X_DESKTOP_APP_ID: dev.curlycloud.t3coil
# Issue #53. Takes the packaged asar from 189.66 MiB / 14,765 files to 99.02 MiB / 3,429.
# Scoped to this step on purpose — see the note on the step that produces it.
T3X_DESKTOP_FILE_EXCLUSIONS: ${{ steps.exclusions.outputs.value }}
run: |
set -euo pipefail
node scripts/build-desktop-artifact.ts \
Expand All@@ -492,6 +531,30 @@ jobs:
fi
echo "No app-update.yml packaged."

# Issue #53's compensating control, and the reason the exclusion list above is safe to grow.
#
# The fork now excludes roughly half the asar. The failure mode of one bad glob is a
# MODULE_NOT_FOUND thrown by a shipped app, on a path that may not run until a user signs in,
# days after a green release. So this reads the artifact that is about to be published, resolves
# every bare import in the packaged first-party bundles against what actually survived, and fails
# if any of them is not loadable — whether or not a fork glob can be blamed for it. Severity does
# not depend on attribution: a bundle that imports what it does not contain is broken either way,
# and an earlier draft that warned on unattributed gaps passed a build that could not start.
#
# Runs on BOTH platforms: the Windows bundle unpacks node_modules outside the asar (the checker
# merges app.asar.unpacked back in) and its graph differs (WSL backend, Linux fff binaries), so a
# mac-only check would not cover it.
- name: Verify the packaged bundle still resolves
shell: bash
run: |
set -euo pipefail
asar="$(find release -name "app.asar" -print -quit)"
if [[ -z "$asar" ]]; then
echo "::error::No app.asar found under release/. Nothing was verified." >&2
exit 1
fi
node scripts/coil/verify-desktop-bundle.mjs --asar "$asar"

# The machine-checkable form of "this update will not re-ask for permissions" (issue #70),
# made against the .app inside the shipped .dmg rather than a staging copy.
#
Expand Down
4 changes: 2 additions & 2 deletions docs/coil/SEAMS.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,7 +2,7 @@

**The authoritative list of every upstream-owned file this fork edits.**

Measured, not asserted: **48 upstream-owned files, +2281 / -1068 lines**, against merge-base
Measured, not asserted: **48 upstream-owned files, +2302 / -1068 lines**, against merge-base
`78f462c4e` (upstream v0.0.33, the 2026-08-10 sync). Everything else the fork adds lives in new
files upstream has never seen and cannot conflict.

Expand DownExpand Up@@ -284,7 +284,7 @@ Sorted by risk, worst first.
| `apps/desktop/src/preload.ts` | +29/-0 | 14 | **406** | `showNotification` + `onNotificationActivated` on the exposed bridge, plus the `t3xUpdate` bridge object (get / subscribe / restart / dismiss) |
| `packages/contracts/src/settings.ts` | +7/-2 | 23 | **207** | `notifyOnNeedsInput` (**persisted schema**) + Claude `homePath` placeholder/description |
| `apps/mobile/modules/t3-composer-editor/ios/T3ComposerEditorView.swift` | +33/-0 | 6 | **198** | Shift+Return newline vs. bare Return submit |
| `scripts/build-desktop-artifact.ts` | +11/-1 | 15 | **180** | Issue #70: `DESKTOP_APP_ID` reads `process.env.T3X_DESKTOP_APP_ID` before falling back to upstream's `com.t3tools.t3code`, so the fork's app owns its own TCC permission rows instead of sharing them with upstream's nightly. Ten of the eleven added lines are the comment explaining that. An env hook rather than a changed literal on purpose: the literal would also have broken three upstream assertions in `build-desktop-artifact.test.ts` and cost a second row. Guarded from the fork side by `scripts/coil/mac-signature.test.ts` (the hook exists and the release workflow sets it) and by `scripts/coil/verify-mac-signature.ts` (the shipped artifact carries the expected identifier) |
| `scripts/build-desktop-artifact.ts` | +32/-1 | 15 | **180** | **Two env hooks, one displaced line, no new deletions.** Issue #70: `DESKTOP_APP_ID` reads `process.env.T3X_DESKTOP_APP_ID` before falling back to upstream's `com.t3tools.t3code`, so the fork's app owns its own TCC permission rows instead of sharing them with upstream's nightly. Issue #53: `DESKTOP_FILE_EXCLUSIONS` appends `process.env.T3X_DESKTOP_FILE_EXCLUSIONS` (comma-separated globs), taking the packaged asar from 189.66 MiB / 14,765 files to 99.02 MiB / 3,429 and the `.zip` users download by 20.1 MB. Most of the added lines are the comments explaining both. Env hooks rather than changed literals on purpose. For #53 the reason is not row count — `build-desktop-artifact.test.ts` is already a row (see #71 above) — but that the fork's list is **67 globs and grows**: an inline list would make every future size fix an edit to an upstream TEST assertion, resolved by hand at every sync. Through the environment, an unset environment packages precisely what upstream packages and upstream's `deepStrictEqual` keeps passing untouched. Guarded from the fork side by `scripts/coil/mac-signature.test.ts` and `scripts/coil/desktop-bundle-size.test.ts` (both hooks exist, the release workflow sets them, the exclusions never name a package the main process loads) and by two artifact checks: `verify-mac-signature.ts` and `verify-desktop-bundle.mjs` (the shipped app still resolves every import its own bundles make) |
| `apps/desktop/src/backend/DesktopBackendConfiguration.ts` | +29/-0 | 6 | **174** | Backend heap headroom (`NODE_OPTIONS`) |
| `apps/desktop/src/backend/DesktopBackendConfiguration.test.ts` | +42/-0 | 4 | **168** | Heap-headroom assertions |
| `apps/desktop/src/main.ts` | +9/-0 | 18 | **162** | `ElectronNotification` layer + the `T3xUpdateDelivery` layer |
Expand Down
Loading
Loading