This repository was archived by the owner on Oct 8, 2025. It is now read-only.
Focalpoint - #19
Merged
Merged
Conversation
artnez
commented
Nov 13, 2014
ContributorAuthor
Ready to merge. |
Open
artnez
commented
Nov 18, 2014
ContributorAuthor
Hey so this is ready to go but it's missing docs. Once we get through the rounds of pull requests we I think we should rewrite the docs. There needs to be a separate section for URL parameters. There will be more and more features that only have a URL parameter (like this one). |
artnez
commented
Nov 21, 2014
ContributorAuthor
ping |
rafikk
commented
Nov 21, 2014
Owner
Can you rebase off the current HEAD? The auto-orientation changes seem to be in here as well. |
artnez
commented
Nov 25, 2014
ContributorAuthor
ping |
Owner
There was a problem hiding this comment.
Shouldn't we return Focalpoint{0.5, 0.5} if either ParseFloat calls fail?
rafikk
commented
Dec 6, 2014
Owner
Sorry for the delay in looking at this. Just a couple minor comments. |
artnez
commented
Dec 6, 2014
ContributorAuthor
np, thanks for the feedback! |
artnez
commented
Dec 12, 2014
ContributorAuthor
ping |
rafikk
commented
Jan 8, 2015
Owner
LGTM. Sorry for the delay. |
rafikk added a commit
that referenced
this pull request
Jan 8, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(note: this PR is dependent on #17 and #20)