stabilize cold streaming smoke test - #155
Merged
Merged
Conversation
The streaming smoke test used a 500 ms deadlock guard around construction of all provider clients, application setup, lazy tokenizer initialization, and the HTTP streaming handshake. Measured cold initialization takes roughly 1.4 to 1.6 seconds on macOS: native-root client construction accounts for about 0.9 seconds and first-use tokenizer setup takes about 0.5 seconds. Use a three-second outer guard so the test accommodates measured cold setup with CI scheduling margin. The upstream terminal event remains blocked by the fixture's notification gate, so returning headers still proves streaming starts before upstream completion. Keep the separate 200 ms first-frame assertion unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTTP streaming smoke test's 500 ms header timeout includes cold provider and tokenizer initialization. That can exceed the limit before streaming starts, especially with native certificate loading.
Raise only that outer deadlock guard to 3 seconds. The 200 ms first-frame assertion stays unchanged, and upstream completion remains blocked until headers and the first frame have arrived.
Validation: the tracked pre-commit hook passed formatting, Clippy, build, and all 1,039 tests. The adjusted test also passed 3 fresh-process diagnostic runs.