Skip to content

ci: drop snapshot-generate-cmd from package-release - #145

Merged
thedavidmeister merged 1 commit into
mainfrom
2026-08-21-drop-snapshot-generate-cmd
Aug 21, 2026
Merged

ci: drop snapshot-generate-cmd from package-release#145
thedavidmeister merged 1 commit into
mainfrom
2026-08-21-drop-snapshot-generate-cmd

Conversation

@thedavidmeister

@thedavidmeisterthedavidmeister commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

rainlanguage/rainix#343 removes the snapshot-generate-cmd input from the
rainix-tag-release reusable workflow. This repo's package-release.yaml
references that workflow at @main and passes the input explicitly, so the
moment #343 merges every sol-v* tag here fails with Invalid input, snapshot-generate-cmd is not defined in the referenced workflow and publishes
nothing. Removing the line ahead of that merge makes the two safe in either
order.

This is a no-op today

The value this repo passes is byte-identical to the input's current default on
rainix main:

value
passed hereforge script ./script/Build.sol --sig "cutRelease()" && forge fmt
rainix main defaultforge script ./script/Build.sol --sig "cutRelease()" && forge fmt

So the release runs the same command with the line and without it — this PR
changes no release behaviour on its own. After #343 the workflow runs the
non-freezing run() entry point instead; that behaviour change belongs to
#343 and lands whether or not this line is still here.

soldeer-package is the only with: key left, and #343 does not touch it.

QA

  • Discriminating tests: n/a - the diff deletes one YAML line from a caller
    workflow. The behaviour it used to select (which command the release runs)
    lives in rainix-tag-release, not in this repo, and is unit-tested there by
    #343. The only claim this PR makes that is checkable here is the
    value/default equivalence, verified under Oracle below.
  • Mutations applied: n/a - ran
    nix run github:rainlanguage/adversarial-mutation-test#mutation-probe -- mutants.toml,
    which reports error: cannot read mutants.toml. This repo has no
    mutants.toml and the diff touches no Solidity or Rust source, so there is
    nothing to mutate.
  • Oracle: .on.workflow_call.inputs["snapshot-generate-cmd"].default in
    .github/workflows/rainix-tag-release.yaml at rainlanguage/rainix@main -
    read from upstream rather than restated from the issue. Both that default and
    this repo's passed value were parsed with yq (not eyeballed, so YAML
    quoting cannot fool the comparison) and are the identical string. That
    equivalence is what makes the deletion a no-op. Independently,
    actionlint on the edited file is clean, and the only with: key left,
    soldeer-package, is a declared and required input both today and after
    #343.
  • Category check: #344 asks this repo to drop the line; covered. The remaining
    four callers and the RAINIX_SHA bump are separate items on the same issue,
    so this is Refs, not Closes.

Not run

  • The repo's own rainix-sol suite was not run locally - forge is not
    available in the authoring environment. It runs on this PR in CI, and no
    Solidity changed.
  • The release path itself cannot be exercised outside a real sol-v* tag push,
    so the end-to-end proof for this line is #343's own end-to-end evidence plus
    the string equivalence above.

Part of rainlanguage/rainix#344, which tracks all five callers plus the
RAINIX_SHA bump - this PR is one of them and does not close it.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Streamlined the package release process by removing unnecessary automated steps.

rainlanguage/rainix#343 removes the `snapshot-generate-cmd` input from
`rainix-tag-release` entirely. This workflow references that reusable at
`@main` and passes the input explicitly, so the moment #343 merges every
`sol-v*` tag here fails with an unexpected-input error and publishes nothing.
Dropping the line now is a no-op: the value passed here is byte-identical to
the input's current default on rainix `main`, so the release runs the same
command before and after this commit. That makes the two merges safe in either
order.
Refs rainlanguage/rainix#344
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Aug 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 40986eac-f312-4456-b14b-0e4641547917

📥 Commits

Reviewing files that changed from the base of the PR and between f702d6e and 2b41645.

📒 Files selected for processing (1)
  • .github/workflows/package-release.yaml
💤 Files with no reviewable changes (1)
  • .github/workflows/package-release.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The package release workflow no longer runs the snapshot-generate-cmd Forge script or the subsequent forge fmt command.

Changes

Package release workflow

Layer / File(s)Summary
Remove snapshot generation command
.github/workflows/package-release.yaml
The release workflow no longer executes Build.sol’s cutRelease() script or forge fmt.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk:⚪ Minimal · up to 2b416

This localized workflow cleanup removes an input that matches the release workflow’s current default and does not change release behavior on its own. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the removal of snapshot-generate-cmd from the package release workflow.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-08-21-drop-snapshot-generate-cmd

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thedavidmeister
thedavidmeister merged commit c6fcd18 into mainAug 21, 2026
4 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@thedavidmeister