Uh oh!
There was an error while loading. Please reload this page.
ci: drop snapshot-generate-cmd from package-release - #145
Conversation
rainlanguage/rainix#343 removes the `snapshot-generate-cmd` input from `rainix-tag-release` entirely. This workflow references that reusable at `@main` and passes the input explicitly, so the moment #343 merges every `sol-v*` tag here fails with an unexpected-input error and publishes nothing. Dropping the line now is a no-op: the value passed here is byte-identical to the input's current default on rainix `main`, so the release runs the same command before and after this commit. That makes the two merges safe in either order. Refs rainlanguage/rainix#344 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe package release workflow no longer runs the ChangesPackage release workflow
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk:⚪ Minimal · up to This localized workflow cleanup removes an input that matches the release workflow’s current default and does not change release behavior on its own. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Uh oh!
There was an error while loading. Please reload this page.
rainlanguage/rainix#343 removes the
snapshot-generate-cmdinput from therainix-tag-releasereusable workflow. This repo'spackage-release.yamlreferences that workflow at
@mainand passes the input explicitly, so themoment #343 merges every
sol-v*tag here fails withInvalid input, snapshot-generate-cmd is not defined in the referenced workflowand publishesnothing. Removing the line ahead of that merge makes the two safe in either
order.
This is a no-op today
The value this repo passes is byte-identical to the input's current default on
rainix
main:forge script ./script/Build.sol --sig "cutRelease()" && forge fmtmaindefaultforge script ./script/Build.sol --sig "cutRelease()" && forge fmtSo the release runs the same command with the line and without it — this PR
changes no release behaviour on its own. After #343 the workflow runs the
non-freezing
run()entry point instead; that behaviour change belongs to#343 and lands whether or not this line is still here.
soldeer-packageis the onlywith:key left, and #343 does not touch it.QA
workflow. The behaviour it used to select (which command the release runs)
lives in
rainix-tag-release, not in this repo, and is unit-tested there by#343. The only claim this PR makes that is checkable here is the
value/default equivalence, verified under Oracle below.
nix run github:rainlanguage/adversarial-mutation-test#mutation-probe -- mutants.toml,which reports
error: cannot read mutants.toml. This repo has nomutants.tomland the diff touches no Solidity or Rust source, so there isnothing to mutate.
.on.workflow_call.inputs["snapshot-generate-cmd"].defaultin.github/workflows/rainix-tag-release.yamlatrainlanguage/rainix@main-read from upstream rather than restated from the issue. Both that default and
this repo's passed value were parsed with
yq(not eyeballed, so YAMLquoting cannot fool the comparison) and are the identical string. That
equivalence is what makes the deletion a no-op. Independently,
actionlinton the edited file is clean, and the onlywith:key left,soldeer-package, is a declared and required input both today and after#343.
four callers and the
RAINIX_SHAbump are separate items on the same issue,so this is Refs, not Closes.
Not run
rainix-solsuite was not run locally -forgeis notavailable in the authoring environment. It runs on this PR in CI, and no
Solidity changed.
sol-v*tag push,so the end-to-end proof for this line is #343's own end-to-end evidence plus
the string equivalence above.
Part of rainlanguage/rainix#344, which tracks all five callers plus the
RAINIX_SHAbump - this PR is one of them and does not close it.🤖 Generated with Claude Code
Summary by CodeRabbit