Skip to content

Drop foundry.toml release metadata: version intent lives in next-v tags (rainix#335) - #261

Open
thedavidmeister wants to merge 1 commit into
mainfrom
2026-08-19-drop-release-metadata
Open

Drop foundry.toml release metadata: version intent lives in next-v tags (rainix#335)#261
thedavidmeister wants to merge 1 commit into
mainfrom
2026-08-19-drop-release-metadata

Conversation

@thedavidmeister

@thedavidmeisterthedavidmeister commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Drops the legacy [package] release-metadata section from foundry.toml, per the ruling on rainlanguage/rainix#335. Since rainlanguage/rainix#336 merged, rainix-autopublish derives the publish version from the Soldeer registry + next-v* git tags and never reads this section, and the publish gate excludes the section (including any attached comment block) from the content hash — so this deletion is content-neutral: it cannot mint a spurious release and changes no behavior. Verified locally: nix develop -c reuse lint (compliant), forge soldeer install, then forge test: 504 passed, 7 failed — all 7 failures are independent of this diff. 5 are testProdDeployment* fork tests failing only on locally missing RPC env vars (CI supplies them). The other 2 reproduce byte-for-byte with this diff reverted (re-ran against origin/main's foundry.toml): testRoundTripFuzzPow (unexpected pow revert on fuzz counterexample args [0x36c2361a37552a3301515f9274db60e6fdc00f971fbd0475fd9c284986634e56, 0x00000003b58e88c75313ec9d329eaaa18fb92f75215b17100000000000000001]) and testAllPublishedSoldeerTagsHaveAFullConstantSuite (live registry has 0.1.7 published but LibDecimalFloatDeploy.sol lacks the *_0_1_7 pinned constants; the FFI script reads the registry + that lib, never foundry.toml). Both look like real pre-existing main issues worth their own tickets, not artifacts of this change.

QA

  • Discriminating tests: n/a - config-metadata deletion; nothing reads the section since rainix#336 (local nix develop -c forge test: 504 passed; 7 pre-existing/env failures reproduced identically on the unmodified baseline; reuse lint compliant)
  • Mutations applied: n/a - no code changed
  • Oracle: rainix#336 gate semantics (section excluded from content hash; version from registry + next-v tags)
  • Category check: issue asks removal of release metadata from consumers; covered exactly for this repo

Summary by CodeRabbit

  • Chores
    • Removed package metadata from the project configuration.
    • Existing build, dependency, network, and verification settings remain unchanged.

…gs (rainix#335)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@thedavidmeisterthedavidmeister self-assigned this Aug 19, 2026
@coderabbitai

coderabbitaiBot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e967bed8-a2ba-445d-859b-2b861861133f

📥 Commits

Reviewing files that changed from the base of the PR and between d3fb611 and bd6cd14.

📒 Files selected for processing (1)
  • foundry.toml
💤 Files with no reviewable changes (1)
  • foundry.toml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The change removes the [package] metadata block from foundry.toml. All other Foundry settings remain unchanged.

Changes

Cohort / File(s)Summary
Foundry configuration
foundry.toml
Removes the project name and version metadata while preserving profiles, dependencies, RPC settings, and verification settings.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk:⚪ Minimal · up to bd6cd

This localized configuration cleanup removes unused release metadata without changing runtime behavior; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the removal of release metadata and the use of tags for version intent.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-08-19-drop-release-metadata

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@thedavidmeister