Uh oh!
There was an error while loading. Please reload this page.
Drop foundry.toml release metadata: version intent lives in next-v tags (rainix#335) - #261
Drop foundry.toml release metadata: version intent lives in next-v tags (rainix#335)#261thedavidmeister wants to merge 1 commit into
Conversation
…gs (rainix#335) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe change removes the Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk:⚪ Minimal · up to This localized configuration cleanup removes unused release metadata without changing runtime behavior; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Drops the legacy
[package]release-metadata section from foundry.toml, per the ruling on rainlanguage/rainix#335. Since rainlanguage/rainix#336 merged, rainix-autopublish derives the publish version from the Soldeer registry +next-v*git tags and never reads this section, and the publish gate excludes the section (including any attached comment block) from the content hash — so this deletion is content-neutral: it cannot mint a spurious release and changes no behavior. Verified locally:nix develop -c reuse lint(compliant),forge soldeer install, thenforge test: 504 passed, 7 failed — all 7 failures are independent of this diff. 5 aretestProdDeployment*fork tests failing only on locally missing RPC env vars (CI supplies them). The other 2 reproduce byte-for-byte with this diff reverted (re-ran against origin/main's foundry.toml):testRoundTripFuzzPow(unexpected pow revert on fuzz counterexample args[0x36c2361a37552a3301515f9274db60e6fdc00f971fbd0475fd9c284986634e56, 0x00000003b58e88c75313ec9d329eaaa18fb92f75215b17100000000000000001]) andtestAllPublishedSoldeerTagsHaveAFullConstantSuite(live registry has 0.1.7 published butLibDecimalFloatDeploy.sollacks the*_0_1_7pinned constants; the FFI script reads the registry + that lib, never foundry.toml). Both look like real pre-existing main issues worth their own tickets, not artifacts of this change.QA
nix develop -c forge test: 504 passed; 7 pre-existing/env failures reproduced identically on the unmodified baseline;reuse lintcompliant)Summary by CodeRabbit