Fix typo in Reparing - #1

Open
randomstep wants to merge 1 commit into
swift-3-api-guidelinesfrom
randomstep-reparing-typo
Open

Fix typo in Reparing#1
randomstep wants to merge 1 commit into
swift-3-api-guidelinesfrom
randomstep-reparing-typo

Conversation

@randomstep

Copy link
Copy Markdown
Owner

What's in this pull request?

Fixes a typo in CString. Reparing -> Repairing

Resolved bug number: (SR-)

NA


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

PlatformComment
All supported platforms@swift-ci Please smoke test
OS X platform@swift-ci Please smoke test OS X platform
Linux platform@swift-ci Please smoke test Linux platform

Validation Testing

PlatformComment
All supported platforms@swift-ci Please test
OS X platform@swift-ci Please test OS X platform
Linux platform@swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

randomstep pushed a commit that referenced this pull request Jan 19, 2018
Add test case for crash triggered in `swift::Type`.
Current number of unresolved compiler crashers: 55 (5619 resolved)
/cc @slavapestov - just wanted to let you know that this crasher caused an assertion failure for the assertion `known != typeBindings.end()` added on 2017-01-19 by you in commit 8de0ca5 :-)
Assertion failure in [`lib/Sema/ConstraintSystem.cpp (line 1807)`](https://github.com/apple/swift/blob/08c4f5106ba8f5ecfafa43de2b922a03dd6c9a2b/lib/Sema/ConstraintSystem.cpp#L1807):
```
Assertion `known != typeBindings.end()' failed.
When executing: auto swift::constraints::Solution::simplifyType(swift::Type)::(anonymous class)::operator()(swift::TypeVariableType *) const
```
Assertion context:
```c++
// Map type variables to fixed types from bindings.
return simplifyTypeImpl(
getConstraintSystem(), type,
[&](TypeVariableType *tvt) -> Type {
auto known = typeBindings.find(tvt);
assert(known != typeBindings.end());
return known->second;
});
}
size_t Solution::getTotalMemory() const {
```
Stack trace:
```
0 0x0000000003f3abd4 PrintStackTraceSignalHandler(void*) (/path/to/swift/bin/swift+0x3f3abd4)
1 0x0000000003f3af16 SignalHandler(int) (/path/to/swift/bin/swift+0x3f3af16)
2 0x00007f53ba016390 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x11390)
3 0x00007f53b853b428 gsignal /build/glibc-bfm8X4/glibc-2.23/signal/../sysdeps/unix/sysv/linux/raise.c:54:0
4 0x00007f53b853d02a abort /build/glibc-bfm8X4/glibc-2.23/stdlib/abort.c:91:0
5 0x00007f53b8533bd7 __assert_fail_base /build/glibc-bfm8X4/glibc-2.23/assert/assert.c:92:0
6 0x00007f53b8533c82 (/lib/x86_64-linux-gnu/libc.so.6+0x2dc82)
7 0x00000000012c3523 swift::Type llvm::function_ref<swift::Type (swift::Type)>::callback_fn<swift::Type simplifyTypeImpl<swift::constraints::Solution::simplifyType(swift::Type) const::$_7>(swift::constraints::ConstraintSystem&, swift::Type, swift::constraints::Solution::simplifyType(swift::Type) const::$_7)::{lambda(swift::Type)#1}>(long, swift::Type) (/path/to/swift/bin/swift+0x12c3523)
8 0x0000000001755dd6 llvm::Optional<swift::Type> llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>::callback_fn<swift::Type::transform(llvm::function_ref<swift::Type (swift::Type)>) const::$_15>(long, swift::TypeBase*) (/path/to/swift/bin/swift+0x1755dd6)
9 0x000000000174f022 swift::Type::transformRec(llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>) const (/path/to/swift/bin/swift+0x174f022)
10 0x000000000174f25e swift::Type::transformRec(llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>) const (/path/to/swift/bin/swift+0x174f25e)
11 0x000000000174f577 swift::Type::transformRec(llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>) const (/path/to/swift/bin/swift+0x174f577)
12 0x0000000001743b07 swift::Type::transform(llvm::function_ref<swift::Type (swift::Type)>) const (/path/to/swift/bin/swift+0x1743b07)
13 0x00000000012c08bf swift::constraints::Solution::simplifyType(swift::Type) const (/path/to/swift/bin/swift+0x12c08bf)
14 0x00000000012d7181 swift::TypeChecker::getTypeOfExpressionWithoutApplying(swift::Expr*&, swift::DeclContext*, swift::ConcreteDeclRef&, swift::FreeTypeVariableBinding, swift::ExprTypeCheckListener*) (/path/to/swift/bin/swift+0x12d7181)
15 0x00000000013cb9a8 (anonymous namespace)::FailureDiagnosis::diagnoseParameterErrors(swift::CalleeCandidateInfo&, swift::Expr*, swift::Expr*, llvm::ArrayRef<swift::Identifier>) (/path/to/swift/bin/swift+0x13cb9a8)
16 0x00000000013d1069 (anonymous namespace)::FailureDiagnosis::visitApplyExpr(swift::ApplyExpr*) (/path/to/swift/bin/swift+0x13d1069)
17 0x00000000013b8506 swift::ASTVisitor<(anonymous namespace)::FailureDiagnosis, bool, void, void, void, void, void>::visit(swift::Expr*) (/path/to/swift/bin/swift+0x13b8506)
18 0x00000000013b2282 swift::constraints::ConstraintSystem::diagnoseFailureForExpr(swift::Expr*) (/path/to/swift/bin/swift+0x13b2282)
19 0x00000000013b82c6 swift::constraints::ConstraintSystem::salvage(llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::Expr*) (/path/to/swift/bin/swift+0x13b82c6)
20 0x00000000012d3008 swift::TypeChecker::solveForExpression(swift::Expr*&, swift::DeclContext*, swift::Type, swift::FreeTypeVariableBinding, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem&, llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>) (/path/to/swift/bin/swift+0x12d3008)
21 0x00000000012d6cf2 swift::TypeChecker::typeCheckExpression(swift::Expr*&, swift::DeclContext*, swift::TypeLoc, swift::ContextualTypePurpose, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem*) (/path/to/swift/bin/swift+0x12d6cf2)
22 0x0000000001364886 swift::ASTVisitor<(anonymous namespace)::StmtChecker, void, swift::Stmt*, void, void, void, void>::visit(swift::Stmt*) (/path/to/swift/bin/swift+0x1364886)
23 0x0000000001363956 (anonymous namespace)::StmtChecker::typeCheckBody(swift::BraceStmt*&) (/path/to/swift/bin/swift+0x1363956)
24 0x0000000001362bc1 swift::TypeChecker::typeCheckFunctionBodyUntil(swift::FuncDecl*, swift::SourceLoc) (/path/to/swift/bin/swift+0x1362bc1)
25 0x0000000001362a75 swift::TypeChecker::typeCheckAbstractFunctionBodyUntil(swift::AbstractFunctionDecl*, swift::SourceLoc) (/path/to/swift/bin/swift+0x1362a75)
26 0x0000000001363632 swift::TypeChecker::typeCheckAbstractFunctionBody(swift::AbstractFunctionDecl*) (/path/to/swift/bin/swift+0x1363632)
27 0x0000000001384cee typeCheckFunctionsAndExternalDecls(swift::TypeChecker&) (/path/to/swift/bin/swift+0x1384cee)
28 0x0000000001385abd swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int, unsigned int, unsigned int, unsigned int) (/path/to/swift/bin/swift+0x1385abd)
29 0x00000000010911c4 swift::CompilerInstance::parseAndTypeCheckMainFile(swift::PersistentParserState&, swift::DelayedParsingCallbacks*, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>) (/path/to/swift/bin/swift+0x10911c4)
30 0x000000000109016e swift::CompilerInstance::parseAndCheckTypes(swift::CompilerInstance::ImplicitImports const&) (/path/to/swift/bin/swift+0x109016e)
31 0x000000000108fb1a swift::CompilerInstance::performSema() (/path/to/swift/bin/swift+0x108fb1a)
32 0x00000000004c88de performCompile(swift::CompilerInstance&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*, swift::UnifiedStatsReporter*) (/path/to/swift/bin/swift+0x4c88de)
33 0x00000000004c762a swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x4c762a)
34 0x000000000047ff84 main (/path/to/swift/bin/swift+0x47ff84)
35 0x00007f53b8526830 __libc_start_main /build/glibc-bfm8X4/glibc-2.23/csu/../csu/libc-start.c:325:0
36 0x000000000047d839 _start (/path/to/swift/bin/swift+0x47d839)
```
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@randomstep
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Fix typo in Reparing - #1

Open
randomstep wants to merge 1 commit into
swift-3-api-guidelinesfrom
randomstep-reparing-typo
Open

Fix typo in Reparing#1
randomstep wants to merge 1 commit into
swift-3-api-guidelinesfrom
randomstep-reparing-typo

Conversation

@randomstep

Copy link
Copy Markdown
Owner

What's in this pull request?

Fixes a typo in CString. Reparing -> Repairing

Resolved bug number: (SR-)

NA


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

PlatformComment
All supported platforms@swift-ci Please smoke test
OS X platform@swift-ci Please smoke test OS X platform
Linux platform@swift-ci Please smoke test Linux platform

Validation Testing

PlatformComment
All supported platforms@swift-ci Please test
OS X platform@swift-ci Please test OS X platform
Linux platform@swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

randomstep pushed a commit that referenced this pull request Jan 19, 2018
Add test case for crash triggered in `swift::Type`.
Current number of unresolved compiler crashers: 55 (5619 resolved)
/cc @slavapestov - just wanted to let you know that this crasher caused an assertion failure for the assertion `known != typeBindings.end()` added on 2017-01-19 by you in commit 8de0ca5 :-)
Assertion failure in [`lib/Sema/ConstraintSystem.cpp (line 1807)`](https://github.com/apple/swift/blob/08c4f5106ba8f5ecfafa43de2b922a03dd6c9a2b/lib/Sema/ConstraintSystem.cpp#L1807):
```
Assertion `known != typeBindings.end()' failed.
When executing: auto swift::constraints::Solution::simplifyType(swift::Type)::(anonymous class)::operator()(swift::TypeVariableType *) const
```
Assertion context:
```c++
// Map type variables to fixed types from bindings.
return simplifyTypeImpl(
getConstraintSystem(), type,
[&](TypeVariableType *tvt) -> Type {
auto known = typeBindings.find(tvt);
assert(known != typeBindings.end());
return known->second;
});
}
size_t Solution::getTotalMemory() const {
```
Stack trace:
```
0 0x0000000003f3abd4 PrintStackTraceSignalHandler(void*) (/path/to/swift/bin/swift+0x3f3abd4)
1 0x0000000003f3af16 SignalHandler(int) (/path/to/swift/bin/swift+0x3f3af16)
2 0x00007f53ba016390 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x11390)
3 0x00007f53b853b428 gsignal /build/glibc-bfm8X4/glibc-2.23/signal/../sysdeps/unix/sysv/linux/raise.c:54:0
4 0x00007f53b853d02a abort /build/glibc-bfm8X4/glibc-2.23/stdlib/abort.c:91:0
5 0x00007f53b8533bd7 __assert_fail_base /build/glibc-bfm8X4/glibc-2.23/assert/assert.c:92:0
6 0x00007f53b8533c82 (/lib/x86_64-linux-gnu/libc.so.6+0x2dc82)
7 0x00000000012c3523 swift::Type llvm::function_ref<swift::Type (swift::Type)>::callback_fn<swift::Type simplifyTypeImpl<swift::constraints::Solution::simplifyType(swift::Type) const::$_7>(swift::constraints::ConstraintSystem&, swift::Type, swift::constraints::Solution::simplifyType(swift::Type) const::$_7)::{lambda(swift::Type)#1}>(long, swift::Type) (/path/to/swift/bin/swift+0x12c3523)
8 0x0000000001755dd6 llvm::Optional<swift::Type> llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>::callback_fn<swift::Type::transform(llvm::function_ref<swift::Type (swift::Type)>) const::$_15>(long, swift::TypeBase*) (/path/to/swift/bin/swift+0x1755dd6)
9 0x000000000174f022 swift::Type::transformRec(llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>) const (/path/to/swift/bin/swift+0x174f022)
10 0x000000000174f25e swift::Type::transformRec(llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>) const (/path/to/swift/bin/swift+0x174f25e)
11 0x000000000174f577 swift::Type::transformRec(llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>) const (/path/to/swift/bin/swift+0x174f577)
12 0x0000000001743b07 swift::Type::transform(llvm::function_ref<swift::Type (swift::Type)>) const (/path/to/swift/bin/swift+0x1743b07)
13 0x00000000012c08bf swift::constraints::Solution::simplifyType(swift::Type) const (/path/to/swift/bin/swift+0x12c08bf)
14 0x00000000012d7181 swift::TypeChecker::getTypeOfExpressionWithoutApplying(swift::Expr*&, swift::DeclContext*, swift::ConcreteDeclRef&, swift::FreeTypeVariableBinding, swift::ExprTypeCheckListener*) (/path/to/swift/bin/swift+0x12d7181)
15 0x00000000013cb9a8 (anonymous namespace)::FailureDiagnosis::diagnoseParameterErrors(swift::CalleeCandidateInfo&, swift::Expr*, swift::Expr*, llvm::ArrayRef<swift::Identifier>) (/path/to/swift/bin/swift+0x13cb9a8)
16 0x00000000013d1069 (anonymous namespace)::FailureDiagnosis::visitApplyExpr(swift::ApplyExpr*) (/path/to/swift/bin/swift+0x13d1069)
17 0x00000000013b8506 swift::ASTVisitor<(anonymous namespace)::FailureDiagnosis, bool, void, void, void, void, void>::visit(swift::Expr*) (/path/to/swift/bin/swift+0x13b8506)
18 0x00000000013b2282 swift::constraints::ConstraintSystem::diagnoseFailureForExpr(swift::Expr*) (/path/to/swift/bin/swift+0x13b2282)
19 0x00000000013b82c6 swift::constraints::ConstraintSystem::salvage(llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::Expr*) (/path/to/swift/bin/swift+0x13b82c6)
20 0x00000000012d3008 swift::TypeChecker::solveForExpression(swift::Expr*&, swift::DeclContext*, swift::Type, swift::FreeTypeVariableBinding, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem&, llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>) (/path/to/swift/bin/swift+0x12d3008)
21 0x00000000012d6cf2 swift::TypeChecker::typeCheckExpression(swift::Expr*&, swift::DeclContext*, swift::TypeLoc, swift::ContextualTypePurpose, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem*) (/path/to/swift/bin/swift+0x12d6cf2)
22 0x0000000001364886 swift::ASTVisitor<(anonymous namespace)::StmtChecker, void, swift::Stmt*, void, void, void, void>::visit(swift::Stmt*) (/path/to/swift/bin/swift+0x1364886)
23 0x0000000001363956 (anonymous namespace)::StmtChecker::typeCheckBody(swift::BraceStmt*&) (/path/to/swift/bin/swift+0x1363956)
24 0x0000000001362bc1 swift::TypeChecker::typeCheckFunctionBodyUntil(swift::FuncDecl*, swift::SourceLoc) (/path/to/swift/bin/swift+0x1362bc1)
25 0x0000000001362a75 swift::TypeChecker::typeCheckAbstractFunctionBodyUntil(swift::AbstractFunctionDecl*, swift::SourceLoc) (/path/to/swift/bin/swift+0x1362a75)
26 0x0000000001363632 swift::TypeChecker::typeCheckAbstractFunctionBody(swift::AbstractFunctionDecl*) (/path/to/swift/bin/swift+0x1363632)
27 0x0000000001384cee typeCheckFunctionsAndExternalDecls(swift::TypeChecker&) (/path/to/swift/bin/swift+0x1384cee)
28 0x0000000001385abd swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int, unsigned int, unsigned int, unsigned int) (/path/to/swift/bin/swift+0x1385abd)
29 0x00000000010911c4 swift::CompilerInstance::parseAndTypeCheckMainFile(swift::PersistentParserState&, swift::DelayedParsingCallbacks*, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>) (/path/to/swift/bin/swift+0x10911c4)
30 0x000000000109016e swift::CompilerInstance::parseAndCheckTypes(swift::CompilerInstance::ImplicitImports const&) (/path/to/swift/bin/swift+0x109016e)
31 0x000000000108fb1a swift::CompilerInstance::performSema() (/path/to/swift/bin/swift+0x108fb1a)
32 0x00000000004c88de performCompile(swift::CompilerInstance&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*, swift::UnifiedStatsReporter*) (/path/to/swift/bin/swift+0x4c88de)
33 0x00000000004c762a swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x4c762a)
34 0x000000000047ff84 main (/path/to/swift/bin/swift+0x47ff84)
35 0x00007f53b8526830 __libc_start_main /build/glibc-bfm8X4/glibc-2.23/csu/../csu/libc-start.c:325:0
36 0x000000000047d839 _start (/path/to/swift/bin/swift+0x47d839)
```
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@randomstep
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix typo in Reparing - #1

Open
randomstep wants to merge 1 commit into
swift-3-api-guidelinesfrom
randomstep-reparing-typo
Open

Fix typo in Reparing#1
randomstep wants to merge 1 commit into
swift-3-api-guidelinesfrom
randomstep-reparing-typo

Conversation

@randomstep

Copy link
Copy Markdown
Owner

What's in this pull request?

Fixes a typo in CString. Reparing -> Repairing

Resolved bug number: (SR-)

NA


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

PlatformComment
All supported platforms@swift-ci Please smoke test
OS X platform@swift-ci Please smoke test OS X platform
Linux platform@swift-ci Please smoke test Linux platform

Validation Testing

PlatformComment
All supported platforms@swift-ci Please test
OS X platform@swift-ci Please test OS X platform
Linux platform@swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

randomstep pushed a commit that referenced this pull request Jan 19, 2018
Add test case for crash triggered in `swift::Type`.
Current number of unresolved compiler crashers: 55 (5619 resolved)
/cc @slavapestov - just wanted to let you know that this crasher caused an assertion failure for the assertion `known != typeBindings.end()` added on 2017-01-19 by you in commit 8de0ca5 :-)
Assertion failure in [`lib/Sema/ConstraintSystem.cpp (line 1807)`](https://github.com/apple/swift/blob/08c4f5106ba8f5ecfafa43de2b922a03dd6c9a2b/lib/Sema/ConstraintSystem.cpp#L1807):
```
Assertion `known != typeBindings.end()' failed.
When executing: auto swift::constraints::Solution::simplifyType(swift::Type)::(anonymous class)::operator()(swift::TypeVariableType *) const
```
Assertion context:
```c++
// Map type variables to fixed types from bindings.
return simplifyTypeImpl(
getConstraintSystem(), type,
[&](TypeVariableType *tvt) -> Type {
auto known = typeBindings.find(tvt);
assert(known != typeBindings.end());
return known->second;
});
}
size_t Solution::getTotalMemory() const {
```
Stack trace:
```
0 0x0000000003f3abd4 PrintStackTraceSignalHandler(void*) (/path/to/swift/bin/swift+0x3f3abd4)
1 0x0000000003f3af16 SignalHandler(int) (/path/to/swift/bin/swift+0x3f3af16)
2 0x00007f53ba016390 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x11390)
3 0x00007f53b853b428 gsignal /build/glibc-bfm8X4/glibc-2.23/signal/../sysdeps/unix/sysv/linux/raise.c:54:0
4 0x00007f53b853d02a abort /build/glibc-bfm8X4/glibc-2.23/stdlib/abort.c:91:0
5 0x00007f53b8533bd7 __assert_fail_base /build/glibc-bfm8X4/glibc-2.23/assert/assert.c:92:0
6 0x00007f53b8533c82 (/lib/x86_64-linux-gnu/libc.so.6+0x2dc82)
7 0x00000000012c3523 swift::Type llvm::function_ref<swift::Type (swift::Type)>::callback_fn<swift::Type simplifyTypeImpl<swift::constraints::Solution::simplifyType(swift::Type) const::$_7>(swift::constraints::ConstraintSystem&, swift::Type, swift::constraints::Solution::simplifyType(swift::Type) const::$_7)::{lambda(swift::Type)#1}>(long, swift::Type) (/path/to/swift/bin/swift+0x12c3523)
8 0x0000000001755dd6 llvm::Optional<swift::Type> llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>::callback_fn<swift::Type::transform(llvm::function_ref<swift::Type (swift::Type)>) const::$_15>(long, swift::TypeBase*) (/path/to/swift/bin/swift+0x1755dd6)
9 0x000000000174f022 swift::Type::transformRec(llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>) const (/path/to/swift/bin/swift+0x174f022)
10 0x000000000174f25e swift::Type::transformRec(llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>) const (/path/to/swift/bin/swift+0x174f25e)
11 0x000000000174f577 swift::Type::transformRec(llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>) const (/path/to/swift/bin/swift+0x174f577)
12 0x0000000001743b07 swift::Type::transform(llvm::function_ref<swift::Type (swift::Type)>) const (/path/to/swift/bin/swift+0x1743b07)
13 0x00000000012c08bf swift::constraints::Solution::simplifyType(swift::Type) const (/path/to/swift/bin/swift+0x12c08bf)
14 0x00000000012d7181 swift::TypeChecker::getTypeOfExpressionWithoutApplying(swift::Expr*&, swift::DeclContext*, swift::ConcreteDeclRef&, swift::FreeTypeVariableBinding, swift::ExprTypeCheckListener*) (/path/to/swift/bin/swift+0x12d7181)
15 0x00000000013cb9a8 (anonymous namespace)::FailureDiagnosis::diagnoseParameterErrors(swift::CalleeCandidateInfo&, swift::Expr*, swift::Expr*, llvm::ArrayRef<swift::Identifier>) (/path/to/swift/bin/swift+0x13cb9a8)
16 0x00000000013d1069 (anonymous namespace)::FailureDiagnosis::visitApplyExpr(swift::ApplyExpr*) (/path/to/swift/bin/swift+0x13d1069)
17 0x00000000013b8506 swift::ASTVisitor<(anonymous namespace)::FailureDiagnosis, bool, void, void, void, void, void>::visit(swift::Expr*) (/path/to/swift/bin/swift+0x13b8506)
18 0x00000000013b2282 swift::constraints::ConstraintSystem::diagnoseFailureForExpr(swift::Expr*) (/path/to/swift/bin/swift+0x13b2282)
19 0x00000000013b82c6 swift::constraints::ConstraintSystem::salvage(llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::Expr*) (/path/to/swift/bin/swift+0x13b82c6)
20 0x00000000012d3008 swift::TypeChecker::solveForExpression(swift::Expr*&, swift::DeclContext*, swift::Type, swift::FreeTypeVariableBinding, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem&, llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>) (/path/to/swift/bin/swift+0x12d3008)
21 0x00000000012d6cf2 swift::TypeChecker::typeCheckExpression(swift::Expr*&, swift::DeclContext*, swift::TypeLoc, swift::ContextualTypePurpose, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem*) (/path/to/swift/bin/swift+0x12d6cf2)
22 0x0000000001364886 swift::ASTVisitor<(anonymous namespace)::StmtChecker, void, swift::Stmt*, void, void, void, void>::visit(swift::Stmt*) (/path/to/swift/bin/swift+0x1364886)
23 0x0000000001363956 (anonymous namespace)::StmtChecker::typeCheckBody(swift::BraceStmt*&) (/path/to/swift/bin/swift+0x1363956)
24 0x0000000001362bc1 swift::TypeChecker::typeCheckFunctionBodyUntil(swift::FuncDecl*, swift::SourceLoc) (/path/to/swift/bin/swift+0x1362bc1)
25 0x0000000001362a75 swift::TypeChecker::typeCheckAbstractFunctionBodyUntil(swift::AbstractFunctionDecl*, swift::SourceLoc) (/path/to/swift/bin/swift+0x1362a75)
26 0x0000000001363632 swift::TypeChecker::typeCheckAbstractFunctionBody(swift::AbstractFunctionDecl*) (/path/to/swift/bin/swift+0x1363632)
27 0x0000000001384cee typeCheckFunctionsAndExternalDecls(swift::TypeChecker&) (/path/to/swift/bin/swift+0x1384cee)
28 0x0000000001385abd swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int, unsigned int, unsigned int, unsigned int) (/path/to/swift/bin/swift+0x1385abd)
29 0x00000000010911c4 swift::CompilerInstance::parseAndTypeCheckMainFile(swift::PersistentParserState&, swift::DelayedParsingCallbacks*, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>) (/path/to/swift/bin/swift+0x10911c4)
30 0x000000000109016e swift::CompilerInstance::parseAndCheckTypes(swift::CompilerInstance::ImplicitImports const&) (/path/to/swift/bin/swift+0x109016e)
31 0x000000000108fb1a swift::CompilerInstance::performSema() (/path/to/swift/bin/swift+0x108fb1a)
32 0x00000000004c88de performCompile(swift::CompilerInstance&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*, swift::UnifiedStatsReporter*) (/path/to/swift/bin/swift+0x4c88de)
33 0x00000000004c762a swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x4c762a)
34 0x000000000047ff84 main (/path/to/swift/bin/swift+0x47ff84)
35 0x00007f53b8526830 __libc_start_main /build/glibc-bfm8X4/glibc-2.23/csu/../csu/libc-start.c:325:0
36 0x000000000047d839 _start (/path/to/swift/bin/swift+0x47d839)
```
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@randomstep
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix typo in Reparing - #1

Open
randomstep wants to merge 1 commit into
swift-3-api-guidelinesfrom
randomstep-reparing-typo
Open

Fix typo in Reparing#1
randomstep wants to merge 1 commit into
swift-3-api-guidelinesfrom
randomstep-reparing-typo

Conversation

@randomstep

Copy link
Copy Markdown
Owner

What's in this pull request?

Fixes a typo in CString. Reparing -> Repairing

Resolved bug number: (SR-)

NA


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

PlatformComment
All supported platforms@swift-ci Please smoke test
OS X platform@swift-ci Please smoke test OS X platform
Linux platform@swift-ci Please smoke test Linux platform

Validation Testing

PlatformComment
All supported platforms@swift-ci Please test
OS X platform@swift-ci Please test OS X platform
Linux platform@swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

randomstep pushed a commit that referenced this pull request Jan 19, 2018
Add test case for crash triggered in `swift::Type`.
Current number of unresolved compiler crashers: 55 (5619 resolved)
/cc @slavapestov - just wanted to let you know that this crasher caused an assertion failure for the assertion `known != typeBindings.end()` added on 2017-01-19 by you in commit 8de0ca5 :-)
Assertion failure in [`lib/Sema/ConstraintSystem.cpp (line 1807)`](https://github.com/apple/swift/blob/08c4f5106ba8f5ecfafa43de2b922a03dd6c9a2b/lib/Sema/ConstraintSystem.cpp#L1807):
```
Assertion `known != typeBindings.end()' failed.
When executing: auto swift::constraints::Solution::simplifyType(swift::Type)::(anonymous class)::operator()(swift::TypeVariableType *) const
```
Assertion context:
```c++
// Map type variables to fixed types from bindings.
return simplifyTypeImpl(
getConstraintSystem(), type,
[&](TypeVariableType *tvt) -> Type {
auto known = typeBindings.find(tvt);
assert(known != typeBindings.end());
return known->second;
});
}
size_t Solution::getTotalMemory() const {
```
Stack trace:
```
0 0x0000000003f3abd4 PrintStackTraceSignalHandler(void*) (/path/to/swift/bin/swift+0x3f3abd4)
1 0x0000000003f3af16 SignalHandler(int) (/path/to/swift/bin/swift+0x3f3af16)
2 0x00007f53ba016390 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x11390)
3 0x00007f53b853b428 gsignal /build/glibc-bfm8X4/glibc-2.23/signal/../sysdeps/unix/sysv/linux/raise.c:54:0
4 0x00007f53b853d02a abort /build/glibc-bfm8X4/glibc-2.23/stdlib/abort.c:91:0
5 0x00007f53b8533bd7 __assert_fail_base /build/glibc-bfm8X4/glibc-2.23/assert/assert.c:92:0
6 0x00007f53b8533c82 (/lib/x86_64-linux-gnu/libc.so.6+0x2dc82)
7 0x00000000012c3523 swift::Type llvm::function_ref<swift::Type (swift::Type)>::callback_fn<swift::Type simplifyTypeImpl<swift::constraints::Solution::simplifyType(swift::Type) const::$_7>(swift::constraints::ConstraintSystem&, swift::Type, swift::constraints::Solution::simplifyType(swift::Type) const::$_7)::{lambda(swift::Type)#1}>(long, swift::Type) (/path/to/swift/bin/swift+0x12c3523)
8 0x0000000001755dd6 llvm::Optional<swift::Type> llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>::callback_fn<swift::Type::transform(llvm::function_ref<swift::Type (swift::Type)>) const::$_15>(long, swift::TypeBase*) (/path/to/swift/bin/swift+0x1755dd6)
9 0x000000000174f022 swift::Type::transformRec(llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>) const (/path/to/swift/bin/swift+0x174f022)
10 0x000000000174f25e swift::Type::transformRec(llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>) const (/path/to/swift/bin/swift+0x174f25e)
11 0x000000000174f577 swift::Type::transformRec(llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>) const (/path/to/swift/bin/swift+0x174f577)
12 0x0000000001743b07 swift::Type::transform(llvm::function_ref<swift::Type (swift::Type)>) const (/path/to/swift/bin/swift+0x1743b07)
13 0x00000000012c08bf swift::constraints::Solution::simplifyType(swift::Type) const (/path/to/swift/bin/swift+0x12c08bf)
14 0x00000000012d7181 swift::TypeChecker::getTypeOfExpressionWithoutApplying(swift::Expr*&, swift::DeclContext*, swift::ConcreteDeclRef&, swift::FreeTypeVariableBinding, swift::ExprTypeCheckListener*) (/path/to/swift/bin/swift+0x12d7181)
15 0x00000000013cb9a8 (anonymous namespace)::FailureDiagnosis::diagnoseParameterErrors(swift::CalleeCandidateInfo&, swift::Expr*, swift::Expr*, llvm::ArrayRef<swift::Identifier>) (/path/to/swift/bin/swift+0x13cb9a8)
16 0x00000000013d1069 (anonymous namespace)::FailureDiagnosis::visitApplyExpr(swift::ApplyExpr*) (/path/to/swift/bin/swift+0x13d1069)
17 0x00000000013b8506 swift::ASTVisitor<(anonymous namespace)::FailureDiagnosis, bool, void, void, void, void, void>::visit(swift::Expr*) (/path/to/swift/bin/swift+0x13b8506)
18 0x00000000013b2282 swift::constraints::ConstraintSystem::diagnoseFailureForExpr(swift::Expr*) (/path/to/swift/bin/swift+0x13b2282)
19 0x00000000013b82c6 swift::constraints::ConstraintSystem::salvage(llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::Expr*) (/path/to/swift/bin/swift+0x13b82c6)
20 0x00000000012d3008 swift::TypeChecker::solveForExpression(swift::Expr*&, swift::DeclContext*, swift::Type, swift::FreeTypeVariableBinding, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem&, llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>) (/path/to/swift/bin/swift+0x12d3008)
21 0x00000000012d6cf2 swift::TypeChecker::typeCheckExpression(swift::Expr*&, swift::DeclContext*, swift::TypeLoc, swift::ContextualTypePurpose, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem*) (/path/to/swift/bin/swift+0x12d6cf2)
22 0x0000000001364886 swift::ASTVisitor<(anonymous namespace)::StmtChecker, void, swift::Stmt*, void, void, void, void>::visit(swift::Stmt*) (/path/to/swift/bin/swift+0x1364886)
23 0x0000000001363956 (anonymous namespace)::StmtChecker::typeCheckBody(swift::BraceStmt*&) (/path/to/swift/bin/swift+0x1363956)
24 0x0000000001362bc1 swift::TypeChecker::typeCheckFunctionBodyUntil(swift::FuncDecl*, swift::SourceLoc) (/path/to/swift/bin/swift+0x1362bc1)
25 0x0000000001362a75 swift::TypeChecker::typeCheckAbstractFunctionBodyUntil(swift::AbstractFunctionDecl*, swift::SourceLoc) (/path/to/swift/bin/swift+0x1362a75)
26 0x0000000001363632 swift::TypeChecker::typeCheckAbstractFunctionBody(swift::AbstractFunctionDecl*) (/path/to/swift/bin/swift+0x1363632)
27 0x0000000001384cee typeCheckFunctionsAndExternalDecls(swift::TypeChecker&) (/path/to/swift/bin/swift+0x1384cee)
28 0x0000000001385abd swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int, unsigned int, unsigned int, unsigned int) (/path/to/swift/bin/swift+0x1385abd)
29 0x00000000010911c4 swift::CompilerInstance::parseAndTypeCheckMainFile(swift::PersistentParserState&, swift::DelayedParsingCallbacks*, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>) (/path/to/swift/bin/swift+0x10911c4)
30 0x000000000109016e swift::CompilerInstance::parseAndCheckTypes(swift::CompilerInstance::ImplicitImports const&) (/path/to/swift/bin/swift+0x109016e)
31 0x000000000108fb1a swift::CompilerInstance::performSema() (/path/to/swift/bin/swift+0x108fb1a)
32 0x00000000004c88de performCompile(swift::CompilerInstance&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*, swift::UnifiedStatsReporter*) (/path/to/swift/bin/swift+0x4c88de)
33 0x00000000004c762a swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x4c762a)
34 0x000000000047ff84 main (/path/to/swift/bin/swift+0x47ff84)
35 0x00007f53b8526830 __libc_start_main /build/glibc-bfm8X4/glibc-2.23/csu/../csu/libc-start.c:325:0
36 0x000000000047d839 _start (/path/to/swift/bin/swift+0x47d839)
```
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@randomstep
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Fix typo in Reparing - #1

Open
randomstep wants to merge 1 commit into
swift-3-api-guidelinesfrom
randomstep-reparing-typo
Open

Fix typo in Reparing#1
randomstep wants to merge 1 commit into
swift-3-api-guidelinesfrom
randomstep-reparing-typo

Conversation

@randomstep

Copy link
Copy Markdown
Owner

What's in this pull request?

Fixes a typo in CString. Reparing -> Repairing

Resolved bug number: (SR-)

NA


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

PlatformComment
All supported platforms@swift-ci Please smoke test
OS X platform@swift-ci Please smoke test OS X platform
Linux platform@swift-ci Please smoke test Linux platform

Validation Testing

PlatformComment
All supported platforms@swift-ci Please test
OS X platform@swift-ci Please test OS X platform
Linux platform@swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

randomstep pushed a commit that referenced this pull request Jan 19, 2018
Add test case for crash triggered in `swift::Type`.
Current number of unresolved compiler crashers: 55 (5619 resolved)
/cc @slavapestov - just wanted to let you know that this crasher caused an assertion failure for the assertion `known != typeBindings.end()` added on 2017-01-19 by you in commit 8de0ca5 :-)
Assertion failure in [`lib/Sema/ConstraintSystem.cpp (line 1807)`](https://github.com/apple/swift/blob/08c4f5106ba8f5ecfafa43de2b922a03dd6c9a2b/lib/Sema/ConstraintSystem.cpp#L1807):
```
Assertion `known != typeBindings.end()' failed.
When executing: auto swift::constraints::Solution::simplifyType(swift::Type)::(anonymous class)::operator()(swift::TypeVariableType *) const
```
Assertion context:
```c++
// Map type variables to fixed types from bindings.
return simplifyTypeImpl(
getConstraintSystem(), type,
[&](TypeVariableType *tvt) -> Type {
auto known = typeBindings.find(tvt);
assert(known != typeBindings.end());
return known->second;
});
}
size_t Solution::getTotalMemory() const {
```
Stack trace:
```
0 0x0000000003f3abd4 PrintStackTraceSignalHandler(void*) (/path/to/swift/bin/swift+0x3f3abd4)
1 0x0000000003f3af16 SignalHandler(int) (/path/to/swift/bin/swift+0x3f3af16)
2 0x00007f53ba016390 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x11390)
3 0x00007f53b853b428 gsignal /build/glibc-bfm8X4/glibc-2.23/signal/../sysdeps/unix/sysv/linux/raise.c:54:0
4 0x00007f53b853d02a abort /build/glibc-bfm8X4/glibc-2.23/stdlib/abort.c:91:0
5 0x00007f53b8533bd7 __assert_fail_base /build/glibc-bfm8X4/glibc-2.23/assert/assert.c:92:0
6 0x00007f53b8533c82 (/lib/x86_64-linux-gnu/libc.so.6+0x2dc82)
7 0x00000000012c3523 swift::Type llvm::function_ref<swift::Type (swift::Type)>::callback_fn<swift::Type simplifyTypeImpl<swift::constraints::Solution::simplifyType(swift::Type) const::$_7>(swift::constraints::ConstraintSystem&, swift::Type, swift::constraints::Solution::simplifyType(swift::Type) const::$_7)::{lambda(swift::Type)#1}>(long, swift::Type) (/path/to/swift/bin/swift+0x12c3523)
8 0x0000000001755dd6 llvm::Optional<swift::Type> llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>::callback_fn<swift::Type::transform(llvm::function_ref<swift::Type (swift::Type)>) const::$_15>(long, swift::TypeBase*) (/path/to/swift/bin/swift+0x1755dd6)
9 0x000000000174f022 swift::Type::transformRec(llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>) const (/path/to/swift/bin/swift+0x174f022)
10 0x000000000174f25e swift::Type::transformRec(llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>) const (/path/to/swift/bin/swift+0x174f25e)
11 0x000000000174f577 swift::Type::transformRec(llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>) const (/path/to/swift/bin/swift+0x174f577)
12 0x0000000001743b07 swift::Type::transform(llvm::function_ref<swift::Type (swift::Type)>) const (/path/to/swift/bin/swift+0x1743b07)
13 0x00000000012c08bf swift::constraints::Solution::simplifyType(swift::Type) const (/path/to/swift/bin/swift+0x12c08bf)
14 0x00000000012d7181 swift::TypeChecker::getTypeOfExpressionWithoutApplying(swift::Expr*&, swift::DeclContext*, swift::ConcreteDeclRef&, swift::FreeTypeVariableBinding, swift::ExprTypeCheckListener*) (/path/to/swift/bin/swift+0x12d7181)
15 0x00000000013cb9a8 (anonymous namespace)::FailureDiagnosis::diagnoseParameterErrors(swift::CalleeCandidateInfo&, swift::Expr*, swift::Expr*, llvm::ArrayRef<swift::Identifier>) (/path/to/swift/bin/swift+0x13cb9a8)
16 0x00000000013d1069 (anonymous namespace)::FailureDiagnosis::visitApplyExpr(swift::ApplyExpr*) (/path/to/swift/bin/swift+0x13d1069)
17 0x00000000013b8506 swift::ASTVisitor<(anonymous namespace)::FailureDiagnosis, bool, void, void, void, void, void>::visit(swift::Expr*) (/path/to/swift/bin/swift+0x13b8506)
18 0x00000000013b2282 swift::constraints::ConstraintSystem::diagnoseFailureForExpr(swift::Expr*) (/path/to/swift/bin/swift+0x13b2282)
19 0x00000000013b82c6 swift::constraints::ConstraintSystem::salvage(llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::Expr*) (/path/to/swift/bin/swift+0x13b82c6)
20 0x00000000012d3008 swift::TypeChecker::solveForExpression(swift::Expr*&, swift::DeclContext*, swift::Type, swift::FreeTypeVariableBinding, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem&, llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>) (/path/to/swift/bin/swift+0x12d3008)
21 0x00000000012d6cf2 swift::TypeChecker::typeCheckExpression(swift::Expr*&, swift::DeclContext*, swift::TypeLoc, swift::ContextualTypePurpose, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem*) (/path/to/swift/bin/swift+0x12d6cf2)
22 0x0000000001364886 swift::ASTVisitor<(anonymous namespace)::StmtChecker, void, swift::Stmt*, void, void, void, void>::visit(swift::Stmt*) (/path/to/swift/bin/swift+0x1364886)
23 0x0000000001363956 (anonymous namespace)::StmtChecker::typeCheckBody(swift::BraceStmt*&) (/path/to/swift/bin/swift+0x1363956)
24 0x0000000001362bc1 swift::TypeChecker::typeCheckFunctionBodyUntil(swift::FuncDecl*, swift::SourceLoc) (/path/to/swift/bin/swift+0x1362bc1)
25 0x0000000001362a75 swift::TypeChecker::typeCheckAbstractFunctionBodyUntil(swift::AbstractFunctionDecl*, swift::SourceLoc) (/path/to/swift/bin/swift+0x1362a75)
26 0x0000000001363632 swift::TypeChecker::typeCheckAbstractFunctionBody(swift::AbstractFunctionDecl*) (/path/to/swift/bin/swift+0x1363632)
27 0x0000000001384cee typeCheckFunctionsAndExternalDecls(swift::TypeChecker&) (/path/to/swift/bin/swift+0x1384cee)
28 0x0000000001385abd swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int, unsigned int, unsigned int, unsigned int) (/path/to/swift/bin/swift+0x1385abd)
29 0x00000000010911c4 swift::CompilerInstance::parseAndTypeCheckMainFile(swift::PersistentParserState&, swift::DelayedParsingCallbacks*, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>) (/path/to/swift/bin/swift+0x10911c4)
30 0x000000000109016e swift::CompilerInstance::parseAndCheckTypes(swift::CompilerInstance::ImplicitImports const&) (/path/to/swift/bin/swift+0x109016e)
31 0x000000000108fb1a swift::CompilerInstance::performSema() (/path/to/swift/bin/swift+0x108fb1a)
32 0x00000000004c88de performCompile(swift::CompilerInstance&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*, swift::UnifiedStatsReporter*) (/path/to/swift/bin/swift+0x4c88de)
33 0x00000000004c762a swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x4c762a)
34 0x000000000047ff84 main (/path/to/swift/bin/swift+0x47ff84)
35 0x00007f53b8526830 __libc_start_main /build/glibc-bfm8X4/glibc-2.23/csu/../csu/libc-start.c:325:0
36 0x000000000047d839 _start (/path/to/swift/bin/swift+0x47d839)
```
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@randomstep
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix typo in Reparing - #1

Open
randomstep wants to merge 1 commit into
swift-3-api-guidelinesfrom
randomstep-reparing-typo
Open

Fix typo in Reparing#1
randomstep wants to merge 1 commit into
swift-3-api-guidelinesfrom
randomstep-reparing-typo

Conversation

@randomstep

Copy link
Copy Markdown
Owner

What's in this pull request?

Fixes a typo in CString. Reparing -> Repairing

Resolved bug number: (SR-)

NA


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

PlatformComment
All supported platforms@swift-ci Please smoke test
OS X platform@swift-ci Please smoke test OS X platform
Linux platform@swift-ci Please smoke test Linux platform

Validation Testing

PlatformComment
All supported platforms@swift-ci Please test
OS X platform@swift-ci Please test OS X platform
Linux platform@swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

randomstep pushed a commit that referenced this pull request Jan 19, 2018
Add test case for crash triggered in `swift::Type`.
Current number of unresolved compiler crashers: 55 (5619 resolved)
/cc @slavapestov - just wanted to let you know that this crasher caused an assertion failure for the assertion `known != typeBindings.end()` added on 2017-01-19 by you in commit 8de0ca5 :-)
Assertion failure in [`lib/Sema/ConstraintSystem.cpp (line 1807)`](https://github.com/apple/swift/blob/08c4f5106ba8f5ecfafa43de2b922a03dd6c9a2b/lib/Sema/ConstraintSystem.cpp#L1807):
```
Assertion `known != typeBindings.end()' failed.
When executing: auto swift::constraints::Solution::simplifyType(swift::Type)::(anonymous class)::operator()(swift::TypeVariableType *) const
```
Assertion context:
```c++
// Map type variables to fixed types from bindings.
return simplifyTypeImpl(
getConstraintSystem(), type,
[&](TypeVariableType *tvt) -> Type {
auto known = typeBindings.find(tvt);
assert(known != typeBindings.end());
return known->second;
});
}
size_t Solution::getTotalMemory() const {
```
Stack trace:
```
0 0x0000000003f3abd4 PrintStackTraceSignalHandler(void*) (/path/to/swift/bin/swift+0x3f3abd4)
1 0x0000000003f3af16 SignalHandler(int) (/path/to/swift/bin/swift+0x3f3af16)
2 0x00007f53ba016390 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x11390)
3 0x00007f53b853b428 gsignal /build/glibc-bfm8X4/glibc-2.23/signal/../sysdeps/unix/sysv/linux/raise.c:54:0
4 0x00007f53b853d02a abort /build/glibc-bfm8X4/glibc-2.23/stdlib/abort.c:91:0
5 0x00007f53b8533bd7 __assert_fail_base /build/glibc-bfm8X4/glibc-2.23/assert/assert.c:92:0
6 0x00007f53b8533c82 (/lib/x86_64-linux-gnu/libc.so.6+0x2dc82)
7 0x00000000012c3523 swift::Type llvm::function_ref<swift::Type (swift::Type)>::callback_fn<swift::Type simplifyTypeImpl<swift::constraints::Solution::simplifyType(swift::Type) const::$_7>(swift::constraints::ConstraintSystem&, swift::Type, swift::constraints::Solution::simplifyType(swift::Type) const::$_7)::{lambda(swift::Type)#1}>(long, swift::Type) (/path/to/swift/bin/swift+0x12c3523)
8 0x0000000001755dd6 llvm::Optional<swift::Type> llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>::callback_fn<swift::Type::transform(llvm::function_ref<swift::Type (swift::Type)>) const::$_15>(long, swift::TypeBase*) (/path/to/swift/bin/swift+0x1755dd6)
9 0x000000000174f022 swift::Type::transformRec(llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>) const (/path/to/swift/bin/swift+0x174f022)
10 0x000000000174f25e swift::Type::transformRec(llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>) const (/path/to/swift/bin/swift+0x174f25e)
11 0x000000000174f577 swift::Type::transformRec(llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>) const (/path/to/swift/bin/swift+0x174f577)
12 0x0000000001743b07 swift::Type::transform(llvm::function_ref<swift::Type (swift::Type)>) const (/path/to/swift/bin/swift+0x1743b07)
13 0x00000000012c08bf swift::constraints::Solution::simplifyType(swift::Type) const (/path/to/swift/bin/swift+0x12c08bf)
14 0x00000000012d7181 swift::TypeChecker::getTypeOfExpressionWithoutApplying(swift::Expr*&, swift::DeclContext*, swift::ConcreteDeclRef&, swift::FreeTypeVariableBinding, swift::ExprTypeCheckListener*) (/path/to/swift/bin/swift+0x12d7181)
15 0x00000000013cb9a8 (anonymous namespace)::FailureDiagnosis::diagnoseParameterErrors(swift::CalleeCandidateInfo&, swift::Expr*, swift::Expr*, llvm::ArrayRef<swift::Identifier>) (/path/to/swift/bin/swift+0x13cb9a8)
16 0x00000000013d1069 (anonymous namespace)::FailureDiagnosis::visitApplyExpr(swift::ApplyExpr*) (/path/to/swift/bin/swift+0x13d1069)
17 0x00000000013b8506 swift::ASTVisitor<(anonymous namespace)::FailureDiagnosis, bool, void, void, void, void, void>::visit(swift::Expr*) (/path/to/swift/bin/swift+0x13b8506)
18 0x00000000013b2282 swift::constraints::ConstraintSystem::diagnoseFailureForExpr(swift::Expr*) (/path/to/swift/bin/swift+0x13b2282)
19 0x00000000013b82c6 swift::constraints::ConstraintSystem::salvage(llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::Expr*) (/path/to/swift/bin/swift+0x13b82c6)
20 0x00000000012d3008 swift::TypeChecker::solveForExpression(swift::Expr*&, swift::DeclContext*, swift::Type, swift::FreeTypeVariableBinding, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem&, llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>) (/path/to/swift/bin/swift+0x12d3008)
21 0x00000000012d6cf2 swift::TypeChecker::typeCheckExpression(swift::Expr*&, swift::DeclContext*, swift::TypeLoc, swift::ContextualTypePurpose, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem*) (/path/to/swift/bin/swift+0x12d6cf2)
22 0x0000000001364886 swift::ASTVisitor<(anonymous namespace)::StmtChecker, void, swift::Stmt*, void, void, void, void>::visit(swift::Stmt*) (/path/to/swift/bin/swift+0x1364886)
23 0x0000000001363956 (anonymous namespace)::StmtChecker::typeCheckBody(swift::BraceStmt*&) (/path/to/swift/bin/swift+0x1363956)
24 0x0000000001362bc1 swift::TypeChecker::typeCheckFunctionBodyUntil(swift::FuncDecl*, swift::SourceLoc) (/path/to/swift/bin/swift+0x1362bc1)
25 0x0000000001362a75 swift::TypeChecker::typeCheckAbstractFunctionBodyUntil(swift::AbstractFunctionDecl*, swift::SourceLoc) (/path/to/swift/bin/swift+0x1362a75)
26 0x0000000001363632 swift::TypeChecker::typeCheckAbstractFunctionBody(swift::AbstractFunctionDecl*) (/path/to/swift/bin/swift+0x1363632)
27 0x0000000001384cee typeCheckFunctionsAndExternalDecls(swift::TypeChecker&) (/path/to/swift/bin/swift+0x1384cee)
28 0x0000000001385abd swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int, unsigned int, unsigned int, unsigned int) (/path/to/swift/bin/swift+0x1385abd)
29 0x00000000010911c4 swift::CompilerInstance::parseAndTypeCheckMainFile(swift::PersistentParserState&, swift::DelayedParsingCallbacks*, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>) (/path/to/swift/bin/swift+0x10911c4)
30 0x000000000109016e swift::CompilerInstance::parseAndCheckTypes(swift::CompilerInstance::ImplicitImports const&) (/path/to/swift/bin/swift+0x109016e)
31 0x000000000108fb1a swift::CompilerInstance::performSema() (/path/to/swift/bin/swift+0x108fb1a)
32 0x00000000004c88de performCompile(swift::CompilerInstance&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*, swift::UnifiedStatsReporter*) (/path/to/swift/bin/swift+0x4c88de)
33 0x00000000004c762a swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x4c762a)
34 0x000000000047ff84 main (/path/to/swift/bin/swift+0x47ff84)
35 0x00007f53b8526830 __libc_start_main /build/glibc-bfm8X4/glibc-2.23/csu/../csu/libc-start.c:325:0
36 0x000000000047d839 _start (/path/to/swift/bin/swift+0x47d839)
```
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@randomstep
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix typo in Reparing - #1

Open
randomstep wants to merge 1 commit into
swift-3-api-guidelinesfrom
randomstep-reparing-typo
Open

Fix typo in Reparing#1
randomstep wants to merge 1 commit into
swift-3-api-guidelinesfrom
randomstep-reparing-typo

Conversation

@randomstep

Copy link
Copy Markdown
Owner

What's in this pull request?

Fixes a typo in CString. Reparing -> Repairing

Resolved bug number: (SR-)

NA


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

PlatformComment
All supported platforms@swift-ci Please smoke test
OS X platform@swift-ci Please smoke test OS X platform
Linux platform@swift-ci Please smoke test Linux platform

Validation Testing

PlatformComment
All supported platforms@swift-ci Please test
OS X platform@swift-ci Please test OS X platform
Linux platform@swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

randomstep pushed a commit that referenced this pull request Jan 19, 2018
Add test case for crash triggered in `swift::Type`.
Current number of unresolved compiler crashers: 55 (5619 resolved)
/cc @slavapestov - just wanted to let you know that this crasher caused an assertion failure for the assertion `known != typeBindings.end()` added on 2017-01-19 by you in commit 8de0ca5 :-)
Assertion failure in [`lib/Sema/ConstraintSystem.cpp (line 1807)`](https://github.com/apple/swift/blob/08c4f5106ba8f5ecfafa43de2b922a03dd6c9a2b/lib/Sema/ConstraintSystem.cpp#L1807):
```
Assertion `known != typeBindings.end()' failed.
When executing: auto swift::constraints::Solution::simplifyType(swift::Type)::(anonymous class)::operator()(swift::TypeVariableType *) const
```
Assertion context:
```c++
// Map type variables to fixed types from bindings.
return simplifyTypeImpl(
getConstraintSystem(), type,
[&](TypeVariableType *tvt) -> Type {
auto known = typeBindings.find(tvt);
assert(known != typeBindings.end());
return known->second;
});
}
size_t Solution::getTotalMemory() const {
```
Stack trace:
```
0 0x0000000003f3abd4 PrintStackTraceSignalHandler(void*) (/path/to/swift/bin/swift+0x3f3abd4)
1 0x0000000003f3af16 SignalHandler(int) (/path/to/swift/bin/swift+0x3f3af16)
2 0x00007f53ba016390 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x11390)
3 0x00007f53b853b428 gsignal /build/glibc-bfm8X4/glibc-2.23/signal/../sysdeps/unix/sysv/linux/raise.c:54:0
4 0x00007f53b853d02a abort /build/glibc-bfm8X4/glibc-2.23/stdlib/abort.c:91:0
5 0x00007f53b8533bd7 __assert_fail_base /build/glibc-bfm8X4/glibc-2.23/assert/assert.c:92:0
6 0x00007f53b8533c82 (/lib/x86_64-linux-gnu/libc.so.6+0x2dc82)
7 0x00000000012c3523 swift::Type llvm::function_ref<swift::Type (swift::Type)>::callback_fn<swift::Type simplifyTypeImpl<swift::constraints::Solution::simplifyType(swift::Type) const::$_7>(swift::constraints::ConstraintSystem&, swift::Type, swift::constraints::Solution::simplifyType(swift::Type) const::$_7)::{lambda(swift::Type)#1}>(long, swift::Type) (/path/to/swift/bin/swift+0x12c3523)
8 0x0000000001755dd6 llvm::Optional<swift::Type> llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>::callback_fn<swift::Type::transform(llvm::function_ref<swift::Type (swift::Type)>) const::$_15>(long, swift::TypeBase*) (/path/to/swift/bin/swift+0x1755dd6)
9 0x000000000174f022 swift::Type::transformRec(llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>) const (/path/to/swift/bin/swift+0x174f022)
10 0x000000000174f25e swift::Type::transformRec(llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>) const (/path/to/swift/bin/swift+0x174f25e)
11 0x000000000174f577 swift::Type::transformRec(llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>) const (/path/to/swift/bin/swift+0x174f577)
12 0x0000000001743b07 swift::Type::transform(llvm::function_ref<swift::Type (swift::Type)>) const (/path/to/swift/bin/swift+0x1743b07)
13 0x00000000012c08bf swift::constraints::Solution::simplifyType(swift::Type) const (/path/to/swift/bin/swift+0x12c08bf)
14 0x00000000012d7181 swift::TypeChecker::getTypeOfExpressionWithoutApplying(swift::Expr*&, swift::DeclContext*, swift::ConcreteDeclRef&, swift::FreeTypeVariableBinding, swift::ExprTypeCheckListener*) (/path/to/swift/bin/swift+0x12d7181)
15 0x00000000013cb9a8 (anonymous namespace)::FailureDiagnosis::diagnoseParameterErrors(swift::CalleeCandidateInfo&, swift::Expr*, swift::Expr*, llvm::ArrayRef<swift::Identifier>) (/path/to/swift/bin/swift+0x13cb9a8)
16 0x00000000013d1069 (anonymous namespace)::FailureDiagnosis::visitApplyExpr(swift::ApplyExpr*) (/path/to/swift/bin/swift+0x13d1069)
17 0x00000000013b8506 swift::ASTVisitor<(anonymous namespace)::FailureDiagnosis, bool, void, void, void, void, void>::visit(swift::Expr*) (/path/to/swift/bin/swift+0x13b8506)
18 0x00000000013b2282 swift::constraints::ConstraintSystem::diagnoseFailureForExpr(swift::Expr*) (/path/to/swift/bin/swift+0x13b2282)
19 0x00000000013b82c6 swift::constraints::ConstraintSystem::salvage(llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::Expr*) (/path/to/swift/bin/swift+0x13b82c6)
20 0x00000000012d3008 swift::TypeChecker::solveForExpression(swift::Expr*&, swift::DeclContext*, swift::Type, swift::FreeTypeVariableBinding, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem&, llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>) (/path/to/swift/bin/swift+0x12d3008)
21 0x00000000012d6cf2 swift::TypeChecker::typeCheckExpression(swift::Expr*&, swift::DeclContext*, swift::TypeLoc, swift::ContextualTypePurpose, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem*) (/path/to/swift/bin/swift+0x12d6cf2)
22 0x0000000001364886 swift::ASTVisitor<(anonymous namespace)::StmtChecker, void, swift::Stmt*, void, void, void, void>::visit(swift::Stmt*) (/path/to/swift/bin/swift+0x1364886)
23 0x0000000001363956 (anonymous namespace)::StmtChecker::typeCheckBody(swift::BraceStmt*&) (/path/to/swift/bin/swift+0x1363956)
24 0x0000000001362bc1 swift::TypeChecker::typeCheckFunctionBodyUntil(swift::FuncDecl*, swift::SourceLoc) (/path/to/swift/bin/swift+0x1362bc1)
25 0x0000000001362a75 swift::TypeChecker::typeCheckAbstractFunctionBodyUntil(swift::AbstractFunctionDecl*, swift::SourceLoc) (/path/to/swift/bin/swift+0x1362a75)
26 0x0000000001363632 swift::TypeChecker::typeCheckAbstractFunctionBody(swift::AbstractFunctionDecl*) (/path/to/swift/bin/swift+0x1363632)
27 0x0000000001384cee typeCheckFunctionsAndExternalDecls(swift::TypeChecker&) (/path/to/swift/bin/swift+0x1384cee)
28 0x0000000001385abd swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int, unsigned int, unsigned int, unsigned int) (/path/to/swift/bin/swift+0x1385abd)
29 0x00000000010911c4 swift::CompilerInstance::parseAndTypeCheckMainFile(swift::PersistentParserState&, swift::DelayedParsingCallbacks*, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>) (/path/to/swift/bin/swift+0x10911c4)
30 0x000000000109016e swift::CompilerInstance::parseAndCheckTypes(swift::CompilerInstance::ImplicitImports const&) (/path/to/swift/bin/swift+0x109016e)
31 0x000000000108fb1a swift::CompilerInstance::performSema() (/path/to/swift/bin/swift+0x108fb1a)
32 0x00000000004c88de performCompile(swift::CompilerInstance&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*, swift::UnifiedStatsReporter*) (/path/to/swift/bin/swift+0x4c88de)
33 0x00000000004c762a swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x4c762a)
34 0x000000000047ff84 main (/path/to/swift/bin/swift+0x47ff84)
35 0x00007f53b8526830 __libc_start_main /build/glibc-bfm8X4/glibc-2.23/csu/../csu/libc-start.c:325:0
36 0x000000000047d839 _start (/path/to/swift/bin/swift+0x47d839)
```
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@randomstep
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Fix typo in Reparing - #1

Open
randomstep wants to merge 1 commit into
swift-3-api-guidelinesfrom
randomstep-reparing-typo
Open

Fix typo in Reparing#1
randomstep wants to merge 1 commit into
swift-3-api-guidelinesfrom
randomstep-reparing-typo

Conversation

@randomstep

Copy link
Copy Markdown
Owner

What's in this pull request?

Fixes a typo in CString. Reparing -> Repairing

Resolved bug number: (SR-)

NA


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

PlatformComment
All supported platforms@swift-ci Please smoke test
OS X platform@swift-ci Please smoke test OS X platform
Linux platform@swift-ci Please smoke test Linux platform

Validation Testing

PlatformComment
All supported platforms@swift-ci Please test
OS X platform@swift-ci Please test OS X platform
Linux platform@swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

randomstep pushed a commit that referenced this pull request Jan 19, 2018
Add test case for crash triggered in `swift::Type`.
Current number of unresolved compiler crashers: 55 (5619 resolved)
/cc @slavapestov - just wanted to let you know that this crasher caused an assertion failure for the assertion `known != typeBindings.end()` added on 2017-01-19 by you in commit 8de0ca5 :-)
Assertion failure in [`lib/Sema/ConstraintSystem.cpp (line 1807)`](https://github.com/apple/swift/blob/08c4f5106ba8f5ecfafa43de2b922a03dd6c9a2b/lib/Sema/ConstraintSystem.cpp#L1807):
```
Assertion `known != typeBindings.end()' failed.
When executing: auto swift::constraints::Solution::simplifyType(swift::Type)::(anonymous class)::operator()(swift::TypeVariableType *) const
```
Assertion context:
```c++
// Map type variables to fixed types from bindings.
return simplifyTypeImpl(
getConstraintSystem(), type,
[&](TypeVariableType *tvt) -> Type {
auto known = typeBindings.find(tvt);
assert(known != typeBindings.end());
return known->second;
});
}
size_t Solution::getTotalMemory() const {
```
Stack trace:
```
0 0x0000000003f3abd4 PrintStackTraceSignalHandler(void*) (/path/to/swift/bin/swift+0x3f3abd4)
1 0x0000000003f3af16 SignalHandler(int) (/path/to/swift/bin/swift+0x3f3af16)
2 0x00007f53ba016390 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x11390)
3 0x00007f53b853b428 gsignal /build/glibc-bfm8X4/glibc-2.23/signal/../sysdeps/unix/sysv/linux/raise.c:54:0
4 0x00007f53b853d02a abort /build/glibc-bfm8X4/glibc-2.23/stdlib/abort.c:91:0
5 0x00007f53b8533bd7 __assert_fail_base /build/glibc-bfm8X4/glibc-2.23/assert/assert.c:92:0
6 0x00007f53b8533c82 (/lib/x86_64-linux-gnu/libc.so.6+0x2dc82)
7 0x00000000012c3523 swift::Type llvm::function_ref<swift::Type (swift::Type)>::callback_fn<swift::Type simplifyTypeImpl<swift::constraints::Solution::simplifyType(swift::Type) const::$_7>(swift::constraints::ConstraintSystem&, swift::Type, swift::constraints::Solution::simplifyType(swift::Type) const::$_7)::{lambda(swift::Type)#1}>(long, swift::Type) (/path/to/swift/bin/swift+0x12c3523)
8 0x0000000001755dd6 llvm::Optional<swift::Type> llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>::callback_fn<swift::Type::transform(llvm::function_ref<swift::Type (swift::Type)>) const::$_15>(long, swift::TypeBase*) (/path/to/swift/bin/swift+0x1755dd6)
9 0x000000000174f022 swift::Type::transformRec(llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>) const (/path/to/swift/bin/swift+0x174f022)
10 0x000000000174f25e swift::Type::transformRec(llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>) const (/path/to/swift/bin/swift+0x174f25e)
11 0x000000000174f577 swift::Type::transformRec(llvm::function_ref<llvm::Optional<swift::Type> (swift::TypeBase*)>) const (/path/to/swift/bin/swift+0x174f577)
12 0x0000000001743b07 swift::Type::transform(llvm::function_ref<swift::Type (swift::Type)>) const (/path/to/swift/bin/swift+0x1743b07)
13 0x00000000012c08bf swift::constraints::Solution::simplifyType(swift::Type) const (/path/to/swift/bin/swift+0x12c08bf)
14 0x00000000012d7181 swift::TypeChecker::getTypeOfExpressionWithoutApplying(swift::Expr*&, swift::DeclContext*, swift::ConcreteDeclRef&, swift::FreeTypeVariableBinding, swift::ExprTypeCheckListener*) (/path/to/swift/bin/swift+0x12d7181)
15 0x00000000013cb9a8 (anonymous namespace)::FailureDiagnosis::diagnoseParameterErrors(swift::CalleeCandidateInfo&, swift::Expr*, swift::Expr*, llvm::ArrayRef<swift::Identifier>) (/path/to/swift/bin/swift+0x13cb9a8)
16 0x00000000013d1069 (anonymous namespace)::FailureDiagnosis::visitApplyExpr(swift::ApplyExpr*) (/path/to/swift/bin/swift+0x13d1069)
17 0x00000000013b8506 swift::ASTVisitor<(anonymous namespace)::FailureDiagnosis, bool, void, void, void, void, void>::visit(swift::Expr*) (/path/to/swift/bin/swift+0x13b8506)
18 0x00000000013b2282 swift::constraints::ConstraintSystem::diagnoseFailureForExpr(swift::Expr*) (/path/to/swift/bin/swift+0x13b2282)
19 0x00000000013b82c6 swift::constraints::ConstraintSystem::salvage(llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::Expr*) (/path/to/swift/bin/swift+0x13b82c6)
20 0x00000000012d3008 swift::TypeChecker::solveForExpression(swift::Expr*&, swift::DeclContext*, swift::Type, swift::FreeTypeVariableBinding, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem&, llvm::SmallVectorImpl<swift::constraints::Solution>&, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>) (/path/to/swift/bin/swift+0x12d3008)
21 0x00000000012d6cf2 swift::TypeChecker::typeCheckExpression(swift::Expr*&, swift::DeclContext*, swift::TypeLoc, swift::ContextualTypePurpose, swift::OptionSet<swift::TypeCheckExprFlags, unsigned int>, swift::ExprTypeCheckListener*, swift::constraints::ConstraintSystem*) (/path/to/swift/bin/swift+0x12d6cf2)
22 0x0000000001364886 swift::ASTVisitor<(anonymous namespace)::StmtChecker, void, swift::Stmt*, void, void, void, void>::visit(swift::Stmt*) (/path/to/swift/bin/swift+0x1364886)
23 0x0000000001363956 (anonymous namespace)::StmtChecker::typeCheckBody(swift::BraceStmt*&) (/path/to/swift/bin/swift+0x1363956)
24 0x0000000001362bc1 swift::TypeChecker::typeCheckFunctionBodyUntil(swift::FuncDecl*, swift::SourceLoc) (/path/to/swift/bin/swift+0x1362bc1)
25 0x0000000001362a75 swift::TypeChecker::typeCheckAbstractFunctionBodyUntil(swift::AbstractFunctionDecl*, swift::SourceLoc) (/path/to/swift/bin/swift+0x1362a75)
26 0x0000000001363632 swift::TypeChecker::typeCheckAbstractFunctionBody(swift::AbstractFunctionDecl*) (/path/to/swift/bin/swift+0x1363632)
27 0x0000000001384cee typeCheckFunctionsAndExternalDecls(swift::TypeChecker&) (/path/to/swift/bin/swift+0x1384cee)
28 0x0000000001385abd swift::performTypeChecking(swift::SourceFile&, swift::TopLevelContext&, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>, unsigned int, unsigned int, unsigned int, unsigned int) (/path/to/swift/bin/swift+0x1385abd)
29 0x00000000010911c4 swift::CompilerInstance::parseAndTypeCheckMainFile(swift::PersistentParserState&, swift::DelayedParsingCallbacks*, swift::OptionSet<swift::TypeCheckingFlags, unsigned int>) (/path/to/swift/bin/swift+0x10911c4)
30 0x000000000109016e swift::CompilerInstance::parseAndCheckTypes(swift::CompilerInstance::ImplicitImports const&) (/path/to/swift/bin/swift+0x109016e)
31 0x000000000108fb1a swift::CompilerInstance::performSema() (/path/to/swift/bin/swift+0x108fb1a)
32 0x00000000004c88de performCompile(swift::CompilerInstance&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*, swift::UnifiedStatsReporter*) (/path/to/swift/bin/swift+0x4c88de)
33 0x00000000004c762a swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) (/path/to/swift/bin/swift+0x4c762a)
34 0x000000000047ff84 main (/path/to/swift/bin/swift+0x47ff84)
35 0x00007f53b8526830 __libc_start_main /build/glibc-bfm8X4/glibc-2.23/csu/../csu/libc-start.c:325:0
36 0x000000000047d839 _start (/path/to/swift/bin/swift+0x47d839)
```
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@randomstep