New bookmark backend + UI - #92
Conversation
- add `library-symbolic` to icons
- modify `open_in_new_tab` to allow automatically switching to opened tab - update `open-in-new-tab` signal in signals vector (hypertext.rs)
ranfdev
commented
Feb 10, 2024
I appreciate it. |
tfuxu
commented
Feb 10, 2024
I see, but I wanted to switch to TOML to allow users to set custom descriptions and tags for better organizing. Also, I will write migration code for users upgrading from older bookmarks format, so no manual migration will be needed. |
ranfdev
commented
Feb 11, 2024
If there's an automatic migration, I approve |
- update `BookmarksWindow` UI file
tfuxu
commented
Feb 19, 2024
@ranfdev This is the current draft structure for bookmarks file: [bookmark.1]
title = "TestSite0"description = "Test Site no. 0"url = "gemini://example.com"
[bookmark.2]
title = "TestSite1"url = "gemini://example.com"
[bookmark.3]
title = "TestSite2"description = "Test Site no. 2"url = "gemini://example.com"
[bookmark.5]
title = "TestSite4"description = "Test Site no. 4"url = "gemini://example.com"Looks good? or would you like something changed? |
ranfdev
commented
Feb 19, 2024
What's the advantage of using the syntax |
tfuxu
commented
Feb 20, 2024
I think having an ID for a bookmark will make it easier to retrieve a particular bookmark struct in |
ranfdev
commented
Feb 21, 2024
I think the |
tfuxu
commented
Feb 21, 2024
I'll see. If I could make edit functionality to work reliably with vector indexes, then for simplicity (and for those who like fiddling with bookmark files), I will switch to |
tfuxu
commented
Feb 21, 2024
ranfdev
commented
Feb 22, 2024
tfuxu
commented
Mar 2, 2024
Imagine if bookmarks had tags. At that point the new tab page could show bookmarks tagged with "new_tab", below the search bar similar to what Firefox is doing. Then you could add some default bookmarks with that tag, so that new users have an initial list of websites to discover the Gemini space |
@ranfdev I'll be splitting this PR into several smaller ones, as it will be easier for me to develop those changes one at the time (and for you to review them afterwards). |







This PR will contain an dedicated window for bookmarks management,
Add Bookmarkpopover and redesigned bookmarks structure based on TOML file format.Things to do:
New TabviewAdd Bookmarkpopover