Fix scoping error for logger in Rails 4

[joshnesbitt]

Currenty this gem does not work on Rails 4 due to a scoping issue with the Logger class. For more information see here.

[MarkLC-r7]

I got this error when running a rails app locally with Rails v3.2.3

/var/lib/gems/1.9.1/gems/le-2.1.7/lib/le.rb:13:in new': uninitialized constant ActiveSupport::Logger (NameError) from /home/mark/WORK/Ruby/Heroku/tempTest/config/environment.rb:7:in<top (required)>'
from /home/mark/WORK/Ruby/Heroku/tempTest/config.ru:4:in require' from /home/mark/WORK/Ruby/Heroku/tempTest/config.ru:4:inblock in

'
from /var/lib/gems/1.9.1/gems/rack-1.4.1/lib/rack/builder.rb:51:in instance_eval' from /var/lib/gems/1.9.1/gems/rack-1.4.1/lib/rack/builder.rb:51:ininitialize'
from /home/mark/WORK/Ruby/Heroku/tempTest/config.ru:1:in new' from /home/mark/WORK/Ruby/Heroku/tempTest/config.ru:1:in'
from /var/lib/gems/1.9.1/gems/rack-1.4.1/lib/rack/builder.rb:40:in eval' from /var/lib/gems/1.9.1/gems/rack-1.4.1/lib/rack/builder.rb:40:inparse_file'
from /var/lib/gems/1.9.1/gems/rack-1.4.1/lib/rack/server.rb:200:in app' from /var/lib/gems/1.9.1/gems/railties-3.2.3/lib/rails/commands/server.rb:46:inapp'
from /var/lib/gems/1.9.1/gems/rack-1.4.1/lib/rack/server.rb:301:in wrapped_app' from /var/lib/gems/1.9.1/gems/rack-1.4.1/lib/rack/server.rb:252:instart'
from /var/lib/gems/1.9.1/gems/railties-3.2.3/lib/rails/commands/server.rb:70:in start' from /var/lib/gems/1.9.1/gems/railties-3.2.3/lib/rails/commands.rb:55:inblock in <top (required)>'
from /var/lib/gems/1.9.1/gems/railties-3.2.3/lib/rails/commands.rb:50:in tap' from /var/lib/gems/1.9.1/gems/railties-3.2.3/lib/rails/commands.rb:50:in<top (required)>'
from script/rails:6:in require' from script/rails:6:in'

Is the ActiveSupport::Logger backwards compatible?

[joshnesbitt]

Wondering if you have to require it? It worked for me in a Rails 4 app, although I'm not sure if it's a backwards compatible change. Maybe make it into a Rails 4 branch?

[mhenrixon]

@joshnesbitt what do you mean it doesn't work? Is it that error you suggested in the link?

[joshnesbitt]

@mhenrixon it seems that it was an issue with the Logger being scoped incorrectly.

[bf4]

Close as invalid