Skip to content

Adding nx-cugraph to RAPIDS Install Selector Tool - #536

Merged
bdice merged 13 commits into
rapidsai:mainfrom
nv-rliu:add-nx-cugraph-to-install-selector
Sep 23, 2024
Merged

Adding nx-cugraph to RAPIDS Install Selector Tool#536
bdice merged 13 commits into
rapidsai:mainfrom
nv-rliu:add-nx-cugraph-to-install-selector

Conversation

@nv-rliu

@nv-rliu nv-rliu commented Sep 3, 2024

Copy link
Copy Markdown
Contributor

Closes https://github.com/rapidsai/graph_dl/issues/604 & closes https://github.com/rapidsai/graph_dl/issues/609

In preparation for its stable release, this PR adds NetworkX + nx-cugraph as an option to the RAPIDS Install Selector Tool > Additional Packages.

Proposed changes:

  • There note also mentions that nx-cugraph is part of the Standard RAPIDS metapackage.
  • Users now have the option to install NetworkX + nx-cugraph via the "Additional Packages" list when installing via conda

image

  • nx-cugraph will be included in the Standard pip installation

image

Notes for Reviewers

  • The additional packages list is now sorted alphabetically (this can be reverted as necessary).
  • When a user clicks "NetworkX + nx-cugraph", this only impacts the conda install option. This adds networkx nx-cugraph to the install command.

@nv-rliu
nv-rliu requested a review from a team as a code owner September 3, 2024 20:59
@netlify

netlify Bot commented Sep 3, 2024

Copy link
Copy Markdown

Deploy Preview for docs-rapids-ai ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9bcbfe6
🔍 Latest deploy log https://app.netlify.com/sites/docs-rapids-ai/deploys/66eb2014a6a96900083e053f
😎 Deploy Preview https://deploy-preview-536--docs-rapids-ai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nv-rliu
nv-rliu marked this pull request as draft September 4, 2024 19:27
@nv-rliu
nv-rliu marked this pull request as ready for review September 4, 2024 19:52

@bdice bdice left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have historically been very cautious about adding buttons to this list. We have far more packages in RAPIDS than we have room to list (we don't show RMM, KvikIO, ...). I would propose editing the cuGraph button to say cuGraph / nx-cugraph if that is a sufficient solution. You can see how we handle that logic for cuSpatial/cuProj here:

if (pkgs.includes("cuSpatial/cuProj")) {
pkgs = pkgs.filter(pkg => pkg !== "cuSpatial/cuProj");
pkgs.push("cuSpatial");
pkgs.push("cuProj");
}

@nv-rliu

nv-rliu commented Sep 6, 2024

Copy link
Copy Markdown
Contributor Author

Thanks @bdice I'll make those changes and push and update shortly

@rlratzel

rlratzel commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

I would propose editing the cuGraph button to say cuGraph / nx-cugraph if that is a sufficient solution.

We discussed that, but decided that might not be desired since installing cugraph with nx-cugraph brings along a lot of extra dependencies that nx-cugraph does not use and users may not want (dask, cudf, etc.).

nx-cugraph is not in the RAPIDS meta-package at the moment either, so we're planning on adding it there too. That will help and seems correct for a RAPIDS install, but it's not as noticeable as a dedicated button and doesn't help users that just want Accelerated NetworkX.

@bdice if nx-cugraph isn't button-worthy, is there an alternative we can discuss?

@rlratzel

rlratzel commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

@bdice if nx-cugraph isn't button-worthy, is there an alternative we can discuss?

cc @beckernick for any additional suggestions.

@bdice

bdice commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

We could revisit the entire UX of the package selector. Maybe there’s a multi-row interface or something that uses a list with checkboxes that would still be visually appealing and provide more flexibility.

@bdice

bdice commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

Also, I don’t want to be a deciding voice here against adding a button. I just raise that concern because we have hesitated on similar changes in the past.

@rlratzel

Copy link
Copy Markdown
Contributor

Discussed offline with @bdice @beckernick @nv-rliu @aravenel @quasiben and decided that the best option would be to add a button to "Additional Packages" named "NetworkX + nx-cugraph" (or just "NetworkX" with a pop-up note indicating nx-cugraph is installed too?) which installs NetworkX and nx-cugraph.

@nv-rliu
nv-rliu requested a review from bdice September 12, 2024 19:56
Comment thread _includes/selector.html Outdated
Comment thread _includes/selector.html Outdated
Comment thread _includes/selector.html Outdated
Comment thread _includes/selector.html Outdated
Comment thread _includes/selector.html Outdated
nv-rliu and others added 3 commits September 18, 2024 12:49
@nv-rliu
nv-rliu requested review from bdice and rlratzel September 18, 2024 17:12

@rlratzel rlratzel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment thread _includes/selector.html Outdated
Comment thread _includes/selector.html
Co-authored-by: Bradley Dice <bdice@bradleydice.com>

@bdice bdice left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s merge this. But it is missing a key feature: people who select “pip” and choose specific packages do not have an option to pick nx-cugraph.

@nv-rliu

nv-rliu commented Sep 23, 2024

Copy link
Copy Markdown
Contributor Author

Let’s merge this. But it is missing a key feature: people who select “pip” and choose specific packages do not have an option to pick nx-cugraph.

@bdice Do you think that I could add an "Additional Packages" bar for pip installation?

PS. Is there a reason why this isn't included for pip when it was added to conda?

@bdice

bdice commented Sep 23, 2024

Copy link
Copy Markdown
Contributor

We've just never implemented a pip "additional packages". I think we could open discussion for that with the team internally and decide how to proceed. In the short term we probably only need a solution for adding nx-cugraph.

@bdice
bdice merged commit 242f7a6 into rapidsai:main Sep 23, 2024
@nv-rliu
nv-rliu deleted the add-nx-cugraph-to-install-selector branch September 23, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants