Skip to content

added uploading dataset and drag & drop support - #317

Open
AjayThorve wants to merge 39 commits into
rapidsai:mainfrom
AjayThorve:demo/viz-app/improvements
Open

added uploading dataset and drag & drop support#317
AjayThorve wants to merge 39 commits into
rapidsai:mainfrom
AjayThorve:demo/viz-app/improvements

Conversation

@AjayThorve

@AjayThorveAjayThorve commented Oct 18, 2021

Copy link
Copy Markdown
Member

Demo is in working condition (can drag/drop datasets and generate graph viz) with a switch to start forceatlas2 rendering.

pendng is get/post pagify plugin for downloading queried datasets(currently sending via simple peer channels.

Edit: Implemented pagify plugin for downloading queried datasets

@AjayThorve
AjayThorveforce-pushed the demo/viz-app/improvements branch from 0620845 to d126f34CompareOctober 18, 2021 17:38
@AjayThorve
AjayThorve marked this pull request as ready for review October 19, 2021 00:13
@AjayThorveAjayThorve changed the title [draft] added uploading dataset and drag & drop support added uploading dataset and drag & drop supportOct 19, 2021

@matekdevmatekdev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just looked through the Front-end stuff

Comment threadmodules/demo/viz-app/components/demo-dashboard/slide-menu/slide-menu.jsx Outdated
Comment threadmodules/demo/viz-app/pages/demo/graph.jsx Outdated
Comment threadmodules/demo/viz-app/pages/demo/graph.jsx Outdated
Comment threadmodules/demo/ssr/graph/plugins/api/index.js Outdated
Comment threadmodules/demo/ssr/graph/plugins/api/index.js Outdated
Comment threadmodules/demo/ssr/graph/plugins/api/index.js Outdated
Comment threadmodules/demo/ssr/graph/plugins/api/index.js Outdated
Comment threadmodules/demo/ssr/graph/plugins/api/index.js Outdated

@trxcllnttrxcllnt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. I think the names for the new routes need to be revisited to align with REST and CRUD principles.

Comment threadmodules/demo/ssr/graph/plugins/api/index.js Outdated
Comment threadmodules/demo/ssr/graph/plugins/api/index.js Outdated
Comment threadmodules/demo/ssr/graph/plugins/graph/index.js Outdated
Comment threadmodules/demo/ssr/graph/plugins/graph/index.js Outdated
Comment threadmodules/demo/ssr/graph/public/video.html Outdated
Comment threadmodules/demo/ssr/graph/plugins/api/index.js Outdated
Comment threadmodules/demo/ssr/graph/plugins/api/index.js Outdated
Comment threadmodules/demo/ssr/graph/plugins/api/index.js Outdated
Comment threadmodules/demo/ssr/graph/package.json Outdated
@AjayThorve

Copy link
Copy Markdown
MemberAuthor

@trxcllnt this is ready for review. Resolved most of the issues you mentioned.

Still pending is better user session tracking, which I'll push out in a follow-up PR

Comment threadmodules/demo/viz-app/pages/demo/graph.jsx
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@AjayThorve@trxcllnt@matekdev