Skip to content

Use configFile option, support an additional repo deploy key - #175

Merged
vyasr merged 21 commits into
branch-24.04from
fix/devcontainer-json-location
Mar 8, 2024
Merged

Use configFile option, support an additional repo deploy key#175
vyasr merged 21 commits into
branch-24.04from
fix/devcontainer-json-location

Conversation

@trxcllnt

Copy link
Copy Markdown
Contributor
  • Make build-in-devcontainer action use the new configFile option
  • Support an additional extra-repo-deploy-key in build-in-devcontainer action

Both of these changes are necessary to build all the RAPIDS projects in rapidsai/devcontainers CI jobs.

@trxcllnt

Copy link
Copy Markdown
ContributorAuthor

The devcontainers builds in NVIDIA/cuml#5760 passes, so I think this change is safe.

@trxcllnt
trxcllnt requested review from bdice and vyasrFebruary 7, 2024 06:44
Comment thread.github/workflows/build-in-devcontainer.yaml Outdated
@trxcllnt
trxcllnt requested a review from bdiceFebruary 9, 2024 17:59

@vyasrvyasr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question but looks good.

Comment thread.github/workflows/build-in-devcontainer.yaml
@trxcllnt

Copy link
Copy Markdown
ContributorAuthor

@bdice@vyasr All the PRs that depend on this branch have been merged, so I'm going to merge this into branch-24.04.

@trxcllnt

Copy link
Copy Markdown
ContributorAuthor

/merge

@vyasr
vyasr merged commit 1f460ea into branch-24.04Mar 8, 2024
@bdice
bdice deleted the fix/devcontainer-json-location branch May 19, 2026 14:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@trxcllnt@vyasr@bdice