Uh oh!
There was an error while loading. Please reload this page.
Changed wheel_type to package_type - #321
Conversation
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
jameslamb
left a comment
There was a problem hiding this comment.
Thanks for considering this! I left one request.
By the way, I noticed this PR has 33 commits in it: https://github.com/rapidsai/shared-workflows/pull/321/commits
I strongly suspect you're re-using a branch from a different PR. We squash all commits down into 1 on merge in this repo (and most RAPIDS repos), which is why git / GitHub are showing that you have 33 commits not on the target branch.
For the future, I recommend getting in the habit of updating your local checkout of the target branch and creating a clean new PR branch from that. Here's how I do that:
# just done one time at setup of my dev environment
git remote add upstream git@github.com:rapidsai/shared-workflows.git
# when I start a new PR
git checkout branch-25.04
git pull upstream branch-25.04
git checkout -b some-pr-branchUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jameslamb
left a comment
There was a problem hiding this comment.
Thanks for considering my suggestions, looks good to me.
Changing the input parameter wheel_type to package_type for standardized usage across shared workflows, as
wheels-publish.yamluses package-type for the same purpose.