Skip to content

fix pre-commit errors - #490

Merged
jameslamb merged 4 commits into
mainfrom
enforce-pre-commit
Jan 20, 2026
Merged

fix pre-commit errors#490
jameslamb merged 4 commits into
mainfrom
enforce-pre-commit

Conversation

@jameslamb

@jameslambjameslamb commented Jan 14, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Fixes#485

This fixes the remaining pre-commit errors on main, so we can start enforcing it on PR CI.

Happy to say actionlint caught a couple of issues in inline shell scripts here 😁

Notes for Reviewers

If this is approved, once it's merged I'll update the branch protections to make the pre-commit.ci workflow required to merge.

@jameslamb
jameslamb requested a review from a team as a code ownerJanuary 14, 2026 21:12
@jameslambjameslamb added the improvement Improves an existing functionality label Jan 14, 2026
@jameslamb
jameslamb requested review from bdice and removed request for a teamJanuary 14, 2026 21:12
@jameslambjameslamb added the non-breaking Introduces a non-breaking change label Jan 14, 2026
@jameslamb
jameslamb marked this pull request as draft January 14, 2026 21:13
@jameslambjameslamb changed the title enforce pre-commit checks in CIWIP: enforce pre-commit checks in CIJan 14, 2026
@jameslamb
jameslamb removed the request for review from bdiceJanuary 14, 2026 21:13
jameslamb
jameslamb commented Jan 14, 2026
View reviewed changes
Comment thread.github/workflows/pr.yaml Outdated
@jameslambjameslamb changed the title WIP: enforce pre-commit checks in CIWIP: fix pre-commit errorsJan 14, 2026
@jameslambjameslamb changed the title WIP: fix pre-commit errorsfix pre-commit errorsJan 14, 2026
@jameslamb
jameslamb marked this pull request as ready for review January 14, 2026 21:17
@jameslamb
jameslamb requested review from a team and msarahan and removed request for a teamJanuary 14, 2026 21:19
@jameslamb
jameslamb merged commit 40ff56d into mainJan 20, 2026
2 checks passed
@jameslamb
jameslamb deleted the enforce-pre-commit branch January 20, 2026 22:38
@jameslamb

jameslamb commented Jan 20, 2026

Copy link
Copy Markdown
MemberAuthor

Merges to main now require pre-commit.ci to pass 😁

image

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdicebdicebdice approved these changes
@msarahanmsarahanAwaiting requested review from msarahanmsarahan is a code owner automatically assigned from rapidsai/ci-codeowners

Assignees

No one assigned

Labels

improvementImproves an existing functionalitynon-breakingIntroduces a non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add 'zizmor' checks in CI

2 participants

@jameslamb@bdice