Uh oh!
There was an error while loading. Please reload this page.
Add UPGRADE.md for 2.0.0 - #10
Conversation
koriym
commented
Apr 9, 2026
@coderabbitai review |
Reviewer's GuideAdds a new UPGRADE.md document describing the breaking changes and migration steps for the upcoming 2.0.0 release, including PHP version requirements, migration from Doctrine annotations to PHP 8 attributes, and removal of certain DI bindings/dependencies. Sequence diagram for ACL interceptor behavior with PHP 8 attributessequenceDiagram
actor User
participant ClientCode
participant AdminController
participant AclInterceptor
User->>ClientCode: invoke createUser(id)
ClientCode->>AdminController: call createUser(id)
activate AclInterceptor
AdminController->>AclInterceptor: intercepted method call
alt Method has RequiresRoles attribute
AclInterceptor->>AdminController: read RequiresRoles attribute
AclInterceptor->>AclInterceptor: evaluate roles against ACL
alt Access allowed
AclInterceptor-->>AdminController: proceed with invocation
AdminController-->>ClientCode: createUser completed
else Access denied
AclInterceptor-->>ClientCode: throw access denied error
end
else Method has no RequiresRoles attribute
AclInterceptor-->>AdminController: proceed without ACL enforcement
AdminController-->>ClientCode: createUser completed
end
ClientCode-->>User: return response
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Actions performedReview triggered.
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 22 minutes and 58 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughAdds Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In the section about migrating from
@RequiresRolesto attributes, consider clarifying how mixed usage is handled (e.g., if both docblock annotations and attributes are present during a partial migration) to avoid ambiguity for users upgrading incrementally. - In the note about
ZendAclModuleno longer binding the various readers, it would help to include a short example of how to bindkoriym/attributes(ordoctrine/annotations) in a typical configuration so users have a concrete reference when adapting their setup.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments- In the section about migrating from `@RequiresRoles` to attributes, consider clarifying how mixed usage is handled (e.g., if both docblock annotations and attributes are present during a partial migration) to avoid ambiguity for users upgrading incrementally.
- In the note about `ZendAclModule` no longer binding the various readers, it would help to include a short example of how to bind `koriym/attributes` (or `doctrine/annotations`) in a typical configuration so users have a concrete reference when adapting their setup.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Uh oh!
There was an error while loading. Please reload this page.
Summary
Add
UPGRADE.mddocumenting the breaking changes for the upcoming 2.0.0 release.Breaking changes documented
@RequiresRolesno longer read — users must migrate to PHP 8 attribute#[RequiresRoles([...])]ZendAclModuleno longer bindsReader/AnnotationReader/AttributeReader/DualReaderTest plan
Summary by Sourcery
Documentation:
Summary by CodeRabbit