Add TetraMeshData class to handle tetrahedral mesh data - #407

Closed
munechika-koyo wants to merge 20 commits into
raysect:masterfrom
munechika-koyo:feature/tetrahedra_mesh
Closed

Add TetraMeshData class to handle tetrahedral mesh data#407
munechika-koyo wants to merge 20 commits into
raysect:masterfrom
munechika-koyo:feature/tetrahedra_mesh

Conversation

@munechika-koyo

@munechika-koyomunechika-koyo commented Jul 25, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Hi,

I would like to propose this PR to introduce new class TetraMesh which is defined reffering to raysect.primitive.mesh.MeshData.
When constructing a kD tree for tetrahedral meshes, MeshKDTree3D class in raysect.core.math.function.float.function3d.interpolate.common module was used, and I need more general way of handling tetrahedral vertices or indices.
So, I decided to add some mesh-handling methods and put it into raysect.primitive module.
According to this modification, I improved some implementations and documents.

In addition, Tetmesh in external package used in demo scripts: Py3DViewer does not work well because of incompatible with version (I guess.), so I changed to use numpy.load method to load tetrahedral vertices and indices arrays.

I would appreciate it if you would confirm my PR and marge it into develop branch:)

@CnlPepper

CnlPepper commented Sep 15, 2022•
edited
Loading

Copy link
Copy Markdown
Member

I'm a little unsure how a tetrahedral mesh fits in the primitive module? Primitives are meant to define a surface that may or may not enclose a volume. A tetrahedral mesh doesn't just represent a surface alone. We'd need to think about where this should live, or if the primitive definition should be extended.

I've unfortunately not got much time to look through this at present as it is a large merge request. I will make one quick comment: the tetra mesh bunny file is a bit large! A simpler mesh would be sufficient for a demo.

@munechika-koyo

munechika-koyo commented Sep 15, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

As @CnlPepper mentioned, TetraMesh is not actual primitive objects. I think it is similar to the MeshData definition (actually I imitated it to implement TetraMesh)

the tetra mesh bunny file is a bit large! A simpler mesh would be sufficient for a demo.

I removed .mesh file due to the out of use. The numpy binary files (.npy) I added have smaller size (totally 30MB) than the .mesh file (45.9MB).

@munechika-koyomunechika-koyo changed the title Add TetraMesh class to handle tetrahedral meshAdd TetraMeshData class to handle tetrahedral mesh dataDec 18, 2023
@munechika-koyo

munechika-koyo commented Dec 18, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

the tetra mesh bunny file is a bit large! A simpler mesh would be sufficient for a demo.

I compressed mesh data in a .npz format, including both the tetra mesh's vertices and indices.
This file has a size of about 12MB. What do you think about this change?

I'm a little unsure how a tetrahedral mesh fits in the primitive module.

As you mentioned, I think the name TetraMesh should be changed to TetraMeshData because the previous one is not inherited from the Primitive object as well.
I want to push this PR to implement the functionality to save/load the tetrahedral mesh structure generated by the kd-tree core like the MeshData.save or MeshData.load because it takes more time to re-generate a tetrahedral kD-tree structure than load it from a .rsm file

I would appreciate it if you would take it into account.

Koyo Munechika added 19 commits January 12, 2025 17:07
Koyo Munechika@munechika-koyo
create TetraMesh class in primitive.mesh module
54ca0e0
Koyo Munechika@munechika-koyo
fix typo and apply TetraMesh to discrete3DMesh
dbf4206
Koyo Munechika@munechika-koyo
rename attribute's name and fix tetra width as 4
bcb2507
Koyo Munechika@munechika-koyo
create from_mesh method with Discreate3DMesh class
2cc0ea7
Koyo Munechika@munechika-koyo
[fix] struct format in saving
364b21a
Koyo Munechika@munechika-koyo
[fix] error about circular reference
ef73bd6
Koyo Munechika@munechika-koyo
[add] bounding_box method to TetraMesh
ad97cb8
Koyo Munechika@munechika-koyo
[fix] demo of tetrahedra mesh to use TetraMesh
2434493
Koyo Munechika@munechika-koyo
[update] demo script for tetrahedra mesh emission
b96b24f
Koyo Munechika@munechika-koyo
[update] document and docstrings of TetraMesh
cd91ae0
Koyo Munechika@munechika-koyo
[fix] docstings types
9c3160a
Koyo Munechika@munechika-koyo
[fix] use cls variable in classmethod
dad8fb8
use cls variables to generate instance from class.
Koyo Munechika@munechika-koyo
[update] to use cls paramter in classmethod
e38b3fa
Koyo Munechika@munechika-koyo
[delete] stanford_bunny.mesh is out of use
917a154
Koyo Munechika@munechika-koyo
✨ Add a method to calculate a barycenter of tetra
fca4e0a
Koyo Munechika@munechika-koyo
🚑 fix cython compile error
2d0181e
The latest Cython caused compile error at `kdtree2d.pyx` and `kdtree3d.pyx`
munechika-koyo@munechika-koyo
🚚 Replace .npy files to .npz file
5006721
munechika-koyo@munechika-koyo
Update TetraMesh to TetraMeshData
cbe36c9
I noticed that priviouse `TetraMesh` was derived from `MeshData` so I should rename it to not confuse it with primitive object as well
munechika-koyo@munechika-koyo
Update tetrahedra mesh demo script to follow TetraMeshData
819737a
@munechika-koyo
munechika-koyo changed the base branch from development to masterJanuary 12, 2025 18:38
@munechika-koyo

munechika-koyo commented Jan 13, 2025

Copy link
Copy Markdown
ContributorAuthor

I would like to revisit this pull request to enhance the handling of tetrahedral meshes.
I also applied the latest change in the master branch into this PR by rebasing.

@munechika-koyo

munechika-koyo commented Feb 15, 2025

Copy link
Copy Markdown
ContributorAuthor

I think that this PR contains many changes, making the review challenging, so I will separate features and propose each of them again.

@munechika-koyomunechika-koyo mentioned this pull request Feb 15, 2025
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@munechika-koyo@CnlPepper
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Add TetraMeshData class to handle tetrahedral mesh data - #407
Closed
munechika-koyo wants to merge 20 commits into
raysect:masterfrom 
munechika-koyo:feature/tetrahedra_mesh
Closed
Add TetraMeshData class to handle tetrahedral mesh data#407
munechika-koyo wants to merge 20 commits into
raysect:masterfrom 
munechika-koyo:feature/tetrahedra_mesh
Conversation
@munechika-koyo
@munechika-koyomunechika-koyo
commented
Jul 25, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Hi,
I would like to propose this PR to introduce new class TetraMesh which is defined reffering to raysect.primitive.mesh.MeshData.

When constructing a kD tree for tetrahedral meshes, MeshKDTree3D class in raysect.core.math.function.float.function3d.interpolate.common module was used, and I need more general way of handling tetrahedral vertices or indices.

So, I decided to add some mesh-handling methods and put it into raysect.primitive module.

According to this modification, I improved some implementations and documents.
In addition, Tetmesh in external package used in demo scripts: Py3DViewer does not work well because of incompatible with version (I guess.), so I changed to use numpy.load method to load tetrahedral vertices and indices arrays.
I would appreciate it if you would confirm my PR and marge it into develop branch:)
@CnlPepper
CnlPepper
commented
Sep 15, 2022•

edited

Loading

Copy link


Copy Markdown

Member
I'm a little unsure how a tetrahedral mesh fits in the primitive module? Primitives are meant to define a surface that may or may not enclose a volume. A tetrahedral mesh doesn't just represent a surface alone. We'd need to think about where this should live, or if the primitive definition should be extended.
I've unfortunately not got much time to look through this at present as it is a large merge request. I will make one quick comment: the tetra mesh bunny file is a bit large! A simpler mesh would be sufficient for a demo.
@munechika-koyo
munechika-koyo
commented
Sep 15, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
As @CnlPepper mentioned, TetraMesh is not actual primitive objects. I think it is similar to the MeshData definition (actually I imitated it to implement TetraMesh)
the tetra mesh bunny file is a bit large! A simpler mesh would be sufficient for a demo.
I removed .mesh file due to the out of use. The numpy binary files (.npy) I added have smaller size (totally 30MB) than the .mesh file (45.9MB).
@munechika-koyomunechika-koyo
changed the title
Add TetraMesh class to handle tetrahedral meshAdd TetraMeshData class to handle tetrahedral mesh dataDec 18, 2023
@munechika-koyo
munechika-koyo
commented
Dec 18, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
the tetra mesh bunny file is a bit large! A simpler mesh would be sufficient for a demo.
I compressed mesh data in a .npz format, including both the tetra mesh's vertices and indices.

This file has a size of about 12MB. What do you think about this change?
I'm a little unsure how a tetrahedral mesh fits in the primitive module.
As you mentioned, I think the name TetraMesh should be changed to TetraMeshData because the previous one is not inherited from the Primitive object as well.

I want to push this PR to implement the functionality to save/load the tetrahedral mesh structure generated by the kd-tree core like the MeshData.save or MeshData.load because it takes more time to re-generate a tetrahedral kD-tree structure than load it from a .rsm file
I would appreciate it if you would take it into account.
Koyo Munechika
added 19 commits
January 12, 2025 17:07
Koyo Munechika@munechika-koyo
create TetraMesh class in primitive.mesh module
54ca0e0
Koyo Munechika@munechika-koyo
fix typo and apply TetraMesh to discrete3DMesh
dbf4206
Koyo Munechika@munechika-koyo
rename attribute's name and fix tetra width as 4
bcb2507
Koyo Munechika@munechika-koyo
create from_mesh method with Discreate3DMesh class
2cc0ea7
Koyo Munechika@munechika-koyo
[fix] struct format in saving
364b21a
Koyo Munechika@munechika-koyo
[fix] error about circular reference
ef73bd6
Koyo Munechika@munechika-koyo
[add] bounding_box method to TetraMesh
ad97cb8
Koyo Munechika@munechika-koyo
[fix] demo of tetrahedra mesh to use TetraMesh
2434493
Koyo Munechika@munechika-koyo
[update] demo script for tetrahedra mesh emission
b96b24f
Koyo Munechika@munechika-koyo
[update] document and docstrings of TetraMesh
cd91ae0
Koyo Munechika@munechika-koyo
[fix] docstings types
9c3160a
Koyo Munechika@munechika-koyo
[fix] use cls variable in classmethod
dad8fb8
use cls variables to generate instance from class.
Koyo Munechika@munechika-koyo
[update] to use cls paramter in classmethod
e38b3fa
Koyo Munechika@munechika-koyo
[delete] stanford_bunny.mesh is out of use
917a154
Koyo Munechika@munechika-koyo
✨ Add a method to calculate a barycenter of tetra
fca4e0a
Koyo Munechika@munechika-koyo
🚑 fix cython compile error
2d0181e
The latest Cython caused compile error at `kdtree2d.pyx` and `kdtree3d.pyx`
munechika-koyo@munechika-koyo
🚚 Replace .npy files to .npz file
5006721
munechika-koyo@munechika-koyo
Update TetraMesh to TetraMeshData
cbe36c9
I noticed that priviouse `TetraMesh` was derived from `MeshData` so I should rename it to not confuse it with primitive object as well
munechika-koyo@munechika-koyo
Update tetrahedra mesh demo script to follow TetraMeshData
819737a
@munechika-koyo
munechika-koyo
changed the base branch from
development
to
masterJanuary 12, 2025 18:38
@munechika-koyo
munechika-koyo
commented
Jan 13, 2025

Copy link


Copy Markdown

ContributorAuthor
I would like to revisit this pull request to enhance the handling of tetrahedral meshes.

I also applied the latest change in the master branch into this PR by rebasing.
@munechika-koyo
munechika-koyo
commented
Feb 15, 2025

Copy link


Copy Markdown

ContributorAuthor
I think that this PR contains many changes, making the review challenging, so I will separate features and propose each of them again.
@munechika-koyomunechika-koyo
mentioned this pull request
Feb 15, 2025
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@munechika-koyo@CnlPepper

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add TetraMeshData class to handle tetrahedral mesh data - #407
Closed
munechika-koyo wants to merge 20 commits into
raysect:masterfrom 
munechika-koyo:feature/tetrahedra_mesh
Closed
Add TetraMeshData class to handle tetrahedral mesh data#407
munechika-koyo wants to merge 20 commits into
raysect:masterfrom 
munechika-koyo:feature/tetrahedra_mesh
Conversation
@munechika-koyo
@munechika-koyomunechika-koyo
commented
Jul 25, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Hi,
I would like to propose this PR to introduce new class TetraMesh which is defined reffering to raysect.primitive.mesh.MeshData.

When constructing a kD tree for tetrahedral meshes, MeshKDTree3D class in raysect.core.math.function.float.function3d.interpolate.common module was used, and I need more general way of handling tetrahedral vertices or indices.

So, I decided to add some mesh-handling methods and put it into raysect.primitive module.

According to this modification, I improved some implementations and documents.
In addition, Tetmesh in external package used in demo scripts: Py3DViewer does not work well because of incompatible with version (I guess.), so I changed to use numpy.load method to load tetrahedral vertices and indices arrays.
I would appreciate it if you would confirm my PR and marge it into develop branch:)
@CnlPepper
CnlPepper
commented
Sep 15, 2022•

edited

Loading

Copy link


Copy Markdown

Member
I'm a little unsure how a tetrahedral mesh fits in the primitive module? Primitives are meant to define a surface that may or may not enclose a volume. A tetrahedral mesh doesn't just represent a surface alone. We'd need to think about where this should live, or if the primitive definition should be extended.
I've unfortunately not got much time to look through this at present as it is a large merge request. I will make one quick comment: the tetra mesh bunny file is a bit large! A simpler mesh would be sufficient for a demo.
@munechika-koyo
munechika-koyo
commented
Sep 15, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
As @CnlPepper mentioned, TetraMesh is not actual primitive objects. I think it is similar to the MeshData definition (actually I imitated it to implement TetraMesh)
the tetra mesh bunny file is a bit large! A simpler mesh would be sufficient for a demo.
I removed .mesh file due to the out of use. The numpy binary files (.npy) I added have smaller size (totally 30MB) than the .mesh file (45.9MB).
@munechika-koyomunechika-koyo
changed the title
Add TetraMesh class to handle tetrahedral meshAdd TetraMeshData class to handle tetrahedral mesh dataDec 18, 2023
@munechika-koyo
munechika-koyo
commented
Dec 18, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
the tetra mesh bunny file is a bit large! A simpler mesh would be sufficient for a demo.
I compressed mesh data in a .npz format, including both the tetra mesh's vertices and indices.

This file has a size of about 12MB. What do you think about this change?
I'm a little unsure how a tetrahedral mesh fits in the primitive module.
As you mentioned, I think the name TetraMesh should be changed to TetraMeshData because the previous one is not inherited from the Primitive object as well.

I want to push this PR to implement the functionality to save/load the tetrahedral mesh structure generated by the kd-tree core like the MeshData.save or MeshData.load because it takes more time to re-generate a tetrahedral kD-tree structure than load it from a .rsm file
I would appreciate it if you would take it into account.
Koyo Munechika
added 19 commits
January 12, 2025 17:07
Koyo Munechika@munechika-koyo
create TetraMesh class in primitive.mesh module
54ca0e0
Koyo Munechika@munechika-koyo
fix typo and apply TetraMesh to discrete3DMesh
dbf4206
Koyo Munechika@munechika-koyo
rename attribute's name and fix tetra width as 4
bcb2507
Koyo Munechika@munechika-koyo
create from_mesh method with Discreate3DMesh class
2cc0ea7
Koyo Munechika@munechika-koyo
[fix] struct format in saving
364b21a
Koyo Munechika@munechika-koyo
[fix] error about circular reference
ef73bd6
Koyo Munechika@munechika-koyo
[add] bounding_box method to TetraMesh
ad97cb8
Koyo Munechika@munechika-koyo
[fix] demo of tetrahedra mesh to use TetraMesh
2434493
Koyo Munechika@munechika-koyo
[update] demo script for tetrahedra mesh emission
b96b24f
Koyo Munechika@munechika-koyo
[update] document and docstrings of TetraMesh
cd91ae0
Koyo Munechika@munechika-koyo
[fix] docstings types
9c3160a
Koyo Munechika@munechika-koyo
[fix] use cls variable in classmethod
dad8fb8
use cls variables to generate instance from class.
Koyo Munechika@munechika-koyo
[update] to use cls paramter in classmethod
e38b3fa
Koyo Munechika@munechika-koyo
[delete] stanford_bunny.mesh is out of use
917a154
Koyo Munechika@munechika-koyo
✨ Add a method to calculate a barycenter of tetra
fca4e0a
Koyo Munechika@munechika-koyo
🚑 fix cython compile error
2d0181e
The latest Cython caused compile error at `kdtree2d.pyx` and `kdtree3d.pyx`
munechika-koyo@munechika-koyo
🚚 Replace .npy files to .npz file
5006721
munechika-koyo@munechika-koyo
Update TetraMesh to TetraMeshData
cbe36c9
I noticed that priviouse `TetraMesh` was derived from `MeshData` so I should rename it to not confuse it with primitive object as well
munechika-koyo@munechika-koyo
Update tetrahedra mesh demo script to follow TetraMeshData
819737a
@munechika-koyo
munechika-koyo
changed the base branch from
development
to
masterJanuary 12, 2025 18:38
@munechika-koyo
munechika-koyo
commented
Jan 13, 2025

Copy link


Copy Markdown

ContributorAuthor
I would like to revisit this pull request to enhance the handling of tetrahedral meshes.

I also applied the latest change in the master branch into this PR by rebasing.
@munechika-koyo
munechika-koyo
commented
Feb 15, 2025

Copy link


Copy Markdown

ContributorAuthor
I think that this PR contains many changes, making the review challenging, so I will separate features and propose each of them again.
@munechika-koyomunechika-koyo
mentioned this pull request
Feb 15, 2025
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@munechika-koyo@CnlPepper

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add TetraMeshData class to handle tetrahedral mesh data - #407
Closed
munechika-koyo wants to merge 20 commits into
raysect:masterfrom 
munechika-koyo:feature/tetrahedra_mesh
Closed
Add TetraMeshData class to handle tetrahedral mesh data#407
munechika-koyo wants to merge 20 commits into
raysect:masterfrom 
munechika-koyo:feature/tetrahedra_mesh
Conversation
@munechika-koyo
@munechika-koyomunechika-koyo
commented
Jul 25, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Hi,
I would like to propose this PR to introduce new class TetraMesh which is defined reffering to raysect.primitive.mesh.MeshData.

When constructing a kD tree for tetrahedral meshes, MeshKDTree3D class in raysect.core.math.function.float.function3d.interpolate.common module was used, and I need more general way of handling tetrahedral vertices or indices.

So, I decided to add some mesh-handling methods and put it into raysect.primitive module.

According to this modification, I improved some implementations and documents.
In addition, Tetmesh in external package used in demo scripts: Py3DViewer does not work well because of incompatible with version (I guess.), so I changed to use numpy.load method to load tetrahedral vertices and indices arrays.
I would appreciate it if you would confirm my PR and marge it into develop branch:)
@CnlPepper
CnlPepper
commented
Sep 15, 2022•

edited

Loading

Copy link


Copy Markdown

Member
I'm a little unsure how a tetrahedral mesh fits in the primitive module? Primitives are meant to define a surface that may or may not enclose a volume. A tetrahedral mesh doesn't just represent a surface alone. We'd need to think about where this should live, or if the primitive definition should be extended.
I've unfortunately not got much time to look through this at present as it is a large merge request. I will make one quick comment: the tetra mesh bunny file is a bit large! A simpler mesh would be sufficient for a demo.
@munechika-koyo
munechika-koyo
commented
Sep 15, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
As @CnlPepper mentioned, TetraMesh is not actual primitive objects. I think it is similar to the MeshData definition (actually I imitated it to implement TetraMesh)
the tetra mesh bunny file is a bit large! A simpler mesh would be sufficient for a demo.
I removed .mesh file due to the out of use. The numpy binary files (.npy) I added have smaller size (totally 30MB) than the .mesh file (45.9MB).
@munechika-koyomunechika-koyo
changed the title
Add TetraMesh class to handle tetrahedral meshAdd TetraMeshData class to handle tetrahedral mesh dataDec 18, 2023
@munechika-koyo
munechika-koyo
commented
Dec 18, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
the tetra mesh bunny file is a bit large! A simpler mesh would be sufficient for a demo.
I compressed mesh data in a .npz format, including both the tetra mesh's vertices and indices.

This file has a size of about 12MB. What do you think about this change?
I'm a little unsure how a tetrahedral mesh fits in the primitive module.
As you mentioned, I think the name TetraMesh should be changed to TetraMeshData because the previous one is not inherited from the Primitive object as well.

I want to push this PR to implement the functionality to save/load the tetrahedral mesh structure generated by the kd-tree core like the MeshData.save or MeshData.load because it takes more time to re-generate a tetrahedral kD-tree structure than load it from a .rsm file
I would appreciate it if you would take it into account.
Koyo Munechika
added 19 commits
January 12, 2025 17:07
Koyo Munechika@munechika-koyo
create TetraMesh class in primitive.mesh module
54ca0e0
Koyo Munechika@munechika-koyo
fix typo and apply TetraMesh to discrete3DMesh
dbf4206
Koyo Munechika@munechika-koyo
rename attribute's name and fix tetra width as 4
bcb2507
Koyo Munechika@munechika-koyo
create from_mesh method with Discreate3DMesh class
2cc0ea7
Koyo Munechika@munechika-koyo
[fix] struct format in saving
364b21a
Koyo Munechika@munechika-koyo
[fix] error about circular reference
ef73bd6
Koyo Munechika@munechika-koyo
[add] bounding_box method to TetraMesh
ad97cb8
Koyo Munechika@munechika-koyo
[fix] demo of tetrahedra mesh to use TetraMesh
2434493
Koyo Munechika@munechika-koyo
[update] demo script for tetrahedra mesh emission
b96b24f
Koyo Munechika@munechika-koyo
[update] document and docstrings of TetraMesh
cd91ae0
Koyo Munechika@munechika-koyo
[fix] docstings types
9c3160a
Koyo Munechika@munechika-koyo
[fix] use cls variable in classmethod
dad8fb8
use cls variables to generate instance from class.
Koyo Munechika@munechika-koyo
[update] to use cls paramter in classmethod
e38b3fa
Koyo Munechika@munechika-koyo
[delete] stanford_bunny.mesh is out of use
917a154
Koyo Munechika@munechika-koyo
✨ Add a method to calculate a barycenter of tetra
fca4e0a
Koyo Munechika@munechika-koyo
🚑 fix cython compile error
2d0181e
The latest Cython caused compile error at `kdtree2d.pyx` and `kdtree3d.pyx`
munechika-koyo@munechika-koyo
🚚 Replace .npy files to .npz file
5006721
munechika-koyo@munechika-koyo
Update TetraMesh to TetraMeshData
cbe36c9
I noticed that priviouse `TetraMesh` was derived from `MeshData` so I should rename it to not confuse it with primitive object as well
munechika-koyo@munechika-koyo
Update tetrahedra mesh demo script to follow TetraMeshData
819737a
@munechika-koyo
munechika-koyo
changed the base branch from
development
to
masterJanuary 12, 2025 18:38
@munechika-koyo
munechika-koyo
commented
Jan 13, 2025

Copy link


Copy Markdown

ContributorAuthor
I would like to revisit this pull request to enhance the handling of tetrahedral meshes.

I also applied the latest change in the master branch into this PR by rebasing.
@munechika-koyo
munechika-koyo
commented
Feb 15, 2025

Copy link


Copy Markdown

ContributorAuthor
I think that this PR contains many changes, making the review challenging, so I will separate features and propose each of them again.
@munechika-koyomunechika-koyo
mentioned this pull request
Feb 15, 2025
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@munechika-koyo@CnlPepper

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Add TetraMeshData class to handle tetrahedral mesh data - #407
Closed
munechika-koyo wants to merge 20 commits into
raysect:masterfrom 
munechika-koyo:feature/tetrahedra_mesh
Closed
Add TetraMeshData class to handle tetrahedral mesh data#407
munechika-koyo wants to merge 20 commits into
raysect:masterfrom 
munechika-koyo:feature/tetrahedra_mesh
Conversation
@munechika-koyo
@munechika-koyomunechika-koyo
commented
Jul 25, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Hi,
I would like to propose this PR to introduce new class TetraMesh which is defined reffering to raysect.primitive.mesh.MeshData.

When constructing a kD tree for tetrahedral meshes, MeshKDTree3D class in raysect.core.math.function.float.function3d.interpolate.common module was used, and I need more general way of handling tetrahedral vertices or indices.

So, I decided to add some mesh-handling methods and put it into raysect.primitive module.

According to this modification, I improved some implementations and documents.
In addition, Tetmesh in external package used in demo scripts: Py3DViewer does not work well because of incompatible with version (I guess.), so I changed to use numpy.load method to load tetrahedral vertices and indices arrays.
I would appreciate it if you would confirm my PR and marge it into develop branch:)
@CnlPepper
CnlPepper
commented
Sep 15, 2022•

edited

Loading

Copy link


Copy Markdown

Member
I'm a little unsure how a tetrahedral mesh fits in the primitive module? Primitives are meant to define a surface that may or may not enclose a volume. A tetrahedral mesh doesn't just represent a surface alone. We'd need to think about where this should live, or if the primitive definition should be extended.
I've unfortunately not got much time to look through this at present as it is a large merge request. I will make one quick comment: the tetra mesh bunny file is a bit large! A simpler mesh would be sufficient for a demo.
@munechika-koyo
munechika-koyo
commented
Sep 15, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
As @CnlPepper mentioned, TetraMesh is not actual primitive objects. I think it is similar to the MeshData definition (actually I imitated it to implement TetraMesh)
the tetra mesh bunny file is a bit large! A simpler mesh would be sufficient for a demo.
I removed .mesh file due to the out of use. The numpy binary files (.npy) I added have smaller size (totally 30MB) than the .mesh file (45.9MB).
@munechika-koyomunechika-koyo
changed the title
Add TetraMesh class to handle tetrahedral meshAdd TetraMeshData class to handle tetrahedral mesh dataDec 18, 2023
@munechika-koyo
munechika-koyo
commented
Dec 18, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
the tetra mesh bunny file is a bit large! A simpler mesh would be sufficient for a demo.
I compressed mesh data in a .npz format, including both the tetra mesh's vertices and indices.

This file has a size of about 12MB. What do you think about this change?
I'm a little unsure how a tetrahedral mesh fits in the primitive module.
As you mentioned, I think the name TetraMesh should be changed to TetraMeshData because the previous one is not inherited from the Primitive object as well.

I want to push this PR to implement the functionality to save/load the tetrahedral mesh structure generated by the kd-tree core like the MeshData.save or MeshData.load because it takes more time to re-generate a tetrahedral kD-tree structure than load it from a .rsm file
I would appreciate it if you would take it into account.
Koyo Munechika
added 19 commits
January 12, 2025 17:07
Koyo Munechika@munechika-koyo
create TetraMesh class in primitive.mesh module
54ca0e0
Koyo Munechika@munechika-koyo
fix typo and apply TetraMesh to discrete3DMesh
dbf4206
Koyo Munechika@munechika-koyo
rename attribute's name and fix tetra width as 4
bcb2507
Koyo Munechika@munechika-koyo
create from_mesh method with Discreate3DMesh class
2cc0ea7
Koyo Munechika@munechika-koyo
[fix] struct format in saving
364b21a
Koyo Munechika@munechika-koyo
[fix] error about circular reference
ef73bd6
Koyo Munechika@munechika-koyo
[add] bounding_box method to TetraMesh
ad97cb8
Koyo Munechika@munechika-koyo
[fix] demo of tetrahedra mesh to use TetraMesh
2434493
Koyo Munechika@munechika-koyo
[update] demo script for tetrahedra mesh emission
b96b24f
Koyo Munechika@munechika-koyo
[update] document and docstrings of TetraMesh
cd91ae0
Koyo Munechika@munechika-koyo
[fix] docstings types
9c3160a
Koyo Munechika@munechika-koyo
[fix] use cls variable in classmethod
dad8fb8
use cls variables to generate instance from class.
Koyo Munechika@munechika-koyo
[update] to use cls paramter in classmethod
e38b3fa
Koyo Munechika@munechika-koyo
[delete] stanford_bunny.mesh is out of use
917a154
Koyo Munechika@munechika-koyo
✨ Add a method to calculate a barycenter of tetra
fca4e0a
Koyo Munechika@munechika-koyo
🚑 fix cython compile error
2d0181e
The latest Cython caused compile error at `kdtree2d.pyx` and `kdtree3d.pyx`
munechika-koyo@munechika-koyo
🚚 Replace .npy files to .npz file
5006721
munechika-koyo@munechika-koyo
Update TetraMesh to TetraMeshData
cbe36c9
I noticed that priviouse `TetraMesh` was derived from `MeshData` so I should rename it to not confuse it with primitive object as well
munechika-koyo@munechika-koyo
Update tetrahedra mesh demo script to follow TetraMeshData
819737a
@munechika-koyo
munechika-koyo
changed the base branch from
development
to
masterJanuary 12, 2025 18:38
@munechika-koyo
munechika-koyo
commented
Jan 13, 2025

Copy link


Copy Markdown

ContributorAuthor
I would like to revisit this pull request to enhance the handling of tetrahedral meshes.

I also applied the latest change in the master branch into this PR by rebasing.
@munechika-koyo
munechika-koyo
commented
Feb 15, 2025

Copy link


Copy Markdown

ContributorAuthor
I think that this PR contains many changes, making the review challenging, so I will separate features and propose each of them again.
@munechika-koyomunechika-koyo
mentioned this pull request
Feb 15, 2025
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@munechika-koyo@CnlPepper

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add TetraMeshData class to handle tetrahedral mesh data - #407
Closed
munechika-koyo wants to merge 20 commits into
raysect:masterfrom 
munechika-koyo:feature/tetrahedra_mesh
Closed
Add TetraMeshData class to handle tetrahedral mesh data#407
munechika-koyo wants to merge 20 commits into
raysect:masterfrom 
munechika-koyo:feature/tetrahedra_mesh
Conversation
@munechika-koyo
@munechika-koyomunechika-koyo
commented
Jul 25, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Hi,
I would like to propose this PR to introduce new class TetraMesh which is defined reffering to raysect.primitive.mesh.MeshData.

When constructing a kD tree for tetrahedral meshes, MeshKDTree3D class in raysect.core.math.function.float.function3d.interpolate.common module was used, and I need more general way of handling tetrahedral vertices or indices.

So, I decided to add some mesh-handling methods and put it into raysect.primitive module.

According to this modification, I improved some implementations and documents.
In addition, Tetmesh in external package used in demo scripts: Py3DViewer does not work well because of incompatible with version (I guess.), so I changed to use numpy.load method to load tetrahedral vertices and indices arrays.
I would appreciate it if you would confirm my PR and marge it into develop branch:)
@CnlPepper
CnlPepper
commented
Sep 15, 2022•

edited

Loading

Copy link


Copy Markdown

Member
I'm a little unsure how a tetrahedral mesh fits in the primitive module? Primitives are meant to define a surface that may or may not enclose a volume. A tetrahedral mesh doesn't just represent a surface alone. We'd need to think about where this should live, or if the primitive definition should be extended.
I've unfortunately not got much time to look through this at present as it is a large merge request. I will make one quick comment: the tetra mesh bunny file is a bit large! A simpler mesh would be sufficient for a demo.
@munechika-koyo
munechika-koyo
commented
Sep 15, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
As @CnlPepper mentioned, TetraMesh is not actual primitive objects. I think it is similar to the MeshData definition (actually I imitated it to implement TetraMesh)
the tetra mesh bunny file is a bit large! A simpler mesh would be sufficient for a demo.
I removed .mesh file due to the out of use. The numpy binary files (.npy) I added have smaller size (totally 30MB) than the .mesh file (45.9MB).
@munechika-koyomunechika-koyo
changed the title
Add TetraMesh class to handle tetrahedral meshAdd TetraMeshData class to handle tetrahedral mesh dataDec 18, 2023
@munechika-koyo
munechika-koyo
commented
Dec 18, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
the tetra mesh bunny file is a bit large! A simpler mesh would be sufficient for a demo.
I compressed mesh data in a .npz format, including both the tetra mesh's vertices and indices.

This file has a size of about 12MB. What do you think about this change?
I'm a little unsure how a tetrahedral mesh fits in the primitive module.
As you mentioned, I think the name TetraMesh should be changed to TetraMeshData because the previous one is not inherited from the Primitive object as well.

I want to push this PR to implement the functionality to save/load the tetrahedral mesh structure generated by the kd-tree core like the MeshData.save or MeshData.load because it takes more time to re-generate a tetrahedral kD-tree structure than load it from a .rsm file
I would appreciate it if you would take it into account.
Koyo Munechika
added 19 commits
January 12, 2025 17:07
Koyo Munechika@munechika-koyo
create TetraMesh class in primitive.mesh module
54ca0e0
Koyo Munechika@munechika-koyo
fix typo and apply TetraMesh to discrete3DMesh
dbf4206
Koyo Munechika@munechika-koyo
rename attribute's name and fix tetra width as 4
bcb2507
Koyo Munechika@munechika-koyo
create from_mesh method with Discreate3DMesh class
2cc0ea7
Koyo Munechika@munechika-koyo
[fix] struct format in saving
364b21a
Koyo Munechika@munechika-koyo
[fix] error about circular reference
ef73bd6
Koyo Munechika@munechika-koyo
[add] bounding_box method to TetraMesh
ad97cb8
Koyo Munechika@munechika-koyo
[fix] demo of tetrahedra mesh to use TetraMesh
2434493
Koyo Munechika@munechika-koyo
[update] demo script for tetrahedra mesh emission
b96b24f
Koyo Munechika@munechika-koyo
[update] document and docstrings of TetraMesh
cd91ae0
Koyo Munechika@munechika-koyo
[fix] docstings types
9c3160a
Koyo Munechika@munechika-koyo
[fix] use cls variable in classmethod
dad8fb8
use cls variables to generate instance from class.
Koyo Munechika@munechika-koyo
[update] to use cls paramter in classmethod
e38b3fa
Koyo Munechika@munechika-koyo
[delete] stanford_bunny.mesh is out of use
917a154
Koyo Munechika@munechika-koyo
✨ Add a method to calculate a barycenter of tetra
fca4e0a
Koyo Munechika@munechika-koyo
🚑 fix cython compile error
2d0181e
The latest Cython caused compile error at `kdtree2d.pyx` and `kdtree3d.pyx`
munechika-koyo@munechika-koyo
🚚 Replace .npy files to .npz file
5006721
munechika-koyo@munechika-koyo
Update TetraMesh to TetraMeshData
cbe36c9
I noticed that priviouse `TetraMesh` was derived from `MeshData` so I should rename it to not confuse it with primitive object as well
munechika-koyo@munechika-koyo
Update tetrahedra mesh demo script to follow TetraMeshData
819737a
@munechika-koyo
munechika-koyo
changed the base branch from
development
to
masterJanuary 12, 2025 18:38
@munechika-koyo
munechika-koyo
commented
Jan 13, 2025

Copy link


Copy Markdown

ContributorAuthor
I would like to revisit this pull request to enhance the handling of tetrahedral meshes.

I also applied the latest change in the master branch into this PR by rebasing.
@munechika-koyo
munechika-koyo
commented
Feb 15, 2025

Copy link


Copy Markdown

ContributorAuthor
I think that this PR contains many changes, making the review challenging, so I will separate features and propose each of them again.
@munechika-koyomunechika-koyo
mentioned this pull request
Feb 15, 2025
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@munechika-koyo@CnlPepper

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add TetraMeshData class to handle tetrahedral mesh data - #407
Closed
munechika-koyo wants to merge 20 commits into
raysect:masterfrom 
munechika-koyo:feature/tetrahedra_mesh
Closed
Add TetraMeshData class to handle tetrahedral mesh data#407
munechika-koyo wants to merge 20 commits into
raysect:masterfrom 
munechika-koyo:feature/tetrahedra_mesh
Conversation
@munechika-koyo
@munechika-koyomunechika-koyo
commented
Jul 25, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Hi,
I would like to propose this PR to introduce new class TetraMesh which is defined reffering to raysect.primitive.mesh.MeshData.

When constructing a kD tree for tetrahedral meshes, MeshKDTree3D class in raysect.core.math.function.float.function3d.interpolate.common module was used, and I need more general way of handling tetrahedral vertices or indices.

So, I decided to add some mesh-handling methods and put it into raysect.primitive module.

According to this modification, I improved some implementations and documents.
In addition, Tetmesh in external package used in demo scripts: Py3DViewer does not work well because of incompatible with version (I guess.), so I changed to use numpy.load method to load tetrahedral vertices and indices arrays.
I would appreciate it if you would confirm my PR and marge it into develop branch:)
@CnlPepper
CnlPepper
commented
Sep 15, 2022•

edited

Loading

Copy link


Copy Markdown

Member
I'm a little unsure how a tetrahedral mesh fits in the primitive module? Primitives are meant to define a surface that may or may not enclose a volume. A tetrahedral mesh doesn't just represent a surface alone. We'd need to think about where this should live, or if the primitive definition should be extended.
I've unfortunately not got much time to look through this at present as it is a large merge request. I will make one quick comment: the tetra mesh bunny file is a bit large! A simpler mesh would be sufficient for a demo.
@munechika-koyo
munechika-koyo
commented
Sep 15, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
As @CnlPepper mentioned, TetraMesh is not actual primitive objects. I think it is similar to the MeshData definition (actually I imitated it to implement TetraMesh)
the tetra mesh bunny file is a bit large! A simpler mesh would be sufficient for a demo.
I removed .mesh file due to the out of use. The numpy binary files (.npy) I added have smaller size (totally 30MB) than the .mesh file (45.9MB).
@munechika-koyomunechika-koyo
changed the title
Add TetraMesh class to handle tetrahedral meshAdd TetraMeshData class to handle tetrahedral mesh dataDec 18, 2023
@munechika-koyo
munechika-koyo
commented
Dec 18, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
the tetra mesh bunny file is a bit large! A simpler mesh would be sufficient for a demo.
I compressed mesh data in a .npz format, including both the tetra mesh's vertices and indices.

This file has a size of about 12MB. What do you think about this change?
I'm a little unsure how a tetrahedral mesh fits in the primitive module.
As you mentioned, I think the name TetraMesh should be changed to TetraMeshData because the previous one is not inherited from the Primitive object as well.

I want to push this PR to implement the functionality to save/load the tetrahedral mesh structure generated by the kd-tree core like the MeshData.save or MeshData.load because it takes more time to re-generate a tetrahedral kD-tree structure than load it from a .rsm file
I would appreciate it if you would take it into account.
Koyo Munechika
added 19 commits
January 12, 2025 17:07
Koyo Munechika@munechika-koyo
create TetraMesh class in primitive.mesh module
54ca0e0
Koyo Munechika@munechika-koyo
fix typo and apply TetraMesh to discrete3DMesh
dbf4206
Koyo Munechika@munechika-koyo
rename attribute's name and fix tetra width as 4
bcb2507
Koyo Munechika@munechika-koyo
create from_mesh method with Discreate3DMesh class
2cc0ea7
Koyo Munechika@munechika-koyo
[fix] struct format in saving
364b21a
Koyo Munechika@munechika-koyo
[fix] error about circular reference
ef73bd6
Koyo Munechika@munechika-koyo
[add] bounding_box method to TetraMesh
ad97cb8
Koyo Munechika@munechika-koyo
[fix] demo of tetrahedra mesh to use TetraMesh
2434493
Koyo Munechika@munechika-koyo
[update] demo script for tetrahedra mesh emission
b96b24f
Koyo Munechika@munechika-koyo
[update] document and docstrings of TetraMesh
cd91ae0
Koyo Munechika@munechika-koyo
[fix] docstings types
9c3160a
Koyo Munechika@munechika-koyo
[fix] use cls variable in classmethod
dad8fb8
use cls variables to generate instance from class.
Koyo Munechika@munechika-koyo
[update] to use cls paramter in classmethod
e38b3fa
Koyo Munechika@munechika-koyo
[delete] stanford_bunny.mesh is out of use
917a154
Koyo Munechika@munechika-koyo
✨ Add a method to calculate a barycenter of tetra
fca4e0a
Koyo Munechika@munechika-koyo
🚑 fix cython compile error
2d0181e
The latest Cython caused compile error at `kdtree2d.pyx` and `kdtree3d.pyx`
munechika-koyo@munechika-koyo
🚚 Replace .npy files to .npz file
5006721
munechika-koyo@munechika-koyo
Update TetraMesh to TetraMeshData
cbe36c9
I noticed that priviouse `TetraMesh` was derived from `MeshData` so I should rename it to not confuse it with primitive object as well
munechika-koyo@munechika-koyo
Update tetrahedra mesh demo script to follow TetraMeshData
819737a
@munechika-koyo
munechika-koyo
changed the base branch from
development
to
masterJanuary 12, 2025 18:38
@munechika-koyo
munechika-koyo
commented
Jan 13, 2025

Copy link


Copy Markdown

ContributorAuthor
I would like to revisit this pull request to enhance the handling of tetrahedral meshes.

I also applied the latest change in the master branch into this PR by rebasing.
@munechika-koyo
munechika-koyo
commented
Feb 15, 2025

Copy link


Copy Markdown

ContributorAuthor
I think that this PR contains many changes, making the review challenging, so I will separate features and propose each of them again.
@munechika-koyomunechika-koyo
mentioned this pull request
Feb 15, 2025
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@munechika-koyo@CnlPepper

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Add TetraMeshData class to handle tetrahedral mesh data - #407
Closed
munechika-koyo wants to merge 20 commits into
raysect:masterfrom 
munechika-koyo:feature/tetrahedra_mesh
Closed
Add TetraMeshData class to handle tetrahedral mesh data#407
munechika-koyo wants to merge 20 commits into
raysect:masterfrom 
munechika-koyo:feature/tetrahedra_mesh
Conversation
@munechika-koyo
@munechika-koyomunechika-koyo
commented
Jul 25, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Hi,
I would like to propose this PR to introduce new class TetraMesh which is defined reffering to raysect.primitive.mesh.MeshData.

When constructing a kD tree for tetrahedral meshes, MeshKDTree3D class in raysect.core.math.function.float.function3d.interpolate.common module was used, and I need more general way of handling tetrahedral vertices or indices.

So, I decided to add some mesh-handling methods and put it into raysect.primitive module.

According to this modification, I improved some implementations and documents.
In addition, Tetmesh in external package used in demo scripts: Py3DViewer does not work well because of incompatible with version (I guess.), so I changed to use numpy.load method to load tetrahedral vertices and indices arrays.
I would appreciate it if you would confirm my PR and marge it into develop branch:)
@CnlPepper
CnlPepper
commented
Sep 15, 2022•

edited

Loading

Copy link


Copy Markdown

Member
I'm a little unsure how a tetrahedral mesh fits in the primitive module? Primitives are meant to define a surface that may or may not enclose a volume. A tetrahedral mesh doesn't just represent a surface alone. We'd need to think about where this should live, or if the primitive definition should be extended.
I've unfortunately not got much time to look through this at present as it is a large merge request. I will make one quick comment: the tetra mesh bunny file is a bit large! A simpler mesh would be sufficient for a demo.
@munechika-koyo
munechika-koyo
commented
Sep 15, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
As @CnlPepper mentioned, TetraMesh is not actual primitive objects. I think it is similar to the MeshData definition (actually I imitated it to implement TetraMesh)
the tetra mesh bunny file is a bit large! A simpler mesh would be sufficient for a demo.
I removed .mesh file due to the out of use. The numpy binary files (.npy) I added have smaller size (totally 30MB) than the .mesh file (45.9MB).
@munechika-koyomunechika-koyo
changed the title
Add TetraMesh class to handle tetrahedral meshAdd TetraMeshData class to handle tetrahedral mesh dataDec 18, 2023
@munechika-koyo
munechika-koyo
commented
Dec 18, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
the tetra mesh bunny file is a bit large! A simpler mesh would be sufficient for a demo.
I compressed mesh data in a .npz format, including both the tetra mesh's vertices and indices.

This file has a size of about 12MB. What do you think about this change?
I'm a little unsure how a tetrahedral mesh fits in the primitive module.
As you mentioned, I think the name TetraMesh should be changed to TetraMeshData because the previous one is not inherited from the Primitive object as well.

I want to push this PR to implement the functionality to save/load the tetrahedral mesh structure generated by the kd-tree core like the MeshData.save or MeshData.load because it takes more time to re-generate a tetrahedral kD-tree structure than load it from a .rsm file
I would appreciate it if you would take it into account.
Koyo Munechika
added 19 commits
January 12, 2025 17:07
Koyo Munechika@munechika-koyo
create TetraMesh class in primitive.mesh module
54ca0e0
Koyo Munechika@munechika-koyo
fix typo and apply TetraMesh to discrete3DMesh
dbf4206
Koyo Munechika@munechika-koyo
rename attribute's name and fix tetra width as 4
bcb2507
Koyo Munechika@munechika-koyo
create from_mesh method with Discreate3DMesh class
2cc0ea7
Koyo Munechika@munechika-koyo
[fix] struct format in saving
364b21a
Koyo Munechika@munechika-koyo
[fix] error about circular reference
ef73bd6
Koyo Munechika@munechika-koyo
[add] bounding_box method to TetraMesh
ad97cb8
Koyo Munechika@munechika-koyo
[fix] demo of tetrahedra mesh to use TetraMesh
2434493
Koyo Munechika@munechika-koyo
[update] demo script for tetrahedra mesh emission
b96b24f
Koyo Munechika@munechika-koyo
[update] document and docstrings of TetraMesh
cd91ae0
Koyo Munechika@munechika-koyo
[fix] docstings types
9c3160a
Koyo Munechika@munechika-koyo
[fix] use cls variable in classmethod
dad8fb8
use cls variables to generate instance from class.
Koyo Munechika@munechika-koyo
[update] to use cls paramter in classmethod
e38b3fa
Koyo Munechika@munechika-koyo
[delete] stanford_bunny.mesh is out of use
917a154
Koyo Munechika@munechika-koyo
✨ Add a method to calculate a barycenter of tetra
fca4e0a
Koyo Munechika@munechika-koyo
🚑 fix cython compile error
2d0181e
The latest Cython caused compile error at `kdtree2d.pyx` and `kdtree3d.pyx`
munechika-koyo@munechika-koyo
🚚 Replace .npy files to .npz file
5006721
munechika-koyo@munechika-koyo
Update TetraMesh to TetraMeshData
cbe36c9
I noticed that priviouse `TetraMesh` was derived from `MeshData` so I should rename it to not confuse it with primitive object as well
munechika-koyo@munechika-koyo
Update tetrahedra mesh demo script to follow TetraMeshData
819737a
@munechika-koyo
munechika-koyo
changed the base branch from
development
to
masterJanuary 12, 2025 18:38
@munechika-koyo
munechika-koyo
commented
Jan 13, 2025

Copy link


Copy Markdown

ContributorAuthor
I would like to revisit this pull request to enhance the handling of tetrahedral meshes.

I also applied the latest change in the master branch into this PR by rebasing.
@munechika-koyo
munechika-koyo
commented
Feb 15, 2025

Copy link


Copy Markdown

ContributorAuthor
I think that this PR contains many changes, making the review challenging, so I will separate features and propose each of them again.
@munechika-koyomunechika-koyo
mentioned this pull request
Feb 15, 2025
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@munechika-koyo@CnlPepper