Uh oh!
There was an error while loading. Please reload this page.
test(e2e): cover disabled org enforcement across resource RPCs - #1861
test(e2e): cover disabled org enforcement across resource RPCs#1861AmanGIT07 wants to merge 2 commits into
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for CI Build 31172836601Coverage decreased (-0.3%) to 47.867%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions456 previously-covered lines in 13 files lost coverage.
Coverage Stats
💛 - Coveralls |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
test/e2e/regression/disabled_org_test.go (2)
148-156: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winAssert that the export contains the disabled org.
exported > 0passes even if the disabled org is absent, because other orgs exist in the suite. Collect the exported rows and check fororgID.
186-194: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winVerify the deletion with a direct read.
The loop only checks the
disabledlisting. AGetOrganizationcall that returnsCodeNotFoundproves the delete cascade removed the org.♻️ Proposed additional assertion
_, err = s.testBench.Client.DeleteOrganization(ctxAdmin, connect.NewRequest(&frontierv1beta1.DeleteOrganizationRequest{Id: deleteOrgID})) s.Assert().NoError(err) + _, err = s.testBench.Client.GetOrganization(ctxAdmin, connect.NewRequest(&frontierv1beta1.GetOrganizationRequest{Id: deleteOrgID}))+ s.Assert().Equal(connect.CodeNotFound, connect.CodeOf(err))+ // after the delete cascade the org must be gone from the admin listing
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: bb8aa701-105f-46a7-af78-bd67f91ef11f
📒 Files selected for processing (2)
test/e2e/regression/disabled_org_test.gotest/e2e/testbench/helper.go
a6afcc2 to
c06d96aCompareCo-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
f8af5e4 to
f5ff2f2Compare
Summary
End-to-end coverage for the disabled-org gate across project, group, resource, billing, and invitation RPCs.
Changes
FailedPreconditionon eight RPCs, non-member still getsPermissionDenied, superuser can list, export, read, and re-enable, member access is restored with no re-grants, and a disabled org can still be deletedTest Plan
make e2e-testpasses locally