First tests and first bug found and fixed. by razvanexu · Pull Request #2 · razvanexu/JavaLearn_Player_Status

razvanexu · 2024-06-06T20:02:37Z

No description provided.

started writing tests (canBUyWeapon method)

radduC · 2024-06-07T19:54:39Z


- public static boolean winProbability(PlayerStatus opponent, int health, int score) {
+ @Override
+ public boolean myWinProbability(PlayerStatus opponent, int health, int score) {


Refactor this to use PlayerStatus opponent1, PlayerStatus opponent2 as parameters instead, to be more clear.

solved in 535b2dd

radduC · 2024-06-07T19:56:41Z

+ @Override
+ public boolean myWinProbability(PlayerStatus opponent, int health, int score) {
 var opponentWinProb = (3 * opponent.getHealth() + opponent.getScore() / 1000) / 4;
 var myWinProb = (3 * health + score / 1000) / 4;


Create another method that calculates win prob. taking a PlayerStatus player as parameter and use it here instead.

radduC · 2024-06-07T19:58:34Z

 public boolean shouldAttackOpponent(PlayerStatus opponent) {
 if (opponent.getWeaponInHand() == weaponInHand) {
- return winProbability(opponent, health, score);
+ return service.myWinProbability(opponent, health, score);


Refactor this to use as parameters (this, opponent) instead.

razvanexu

Please review my latest refactoring

radduC · 2024-06-11T19:24:30Z

Good to merge.

razvanexu added 2 commits June 5, 2024 22:04

Implemented dependency inversion for Services class;
687d51a
started writing tests (canBUyWeapon method)

First battery of tests
e65f314

razvanexu requested a review from radduC June 6, 2024 20:05