Uh oh!
There was an error while loading. Please reload this page.
Conversation
brgix
commented
Feb 3, 2026
| polyg.reverse() | ||
| res = realignedFace(polyg) | ||
| res = realignedFace(polyg, True) |
MemberAuthor
There was a problem hiding this comment.
A gross omission, inserted more than 12 months ago. Forcing realignFace to rotate so a polygon bounded box is wider than deeper (vs X-axis).
brgix
commented
Feb 3, 2026
| space = openstudio.model.Space(model) | ||
| floor = openstudio.model.Surface(vtx, model) | ||
| floor.setSpace(space) | ||
| self.assertAlmostEqual(osut.spaceWidth(space),1,3) |
MemberAuthor
There was a problem hiding this comment.
Basic tests demonstrating that spaceWidth (now) always returns the narrower dimension of a space's bounded box.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.