Skip to content

Support python3.8 - #9

Closed
akasto wants to merge 2 commits into
rdegges:masterfrom
akasto:master
Closed

Support python3.8#9
akasto wants to merge 2 commits into
rdegges:masterfrom
akasto:master

Conversation

@akasto

@akastoakasto commented Feb 13, 2020

Copy link
Copy Markdown
  • linux_distribution was removed from platform in 3.8
  • removed end of life python versions

gudnigand others added 2 commits February 13, 2020 09:58
 - linux_distribution was removed from platform in 3.8

@mblahaymblahay left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not believe removing 2.7 compatibility is the right move.

Comment threadrequirements.txt
Comment on lines +1 to +2
pytest>=3.0.2
pytest-cov>=2.3.1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you reduce the required versions?

@nwithan8

Copy link
Copy Markdown

I do not believe removing 2.7 compatibility is the right move.

Python 2 reached EOL on Jan. 1, 2020.
https://www.python.org/doc/sunset-python-2/
It's time to move on.

@mblahay

Copy link
Copy Markdown

Like it or not, Python 2 is used, and supported to some extent, out in the wild. Besides, an email I received from this repo's owner said that he was no longer in control of changes to ipify. This means that pull requests here are not going to see the light of day. It might be better to leave this one alone and create a fork that is compatible with Python 3. Call it ipify3, then 2 and 3 can be supported.

@nwithan8

Copy link
Copy Markdown

Like it or not, Python 2 is used, and supported to some extent, out in the wild. Besides, an email I received from this repo's owner said that he was no longer in control of changes to ipify. This means that pull requests here are not going to see the light of day. It might be better to leave this one alone and create a fork that is compatible with Python 3. Call it ipify3, then 2 and 3 can be supported.

Done and done. Available on PyPi
https://github.com/nwithan8/ipify2

@akastoakasto closed this Feb 16, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@akasto@nwithan8@mblahay