Support python3.8 - #9
Conversation
- linux_distribution was removed from platform in 3.8
mblahay
left a comment
There was a problem hiding this comment.
I do not believe removing 2.7 compatibility is the right move.
| pytest>=3.0.2 | ||
| pytest-cov>=2.3.1 |
There was a problem hiding this comment.
Why did you reduce the required versions?
nwithan8
commented
Dec 9, 2020
Python 2 reached EOL on Jan. 1, 2020. |
mblahay
commented
Dec 9, 2020
Like it or not, Python 2 is used, and supported to some extent, out in the wild. Besides, an email I received from this repo's owner said that he was no longer in control of changes to ipify. This means that pull requests here are not going to see the light of day. It might be better to leave this one alone and create a fork that is compatible with Python 3. Call it ipify3, then 2 and 3 can be supported. |
nwithan8
commented
Dec 9, 2020
Done and done. Available on PyPi |
Uh oh!
There was an error while loading. Please reload this page.