Fix model_optimizer_options argument - #195
Open
dmitriy-serdyuk wants to merge 5 commits into
Open
Conversation
dmitriy-serdyuk
commented
Sep 24, 2018
CollaboratorAuthor
Actually, why do you need this argument? I can see now that that |
rdevon
commented
Oct 4, 2018
Owner
@dmitriy-serdyuk Can you rebase this to dev? I think there might be some overlapping in the branches |
dmitriy-serdyukforce-pushed
the
fix-model-optimizer
branch
from
October 4, 2018 18:43
c5c8711 to
4d5bf24Comparedmitriy-serdyuk
commented
Oct 4, 2018
CollaboratorAuthor
Done |
rdevon
commented
Oct 7, 2018
Owner
@dmitriy-serdyuk OK good. I'll fix the flake errors with dev and start merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Either I do not understand how to use option
model_optimizer_optionsor it will not work with current implementation.This PR allows to write
--o.model_optimizer_options "encoder={'lr': 0.01}".