Uh oh!
There was an error while loading. Please reload this page.
Add missing input binding method getType - #26
Conversation
7297fe9 to
0fb80beCompare…. Fixes shiny::registerInputHandler with reactR inputs.
0fb80be to
1eba39eComparegetTypegetTypetimelyportfolio
commented
Apr 23, 2019
@alandipert makes sense. I will likely wait a couple of weeks to avoid upsetting our friends at CRAN. |
@alandipert just got to play with this and my Will package authors need to change their code to work with this change? Or will the scaffold need to be changed? I believe we are missing a |
alandipert
commented
Apr 27, 2019
Hm, I didn't expect them to. I probably misunderstood what |
@alandipert I mistakenly thought that As of now, I think we should revert this commit, but it does seem we need to find a way for a user to provide a |
timelyportfolio
commented
Apr 27, 2019
@alandipert these Shiny lines confirm that a handler is required if |
The reactR-generated Shiny input binding was missing an implementation for
getType, which is required in order forshiny::registerInputHandlerto work.This PR adds an implementation that simply identifies the input by the unique name we're already collecting from the user.