Uh oh!
There was an error while loading. Please reload this page.
Callback error - #30
Merged
Merged
Conversation
alandipertforce-pushed
the
callback-error
branch
2 times, most recently
from
May 10, 2019 22:05
2e7f26d to
cd1f7f2Comparealandipert
marked this pull request as ready for review
May 10, 2019 22:06
Merged
Collaborator
Glad we are finding all these edge cases and offering full support for all of Shiny options. I was not aware of this one either. Instead I always handled with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a race condition introduced by combination with
renderUI()that manifested in the colorpicker-example demo app; please see the comment in input.js for details.#29 should be merged first and
yarn run webpackshould be run after merging this. I didn't run it so as to not conflict with the other PR.