Upgrade dom-helpers

[TrySound]

Ref react-bootstrap/dom-helpers@87e2fe4

/cc @jquense

[taion]

might want to update RTG first, though, since we're still pulling in dom-helpers via RTG

[TrySound]

Done @taionreactjs/react-transition-group#549

[bpas247]

hmm, strange that the CI build didn't kick off. Is this branch up to date with the master branch?

[TrySound]

Yes, I pulled master before submmitting.

[bpas247]

I just ran the build locally, and it seems to be failing on this test with the following error:

Error: Uncaught AssertionError: expected 'focus-container' to include 'modal' (node_modules/chai/chai.js:239)

[TrySound]

@bpas247 Looks like it was race condition.

[jquense]

yeah that happens occasionally when browser windows aren't actively focused

[bpas247]

Seems to be working as of 8833780 👍

[bpas247]

We've changed up the CI configuration since this PR has been opened (see #448 and #439), so we'll probably need to merge the changes from master into this branch to get those required status checks to kick off properly.

@TrySound do you mind doing that? If not, I'd be more than happy to 😃

[taion]

I merged this to master. Will merge once CI goes green.

[taion]

okay... so the way we have the codecov secret set up means it's not accessible for builds from forks. bleh.

[bpas247]

okay... so the way we have the codecov secret set up means it's not accessible for builds from forks. bleh.

Any easy fix for that?

[taion]

I don't see a way in the secret config to expose secrets to builds from forks. We might just have to wait until there's better first-party support here, and just deal with the pain for now. Not a problem in this case anyway because we don't care about coverage diffs for this change.

[bpas247]

This seems related to the overall issue of not allowing token-free uploads for public repos, so hopefully they'll push a fix for it soon.

[TrySound]

@taion@bpas247 is there anything blocking release?