Skip to content

feat: support dropdownStyle and merge dropdownMenuColumnStyle to styles prop - #413

Open
BoyYangzai wants to merge 7 commits into
react-component:masterfrom
BoyYangzai:fix-dropdownStyle
Open

feat: support dropdownStyle and merge dropdownMenuColumnStyle to styles prop#413
BoyYangzai wants to merge 7 commits into
react-component:masterfrom
BoyYangzai:fix-dropdownStyle

Conversation

@BoyYangzai

@BoyYangzaiBoyYangzai commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

测试 rc 与 antd 所有 test都通过
合并后补充 antd pr

@vercel

vercelBot commented Jun 5, 2023•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
cascader✅ Ready (Inspect)Visit Preview💬 Add feedbackJun 21, 2023 8:20am

@codecov

codecovBot commented Jun 5, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #413 (48fe8cf) into master (6ba06e9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 48fe8cf differs from pull request most recent head 8dd950a. Consider uploading reports for the commit 8dd950a to get more accurate results

@@ Coverage Diff @@## master #413 +/- ##
=======================================
Coverage 99.81% 99.81% =======================================
Files 19 19 Lines 550 554 +4 Branches 154 157 +3 =======================================
+ Hits 549 553 +4 
Misses 1 1
Impacted FilesCoverage Δ
src/Cascader.tsx100.00% <100.00%> (ø)
src/utils/warningPropsUtil.ts100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

afc163
afc163 reviewed Jun 5, 2023
View reviewed changes
Comment threadsrc/Cascader.tsx
afc163
afc163 reviewed Jun 5, 2023
View reviewed changes
Comment threadsrc/Cascader.tsx Outdated
@MadCcc

MadCcc commented Jun 5, 2023

Copy link
Copy Markdown
Member
styles: { dropdown: React.CSSProperties }

现在的 API 应该这么设计了

@MadCcc

MadCcc commented Jun 5, 2023•
edited
Loading

Copy link
Copy Markdown
Member

feature 分支吧 看成 antd 了

@BoyYangzaiBoyYangzai changed the title feat: support dropdownStylefeat: support dropdownStyle and merge dropdownMenuColumnStyle to styles propJun 5, 2023
@MadCcc

MadCcc commented Jun 7, 2023

Copy link
Copy Markdown
Member

styles 的测试需要加一下

afc163
afc163 reviewed Jun 9, 2023
View reviewed changes
Comment threadtests/index.spec.tsx Outdated
afc163
afc163 reviewed Jun 9, 2023
View reviewed changes
Comment threadtests/index.spec.tsx Outdated
@97702573

97702573 commented Jun 15, 2023

Copy link
Copy Markdown

@BoyYangzai 请问下已经发布线上了吗，antd版本是多少，现在可以使用吗

zombieJ
zombieJ reviewed Jun 16, 2023
View reviewed changes
Comment threadsrc/Cascader.tsx Outdated
zombieJ
zombieJ reviewed Jun 19, 2023
View reviewed changes
Comment threadsrc/Cascader.tsx Outdated
zombieJ
zombieJ reviewed Jun 19, 2023
View reviewed changes
Comment threadsrc/Cascader.tsx Outdated
zombieJ
zombieJ reviewed Jun 21, 2023
View reviewed changes
Comment threadsrc/Cascader.tsx
/** @deprecated Use `dropdownClassName` instead */
popupClassName?: string;
dropdownClassName?: string;
/** @deprecated Use `styles.popupColumn` instead */

@zombieJzombieJJun 21, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

上面的 popupClassNamedropdownClassName 备注也更新一下~

zombieJ
zombieJ reviewed Jun 21, 2023
View reviewed changes
Comment threadsrc/utils/warningPropsUtil.ts
popupPlacement === undefined,
'`popupPlacement` is deprecated. Please use `placement` instead.',
);
warning(

@zombieJzombieJJun 21, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

上面还有 popupXX 废弃请用 dropdown 的wanring 也需要清理掉

@yoyo837

yoyo837 commented Aug 16, 2023

Copy link
Copy Markdown
Member

ping

@97702573

97702573 commented Oct 19, 2023

Copy link
Copy Markdown

@BoyYangzai 嗨 请问什么时候解决下冲突 然后合并代码呀。

@afc163

afc163 commented Dec 31, 2024

Copy link
Copy Markdown
Member

@BoyYangzai 冲突了

@yoyo837

yoyo837 commented Jan 2, 2025

Copy link
Copy Markdown
Member

洋仔都不冒泡了

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afc163afc163afc163 left review comments
@zombieJzombieJzombieJ left review comments
+1 more reviewer
@RedJueRedJueRedJue approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cascader组件添加下拉菜单的 style API

7 participants

@BoyYangzai@MadCcc@97702573@yoyo837@afc163@zombieJ@RedJue