Skip to content

docs: demos refactor function component - #299

Merged
MadCcc merged 2 commits into
react-component:masterfrom
Wxh16144-forks:wuxh/update-demos
Jan 13, 2023
Merged

docs: demos refactor function component#299
MadCcc merged 2 commits into
react-component:masterfrom
Wxh16144-forks:wuxh/update-demos

Conversation

@Wxh16144

Copy link
Copy Markdown
Contributor

No description provided.

@vercel

vercelBot commented Jan 13, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated
collapse✅ Ready (Inspect)Visit PreviewJan 13, 2023 at 6:28AM (UTC)

@codecov

codecovBot commented Jan 13, 2023

Copy link
Copy Markdown

Codecov Report

Merging #299 (70e39a0) into master (da97f2d) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #299 +/- ##
=======================================
Coverage 98.85% 98.85% =======================================
Files 4 4 Lines 87 87 Branches 33 33 =======================================
Hits 86 86 Misses 1 1 
Impacted FilesCoverage Δ
src/index.tsx100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment threadsrc/index.tsx Outdated
Comment on lines +3 to +7
export type {
CollapsePanelProps,
CollapseProps,
CollapsibleType,
} from './interface';

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可不可以用 CollapseProps['xxx'] 代替?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原来没暴露出去的,那我调整一下 TS 类型推导

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我看了一下 antd 也没用到这个类型推导。是否要 export 出去呢

exporttype{CollapseProps,CollapsePanelProps}from'./interface';

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两个感觉可以的

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Wxh16144@MadCcc