Skip to content

fix: Fix uuid during testing - #282

Open
hedrall wants to merge 1 commit into
react-component:masterfrom
hedrall:feature/fix-uuid-in-test
Open

fix: Fix uuid during testing#282
hedrall wants to merge 1 commit into
react-component:masterfrom
hedrall:feature/fix-uuid-in-test

Conversation

@hedrall

@hedrallhedrall commented Feb 24, 2022

Copy link
Copy Markdown

How about fixing the UUID by referring to NODE_ENV?

In my test environment, import rc-dialog only once (via antd), so the snapshot test will show the difference.

スクリーンショット 2022-02-25 6 51 20

@vercel

vercelBot commented Feb 24, 2022

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/dialog/82aAcdjVNct2a4Kk24JeftJnGx2b
✅ Preview: https://dialog-git-fork-hedrall-feature-fix-uuid-ff71f9-react-component.vercel.app

@hedrallhedrall changed the title fix uuid when testFix uuid during testingFeb 24, 2022
@hedrallhedrall changed the title Fix uuid during testingfix: Fix uuid during testingFeb 24, 2022
@codecov

codecovBot commented Feb 25, 2022

Copy link
Copy Markdown

Codecov Report

Merging #282 (c9eec35) into master (65f1f8c) will decrease coverage by 1.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #282 +/- ##
==========================================
- Coverage 98.12% 96.91% -1.22% 
==========================================
Files 6 6 Lines 160 162 +2 Branches 47 48 +1 ==========================================
Hits 157 157 - Misses 2 4 +2 
Partials 1 1 
Impacted FilesCoverage Δ
src/util.ts92.85% <100.00%> (-7.15%)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65f1f8c...c9eec35. Read the comment docs.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@hedrall