Skip to content

fix: 释放事件同样需要 movable 为 true#495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AutumnChen wants to merge 1 commit into
base:master
Choose a base branch
from
+10 −8
Open

fix: 释放事件同样需要 movable 为 true #495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/hooks/useMouseEvent.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -115,15 +115,17 @@ export default function useMouseEvent(
}

return () => {
window.removeEventListener('mouseup', onMouseUp);
window.removeEventListener('mousemove', onMouseMove);
if (movable) {
window.removeEventListener('mouseup', onMouseUp);
window.removeEventListener('mousemove', onMouseMove);

/* istanbul ignore next */
try {
window.top?.removeEventListener('mouseup', onMouseUp);
window.top?.removeEventListener('mousemove', onMouseMove);
} catch (error) {
// Do nothing
/* istanbul ignore next */
try {
Comment on lines 117 to +123

CopilotAIFeb 10, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change alters cleanup behavior based on movable, but there’s no regression test covering the cross-origin/iframe scenario when movable={false}. Consider adding a Jest test (similar to tests/crossOrigin.test.tsx) that renders with movable={false} and a window.top getter that throws or counts accesses, then asserts unmount does not touch window.top (and does not throw).

Copilot uses AI. Check for mistakes.
window.top?.removeEventListener('mouseup', onMouseUp);
window.top?.removeEventListener('mousemove', onMouseMove);
} catch (error) {
// Do nothing
}
}
};
}, [open, isMoving, x, y, rotate, movable]);
Expand Down
Loading