Uh oh!
There was an error while loading. Please reload this page.
Closed
fix: pass fetchPriority to img element instead of wrapper div#501
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Add fetchPriority to ImageElementProps and COMMON_PROPS so it gets correctly forwarded to the inner img element. Also filter COMMON_PROPS from otherProps to prevent img-specific attributes from leaking to the wrapper div. Closes#270 Co-authored-by: afc163 <507615+afc163@users.noreply.github.com>
CopilotAI
changed the title
[WIP] Fix fetchPriority attribute propagation in Image componentfix: pass fetchPriority to img element instead of wrapper divMar 17, 2026
afc163
commented
Mar 20, 2026
Member
@copilot 没有修复,看看 ci |
ContributorAuthor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #501 +/- ##
=======================================
Coverage 99.41% 99.41% =======================================
Files 17 17 Lines 511 516 +5 Branches 153 153 =======================================
+ Hits 508 513 +5
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetchPrioritytoImageElementPropstype insrc/interface.tsfetchPrioritytoCOMMON_PROPSarray insrc/common.tsCOMMON_PROPSfrom wrapper div props insrc/Image.tsxfetchPriorityis passed to the<img>element and not the wrapper<div>Original prompt
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.