Skip to content

fix: preserve PreviewGroup imageRender contract#529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Cherry7593 wants to merge 1 commit into
base:master
Choose a base branch
from
+30 −1
Draft

fix: preserve PreviewGroup imageRender contract #529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/PreviewGroup.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@ import type { TransformType } from './hooks/useImageTransform';
import usePreviewItems from './hooks/usePreviewItems';
import type { ImageElementProps, OnGroupPreview } from './interface';

export interface GroupPreviewConfig extends InternalPreviewConfig {
export interface GroupPreviewConfig extends Omit<InternalPreviewConfig, 'imageRender'> {
current?: number;
// Similar to InternalPreviewConfig but has additional current
imageRender?: (
Expand Down
29 changes: 29 additions & 0 deletions tests/previewGroup.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -151,6 +151,35 @@ describe('PreviewGroup', () => {
expect(previewProgressElement.textContent).toEqual('current:1 / total:3');
});

it('imageRender receives the current group index', () => {
const imageRender = jest.fn((originalNode, { current }) => (
<div data-testid="group-image-render" data-current={current}>
{originalNode}
</div>
));

render(
<Image.PreviewGroup
items={['src1', 'src2']}
preview={{ open: true, imageRender }}
/>,
);

expect(document.querySelector('[data-testid="group-image-render"]')).toHaveAttribute(
'data-current',
'0',
);
fireEvent.click(document.querySelector('.rc-image-preview-switch-next'));
expect(document.querySelector('[data-testid="group-image-render"]')).toHaveAttribute(
'data-current',
'1',
);
expect(imageRender).toHaveBeenLastCalledWith(
expect.anything(),
expect.objectContaining({ current: 1 }),
);
});

it('Switch', () => {
const previewProgressElementPath = '.rc-image-preview-progress';
const { container } = render(
Expand Down