Skip to content

fix: should process 0 correctly when precision is 0 - #390

Open
boomler wants to merge 1 commit into
react-component:masterfrom
boomler:fix-zero
Open

fix: should process 0 correctly when precision is 0#390
boomler wants to merge 1 commit into
react-component:masterfrom
boomler:fix-zero

Conversation

@boomler

@boomlerboomler commented Jan 1, 2022

Copy link
Copy Markdown
Contributor

Fix the issue reported by:
ant-design/ant-design#33084 (comment)

@vercel

vercelBot commented Jan 1, 2022

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/input-number/Grq5ac3Jwaze5dK5MnBSaSmmtCxu
✅ Preview: https://input-number-git-fork-boomler-fix-zero-react-component.vercel.app

@codecov

codecovBot commented Jan 1, 2022

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.65%. Comparing base (d3de147) to head (c8d2672).
⚠️ Report is 128 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #390 +/- ##
==========================================
+ Coverage 97.76% 98.65% +0.88% 
==========================================
Files 9 9 Lines 448 445 -3 Branches 116 116 ==========================================
+ Hits 438 439 +1 + Misses 10 6 -4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@boomler

Copy link
Copy Markdown
ContributorAuthor

Hi @zombieJ . This pr is to solve a bug caused by #385.
I think this bug is quit easy to happen, so let's see whether this is a good solution or you have other suggestions.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@boomler@zombieJ