Uh oh!
There was an error while loading. Please reload this page.
fix: keep measurement textarea out of tab order - #200
Conversation
@nrps9909 is attempting to deploy a commit to the afc163's projects Team on Vercel. A member of the Team first needs to authorize it. |
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. Walkthrough隐藏测量 textarea 现在使用有效的 Changes隐藏 textarea 的 Tab 顺序修正
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk:⚪ Minimal · up to The change restores the hidden measurement textarea’s intended exclusion from keyboard tab order and adds regression coverage; no actionable merge-blocking risk remains after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (2 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
tab-indexattribute on the autosize measurement textarea with the standardtabindextabindex="-1"is present and the misspelled attribute is absentBrowsers ignore
tab-index, so the intended keyboard safeguard was not applied. This is the rc-input counterpart of react-component/textarea#80 and its open fix#81; rc-input is a separately published package with the same copied measurement implementation and currently has no corresponding issue or PR.Verification
tabindexwas missingnpm run tscnpm run lint— 0 errors, 2 pre-existing Hook dependency warningsnpm run compile— ESM, CJS, declarations, and Less compilation passedgit diff --checkI checked every current open rc-input PR changed file and found no overlap with
src/calculateNodeHeight.tsx.AI assistance disclosure: Codex was used to confirm the duplicated invalid attribute in the separately published rc-input package, audit open work, add the regression, and run verification. The exact-base failure and one-token source correction were reviewed locally.
Summary by CodeRabbit
Bug 修复
测试
tabindex="-1"属性。