Skip to content

fix(Menu): add setState condition in updateMiniStore method to avoid … - #309

Open
grantedFine wants to merge 2 commits into
react-component:masterfrom
grantedFine:fix/updateMiniStore
Open

fix(Menu): add setState condition in updateMiniStore method to avoid …#309
grantedFine wants to merge 2 commits into
react-component:masterfrom
grantedFine:fix/updateMiniStore

Conversation

@grantedFine

Copy link
Copy Markdown

add setState condition in updateMiniStore method to avoid infinite call in componentDidUpdate

@vercel

vercelBot commented Feb 13, 2020

Copy link
Copy Markdown

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/menu/fot5i48vk
✅ Preview: https://menu-git-fork-grantedfine-fix-updateministore.react-component.now.sh

@codecov

codecovBot commented Feb 13, 2020

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.50%. Comparing base (2a5e6cb) to head (08c1299).
⚠️ Report is 255 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #309 +/- ##
==========================================
+ Coverage 95.49% 95.50% +0.01% 
==========================================
Files 11 11 Lines 888 890 +2 Branches 265 267 +2 ==========================================
+ Hits 848 850 +2 
Misses 40 40 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@afc163

Copy link
Copy Markdown
Member

conflict

@delete-merged-branch
delete-merged-branchBot deleted the branch react-component:masterMarch 31, 2023 07:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@grantedFine@afc163@parchedLake