Skip to content

fix: typeof openKeys can be React.Key - #347

Open
xyuanbuilds wants to merge 2 commits into
react-component:masterfrom
xyuanbuilds:patch-1
Open

fix: typeof openKeys can be React.Key#347
xyuanbuilds wants to merge 2 commits into
react-component:masterfrom
xyuanbuilds:patch-1

Conversation

@xyuanbuilds

Copy link
Copy Markdown

when get keys in onOpenChange to set openKeys, type mismatch. maybe use React.Key is better.

when get keys in onOpenChange to set openKeys, type mismatch. maybe use React.Key is better.
@codecov

codecovBot commented Oct 30, 2020

Copy link
Copy Markdown

Codecov Report

Merging #347 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #347 +/- ##
=======================================
Coverage 95.49% 95.49% =======================================
Files 11 11 Lines 888 888 Branches 265 265 =======================================
Hits 848 848 Misses 40 40 
Impacted FilesCoverage Δ
src/Menu.tsx98.12% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a5e6cb...1111176. Read the comment docs.

@delete-merged-branch
delete-merged-branchBot deleted the branch react-component:masterMarch 31, 2023 07:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@xyuanbuilds