Skip to content

feat: add api inlineMaxLevel - #421

Open
zhengshuai1001 wants to merge 4 commits into
react-component:masterfrom
zhengshuai1001:fix-31669
Open

feat: add api inlineMaxLevel#421
zhengshuai1001 wants to merge 4 commits into
react-component:masterfrom
zhengshuai1001:fix-31669

Conversation

@zhengshuai1001

@zhengshuai1001zhengshuai1001 commented Aug 5, 2021

Copy link
Copy Markdown

内联菜单,最多指定某一层次的子菜单,较深的子菜单将右弹窗。关联antd issue: #31669

inlineMaxLevel = 2 的效果:
内联菜单超过2级后将在右侧弹窗显示

动画2

inline menu, specify at most a certain level of submenu, deeper submenu will right popover.
@afc163

Copy link
Copy Markdown
Member

inlineMaxLevel 的命名有没有更好的方案?

@zombieJ

@codecov

codecovBot commented Aug 5, 2021

Copy link
Copy Markdown

Codecov Report

Merging #421 (2bd3a32) into master (f468451) will decrease coverage by 1.82%.
The diff coverage is 67.56%.

❗ Current head 2bd3a32 differs from pull request most recent head 4887ac3. Consider uploading reports for the commit 4887ac3 to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@## master #421 +/- ##
==========================================
- Coverage 99.84% 98.02% -1.83% 
==========================================
Files 24 25 +1 Lines 631 657 +26 Branches 160 172 +12 ==========================================
+ Hits 630 644 +14 - Misses 1 13 +12 
Impacted FilesCoverage Δ
src/context/MenuContext.tsx100.00% <ø> (ø)
src/Menu.tsx95.48% <40.00%> (-4.52%)⬇️
src/utils/multiModeUtil.ts66.66% <66.66%> (ø)
src/SubMenu/index.tsx96.70% <83.33%> (-3.30%)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f468451...4887ac3. Read the comment docs.

@yoyo837

Copy link
Copy Markdown
Member

inlineMaxDeep?

@zhengshuai1001

Copy link
Copy Markdown
Author

请问这个api 命名叫什么呢?

@zhengshuai1001

Copy link
Copy Markdown
Author

@afc163 麻烦抽空看一下,Thanks

@zhengshuai1001

Copy link
Copy Markdown
Author

@yoyo837 能帮忙看下么,谢谢

@yoyo837
yoyo837 requested a review from zombieJAugust 10, 2021 03:12
@yoyo837

Copy link
Copy Markdown
Member

image

等这个大佬看看.

@574495412

Copy link
Copy Markdown

这样做意义不大

@delete-merged-branch
delete-merged-branchBot deleted the branch react-component:masterMarch 31, 2023 07:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@zhengshuai1001@afc163@yoyo837@574495412