Skip to content

fix: can not open in web component - #575

Merged
afc163 merged 1 commit into
react-component:masterfrom
tmkx:master
Feb 6, 2021
Merged

fix: can not open in web component#575
afc163 merged 1 commit into
react-component:masterfrom
tmkx:master

Conversation

@tmkx

@tmkxtmkx commented Nov 28, 2020

Copy link
Copy Markdown
Contributor

@vercel

vercelBot commented Nov 28, 2020

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/select/krxeowwib
✅ Preview: https://select-git-master.react-component.vercel.app

@tmkx

tmkx commented Nov 28, 2020

Copy link
Copy Markdown
ContributorAuthor

image

event.target is not the origin target in web component.

@yoyo837

Copy link
Copy Markdown
Member

Could your add some test case for it?

@codecov

codecovBot commented Nov 28, 2020

Copy link
Copy Markdown

Codecov Report

Merging #575 (7f405f0) into master (7781194) will decrease coverage by 0.10%.
The diff coverage is 75.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #575 +/- ##
==========================================
- Coverage 99.27% 99.17% -0.11% 
==========================================
Files 20 20 Lines 967 968 +1 Branches 327 328 +1 ==========================================
Hits 960 960 - Misses 6 7 +1 
Partials 1 1 
Impacted FilesCoverage Δ
src/hooks/useSelectTriggerControl.ts93.33% <75.00%> (-6.67%)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7781194...7f405f0. Read the comment docs.

@tmkx

tmkx commented Nov 28, 2020

Copy link
Copy Markdown
ContributorAuthor

Could your add some test case for it?

JSDOM 16.2 includes basic support for custom elements and is available in Jest 26.5 and above. See

But...

yarn why v1.22.5
[1/4] 🤔 Why do we have the module "jest"...?
[2/4] 🚚 Initialising dependency graph...
[3/4] 🔍 Finding dependency...
[4/4] 🚡 Calculating file sizes...
=> Found "jest@24.9.0"
info Reasons this module exists

  • "father#umi-test" depends on it
  • Hoisted from "father#umi-test#jest"
    info Disk size without dependencies: "48KB"
    info Disk size with unique dependencies: "300KB"
    info Disk size with transitive dependencies: "48KB"
    info Number of shared dependencies: 230

@yoyo837

@zombieJ

Copy link
Copy Markdown
Member

Thx for contribution. Could you help to provide a test case for this?

@tmkx

tmkx commented Nov 30, 2020

Copy link
Copy Markdown
ContributorAuthor

Thx for contribution. Could you help to provide a test case for this?

Jest's version is too low to support custom elements.

The version of father#umi-test#jest is 24.9.0, but Jest supports it after 26.5.

@yoyo837

Copy link
Copy Markdown
Member

Need upstream supports, you can contribute to them about that also.

@zombieJ

Copy link
Copy Markdown
Member

@PeachScript

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tmkx@yoyo837@zombieJ@afc163