Skip to content

chore: migrate jest to vitest - #989

Merged
zombieJ merged 11 commits into
react-component:masterfrom
Dunqing:chore/migrate-vitest
May 10, 2023
Merged

chore: migrate jest to vitest#989
zombieJ merged 11 commits into
react-component:masterfrom
Dunqing:chore/migrate-vitest

Conversation

@Dunqing

@DunqingDunqing commented May 6, 2023

Copy link
Copy Markdown
Contributor
  1. 有很多测试改动,我 Debug 后觉得是之前的测试就是不正确的
  2. 有几个错误的测试改到 testing-library 实现了

@vercel

vercelBot commented May 6, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
table✅ Ready (Inspect)Visit Preview💬 Add feedbackMay 10, 2023 0:36am

@codecov

codecovBot commented May 6, 2023

Copy link
Copy Markdown

Codecov Report

Merging #989 (aedf282) into master (3062ae3) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head aedf282 differs from pull request most recent head 1e956b7. Consider uploading reports for the commit 1e956b7 to get more accurate results

@@ Coverage Diff @@## master #989 +/- ##
==========================================
+ Coverage 99.49% 99.52% +0.02% 
==========================================
Files 36 40 +4 Lines 989 3563 +2574 Branches 305 476 +171 ==========================================
+ Hits 984 3546 +2562 - Misses 5 17 +12 
Impacted FilesCoverage Δ
__mocks__/rc-util/lib/getScrollBarSize.ts75.00% <ø> (ø)
src/Table.tsx99.76% <100.00%> (+0.69%)⬆️
src/hooks/useFlattenRecords.ts100.00% <100.00%> (ø)
src/index.ts100.00% <100.00%> (ø)
src/stickyScrollBar.tsx97.84% <100.00%> (+0.58%)⬆️

... and 36 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment threadtests/FixedHeader.spec.jsx Outdated
expect();
expect(wrapper.find('colgroup col').at(0).props().style.width).toEqual(100);
expect(wrapper.find('colgroup col').at(1).props().style.width).toEqual(200);
expect(wrapper.find('colgroup col').at(2).props().style.width).toEqual(0);

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这行被删除是因为没加上.ant-table-body 前确实有这一项,但加上之后 column 如果宽度是0是不会显示这个 col 的所以根本不存在

Comment threadtests/Sticky.spec.jsx Outdated
Comment threadtests/Sticky.spec.jsx Outdated
Comment threadtests/Table.spec.jsx Outdated
Comment threadtests/Sticky.spec.jsx Outdated
Comment threadtests/Sticky.spec.jsx Outdated
Comment threadsrc/stickyScrollBar.tsx Outdated
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Dunqing@zombieJ